132835 2014-05-12 13:52:21 -0700 Layer for bottom overhang area needs to be offset by the topContentInset 2014-05-12 14:07:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1008717 0 bdakin 2014-05-12 13:52:21 -0700 Layer for bottom overhang area needs to be offset by the topContentInset <rdar://problem/16641115> 1008720 1 231323 bdakin 2014-05-12 14:00:27 -0700 Created attachment 231323 Patch 1008722 2 commit-queue 2014-05-12 14:03:31 -0700 Attachment 231323 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1008724 3 bdakin 2014-05-12 14:07:48 -0700 Thanks! http://trac.webkit.org/changeset/168643 231323 2014-05-12 14:00:27 -0700 2014-05-12 14:02:12 -0700 Patch for-review.txt text/plain 1873 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODY0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTEyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBMYXllciBmb3IgYm90dG9tIG92ZXJo YW5nIGFyZWEgbmVlZHMgdG8gYmUgb2Zmc2V0IGJ5IHRoZSB0b3BDb250ZW50SW5zZXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjgzNQorICAgICAg ICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjY0MTExNT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgKE9PUFMhKS4KKworICAgICAgICBQdXNoIHRoaXMgbGF5ZXIgZG93biBieSB0aGUgdG9w Q29udGVudEluc2V0IGluIGFkZGl0aW9uIHRvIHRoZSByb290IGxheWVyIGhlaWdodCwgCisgICAg ICAgIGZvb3RlciBoZWlnaHQsIGFuZCBoZWFkZXIgaGVpZ2h0LgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5 ZXJDb21wb3NpdG9yOjp1cGRhdGVMYXllckZvckJvdHRvbU92ZXJoYW5nQXJlYSk6CisKIDIwMTQt MDUtMDkgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMTY3ODE4KTogZWRpdGluZy9pbnNlcnRpbmcvdHlwaW5nLXNwYWNlLXRvLXRy aWdnZXItc21hcnQtbGluay5odG1sIGZhaWxzIG9uIFdlYktpdDEgYm90cwpJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJKHJl dmlzaW9uIDE2ODYzMSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTM1LDcgKzI5MzUsOCBAQCBHcmFwaGlj c0xheWVyKiBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwCiAgICAgICAgIG1fc2Nyb2xsTGF5ZXIt PmFkZENoaWxkQmVsb3cobV9sYXllckZvckJvdHRvbU92ZXJoYW5nQXJlYS5nZXQoKSwgbV9yb290 Q29udGVudExheWVyLmdldCgpKTsKICAgICB9CiAKLSAgICBtX2xheWVyRm9yQm90dG9tT3Zlcmhh bmdBcmVhLT5zZXRQb3NpdGlvbihGbG9hdFBvaW50KDAsIG1fcm9vdENvbnRlbnRMYXllci0+c2l6 ZSgpLmhlaWdodCgpICsgbV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLmhlYWRlckhlaWdodCgpICsg bV9yZW5kZXJWaWV3LmZyYW1lVmlldygpLmZvb3RlckhlaWdodCgpKSk7CisgICAgbV9sYXllckZv ckJvdHRvbU92ZXJoYW5nQXJlYS0+c2V0UG9zaXRpb24oRmxvYXRQb2ludCgwLCBtX3Jvb3RDb250 ZW50TGF5ZXItPnNpemUoKS5oZWlnaHQoKSArIG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS5oZWFk ZXJIZWlnaHQoKQorICAgICAgICArIG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS5mb290ZXJIZWln aHQoKSArIG1fcmVuZGVyVmlldy5mcmFtZVZpZXcoKS50b3BDb250ZW50SW5zZXQoKSkpOwogICAg IHJldHVybiBtX2xheWVyRm9yQm90dG9tT3ZlcmhhbmdBcmVhLmdldCgpOwogfQogCg==