132831 2014-05-12 11:58:48 -0700 REGRESSION(168625): [GTK] Build broken. 2014-05-12 12:55:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez webkit-unassigned andersca cgarcia commit-queue ltilve mrobinson svillar zan oldest_to_newest 1008678 0 clopez 2014-05-12 11:58:48 -0700 Revision r168625 <http://trac.webkit.org/168625> broke the GTK build: ../../Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:127:59: error: static member function ‘static WTF::String WebKit::WebContext::platformDefaultLocalStorageDirectory()’ declared with type qualifiers String WebContext::platformDefaultLocalStorageDirectory() const ^ 1008679 1 clopez 2014-05-12 11:59:26 -0700 (In reply to comment #0) > Revision r168625 <http://trac.webkit.org/168625> broke the GTK build: > ^ http://trac.webkit.org/r168625 1008685 2 231314 clopez 2014-05-12 12:15:47 -0700 Created attachment 231314 Patch 1008693 3 231314 commit-queue 2014-05-12 12:55:07 -0700 Comment on attachment 231314 Patch Clearing flags on attachment: 231314 Committed r168638: <http://trac.webkit.org/changeset/168638> 1008694 4 commit-queue 2014-05-12 12:55:11 -0700 All reviewed patches have been landed. Closing bug. 231314 2014-05-12 12:15:47 -0700 2014-05-12 12:55:07 -0700 Patch bug-132831-20140512211523.patch text/plain 1571 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjIyMzkzOGE0ZmRiNTk1 MzI0MDZkODE0ZTYwY2U5Mzg2MzE0ZmExMy4uMTNjN2VhNGRjZmMzMGE5Y2FiOWRjOThhZmMxMWJj ODVlMzc5MGQ3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTEyICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04oMTY4NjI1KTogW0dUS10gYnVpbGQgYnJva2VuIGR1ZSB0byBXS0NvbnRleHRTZXRM b2NhbFN0b3JhZ2VEaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMjgzMQorCisgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkNvbnRleHQ6OnBsYXRmb3JtRGVmYXVsdExvY2FsU3RvcmFnZURpcmVjdG9yeSk6 CisgICAgICAgIFRoaXMgaXMgbm93IGEgc3RhdGljIG1lbWJlciBmdW5jdGlvbi4KKwogMjAxNC0w NS0xMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFdL V2ViVmlldyBzaG91bGQgZGVmYXVsdCB0byBfYmFja2dyb3VuZEV4dGVuZHNCZXlvbmRQYWdlID0g WUVTCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRH dGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcApp bmRleCBhYjkzZGYyOTllYjI0ODM2ODEyN2UwMTNlMjhkNGNiNWIwNWIxMTQzLi5jM2QxOGZmMzcx Zjk0N2ZkMjA2MDZjZGQxMzdmMzRhOTQwM2MzNGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHAKQEAgLTEyNCw3ICsxMjQsNyBAQCBTdHJpbmcg V2ViQ29udGV4dDo6cGxhdGZvcm1EZWZhdWx0SWNvbkRhdGFiYXNlUGF0aCgpIGNvbnN0CiAgICAg cmV0dXJuIFdlYkNvcmU6OmZpbGVuYW1lVG9TdHJpbmcoZGF0YWJhc2VEaXJlY3RvcnkuZ2V0KCkp OwogfQogCi1TdHJpbmcgV2ViQ29udGV4dDo6cGxhdGZvcm1EZWZhdWx0TG9jYWxTdG9yYWdlRGly ZWN0b3J5KCkgY29uc3QKK1N0cmluZyBXZWJDb250ZXh0OjpwbGF0Zm9ybURlZmF1bHRMb2NhbFN0 b3JhZ2VEaXJlY3RvcnkoKQogewogICAgIEdVbmlxdWVQdHI8Z2NoYXI+IHN0b3JhZ2VEaXJlY3Rv cnkoZ19idWlsZF9maWxlbmFtZShnX2dldF91c2VyX2RhdGFfZGlyKCksICJ3ZWJraXRndGsiLCAi bG9jYWxzdG9yYWdlIiwgbnVsbHB0cikpOwogICAgIHJldHVybiBXZWJDb3JlOjpmaWxlbmFtZVRv U3RyaW5nKHN0b3JhZ2VEaXJlY3RvcnkuZ2V0KCkpOwo=