<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>132814</bug_id>
          
          <creation_ts>2014-05-12 03:02:40 -0700</creation_ts>
          <short_desc>[Stable] [GTK] GdiObject.h missing in WebKitGTK 2.4.1 tarball</short_desc>
          <delta_ts>2014-05-26 04:41:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Windows 7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>133028</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Milan Crha">mcrha</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gustavo</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1008517</commentid>
    <comment_count>0</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-05-12 03:02:40 -0700</bug_when>
    <thetext>Revision r155454 introduces GdiObject.h (see bug #120778), but this is missing in the sources of tarball for 2.4.1. There are still references to this file, the same as used functions (adoptGDIObject) in the sources. I reverted those references locally, but it would be good to have this fixed in the future releases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008725</commentid>
    <comment_count>1</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-12 14:09:58 -0700</bug_when>
    <thetext>I can see that the following files are missing from the tarball.

Source/WebCore/platform/win/GDIObjectCounter.h
Source/WebCore/platform/win/GDIObjectCounter.cpp
Source/WebCore/platform/graphics/win/SharedGDIObject.h
Source/WTF/wtf/win/GDIObject.h

Does it build fine if you add them manually?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008888</commentid>
    <comment_count>2</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-05-13 00:24:03 -0700</bug_when>
    <thetext>I have more other changes here, which I&apos;m trying to fine-tune before offering to upstream. I&apos;m building with msys/mingw32.

I can try to add the file into sources, but I do not think it&apos;s enough to just get them from anywhere and hope it&apos;ll work, I expect it needs also some Makefile change thus the build system knows about those files (at least for the .cpp file). My question then is:

- where do I get those files from, please? Exact link welcome.
- which Makefile should I change and in what way?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008892</commentid>
    <comment_count>3</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-13 00:57:16 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; - where do I get those files from, please? Exact link welcome.

You can browse the repository here:

   http://trac.webkit.org/browser/releases/WebKitGTK

Or you can also clone this git repository which contains the
webkit-2.4 branch with all the stable releases.

   https://github.com/bertogg/webkit

Here are the direct links to the files I mentioned earlier:

   https://raw.githubusercontent.com/bertogg/webkit/webkit-2.4/Source/WebCore/platform/win/GDIObjectCounter.h
   https://raw.githubusercontent.com/bertogg/webkit/webkit-2.4/Source/WebCore/platform/win/GDIObjectCounter.cpp
   https://raw.githubusercontent.com/bertogg/webkit/webkit-2.4/Source/WebCore/platform/graphics/win/SharedGDIObject.h
   https://raw.githubusercontent.com/bertogg/webkit/webkit-2.4/Source/WTF/wtf/win/GDIObject.h

&gt; - which Makefile should I change and in what way?

You probably need to add those files to this Makefile:

   Source/WebCore/GNUmakefile.list.am

See the TARGET_WIN32 section. Run autogen.sh afterwards so the new
Makefiles are generated with your changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1009964</commentid>
    <comment_count>4</comment_count>
      <attachid>231626</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-05-17 07:07:53 -0700</bug_when>
    <thetext>Created attachment 231626
my changes to webkit

Thanks for the pointer. i took the files from tracker&apos;s trunk branch. The path Source/WTF/wtf/win/ doesn&apos;t exist in tarball, thus I created it and added there the file. there had been some issues with GdiObject itself, mingw/msys has a clash with deleteObject, thus I renamed it to deleteObjectGDI and there was also a problem with specialization of that template,, thus the later change in the GdiObject.h. Other related changes are attached. I hope it helps.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1009965</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-05-17 07:09:04 -0700</bug_when>
    <thetext>Attachment 231626 did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1010740</commentid>
    <comment_count>6</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-21 05:50:11 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; there had been some issues with GdiObject itself, mingw/msys has a
&gt; clash with deleteObject, thus I renamed it to deleteObjectGDI

Doesn&apos;t the WTF namespace prevent this problem from happening?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1010769</commentid>
    <comment_count>7</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-05-21 08:50:07 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #4)
&gt; &gt; there had been some issues with GdiObject itself, mingw/msys has a
&gt; &gt; clash with deleteObject, thus I renamed it to deleteObjectGDI
&gt; 
&gt; Doesn&apos;t the WTF namespace prevent this problem from happening?

I did not investigate it into deep, thus I do not know from where the clash comes, but if it&apos;s a define, then the namespace wouldn&apos;t help.

The thing is, without rename I get a compiler error (I can regenerate it, if it helps), then I searched the Internet and one way to fix it was to rename the symbol, which I did and it helped.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1010943</commentid>
    <comment_count>8</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-22 04:29:51 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; &gt; &gt; there had been some issues with GdiObject itself, mingw/msys has a
&gt; &gt; &gt; clash with deleteObject, thus I renamed it to deleteObjectGDI
&gt; &gt;
&gt; &gt; Doesn&apos;t the WTF namespace prevent this problem from happening?

&gt; The thing is, without rename I get a compiler error (I can
&gt; regenerate it, if it helps), then I searched the Internet and one
&gt; way to fix it was to rename the symbol, which I did and it helped.

It would be great if we can investigate this a bit more. If you can
regenerate the error and/or attach the relevant headers that produce
this clash then we can try to help.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011537</commentid>
    <comment_count>9</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-05-24 14:10:39 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; It would be great if we can investigate this a bit more. If you can
&gt; regenerate the error and/or attach the relevant headers that produce
&gt; this clash then we can try to help.

Weird, I reverted my changes in GdiObject.h (the rename from deleteObject to deleteObjectGDI) and the compile finished without stopping on this as before. I also didn&apos;t fine the &apos;deleteObject&apos; defined anywhere in mingw32 headers (and even binaries), thus it might be some other kind of a clash. I changed one thing, I configured webkitgtk with --enable-jit this time.

In any case, I propose to not use my rename in the GdiObject.h, just feel free to use the other parts of the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011565</commentid>
    <comment_count>10</comment_count>
      <attachid>232033</attachid>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-25 04:22:59 -0700</bug_when>
    <thetext>Created attachment 232033
Patch

(In reply to comment #9)
&gt; In any case, I propose to not use my rename in the GdiObject.h, just
&gt; feel free to use the other parts of the patch.

Here&apos;s the updated patch. I made a couple of changes:

1) I renamed GdiObject.h to GDIObject.h in the patch. That&apos;s the
   correct name of the file.

2) I removed the if TARGET_WIN32 part around it, this is a header file
   so it&apos;s not really necessary.

We should also check if the master branch is affected by this, although
that would require a separate patch if it was the case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011666</commentid>
    <comment_count>11</comment_count>
      <attachid>232033</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-05-26 00:44:58 -0700</bug_when>
    <thetext>Comment on attachment 232033
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011667</commentid>
    <comment_count>12</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-05-26 00:45:36 -0700</bug_when>
    <thetext>Pushed to the stable branch as &lt;http://trac.webkit.org/changeset/169331&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011668</commentid>
    <comment_count>13</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-05-26 00:51:23 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; 1) I renamed GdiObject.h to GDIObject.h in the patch. That&apos;s the
&gt;    correct name of the file.

Ahh, unnoticed by me, due to Windows being case insensitive in file names. I suppose, for a sake of consistency, the #include directives around the source code should be also changed to capitals on GDI.

&gt; 2) I removed the if TARGET_WIN32 part around it, this is a header file
&gt;    so it&apos;s not really necessary.

Are you sure? You definitely do not want to compile windows-specific headers on Linux (or basically any other than Windows system), the same as you do not compile posix related code on windows. I would keep there the check for TARGET_WIN32, the same as it is in Source/WebCore/GNUmakefile.list.am.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011698</commentid>
    <comment_count>14</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-26 04:41:19 -0700</bug_when>
    <thetext>(In reply to comment #13)

&gt; &gt; 2) I removed the if TARGET_WIN32 part around it, this is a header
&gt; &gt;    file so it&apos;s not really necessary.

&gt; Are you sure? You definitely do not want to compile windows-specific
&gt; headers on Linux

Well, headers are not compiled :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>231626</attachid>
            <date>2014-05-17 07:07:53 -0700</date>
            <delta_ts>2014-05-25 04:22:59 -0700</delta_ts>
            <desc>my changes to webkit</desc>
            <filename>wk.patch</filename>
            <type>text/plain</type>
            <size>2978</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">LS0tIHdlYmtpdGd0ay0yLjQuMS5vbGQvU291cmNlL1dURi9HTlVtYWtlZmlsZS5saXN0LmFtCTIw
MTQtMDQtMTQgMDY6NDA6NDUgKzAwMDAKKysrIHdlYmtpdGd0ay0yLjQuMS9Tb3VyY2UvV1RGL0dO
VW1ha2VmaWxlLmxpc3QuYW0JMjAxNC0wNS0xNyAwOTo1NDo0MSArMDAwMApAQCAtMjU2LDMgKzI1
Niw4IEBAIHd0Zl9zb3VyY2VzICs9IFwKICAgICBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL1VuaWNv
ZGVNYWNyb3NGcm9tSUNVLmggXAogICAgIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvaWN1L0NvbGxh
dG9ySUNVLmNwcCBcCiAgICAgU291cmNlL1dURi93dGYvdW5pY29kZS9pY3UvVW5pY29kZUljdS5o
CisKK2lmIFRBUkdFVF9XSU4zMgord3RmX3NvdXJjZXMgKz0gXAorICAgIFNvdXJjZS9XVEYvd3Rm
L3dpbi9HZGlPYmplY3QuaAorZW5kaWYgIyBUQVJHRVRfV0lOMzIKLS0tIHdlYmtpdGd0ay0yLjQu
MS5vbGQvU291cmNlL1dURi93dGYvd2luL0dESU9iamVjdC5oCTIwMTQtMDUtMTcgMDc6NDI6NTAg
KzAwMDAKKysrIHdlYmtpdGd0ay0yLjQuMS9Tb3VyY2UvV1RGL3d0Zi93aW4vR0RJT2JqZWN0LmgJ
MjAxNC0wNS0xNyAxMTozOToyNSArMDAwMApAQCAtMzUsMTQgKzM1LDE0IEBACiAKIG5hbWVzcGFj
ZSBXVEYgewogCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPiB2b2lkIGRlbGV0ZU9iamVjdChUKTsKK3Rl
bXBsYXRlPHR5cGVuYW1lIFQ+IHZvaWQgZGVsZXRlT2JqZWN0R0RJKFQpOwogCiB0ZW1wbGF0ZTx0
eXBlbmFtZSBUPiBjbGFzcyBHRElPYmplY3QgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEdE
SU9iamVjdCk7CiBwdWJsaWM6CiAgICAgR0RJT2JqZWN0KCkgOiBtX29iamVjdCgwKSB7IH0KICAg
ICBHRElPYmplY3Qoc3RkOjpudWxscHRyX3QpIDogbV9vYmplY3QoMCkgeyB9Ci0gICAgfkdESU9i
amVjdCgpIHsgZGVsZXRlT2JqZWN0PFQ+KG1fb2JqZWN0KTsgfQorICAgIH5HRElPYmplY3QoKSB7
IGRlbGV0ZU9iamVjdEdESTxUPihtX29iamVjdCk7IH0KIAogICAgIFQgZ2V0KCkgY29uc3QgeyBy
ZXR1cm4gbV9vYmplY3Q7IH0KIApAQCAtNzgsNyArNzgsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBU
PiBpbmxpbmUgdm9pZCBHRElPYmplCiB7CiAgICAgVCBvYmplY3QgPSBtX29iamVjdDsKICAgICBt
X29iamVjdCA9IDA7Ci0gICAgZGVsZXRlT2JqZWN0KG9iamVjdCk7CisgICAgZGVsZXRlT2JqZWN0
R0RJKG9iamVjdCk7CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBUIEdESU9iamVj
dDxUPjo6bGVhaygpCkBAIC0xMTEsMTMgKzExMSwxMyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBp
bmxpbmUgdm9pZCBzd2FwKEdECiB9CiAKIC8vIE5lYXJseSBhbGwgR0RJIHR5cGVzIHVzZSB0aGUg
c2FtZSBEZWxldGVPYmplY3QgY2FsbC4KLXRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB2b2lk
IGRlbGV0ZU9iamVjdDxUPihUIG9iamVjdCkKK3RlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB2
b2lkIGRlbGV0ZU9iamVjdEdESShUIG9iamVjdCkKIHsKICAgICBpZiAob2JqZWN0KQogICAgICAg
ICA6OkRlbGV0ZU9iamVjdChvYmplY3QpOwogfQogCi10ZW1wbGF0ZTw+IGlubGluZSB2b2lkIGRl
bGV0ZU9iamVjdDxIREM+KEhEQyBoZGMpCit0ZW1wbGF0ZTw+IGlubGluZSB2b2lkIGRlbGV0ZU9i
amVjdEdESTxIREM+KEhEQyBoZGMpCiB7CiAgICAgaWYgKGhkYykKICAgICAgICAgOjpEZWxldGVE
QyhoZGMpOwotLS0gd2Via2l0Z3RrLTIuNC4xLm9sZC9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmls
ZS5saXN0LmFtCTIwMTQtMDQtMTQgMDc6NTc6NDIgKzAwMDAKKysrIHdlYmtpdGd0ay0yLjQuMS9T
b3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCTIwMTQtMDUtMTcgMDc6NDU6MjMgKzAw
MDAKQEAgLTYyODEsOSArNjI4MywxMiBAQCB3ZWJjb3JlX3NvdXJjZXMgKz0gXAogCVNvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5jcHAg
XAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRX
aW4uY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTG9jYWxXaW5k
b3dzQ29udGV4dC5oIFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vU2hh
cmVkR0RJT2JqZWN0LmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9U
cmFuc2Zvcm1hdGlvbk1hdHJpeFdpbi5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dp
bi9CaXRtYXBJbmZvLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0JpdG1hcElu
Zm8uaCBcCisJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0dESU9iamVjdENvdW50ZXIuY3Bw
IFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vR0RJT2JqZWN0Q291bnRlci5oIFwKIAlT
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vU3lzdGVtSW5mby5jcHAgXAogCVNvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL3dpbi9TeXN0ZW1JbmZvLmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L3dpbi9XZWJDb3JlSW5zdGFuY2VIYW5kbGUuY3BwIFwKLS0tIHdlYmtpdGd0ay0yLjQuMS5vbGQv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dENhaXJv
V2luLmNwcAkyMDE0LTA1LTE2IDE5OjA3OjUzICswMDAwCisrKyB3ZWJraXRndGstMi40LjEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dENhaXJvV2lu
LmNwcAkyMDE0LTA1LTE3IDA5OjU0OjA5ICswMDAwCkBAIC0zMiw2ICszMiw3IEBACiAKICNpbmNs
dWRlIDxjYWlyby13aW4zMi5oPgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJp
dmF0ZUNhaXJvLmgiCisjaW5jbHVkZSA8d3RmL3dpbi9HZGlPYmplY3QuaD4KIAogdXNpbmcgbmFt
ZXNwYWNlIHN0ZDsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>232033</attachid>
            <date>2014-05-25 04:22:59 -0700</date>
            <delta_ts>2014-05-26 00:44:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>132814.diff</filename>
            <type>text/plain</type>
            <size>3129</size>
            <attacher name="Alberto Garcia">berto</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK
aW5kZXggNDRlOTIzNi4uM2VhNzJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wNS0yNSAg
TWlsYW4gQ3JoYSAgPG1jcmhhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW1N0YWJsZV0gW0dUS10g
R2RpT2JqZWN0LmggbWlzc2luZyBpbiBXZWJLaXRHVEsgMi40LjEgdGFyYmFsbAorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyODE0CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgZmlsZXMg
dG8gZml4IHRoZSBtaW5ndzMyIGJ1aWxkLgorCisgICAgICAgICogR05VbWFrZWZpbGUubGlzdC5h
bToKKwogMjAxNC0wNC0xOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAg
ICAgIE1ha2UgaXQgZWFzaWVyIHRvIGNoZWNrIGlmIGFuIGludGVnZXIgc3VtIHdvdWxkIG92ZXJm
bG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0dOVW1ha2VmaWxlLmxpc3QuYW0gYi9Tb3VyY2Uv
V1RGL0dOVW1ha2VmaWxlLmxpc3QuYW0KaW5kZXggODY3ODVmMi4uYmQyODg3NCAxMDA2NDQKLS0t
IGEvU291cmNlL1dURi9HTlVtYWtlZmlsZS5saXN0LmFtCisrKyBiL1NvdXJjZS9XVEYvR05VbWFr
ZWZpbGUubGlzdC5hbQpAQCAtMjU1LDQgKzI1NSw1IEBAIHd0Zl9zb3VyY2VzICs9IFwKICAgICBT
b3VyY2UvV1RGL3d0Zi91bmljb2RlL1VuaWNvZGUuaCBcCiAgICAgU291cmNlL1dURi93dGYvdW5p
Y29kZS9Vbmljb2RlTWFjcm9zRnJvbUlDVS5oIFwKICAgICBTb3VyY2UvV1RGL3d0Zi91bmljb2Rl
L2ljdS9Db2xsYXRvcklDVS5jcHAgXAotICAgIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvaWN1L1Vu
aWNvZGVJY3UuaAorICAgIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvaWN1L1VuaWNvZGVJY3UuaCBc
CisgICAgU291cmNlL1dURi93dGYvd2luL0dESU9iamVjdC5oCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI3YzE0
Ny4uMDE2MzZmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTI1ICBNaWxh
biBDcmhhICA8bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbU3RhYmxlXSBbR1RLXSBHZGlP
YmplY3QuaCBtaXNzaW5nIGluIFdlYktpdEdUSyAyLjQuMSB0YXJiYWxsCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI4MTQKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2luZyBmaWxlcyBhbmQg
aW5jbHVkZXMgdG8gZml4IHRoZSBtaW5ndzMyIGJ1aWxkLgorCisgICAgICAgICogR05VbWFrZWZp
bGUubGlzdC5hbToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250
ZXh0Q2Fpcm9XaW4uY3BwOgorCiAyMDE0LTA1LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn
YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0gVExTRXJyb3JzIGRvIG5vdCBjYXVz
ZSBwYWdlIGxvYWQgdG8gZmFpbCB3aGVuIG5vdCBpZ25vcmVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUu
bGlzdC5hbQppbmRleCAxN2RjYzVjLi43MGU4YWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9HTlVtYWtlZmlsZS5saXN0LmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxp
c3QuYW0KQEAgLTYyODEsOSArNjI4MSwxMiBAQCB3ZWJjb3JlX3NvdXJjZXMgKz0gXAogCVNvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5j
cHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRl
eHRXaW4uY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTG9jYWxX
aW5kb3dzQ29udGV4dC5oIFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4v
U2hhcmVkR0RJT2JqZWN0LmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp
bi9UcmFuc2Zvcm1hdGlvbk1hdHJpeFdpbi5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L3dpbi9CaXRtYXBJbmZvLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0JpdG1h
cEluZm8uaCBcCisJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0dESU9iamVjdENvdW50ZXIu
Y3BwIFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vR0RJT2JqZWN0Q291bnRlci5oIFwK
IAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vU3lzdGVtSW5mby5jcHAgXAogCVNvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL3dpbi9TeXN0ZW1JbmZvLmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL3dpbi9XZWJDb3JlSW5zdGFuY2VIYW5kbGUuY3BwIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0Q2Fp
cm9XaW4uY3BwCmluZGV4IGNlNmMwNTQuLjFiMmQ4NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5jcHAKKysr
IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dENh
aXJvV2luLmNwcApAQCAtMzIsNiArMzIsNyBAQAogCiAjaW5jbHVkZSA8Y2Fpcm8td2luMzIuaD4K
ICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDYWlyby5oIgorI2luY2x1
ZGUgPHd0Zi93aW4vR2RpT2JqZWN0Lmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAK
</data>
<flag name="review"
          id="256506"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
          </attachment>
      

    </bug>

</bugzilla>