132810 2014-05-11 20:24:32 -0700 REGRESSION(r168603): [GTK] Build broken. 2014-05-11 23:22:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 isair webkit-unassigned berto cgarcia commit-queue gustavo mrobinson oldest_to_newest 1008471 0 isair 2014-05-11 20:24:32 -0700 Revision r168118 <http://trac.webkit.org/changeset/168603> broke the GTK Build: ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp: In function 'void* createDefaultWebContext(gpointer)': ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:256:98: error: no matching function for call to 'WebKit::WebContext::create(WTF::String)' ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:256:98: note: candidate is: In file included from ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h:30:0, from ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:42: ../../Source/WebKit2/UIProcess/WebContext.h:110:35: note: static WTF::PassRefPtr<WebKit::WebContext> WebKit::WebContext::create(WebKit::WebContextConfiguration) ../../Source/WebKit2/UIProcess/WebContext.h:110:35: note: no known conversion for argument 1 from 'WTF::String' to 'WebKit::WebContextConfiguration' 1008473 1 231273 isair 2014-05-11 20:39:27 -0700 Created attachment 231273 Patch 1008474 2 commit-queue 2014-05-11 20:42:03 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1008480 3 231273 cgarcia 2014-05-11 22:51:48 -0700 Comment on attachment 231273 Patch Thanks! 1008482 4 231273 commit-queue 2014-05-11 23:22:16 -0700 Comment on attachment 231273 Patch Clearing flags on attachment: 231273 Committed r168608: <http://trac.webkit.org/changeset/168608> 1008483 5 commit-queue 2014-05-11 23:22:19 -0700 All reviewed patches have been landed. Closing bug. 231273 2014-05-11 20:39:27 -0700 2014-05-11 23:22:15 -0700 Patch bug-132810-20140512123904.patch text/plain 1962 isair U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDA0MjMzOGE3MDgxNjgy NWQzYjFlNjk4OTY3MGUzMWE4YWUwMWEzNy4uNzlmNGE4NTY3Yzk4NjlkNWZkMTk5ZDgxYTIxN2Q3 YTA3YmU3YTZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTExICBTZW9u Z2p1biBLaW0gIDxpc0FpckBjb21wYW55MTAwLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIx Njg2MDMpOiBbR1RLXSBCdWlsZCBicm9rZW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI4MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQu Y3BwOgorICAgICAgICAoY3JlYXRlRGVmYXVsdFdlYkNvbnRleHQpOgorICAgICAgICBDb25zdHJ1 Y3QgYSBXZWJDb250ZXh0Q29uZmlndXJhdGlvbiBvYmplY3QgYW5kIHBhc3MgaXQgdG8gV2ViQ29u dGV4dDo6Y3JlYXRlLgorCiAyMDE0LTA1LTExICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGxvY2FsIHN0b3JhZ2UgZGlyZWN0b3J5IGFuZCBz YW5kYm94IGV4dGVuc2lvbiBmcm9tIFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5j cHAKaW5kZXggNDAyMmJiNzJlZWQ0MjFlOTFmNjQzNjk2MmEyOGM2MTkyOGE4ZTFlNy4uMTdiYmNj NWVlNGVmYmRlNjg5NGIwZmVkYmExYTQ1MzExMzlkMzk5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAKQEAgLTI1Myw3 ICsyNTMsMTAgQEAgc3RhdGljIGdwb2ludGVyIGNyZWF0ZURlZmF1bHRXZWJDb250ZXh0KGdwb2lu dGVyKQogICAgIHN0YXRpYyBHUmVmUHRyPFdlYktpdFdlYkNvbnRleHQ+IHdlYkNvbnRleHQgPSBh ZG9wdEdSZWYoV0VCS0lUX1dFQl9DT05URVhUKGdfb2JqZWN0X25ldyhXRUJLSVRfVFlQRV9XRUJf Q09OVEVYVCwgTlVMTCkpKTsKICAgICBXZWJLaXRXZWJDb250ZXh0UHJpdmF0ZSogcHJpdiA9IHdl YkNvbnRleHQtPnByaXY7CiAKLSAgICBwcml2LT5jb250ZXh0ID0gV2ViQ29udGV4dDo6Y3JlYXRl KFdlYkNvcmU6OmZpbGVuYW1lVG9TdHJpbmcoaW5qZWN0ZWRCdW5kbGVGaWxlbmFtZSgpLmRhdGEo KSkpOworICAgIFdlYkNvbnRleHRDb25maWd1cmF0aW9uIHdlYkNvbnRleHRDb25maWd1cmF0aW9u OworICAgIHdlYkNvbnRleHRDb25maWd1cmF0aW9uLmluamVjdGVkQnVuZGxlUGF0aCA9IFdlYkNv cmU6OmZpbGVuYW1lVG9TdHJpbmcoaW5qZWN0ZWRCdW5kbGVGaWxlbmFtZSgpLmRhdGEoKSk7Cisg ICAgcHJpdi0+Y29udGV4dCA9IFdlYkNvbnRleHQ6OmNyZWF0ZShzdGQ6Om1vdmUod2ViQ29udGV4 dENvbmZpZ3VyYXRpb24pKTsKKwogICAgIHByaXYtPnJlcXVlc3RNYW5hZ2VyID0gd2ViQ29udGV4 dC0+cHJpdi0+Y29udGV4dC0+c3VwcGxlbWVudDxXZWJTb3VwQ3VzdG9tUHJvdG9jb2xSZXF1ZXN0 TWFuYWdlcj4oKTsKICAgICBwcml2LT5jb250ZXh0LT5zZXRDYWNoZU1vZGVsKENhY2hlTW9kZWxQ cmltYXJ5V2ViQnJvd3Nlcik7CiAgICAgcHJpdi0+dGxzRXJyb3JzUG9saWN5ID0gV0VCS0lUX1RM U19FUlJPUlNfUE9MSUNZX0lHTk9SRTsK