132792 2014-05-10 17:13:19 -0700 ASSERTION FAILED: !m_connection under RunJavaScriptAlert 2014-05-10 17:30:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1008340 0 andersca 2014-05-10 17:13:19 -0700 ASSERTION FAILED: !m_connection under RunJavaScriptAlert 1008341 1 231243 andersca 2014-05-10 17:15:16 -0700 Created attachment 231243 Patch 1008344 2 commit-queue 2014-05-10 17:17:39 -0700 Attachment 231243 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:198: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1008345 3 andersca 2014-05-10 17:30:49 -0700 Committed r168588: <http://trac.webkit.org/changeset/168588> 231243 2014-05-10 17:15:16 -0700 2014-05-10 17:29:29 -0700 Patch bug-132792-20140511001453.patch text/plain 6525 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDA4YTk1YzNhZGM0NmUx NTEyMWE3Yjc2ZmFmNDgyN2FhZDU0ZDk5MC4uZTA2ZTE5OTVhMDc0YzdhNTZhNmYyODkzOGQxODkx ZGE3NzJjNGQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTA1LTEwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQVNTRVJUSU9OIEZB SUxFRDogIW1fY29ubmVjdGlvbiB1bmRlciBSdW5KYXZhU2NyaXB0QWxlcnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjc5MgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTY2OTExMzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRGV0ZWN0IGlmIHNvbWVvbmUgaW1wbGVtZW50aW5nIGEgVUkgZGVsZWdh dGUgbWV0aG9kIHdpdGggYSBjb21wbGV0aW9uIGhhbmRsZXIgbmV2ZXIgY2FsbHMgdGhlIGNvbXBs ZXRpb24KKyAgICAgICAgaGFuZGxlciBhbmQgcmFpc2UgYW4gZXhjZXB0aW9uIGluc3RlYWQgb2Yg YXNzZXJ0aW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW06Cisg ICAgICAgIChXZWJLaXQ6OkNvbXBsZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI6OmNyZWF0ZSk6Cisg ICAgICAgIChXZWJLaXQ6OkNvbXBsZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI6On5Db21wbGV0aW9u SGFuZGxlckNhbGxDaGVja2VyKToKKyAgICAgICAgKFdlYktpdDo6Q29tcGxldGlvbkhhbmRsZXJD YWxsQ2hlY2tlcjo6ZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVyKToKKyAgICAgICAgKFdlYktpdDo6 Q29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tlcjo6Q29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tl cik6CisgICAgICAgIChXZWJLaXQ6OkNvbXBsZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI6OmNsYXNz SW1wbGVtZW50aW5nRGVsZWdhdGVNZXRob2QpOgorICAgICAgICAoV2ViS2l0OjpVSURlbGVnYXRl OjpVSUNsaWVudDo6cnVuSmF2YVNjcmlwdEFsZXJ0KToKKyAgICAgICAgKFdlYktpdDo6VUlEZWxl Z2F0ZTo6VUlDbGllbnQ6OnJ1bkphdmFTY3JpcHRDb25maXJtKToKKyAgICAgICAgKFdlYktpdDo6 VUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OnJ1bkphdmFTY3JpcHRQcm9tcHQpOgorCisyMDE0LTA1LTEw ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgVXNlIHhw Y19jb25uZWN0aW9uX2tpbGwgZm9yIGtpbGxpbmcgY2hpbGQgcHJvY2Vzc2VzIHdoZXJlIGFwcHJv cHJpYXRlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzI3ODgKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NjY0MTg1PgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbQppbmRleCBiNzdmYTExNDhiZDE0NDAzMzE0 Zjk0ZGM2MTdiZjlhNWFjYzQwOTE5Li5lZjQ5ODNiNTgxOWNkNzJkY2ZhZTdkNjIwNDFhZDJlYmNm ZjllOTVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvVUlEZWxl Z2F0ZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5t bQpAQCAtMzgsNiArMzgsNTcgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIENvbXBs ZXRpb25IYW5kbGVyQ2FsbENoZWNrZXIgOiBwdWJsaWMgV1RGOjpUaHJlYWRTYWZlUmVmQ291bnRl ZDxDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyPiB7CitwdWJsaWM6CisgICAgc3RhdGljIFBh c3NSZWZQdHI8Q29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tlcj4gY3JlYXRlKGlkIGRlbGVnYXRl LCBTRUwgZGVsZWdhdGVNZXRob2RTZWxlY3RvcikKKyAgICB7CisgICAgICAgIHJldHVybiBhZG9w dFJlZihuZXcgQ29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tlcihvYmplY3RfZ2V0Q2xhc3MoZGVs ZWdhdGUpLCBkZWxlZ2F0ZU1ldGhvZFNlbGVjdG9yKSk7CisgICAgfQorCisgICAgfkNvbXBsZXRp b25IYW5kbGVyQ2FsbENoZWNrZXIoKQorICAgIHsKKyAgICAgICAgaWYgKG1fZGlkQ2FsbENvbXBs ZXRpb25IYW5kbGVyKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIENsYXNzIGRlbGVn YXRlQ2xhc3MgPSBjbGFzc0ltcGxlbWVudGluZ0RlbGVnYXRlTWV0aG9kKCk7CisgICAgICAgIFtO U0V4Y2VwdGlvbiByYWlzZTpOU0ludGVybmFsSW5jb25zaXN0ZW5jeUV4Y2VwdGlvbiBmb3JtYXQ6 QCJDb21wbGV0aW9uIGhhbmRsZXIgcGFzc2VkIHRvICVjWyVAICVAXSB3YXMgbm90IGNhbGxlZCIs IGNsYXNzX2lzTWV0YUNsYXNzKGRlbGVnYXRlQ2xhc3MpID8gJysnIDogJy0nLCBOU1N0cmluZ0Zy b21DbGFzcyhkZWxlZ2F0ZUNsYXNzKSwgTlNTdHJpbmdGcm9tU2VsZWN0b3IobV9kZWxlZ2F0ZU1l dGhvZFNlbGVjdG9yKV07CisgICAgfQorCisgICAgdm9pZCBkaWRDYWxsQ29tcGxldGlvbkhhbmRs ZXIoKQorICAgIHsKKyAgICAgICAgQVNTRVJUKCFtX2RpZENhbGxDb21wbGV0aW9uSGFuZGxlcik7 CisgICAgICAgIG1fZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVyID0gdHJ1ZTsKKyAgICB9CisKK3By aXZhdGU6CisgICAgQ29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tlcihDbGFzcyBkZWxlZ2F0ZUNs YXNzLCBTRUwgZGVsZWdhdGVNZXRob2RTZWxlY3RvcikKKyAgICAgICAgOiBtX2RlbGVnYXRlQ2xh c3MoZGVsZWdhdGVDbGFzcykKKyAgICAgICAgLCBtX2RlbGVnYXRlTWV0aG9kU2VsZWN0b3IoZGVs ZWdhdGVNZXRob2RTZWxlY3RvcikKKyAgICAgICAgLCBtX2RpZENhbGxDb21wbGV0aW9uSGFuZGxl cihmYWxzZSkKKyAgICB7CisgICAgfQorCisgICAgQ2xhc3MgY2xhc3NJbXBsZW1lbnRpbmdEZWxl Z2F0ZU1ldGhvZCgpIGNvbnN0CisgICAgeworICAgICAgICBDbGFzcyBkZWxlZ2F0ZUNsYXNzID0g bV9kZWxlZ2F0ZUNsYXNzOworICAgICAgICBNZXRob2QgZGVsZWdhdGVNZXRob2QgPSBjbGFzc19n ZXRJbnN0YW5jZU1ldGhvZChkZWxlZ2F0ZUNsYXNzLCBtX2RlbGVnYXRlTWV0aG9kU2VsZWN0b3Ip OworCisgICAgICAgIGZvciAoQ2xhc3Mgc3VwZXJjbGFzcyA9IGNsYXNzX2dldFN1cGVyY2xhc3Mo ZGVsZWdhdGVDbGFzcyk7IHN1cGVyY2xhc3M7IHN1cGVyY2xhc3MgPSBjbGFzc19nZXRTdXBlcmNs YXNzKHN1cGVyY2xhc3MpKSB7CisgICAgICAgICAgICBpZiAoY2xhc3NfZ2V0SW5zdGFuY2VNZXRo b2Qoc3VwZXJjbGFzcywgbV9kZWxlZ2F0ZU1ldGhvZFNlbGVjdG9yKSAhPSBkZWxlZ2F0ZU1ldGhv ZCkKKyAgICAgICAgICAgICAgICBicmVhazsKKworICAgICAgICAgICAgZGVsZWdhdGVDbGFzcyA9 IHN1cGVyY2xhc3M7CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gZGVsZWdhdGVDbGFzczsK KyAgICB9CisKKyAgICBDbGFzcyBtX2RlbGVnYXRlQ2xhc3M7CisgICAgU0VMIG1fZGVsZWdhdGVN ZXRob2RTZWxlY3RvcjsKKyAgICBib29sIG1fZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVyOworfTsK KworCiBVSURlbGVnYXRlOjpVSURlbGVnYXRlKFdLV2ViVmlldyAqd2ViVmlldykKICAgICA6IG1f d2ViVmlldyh3ZWJWaWV3KQogewpAQCAtMTIzLDggKzE3NCwxMCBAQCB2b2lkIFVJRGVsZWdhdGU6 OlVJQ2xpZW50OjpydW5KYXZhU2NyaXB0QWxlcnQoV2ViS2l0OjpXZWJQYWdlUHJveHkqLCBjb25z dCBXVEY6OgogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgW2RlbGVnYXRlIHdlYlZpZXc6 bV91aURlbGVnYXRlLm1fd2ViVmlldyBydW5KYXZhU2NyaXB0QWxlcnRQYW5lbFdpdGhNZXNzYWdl Om1lc3NhZ2UgaW5pdGlhdGVkQnlGcmFtZTphZG9wdE5TKFtbV0tGcmFtZUluZm8gYWxsb2NdIGlu aXRXaXRoV2ViRnJhbWVQcm94eToqd2ViRnJhbWVQcm94eV0pLmdldCgpIGNvbXBsZXRpb25IYW5k bGVyOltjb21wbGV0aW9uSGFuZGxlcl0geworICAgIFJlZlB0cjxDb21wbGV0aW9uSGFuZGxlckNh bGxDaGVja2VyPiBjaGVja2VyID0gQ29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tlcjo6Y3JlYXRl KGRlbGVnYXRlLmdldCgpLCBAc2VsZWN0b3Iod2ViVmlldzpydW5KYXZhU2NyaXB0QWxlcnRQYW5l bFdpdGhNZXNzYWdlOmluaXRpYXRlZEJ5RnJhbWU6Y29tcGxldGlvbkhhbmRsZXI6KSk7CisgICAg W2RlbGVnYXRlIHdlYlZpZXc6bV91aURlbGVnYXRlLm1fd2ViVmlldyBydW5KYXZhU2NyaXB0QWxl cnRQYW5lbFdpdGhNZXNzYWdlOm1lc3NhZ2UgaW5pdGlhdGVkQnlGcmFtZTphZG9wdE5TKFtbV0tG cmFtZUluZm8gYWxsb2NdIGluaXRXaXRoV2ViRnJhbWVQcm94eToqd2ViRnJhbWVQcm94eV0pLmdl dCgpIGNvbXBsZXRpb25IYW5kbGVyOltjb21wbGV0aW9uSGFuZGxlciwgY2hlY2tlcl0gewogICAg ICAgICBjb21wbGV0aW9uSGFuZGxlcigpOworICAgICAgICBjaGVja2VyLT5kaWRDYWxsQ29tcGxl dGlvbkhhbmRsZXIoKTsKICAgICB9XTsKIH0KIApAQCAtMTQxLDggKzE5NCwxMCBAQCB2b2lkIFVJ RGVsZWdhdGU6OlVJQ2xpZW50OjpydW5KYXZhU2NyaXB0Q29uZmlybShXZWJLaXQ6OldlYlBhZ2VQ cm94eSosIGNvbnN0IFdURgogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgW2RlbGVnYXRl IHdlYlZpZXc6bV91aURlbGVnYXRlLm1fd2ViVmlldyBydW5KYXZhU2NyaXB0Q29uZmlybVBhbmVs V2l0aE1lc3NhZ2U6bWVzc2FnZSBpbml0aWF0ZWRCeUZyYW1lOmFkb3B0TlMoW1tXS0ZyYW1lSW5m byBhbGxvY10gaW5pdFdpdGhXZWJGcmFtZVByb3h5Oip3ZWJGcmFtZVByb3h5XSkuZ2V0KCkgY29t cGxldGlvbkhhbmRsZXI6W2NvbXBsZXRpb25IYW5kbGVyXShCT09MIHJlc3VsdCkgeworICAgIFJl ZlB0cjxDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyPiBjaGVja2VyID0gQ29tcGxldGlvbkhh bmRsZXJDYWxsQ2hlY2tlcjo6Y3JlYXRlKGRlbGVnYXRlLmdldCgpLCBAc2VsZWN0b3Iod2ViVmll dzpydW5KYXZhU2NyaXB0Q29uZmlybVBhbmVsV2l0aE1lc3NhZ2U6aW5pdGlhdGVkQnlGcmFtZTpj b21wbGV0aW9uSGFuZGxlcjopKTsKKyAgICBbZGVsZWdhdGUgd2ViVmlldzptX3VpRGVsZWdhdGUu bV93ZWJWaWV3IHJ1bkphdmFTY3JpcHRDb25maXJtUGFuZWxXaXRoTWVzc2FnZTptZXNzYWdlIGlu aXRpYXRlZEJ5RnJhbWU6YWRvcHROUyhbW1dLRnJhbWVJbmZvIGFsbG9jXSBpbml0V2l0aFdlYkZy YW1lUHJveHk6KndlYkZyYW1lUHJveHldKS5nZXQoKSBjb21wbGV0aW9uSGFuZGxlcjpbY29tcGxl dGlvbkhhbmRsZXIsIGNoZWNrZXJdKEJPT0wgcmVzdWx0KSB7CiAgICAgICAgIGNvbXBsZXRpb25I YW5kbGVyKHJlc3VsdCk7CisgICAgICAgIGNoZWNrZXItPmRpZENhbGxDb21wbGV0aW9uSGFuZGxl cigpOwogICAgIH1dOwogfQogCkBAIC0xNTksOCArMjE0LDEwIEBAIHZvaWQgVUlEZWxlZ2F0ZTo6 VUlDbGllbnQ6OnJ1bkphdmFTY3JpcHRQcm9tcHQoV2ViS2l0OjpXZWJQYWdlUHJveHkqLCBjb25z dCBXVEY6CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBbZGVsZWdhdGUgd2ViVmlldzpt X3VpRGVsZWdhdGUubV93ZWJWaWV3IHJ1bkphdmFTY3JpcHRUZXh0SW5wdXRQYW5lbFdpdGhQcm9t cHQ6bWVzc2FnZSBkZWZhdWx0VGV4dDpkZWZhdWx0VmFsdWUgaW5pdGlhdGVkQnlGcmFtZTphZG9w dE5TKFtbV0tGcmFtZUluZm8gYWxsb2NdIGluaXRXaXRoV2ViRnJhbWVQcm94eToqd2ViRnJhbWVQ cm94eV0pLmdldCgpIGNvbXBsZXRpb25IYW5kbGVyOltjb21wbGV0aW9uSGFuZGxlcl0oTlNTdHJp bmcgKnJlc3VsdCkgeworICAgIFJlZlB0cjxDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyPiBj aGVja2VyID0gQ29tcGxldGlvbkhhbmRsZXJDYWxsQ2hlY2tlcjo6Y3JlYXRlKGRlbGVnYXRlLmdl dCgpLCBAc2VsZWN0b3Iod2ViVmlldzpydW5KYXZhU2NyaXB0VGV4dElucHV0UGFuZWxXaXRoUHJv bXB0OmRlZmF1bHRUZXh0OmluaXRpYXRlZEJ5RnJhbWU6Y29tcGxldGlvbkhhbmRsZXI6KSk7Cisg ICAgW2RlbGVnYXRlIHdlYlZpZXc6bV91aURlbGVnYXRlLm1fd2ViVmlldyBydW5KYXZhU2NyaXB0 VGV4dElucHV0UGFuZWxXaXRoUHJvbXB0Om1lc3NhZ2UgZGVmYXVsdFRleHQ6ZGVmYXVsdFZhbHVl IGluaXRpYXRlZEJ5RnJhbWU6YWRvcHROUyhbW1dLRnJhbWVJbmZvIGFsbG9jXSBpbml0V2l0aFdl YkZyYW1lUHJveHk6KndlYkZyYW1lUHJveHldKS5nZXQoKSBjb21wbGV0aW9uSGFuZGxlcjpbY29t cGxldGlvbkhhbmRsZXIsIGNoZWNrZXJdKE5TU3RyaW5nICpyZXN1bHQpIHsKICAgICAgICAgY29t cGxldGlvbkhhbmRsZXIocmVzdWx0KTsKKyAgICAgICAgY2hlY2tlci0+ZGlkQ2FsbENvbXBsZXRp b25IYW5kbGVyKCk7CiAgICAgfV07CiB9CiAK