132790 2014-05-10 16:53:29 -0700 Implement -forwardingTargetForSelector on WKScrollViewDelegateForwarder 2014-05-10 20:33:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca mitz sam simon.fraser webkit-bug-importer oldest_to_newest 1008332 0 thorton 2014-05-10 16:53:29 -0700 This is a ~4.3% win on UI process total time (5%->0.7%) running http://www.kevs3d.co.uk/dev/canvasmark/, as predicted by https://bugs.webkit.org/show_bug.cgi?id=127085#c2. 1008333 1 webkit-bug-importer 2014-05-10 16:53:47 -0700 <rdar://problem/16877802> 1008359 2 231244 thorton 2014-05-10 20:15:27 -0700 Created attachment 231244 patch 1008360 3 231244 mitz 2014-05-10 20:20:15 -0700 Comment on attachment 231244 patch View in context: https://bugs.webkit.org/attachment.cgi?id=231244&action=review > Source/WebKit2/UIProcess/ios/WKScrollView.mm:91 > + BOOL internalDelegateWillRespond = [_internalDelegate respondsToSelector:aSelector]; > + BOOL externalDelegateWillRespond = [_externalDelegate respondsToSelector:aSelector]; We could make things even faster by caching these for some or all selectors. > Source/WebKit2/UIProcess/ios/WKScrollView.mm:97 > + return self; The documentation for -forwardingTargetForSelector: says (Obviously if you return self from this method, the code would just fall into an infinite loop.) Why are you returning self? 1008363 4 thorton 2014-05-10 20:24:22 -0700 (In reply to comment #3) > (From update of attachment 231244 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231244&action=review > > > Source/WebKit2/UIProcess/ios/WKScrollView.mm:91 > > + BOOL internalDelegateWillRespond = [_internalDelegate respondsToSelector:aSelector]; > > + BOOL externalDelegateWillRespond = [_externalDelegate respondsToSelector:aSelector]; > > We could make things even faster by caching these for some or all selectors. > > > Source/WebKit2/UIProcess/ios/WKScrollView.mm:97 > > + return self; > > The documentation for -forwardingTargetForSelector: says > (Obviously if you return self from this method, the code would just fall into an infinite loop.) > Why are you returning self? Ha! I missed that, and misunderstood the fallback case. Also that suggests to me that we never run into this case, because I haven't seen any infinite loops yet today :D 1008364 5 231246 thorton 2014-05-10 20:31:18 -0700 Created attachment 231246 patch 1008365 6 thorton 2014-05-10 20:33:25 -0700 http://trac.webkit.org/changeset/168593 231244 2014-05-10 20:15:27 -0700 2014-05-10 20:31:18 -0700 patch invocation.diff text/plain 1686 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZjQyNGYxLi45M2JjM2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDUtMTAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgSW1wbGVtZW50IC1mb3J3YXJkaW5nVGFyZ2V0Rm9yU2VsZWN0b3Igb24gV0tTY3Jv bGxWaWV3RGVsZWdhdGVGb3J3YXJkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMjc5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY4Nzc4MDI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLU2Nyb2xsVmlldy5tbToKKyAgICAgICAgKC1bV0tTY3JvbGxWaWV3RGVsZWdh dGVGb3J3YXJkZXIgZm9yd2FyZGluZ1RhcmdldEZvclNlbGVjdG9yOl0pOgorICAgICAgICBJZiBv bmx5IG9uZSBvZiB0aGUgZGVsZWdhdGVzIHdpbGwgcmVzcG9uZCB0byBhIHNlbGVjdG9yLAorICAg ICAgICB3ZSBjYW4gcmV0dXJuIGl0IGZyb20gZm9yd2FyZGluZ1RhcmdldEZvclNlbGVjdG9yOiB0 byBhdm9pZAorICAgICAgICBOU0ludm9jYXRpb24gb3ZlcmhlYWQuCisKIDIwMTQtMDUtMDkgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFJlbW92ZSBh IGRlcHJlY2F0ZWQgYnVuZGxlIGZvcm0gZGVsZWdhdGUgbWV0aG9kIG5vdyB0aGF0IG5vIG9uZSBp bXBsZW1lbnRzIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL U2Nyb2xsVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3 Lm1tCmluZGV4IDQxYWUzYjguLjEwNThmMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tTY3JvbGxWaWV3Lm1tCkBAIC04NSw2ICs4NSwxOCBAQAogICAgICAgICBbc3VwZXIg Zm9yd2FyZEludm9jYXRpb246YW5JbnZvY2F0aW9uXTsKIH0KIAorLSAoaWQpZm9yd2FyZGluZ1Rh cmdldEZvclNlbGVjdG9yOihTRUwpYVNlbGVjdG9yCit7CisgICAgQk9PTCBpbnRlcm5hbERlbGVn YXRlV2lsbFJlc3BvbmQgPSBbX2ludGVybmFsRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOmFT ZWxlY3Rvcl07CisgICAgQk9PTCBleHRlcm5hbERlbGVnYXRlV2lsbFJlc3BvbmQgPSBbX2V4dGVy bmFsRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOmFTZWxlY3Rvcl07CisKKyAgICBpZiAoaW50 ZXJuYWxEZWxlZ2F0ZVdpbGxSZXNwb25kICYmICFleHRlcm5hbERlbGVnYXRlV2lsbFJlc3BvbmQp CisgICAgICAgIHJldHVybiBfaW50ZXJuYWxEZWxlZ2F0ZTsKKyAgICBpZiAoZXh0ZXJuYWxEZWxl Z2F0ZVdpbGxSZXNwb25kICYmICFpbnRlcm5hbERlbGVnYXRlV2lsbFJlc3BvbmQpCisgICAgICAg IHJldHVybiBfZXh0ZXJuYWxEZWxlZ2F0ZTsKKyAgICByZXR1cm4gc2VsZjsKK30KKwogQGVuZAog CiBAaW1wbGVtZW50YXRpb24gV0tTY3JvbGxWaWV3IHsK 231246 2014-05-10 20:31:18 -0700 2014-05-10 20:31:36 -0700 patch invocation.diff text/plain 1685 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZjQyNGYxLi45M2JjM2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDUtMTAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgSW1wbGVtZW50IC1mb3J3YXJkaW5nVGFyZ2V0Rm9yU2VsZWN0b3Igb24gV0tTY3Jv bGxWaWV3RGVsZWdhdGVGb3J3YXJkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMjc5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY4Nzc4MDI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLU2Nyb2xsVmlldy5tbToKKyAgICAgICAgKC1bV0tTY3JvbGxWaWV3RGVsZWdh dGVGb3J3YXJkZXIgZm9yd2FyZGluZ1RhcmdldEZvclNlbGVjdG9yOl0pOgorICAgICAgICBJZiBv bmx5IG9uZSBvZiB0aGUgZGVsZWdhdGVzIHdpbGwgcmVzcG9uZCB0byBhIHNlbGVjdG9yLAorICAg ICAgICB3ZSBjYW4gcmV0dXJuIGl0IGZyb20gZm9yd2FyZGluZ1RhcmdldEZvclNlbGVjdG9yOiB0 byBhdm9pZAorICAgICAgICBOU0ludm9jYXRpb24gb3ZlcmhlYWQuCisKIDIwMTQtMDUtMDkgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFJlbW92ZSBh IGRlcHJlY2F0ZWQgYnVuZGxlIGZvcm0gZGVsZWdhdGUgbWV0aG9kIG5vdyB0aGF0IG5vIG9uZSBp bXBsZW1lbnRzIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL U2Nyb2xsVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3 Lm1tCmluZGV4IDQxYWUzYjguLmY0MTIxMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tTY3JvbGxWaWV3Lm1tCkBAIC04NSw2ICs4NSwxOCBAQAogICAgICAgICBbc3VwZXIg Zm9yd2FyZEludm9jYXRpb246YW5JbnZvY2F0aW9uXTsKIH0KIAorLSAoaWQpZm9yd2FyZGluZ1Rh cmdldEZvclNlbGVjdG9yOihTRUwpYVNlbGVjdG9yCit7CisgICAgQk9PTCBpbnRlcm5hbERlbGVn YXRlV2lsbFJlc3BvbmQgPSBbX2ludGVybmFsRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOmFT ZWxlY3Rvcl07CisgICAgQk9PTCBleHRlcm5hbERlbGVnYXRlV2lsbFJlc3BvbmQgPSBbX2V4dGVy bmFsRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOmFTZWxlY3Rvcl07CisKKyAgICBpZiAoaW50 ZXJuYWxEZWxlZ2F0ZVdpbGxSZXNwb25kICYmICFleHRlcm5hbERlbGVnYXRlV2lsbFJlc3BvbmQp CisgICAgICAgIHJldHVybiBfaW50ZXJuYWxEZWxlZ2F0ZTsKKyAgICBpZiAoZXh0ZXJuYWxEZWxl Z2F0ZVdpbGxSZXNwb25kICYmICFpbnRlcm5hbERlbGVnYXRlV2lsbFJlc3BvbmQpCisgICAgICAg IHJldHVybiBfZXh0ZXJuYWxEZWxlZ2F0ZTsKKyAgICByZXR1cm4gbmlsOworfQorCiBAZW5kCiAK IEBpbXBsZW1lbnRhdGlvbiBXS1Njcm9sbFZpZXcgewo=