132783 2014-05-10 14:20:29 -0700 [iOS WebKit2] REGRESSION (r168493): Canvasmark 2013 benchmark always hits the RELEASE_ASSERT in RemoteLayerTreeDrawingArea::flushLayers() 2014-05-10 17:54:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue sam simon.fraser webkit-bug-importer oldest_to_newest 1008302 0 thorton 2014-05-10 14:20:29 -0700 Threading is hard (for me). This page: http://www.kevs3d.co.uk/dev/canvasmark/ always hits the RELEASE_ASSERT added in r168493 when running the benchmark. However! It's a total lie; we're getting didUpdate back from the UI process on the Web process's main thread while the Web process's CommitQueue is *in between* sendMessage() and setting m_hasFlushed. So, we assert. I'm going to move resetting m_hasFlushed *before* sendMessage(), because we really only care about asserting if we start flushing again before we have flushed the contexts; sendMessage() doesn't really have any bearing on flushing correctness. 1008303 1 webkit-bug-importer 2014-05-10 14:21:46 -0700 <rdar://problem/16877326> 1008305 2 231235 thorton 2014-05-10 14:30:08 -0700 Created attachment 231235 patch 1008349 3 231235 commit-queue 2014-05-10 17:54:00 -0700 Comment on attachment 231235 patch Clearing flags on attachment: 231235 Committed r168589: <http://trac.webkit.org/changeset/168589> 1008350 4 commit-queue 2014-05-10 17:54:03 -0700 All reviewed patches have been landed. Closing bug. 231235 2014-05-10 14:30:08 -0700 2014-05-10 17:54:00 -0700 patch race.diff text/plain 2110 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkZjQyNGYxLi5hNTYxMzIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTQtMDUtMTAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW2lPUyBXZWJLaXQyXSBSRUdSRVNTSU9OIChyMTY4NDkzKTogQ2FudmFzbWFyayAy MDEzIGJlbmNobWFyayBhbHdheXMgaGl0cyB0aGUgUkVMRUFTRV9BU1NFUlQgaW4gUmVtb3RlTGF5 ZXJUcmVlRHJhd2luZ0FyZWE6OmZsdXNoTGF5ZXJzKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjc4MworICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTY4NzczMjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1t OgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYTo6QmFja2luZ1N0 b3JlRmx1c2hlcjo6Zmx1c2gpOgorICAgICAgICBUaGVyZSdzIGEgcmFjZSB3aW5kb3cgYmV0d2Vl biB0aGUgQmFja2luZ1N0b3JlRmx1c2hlciBzZW5kaW5nIHRoZSBuZXcKKyAgICAgICAgbGF5ZXIg dHJlZSB0byB0aGUgVUkgcHJvY2VzcyBhbmQgdXBkYXRpbmcgbV9oYXNGbHVzaGVkIHdoZXJlIHdl IGNhbgorICAgICAgICBnZXQgYSByZXBseSBiYWNrIGluIChvbiB0aGUgV2ViIHByb2Nlc3MgbWFp biB0aHJlYWQpIGZyb20gdGhlIFVJIHByb2Nlc3MKKyAgICAgICAgdGhhdCB3ZSBjb21taXR0ZWQg dGhlIG5ldyBsYXllciB0cmVlIChkaWRVcGRhdGUpLgorICAgICAgICBUaGlzIHdpbGwgY2F1c2Ug dGhlIFJFTEVBU0VfQVNTRVJUIGluIGZsdXNoTGF5ZXJzKCkgdG8gZmlyZSBpbmNvcnJlY3RseS4K KyAgICAgICAgU2luY2UgdGhlIFJFTEVBU0VfQVNTRVJUIGlzIHRoZXJlIG9ubHkgdG8gYXZvaWQg cGFpbnRpbmcgZ2FyYmFnZSwgbW92ZQorICAgICAgICBvdXIgY29kZSB0byBzZXQgbV9oYXNGbHVz aGVkPXRydWUgdG8gYWZ0ZXIgd2UgZmluaXNoIGNhbGxpbmcgQ0dDb250ZXh0Rmx1c2gKKyAgICAg ICAgb24gYWxsIG9mIHRoZSBjb250ZXh0cywgaW5zdGVhZCBvZiBhZnRlciB3ZSBzZW5kIHRoZSBs YXllciB0cmVlIGNvbW1pdCBtZXNzYWdlLAorICAgICAgICB3aGljaCB3aWxsIHJlbW92ZSB0aGUg cmFjZSBlbnRpcmVseS4KKwogMjAxNC0wNS0wOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFtDb2NvYV0gUmVtb3ZlIGEgZGVwcmVjYXRlZCBidW5kbGUgZm9ybSBk ZWxlZ2F0ZSBtZXRob2Qgbm93IHRoYXQgbm8gb25lIGltcGxlbWVudHMgaXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJh d2luZ0FyZWEubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1JlbW90 ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1tCmluZGV4IDA4NGUwOTguLmFlOTI3ZWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVl RHJhd2luZ0FyZWEubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5tbQpAQCAtMzM2LDkgKzMzNiw5IEBAIHZvaWQg UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OkJhY2tpbmdTdG9yZUZsdXNoZXI6OmZsdXNoKCkK IAogICAgIGZvciAoYXV0byYgY29udGV4dCA6IG1fY29udGV4dHNUb0ZsdXNoKQogICAgICAgICBD R0NvbnRleHRGbHVzaChjb250ZXh0LmdldCgpKTsKKyAgICBtX2hhc0ZsdXNoZWQgPSB0cnVlOwog CiAgICAgbV9jb25uZWN0aW9uLT5zZW5kTWVzc2FnZShzdGQ6Om1vdmUobV9jb21taXRFbmNvZGVy KSk7Ci0gICAgbV9oYXNGbHVzaGVkID0gdHJ1ZTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0 Cg==