132771 2014-05-09 23:59:29 -0700 [EFL][WK2] Move the ownership of EwkSettings from EwkView to EwkPageGroup 2014-05-10 18:35:43 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1008229 0 ryuan.choi 2014-05-09 23:59:29 -0700 EwkSettings specialized WKPreferences which WKPageGroup contains. So, we'd better to move ownership of EwkSettings. 1008230 1 231219 ryuan.choi 2014-05-10 00:01:49 -0700 Created attachment 231219 Patch 1008231 2 231219 gyuyoung.kim 2014-05-10 00:04:28 -0700 Comment on attachment 231219 Patch I agree with this moving. 1008353 3 231219 commit-queue 2014-05-10 18:35:37 -0700 Comment on attachment 231219 Patch Clearing flags on attachment: 231219 Committed r168590: <http://trac.webkit.org/changeset/168590> 1008354 4 commit-queue 2014-05-10 18:35:43 -0700 All reviewed patches have been landed. Closing bug. 231219 2014-05-10 00:01:49 -0700 2014-05-10 18:35:37 -0700 Patch bug-132771-20140510160125.patch text/plain 6269 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmJkNmU3MmVhZmJjMTMw MTczODY2NTE3NTk2NjljMGZhNTUwMjQ1MC4uZWQxODg4NGJkNTZhOTk5ZjQ3ZjExZDk2NzNkYWNj ZjFkMTc2YTQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTA5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIE1v dmUgdGhlIG93bmVyc2hpcCBvZiBFd2tTZXR0aW5ncyBmcm9tIEV3a1ZpZXcgdG8gRXdrUGFnZUdy b3VwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI3 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3Zl ZCBvd25lcnNoaXAgb2YgRXdrU2V0dGluZ3MgZnJvbSBFd2tWaWV3IHRvIEV3a1BhZ2VHcm91cC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAgICAoRXdr Vmlldzo6RXdrVmlldyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5oOgor ICAgICAgICAoRXdrVmlldzo6c2V0dGluZ3MpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL2V3a19wYWdlX2dyb3VwLmNwcDoKKyAgICAgICAgKEV3a1BhZ2VHcm91cDo6RXdr UGFnZUdyb3VwKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfcGFnZV9ncm91cF9w cml2YXRlLmg6CisgICAgICAgIChFd2tQYWdlR3JvdXA6OnNldHRpbmdzKToKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3NldHRpbmdzX2dl dCk6CisKIDIwMTQtMDUtMDkgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPU11bV0syXSBGaXggYnVncyBleHBvc2VkIGJ5IHIxNjg1NTYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5kZXggYmJiYWQxMGM1 Yzg2ODRiZTk2YmM1OGZiM2M4ODE2N2M1YjZmNzA1MC4uYzlhNjBlZTg4MWNjZDkwZjJmNDhmMjg4 YTVkOWQwMjNiYmI4ZTBkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv RXdrVmlldy5jcHAKQEAgLTI4MSw3ICsyODEsNiBAQCBFd2tWaWV3OjpFd2tWaWV3KFdLVmlld1Jl ZiB2aWV3LCBFdmFzX09iamVjdCogZXZhc09iamVjdCkKICAgICAsIG1fdmlicmF0aW9uQ2xpZW50 KHN0ZDo6bWFrZV91bmlxdWU8VmlicmF0aW9uQ2xpZW50RWZsPih0aGlzKSkKICNlbmRpZgogICAg ICwgbV9iYWNrRm9yd2FyZExpc3Qoc3RkOjptYWtlX3VuaXF1ZTxFd2tCYWNrRm9yd2FyZExpc3Q+ KFdLUGFnZUdldEJhY2tGb3J3YXJkTGlzdCh3a1BhZ2UoKSkpKQotICAgICwgbV9zZXR0aW5ncyhz dGQ6Om1ha2VfdW5pcXVlPEV3a1NldHRpbmdzPihXS1BhZ2VHcm91cEdldFByZWZlcmVuY2VzKFdL UGFnZUdldFBhZ2VHcm91cCh3a1BhZ2UoKSkpKSkKICAgICAsIG1fdXNlQ3VzdG9tQ3Vyc29yKGZh bHNlKQogICAgICwgbV91c2VyQWdlbnQoV0tFaW5hU2hhcmVkU3RyaW5nKEFkb3B0V0ssIFdLUGFn ZUNvcHlVc2VyQWdlbnQod2tQYWdlKCkpKSkKICAgICAsIG1fbW91c2VFdmVudHNFbmFibGVkKGZh bHNlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmll dy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5oCmluZGV4IDE2 YmUyODJlMzljOTYxNTZiMmI2NGM2YzQ1NmVmMjI1NzNkNWVhMzguLmQzNjE3ZTliZDlmZWMzMjQ1 NjU2ZGQ5MzQwNmVkYjAxNGY5ZjMwMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL0V3a1ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9Fd2tWaWV3LmgKQEAgLTc2LDcgKzc2LDYgQEAgY2xhc3MgRXdrQ29sb3JQaWNrZXI7CiBj bGFzcyBFd2tDb250ZXh0TWVudTsKIGNsYXNzIEV3a1BhZ2VHcm91cDsKIGNsYXNzIEV3a1BvcHVw TWVudTsKLWNsYXNzIEV3a1NldHRpbmdzOwogY2xhc3MgRXdrVXJsUmVxdWVzdDsKIGNsYXNzIEV3 a1dpbmRvd0ZlYXR1cmVzOwogCkBAIC05OSw3ICs5OCw2IEBAIHB1YmxpYzoKICAgICBXZWJLaXQ6 OldlYlBhZ2VQcm94eSogcGFnZSgpIHsgcmV0dXJuIHdlYlZpZXcoKS0+cGFnZSgpOyB9CiAgICAg RXdrQ29udGV4dCogZXdrQ29udGV4dCgpIHsgcmV0dXJuIG1fY29udGV4dC5nZXQoKTsgfQogICAg IEV3a1BhZ2VHcm91cCogZXdrUGFnZUdyb3VwKCkgeyByZXR1cm4gbV9wYWdlR3JvdXAuZ2V0KCk7 IH0KLSAgICBFd2tTZXR0aW5ncyogc2V0dGluZ3MoKSB7IHJldHVybiBtX3NldHRpbmdzLmdldCgp OyB9CiAgICAgRXdrQmFja0ZvcndhcmRMaXN0KiBiYWNrRm9yd2FyZExpc3QoKSB7IHJldHVybiBt X2JhY2tGb3J3YXJkTGlzdC5nZXQoKTsgfQogICAgIEV3a1dpbmRvd0ZlYXR1cmVzKiB3aW5kb3dG ZWF0dXJlcygpOwogCkBAIC0yNTQsNyArMjUyLDYgQEAgcHJpdmF0ZToKICAgICBzdGQ6OnVuaXF1 ZV9wdHI8V2ViS2l0OjpWaWJyYXRpb25DbGllbnRFZmw+IG1fdmlicmF0aW9uQ2xpZW50OwogI2Vu ZGlmCiAgICAgc3RkOjp1bmlxdWVfcHRyPEV3a0JhY2tGb3J3YXJkTGlzdD4gbV9iYWNrRm9yd2Fy ZExpc3Q7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPEV3a1NldHRpbmdzPiBtX3NldHRpbmdzOwogICAg IFJlZlB0cjxFd2tXaW5kb3dGZWF0dXJlcz4gbV93aW5kb3dGZWF0dXJlczsKICAgICB1bmlvbiBD dXJzb3JJZGVudGlmaWVyIHsKICAgICAgICAgQ3Vyc29ySWRlbnRpZmllcigpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfcGFnZV9ncm91cC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfcGFnZV9ncm91cC5jcHAKaW5kZXgg ODg4MTRlZDliOWQ1N2Q2MGI4MTI3NmU3ODlmZGE3Y2YxMjcyYmI0YS4uNzU1YzU4MDIzNDRiZGNm ZTc0ZmI4MGQyM2I0ZWI1NDUzYTlhNTE4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3BhZ2VfZ3JvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a19wYWdlX2dyb3VwLmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2lu Y2x1ZGUgIldLUGFnZUdyb3VwLmgiCiAjaW5jbHVkZSAiV0tTdHJpbmcuaCIKICNpbmNsdWRlICJl d2tfcGFnZV9ncm91cF9wcml2YXRlLmgiCisjaW5jbHVkZSAiZXdrX3NldHRpbmdzX3ByaXZhdGUu aCIKICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdl YktpdDsKQEAgLTY3LDYgKzY4LDcgQEAgUGFzc1JlZlB0cjxFd2tQYWdlR3JvdXA+IEV3a1BhZ2VH cm91cDo6Y3JlYXRlKGNvbnN0IGNoYXIqIGlkZW50aWZpZXIpCiAKIEV3a1BhZ2VHcm91cDo6RXdr UGFnZUdyb3VwKFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cFJlZikKICAgICA6IG1fcGFnZUdyb3Vw UmVmKHBhZ2VHcm91cFJlZikKKyAgICAsIG1fc2V0dGluZ3Moc3RkOjptYWtlX3VuaXF1ZTxFd2tT ZXR0aW5ncz4oV0tQYWdlR3JvdXBHZXRQcmVmZXJlbmNlcyhwYWdlR3JvdXBSZWYpKSkKIHsKICAg ICBQYWdlR3JvdXBNYXA6OkFkZFJlc3VsdCByZXN1bHQgPSBwYWdlR3JvdXBNYXAoKS5hZGQocGFn ZUdyb3VwUmVmLCB0aGlzKTsKICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0LmlzTmV3 RW50cnkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3BhZ2VfZ3JvdXBfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3BhZ2VfZ3JvdXBfcHJpdmF0ZS5oCmluZGV4IGE3M2RiOGUxNDg4ODc4YjcxZjQ1MjY0N2Ew MGJiNmU0ODQyN2QwMGEuLmQ1MDNmZmIxYmU0NjI0MTgyMzI1Njk2NjRhOTRjOTQ1OGJhYzI5ZTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19wYWdlX2dy b3VwX3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf cGFnZV9ncm91cF9wcml2YXRlLmgKQEAgLTM0LDcgKzM0LDcgQEAKICNpbmNsdWRlIDx3dGYvUmVm Q291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAotY2xhc3MgRXdrVmlldzsKK2Ns YXNzIEV3a1NldHRpbmdzOwogCiBjbGFzcyBFd2tQYWdlR3JvdXAgOiBwdWJsaWMgRXdrT2JqZWN0 IHsKIHB1YmxpYzoKQEAgLTQ2LDYgKzQ2LDcgQEAgcHVibGljOgogICAgIH5Fd2tQYWdlR3JvdXAo KTsKIAogICAgIFdLUGFnZUdyb3VwUmVmIHdrUGFnZUdyb3VwKCkgY29uc3QgeyByZXR1cm4gbV9w YWdlR3JvdXBSZWYuZ2V0KCk7IH0KKyAgICBFd2tTZXR0aW5ncyogc2V0dGluZ3MoKSBjb25zdCB7 IHJldHVybiBtX3NldHRpbmdzLmdldCgpOyB9CiAKICAgICB2b2lkIGFkZFVzZXJTdHlsZVNoZWV0 KGNvbnN0IFN0cmluZyYgc291cmNlLCBjb25zdCBTdHJpbmcmIGJhc2VVUkwsIEVpbmFfTGlzdCog d2hpdGVsaXN0LCBFaW5hX0xpc3QqIGJsYWNrbGlzdCwgYm9vbCBtYWluRnJhbWVPbmx5KTsKICAg ICB2b2lkIHJlbW92ZUFsbFVzZXJTdHlsZVNoZWV0cygpOwpAQCAtNTQsNiArNTUsNyBAQCBwcml2 YXRlOgogICAgIGV4cGxpY2l0IEV3a1BhZ2VHcm91cChXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBS ZWYpOyAgICAKIAogICAgIFdLUmV0YWluUHRyPFdLUGFnZUdyb3VwUmVmPiBtX3BhZ2VHcm91cFJl ZjsKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8RXdrU2V0dGluZ3M+IG1fc2V0dGluZ3M7CiB9OwogCiAj ZW5kaWYgLy8gZXdrX3BhZ2VfZ3JvdXBfcHJpdmF0ZV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzX3ByaXZhdGUuaAppbmRleCAwZGUx OTlkYjg3ODZkYWRlNmNlM2Q1NTI4NGYzZDY4ZWY5NDkzZDc5Li5kZTlkNWFkMDU5YTg0YmY4YzA5 NzcxZGYxMmJiYTMwMTI4ZWYxMmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5nc19wcml2YXRlLmgKQEAgLTMxLDcgKzMxLDYgQEAK ICNpbmNsdWRlICJXS1JldGFpblB0ci5oIgogI2luY2x1ZGUgPFdlYktpdDIvV0tCYXNlLmg+CiAK LWNsYXNzIEV3a1ZpZXc7CiAvKioKICAqIFxzdHJ1Y3QgIEV3a19TZXR0aW5ncwogICogQGJyaWVm ICAgQ29udGFpbnMgdGhlIHNldHRpbmdzIGRhdGEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggNWVlODQzZjUyZTA4ZTNjZTU3ZWRmODE0OTU0 ZTFkMjBkYzQ3Yjc3Yi4uOTJkMzFmYzQyZTM2OGNhM2I3MzVmZjQ2OWRmYjIwODljZDUzYWY4NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApAQCAt MTg3LDcgKzE4Nyw3IEBAIEV3a19TZXR0aW5ncyogZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KGNvbnN0 IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVS Tihld2tWaWV3LCBpbXBsLCBudWxscHRyKTsKIAotICAgIHJldHVybiBpbXBsLT5zZXR0aW5ncygp OworICAgIHJldHVybiBpbXBsLT5ld2tQYWdlR3JvdXAoKS0+c2V0dGluZ3MoKTsKIH0KIAogY29u c3QgY2hhciogZXdrX3ZpZXdfdGl0bGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQo=