132770 2014-05-09 22:47:32 -0700 [Mac] [iOS] Underlines are too low 2014-05-19 17:26:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue darin dino enrica esprehn+autocc glenn jonlee kondapallykalyan mitz simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1008218 0 mmaxfield 2014-05-09 22:47:32 -0700 [Mac] [iOS] Underlines are too low 1008219 1 231215 mmaxfield 2014-05-09 22:50:10 -0700 Created attachment 231215 Patch 1008223 2 mmaxfield 2014-05-09 22:54:55 -0700 <rdar://problem/16364632> 1008274 3 231215 darin 2014-05-10 11:37:09 -0700 Comment on attachment 231215 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231215&action=review > Source/WebCore/rendering/InlineTextBox.cpp:1015 > + float textDecorationThickness = roundf(fontSizeScaling); Seems really strange to “round a scaling”; why do strokes need to be integers? Wouldn’t the pixel ratio have something to do with the rounding we want to do, rather than just integer boundaries. Rationale might be helpful. Is it really OK to round the thickness down to 0 if the font size is <1/2 the size of the text decoration base font size? I think getting rid of the fontSizeScaling local would be helpful, since it would be incorrect to use that value in the code below. 1008275 4 zalan 2014-05-10 11:46:52 -0700 (In reply to comment #3) > (From update of attachment 231215 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231215&action=review > > > Source/WebCore/rendering/InlineTextBox.cpp:1015 > > + float textDecorationThickness = roundf(fontSizeScaling); > > Seems really strange to “round a scaling”; why do strokes need to be integers? Wouldn’t the pixel ratio have something to do with the rounding we want to do, rather than just integer boundaries. Rationale might be helpful. Agree, integral rounding at painting time needs strong justification. 1008415 5 mmaxfield 2014-05-11 10:17:31 -0700 *** Bug 132722 has been marked as a duplicate of this bug. *** 1008417 6 231215 mmaxfield 2014-05-11 10:22:52 -0700 Comment on attachment 231215 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231215&action=review >>> Source/WebCore/rendering/InlineTextBox.cpp:1015 >>> + float textDecorationThickness = roundf(fontSizeScaling); >> >> Seems really strange to “round a scaling”; why do strokes need to be integers? Wouldn’t the pixel ratio have something to do with the rounding we want to do, rather than just integer boundaries. Rationale might be helpful. >> >> Is it really OK to round the thickness down to 0 if the font size is <1/2 the size of the text decoration base font size? >> >> I think getting rid of the fontSizeScaling local would be helpful, since it would be incorrect to use that value in the code below. > > Agree, integral rounding at painting time needs strong justification. Done. I was keeping the roundf() from above, but I think the two of you are right. 1008420 7 mmaxfield 2014-05-11 10:36:54 -0700 https://trac.webkit.org/changeset/168599 1008423 8 darin 2014-05-11 10:42:12 -0700 While the roundf is probably not right, removing it could have big effects; we might start drawing anti-aliased grey underlines that don’t look good where before we would be rounding up or down and drawing much-different-looking black underlines. We need to follow up with plenty of testing. 1008436 9 zalan 2014-05-11 11:56:42 -0700 (In reply to comment #7) > https://trac.webkit.org/changeset/168599 +float textDecorationThickness = renderer().style().fontSize() / textDecorationBaseFontSize; This should be pixel snapped to avoid lines like 1.6px -to not to produce anti-aliased lines. +FloatPoint deviceOrigin = FloatPoint(roundf(devicePoint.x()), ceilf(devicePoint.y())); This is integral rounding, so it will most likely end up snapping to wrong coordinates in certain edge cases. I think we should not round in this function at all and the caller (or where we have the context of the rounding strategy) should do the snapping instead. 1009077 10 mmaxfield 2014-05-13 14:33:47 -0700 (In reply to comment #9) > (In reply to comment #7) > > https://trac.webkit.org/changeset/168599 > +float textDecorationThickness = renderer().style().fontSize() / textDecorationBaseFontSize; > This should be pixel snapped to avoid lines like 1.6px -to not to produce anti-aliased lines. > > +FloatPoint deviceOrigin = FloatPoint(roundf(devicePoint.x()), ceilf(devicePoint.y())); > This is integral rounding, so it will most likely end up snapping to wrong coordinates in certain edge cases. I think we should not round in this function at all and the caller (or where we have the context of the rounding strategy) should do the snapping instead. <rdar://problem/16903502> 1009312 11 mmaxfield 2014-05-14 12:10:16 -0700 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #7) > > > https://trac.webkit.org/changeset/168599 > > +float textDecorationThickness = renderer().style().fontSize() / textDecorationBaseFontSize; > > This should be pixel snapped to avoid lines like 1.6px -to not to produce anti-aliased lines. > > > > +FloatPoint deviceOrigin = FloatPoint(roundf(devicePoint.x()), ceilf(devicePoint.y())); > > This is integral rounding, so it will most likely end up snapping to wrong coordinates in certain edge cases. I think we should not round in this function at all and the caller (or where we have the context of the rounding strategy) should do the snapping instead. > > <rdar://problem/16903502> I confused the Radar Bug Importer with my last comment. The new radar I filed for moving the pixel-snapping code is at <rdar://problem/16903502> <rdar://problem/16364632> 1010364 12 mmaxfield 2014-05-19 17:26:41 -0700 http://trac.webkit.org/changeset/168599 231215 2014-05-09 22:50:10 -0700 2014-05-11 10:22:52 -0700 Patch bug-132770-20140509224947.patch text/plain 7510 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNmMjdkNDQwNTQ2MGRl NmUxZDE2YTUxMTVjZTYyNjgxYjIyNDJlYS4uMGVhMWJhMjQxYzBlZjNlZGYyNGUyMTExMmM0Zjlm NTllMjE5MWE0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA1LTA5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPGxpdGhlcnVtQGdtYWlsLmNvbT4KKworICAgICAgICBbTWFjXSBbaU9T XSBVbmRlcmxpbmVzIGFyZSB0b28gbG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzI3NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBjb21wdXRlVW5kZXJsaW5lT2Zmc2V0KCkgaW5zaWRlIElubGluZVRl eHRCb3guY3BwIGxvd2VycyB1bmRlcmxpbmVzIGZyb20gdGV4dAorICAgICAgICBiYXNlbGluZSBi eSBhIHZhbHVlIHRoYXQgaXMgcHJvcG9ydGlvbmFsIHRvIHRoZSBmb250IHNpemUuIEhvd2V2ZXIs IHRoaXMKKyAgICAgICAgbG93ZXJpbmcgd2FzIGRvbmUgYSBzZWNvbmQgdGltZSBpbgorICAgICAg ICBHcmFwaGljc0NvbnRleHQ6OmNvbXB1dGVMaW5lQm91bmRzQW5kQW50aWFsaWFzaW5nTW9kZUZv clRleHQoKS4gVGhpcyBwYXRjaAorICAgICAgICByZW1vdmVzIHRoaXMgc2Vjb25kLCBwbGF0Zm9y bS1kZXBlbmRlbnQgbG93ZXJpbmcuCisKKyAgICAgICAgVGhpcyBkdXBsaWNhdGlvbiB3YXMgY2F1 c2VkIGJ5IG1lcmdpbmcgaU9TIGludG8gb3BlbiBzb3VyY2UsIHdoZXJlIGlPUyB1c2VkCisgICAg ICAgIHRoZSBHcmFwaGljc0NvbnRleHQgYXBwcm9hY2ggYW5kIG9wZW4gc291cmNlIHVzZWQgdGhl IElubGluZVRleHRCb3ggYXBwcm9hY2guCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2NzczMt dGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tdGhpY2tuZXNzLmh0bWwu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpjb21wdXRlTGluZUJvdW5kc0FuZEFudGlh bGlhc2luZ01vZGVGb3JUZXh0KTogUmVtb3ZlCisgICAgICAgIHJlZHVuZGFudCBsb3dlcmluZyBj b2RlCisgICAgICAgICogcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW5saW5lVGV4dEJveDo6cGFpbnREZWNvcmF0aW9uKTogQ2xlYW4gdXAgdGV4dERlY29y YXRpb25UaGlja25lc3MKKyAgICAgICAgdmFyaWFibGUKKwogMjAxNC0wNS0wOSAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTY4NTE4 KTogTXVsdGlwbGUgdGVzdHMgZm9yIHdvcmtlcnMgaW4gYmxvYnMgYXNzZXJ0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcAppbmRl eCBlNzM2ZDZmNDVmMjllOWY1Mjg1M2U2NTM5MTIwMmRmZjFlOWMwZjc4Li4yMjVlMmZlNWVmOWYz NmRkY2JjZDBmMGM0YTA2NTY1YTBhOThlNTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAKQEAgLTk3NywxNiArOTc3LDgg QEAgRmxvYXRSZWN0IEdyYXBoaWNzQ29udGV4dDo6Y29tcHV0ZUxpbmVCb3VuZHNBbmRBbnRpYWxp YXNpbmdNb2RlRm9yVGV4dChjb25zdCBGbG8KICAgICAgICAgICAgIGNvbG9yID0gQ29sb3IoY29s b3IucmVkKCksIGNvbG9yLmdyZWVuKCksIGNvbG9yLmJsdWUoKSwgYWxwaGEpOwogICAgICAgICB9 CiAKLSAgICAgICAgLy8gRG9uJ3Qgb2Zmc2V0IGxpbmUgZnJvbSBib3R0b20gb2YgdGV4dCBpZiBz Y2FsZSBpcyBsZXNzIHRoYW4gb2Zmc2V0VW5kZXJMaW5lU2NhbGUuCi0gICAgICAgIHN0YXRpYyBj b25zdCBmbG9hdCBvZmZzZXRVbmRlcmxpbmVTY2FsZSA9IDAuNGY7Ci0gICAgICAgIGZsb2F0IGR5 ID0gc2NhbGUgPCBvZmZzZXRVbmRlcmxpbmVTY2FsZSA/IDAgOiAxOwotCi0gICAgICAgIC8vIElm IHdlJ3ZlIGluY3JlYXNlZCB0aGUgdGhpY2tuZXNzIG9mIHRoZSBsaW5lLCBtYWtlIHN1cmUgdG8g bW92ZSB0aGUgbG9jYXRpb24gdG9vLgotICAgICAgICBpZiAodGhpY2tuZXNzID4gMSkKLSAgICAg ICAgICAgIGR5ICs9IHJvdW5kZih0aGlja25lc3MpIC0gMTsKLQogICAgICAgICBGbG9hdFBvaW50 IGRldmljZVBvaW50ID0gdHJhbnNmb3JtLm1hcFBvaW50KHBvaW50KTsKLSAgICAgICAgRmxvYXRQ b2ludCBkZXZpY2VPcmlnaW4gPSBGbG9hdFBvaW50KHJvdW5kZihkZXZpY2VQb2ludC54KCkpLCBj ZWlsZihkZXZpY2VQb2ludC55KCkpICsgZHkpOworICAgICAgICBGbG9hdFBvaW50IGRldmljZU9y aWdpbiA9IEZsb2F0UG9pbnQocm91bmRmKGRldmljZVBvaW50LngoKSksIGNlaWxmKGRldmljZVBv aW50LnkoKSkpOwogICAgICAgICBvcmlnaW4gPSB0cmFuc2Zvcm0uaW52ZXJzZSgpLm1hcFBvaW50 KGRldmljZU9yaWdpbik7CiAgICAgfQogICAgIHJldHVybiBGbG9hdFJlY3Qob3JpZ2luLngoKSwg b3JpZ2luLnkoKSwgd2lkdGgsIHRoaWNrbmVzcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv SW5saW5lVGV4dEJveC5jcHAKaW5kZXggMzdmZTBmOTk2ZTJmYjMxN2I0NjY2NTU5NzFiOGRkZGMx MDFkZTNkMy4uMjZhZWU4YTVhYTNhMTEwMmQ5MTdhM2NjNDQxYjNkODAyOGNkNGNhZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcApAQCAtOTg5LDkgKzk4OSw2 IEBAIHZvaWQgSW5saW5lVGV4dEJveDo6cGFpbnREZWNvcmF0aW9uKEdyYXBoaWNzQ29udGV4dCYg Y29udGV4dCwgY29uc3QgRmxvYXRQb2ludCYKICAgICBVTlVTRURfUEFSQU0odGV4dFBhaW50ZXIp OwogI2VuZGlmCiAKLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGltcHJvdmUgdGhpcyBydWxlIGFu ZCBub3QgYWx3YXlzIGp1c3QgYXNzdW1lIDEuCi0gICAgY29uc3QgZmxvYXQgdGV4dERlY29yYXRp b25UaGlja25lc3MgPSAxLmY7Ci0KICAgICBpZiAobV90cnVuY2F0aW9uID09IGNGdWxsVHJ1bmNh dGlvbikKICAgICAgICAgcmV0dXJuOwogCkBAIC0xMDE1LDggKzEwMTIsOCBAQCB2b2lkIElubGlu ZVRleHRCb3g6OnBhaW50RGVjb3JhdGlvbihHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0 IEZsb2F0UG9pbnQmCiAKICAgICBjb25zdCBmbG9hdCB0ZXh0RGVjb3JhdGlvbkJhc2VGb250U2l6 ZSA9IDE2OwogICAgIGZsb2F0IGZvbnRTaXplU2NhbGluZyA9IHJlbmRlcmVyKCkuc3R5bGUoKS5m b250U2l6ZSgpIC8gdGV4dERlY29yYXRpb25CYXNlRm9udFNpemU7Ci0gICAgZmxvYXQgc3Ryb2tl VGhpY2tuZXNzID0gcm91bmRmKHRleHREZWNvcmF0aW9uVGhpY2tuZXNzICogZm9udFNpemVTY2Fs aW5nKTsKLSAgICBjb250ZXh0LnNldFN0cm9rZVRoaWNrbmVzcyhzdHJva2VUaGlja25lc3MpOwor ICAgIGZsb2F0IHRleHREZWNvcmF0aW9uVGhpY2tuZXNzID0gcm91bmRmKGZvbnRTaXplU2NhbGlu Zyk7CisgICAgY29udGV4dC5zZXRTdHJva2VUaGlja25lc3ModGV4dERlY29yYXRpb25UaGlja25l c3MpOwogCiAgICAgYm9vbCBsaW5lc0FyZU9wYXF1ZSA9ICFpc1ByaW50aW5nICYmICghKGRlY29y YXRpb24gJiBUZXh0RGVjb3JhdGlvblVuZGVybGluZSkgfHwgdW5kZXJsaW5lLmFscGhhKCkgPT0g MjU1KSAmJiAoIShkZWNvcmF0aW9uICYgVGV4dERlY29yYXRpb25PdmVybGluZSkgfHwgb3Zlcmxp bmUuYWxwaGEoKSA9PSAyNTUpICYmICghKGRlY29yYXRpb24gJiBUZXh0RGVjb3JhdGlvbkxpbmVU aHJvdWdoKSB8fCBsaW5ldGhyb3VnaC5hbHBoYSgpID09IDI1NSk7CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmOWZhNGRk OGI3OWNkNjM0NDRiNjY1ODM0ZGU0YjY4MWNlYWE4YWI4Li4zODg3ZjYzMjViODQ4ZWJiNGQxMmVl YzczYzc4ZTk0NzliZGVlN2NlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDUtMDkgIE15 bGVzIEMuIE1heGZpZWxkICA8bGl0aGVydW1AZ21haWwuY29tPgorCisgICAgICAgIFtNYWNdIFtp T1NdIFVuZGVybGluZXMgYXJlIHRvbyBsb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMjc3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNlZSBwZXItZmlsZSBkZXNjcmlwdGlvbnMuCisKKyAgICAgICAg KiBmYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tc3R5 bGUtZG91YmxlLXNwYWNlLXNjYWxlcy5odG1sOiBNYWRlCisgICAgICAgIHRlc3QgbW9yZSByb2J1 c3Qgc28gaXQgZG9lcyBub3QgYmFyZWx5IGNsaXAgdW5kZXJsaW5lcywgYnV0IHJhdGhlciBnaXZl cyB0aGVtIGEgY291cGxlCisgICAgICAgIHBpeGVscyBvZiB3aWdnbGUgcm9vbS4KKyAgICAgICAg KiBmYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tdGhp Y2tuZXNzLmh0bWw6IE5vdCBvbmx5IGRvZXMgdGhpcyB0ZXN0CisgICAgICAgIHVuZGVybGluZSB0 aGlja25lc3MsIGJ1dCBpdCBhbHNvIHRlc3RzIHVuZGVybGluZSBwb3NpdGlvbi4gVXBkYXRlZCB0 aGlzIHRlc3QgdG8gbm90IGV4cGVjdAorICAgICAgICBpbmNvcnJlY3QgcmVzdWx0cy4KKwogMjAx NC0wNS0wOSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMTY4NTE4KTogTXVsdGlwbGUgdGVzdHMgZm9yIHdvcmtlcnMgaW4gYmxvYnMg YXNzZXJ0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NzczMtdGV4dC9jc3MzLXRleHQt ZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tc3R5bGUtZG91YmxlLXNwYWNlLXNjYWxlcy5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1k ZWNvcmF0aW9uLXN0eWxlLWRvdWJsZS1zcGFjZS1zY2FsZXMuaHRtbAppbmRleCAwNmQzZWNmODMz MzgwMDQ4MDY4YWZjYzk4MWYyMTAzYTY2ZjIwZGQzLi41NmVmMTI4OGIxNjk5OGI4MmUxYzg0ZTU1 ZjVkNWExYWFlMDgwZGQ0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2NzczMtdGV4dC9j c3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tc3R5bGUtZG91YmxlLXNwYWNlLXNj YWxlcy5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNv cmF0aW9uL3RleHQtZGVjb3JhdGlvbi1zdHlsZS1kb3VibGUtc3BhY2Utc2NhbGVzLmh0bWwKQEAg LTcsNyArNyw3IEBAIFRoaXMgdGVzdCByZW5kZXJzIGxhcmdlIHRleHQgd2l0aCBhIGRvdWJsZSB1 bmRlcmxpbmUsIGJ1dCB0aGVuIGJhcmVseSBjbGlwcyBvZmYKIHVzaW5nIG92ZXJmbG93OiBoaWRk ZW4uIEl0IG1ha2VzIHN1cmUgdGhhdCB0aGlzIGlzIGV4YWN0bHkgdGhlIHNhbWUgYXMgYSBzaW5n bGUgdW5kZXJsaW5lLiBJZiB0aGUKIHNwYWNlIGJldHdlZW4gdGhlIHR3byB1bmRlcmxpbmVzIGRv ZXMgbm90IHNjYWxlIHdpdGggZm9udCBzaXplLCBpdCB3aWxsIGFwcGVhciBhcyB0aG91Z2ggdGhl cmUgaXMgYQogc2luZ2xlIHRoaWNrIHVuZGVybGluZSAoYmVjYXVzZSB0aGV5IHdpbGwgYmUgZHJh d24gb24gdG9wIG9mIGVhY2ggb3RoZXIpIGFuZCB3aWxsIHRodXMgZmFpbCB0aGlzIHRlc3QuCi08 ZGl2IHN0eWxlPSJ3aWR0aDogMTAwcHg7IGhlaWdodDogOTlweDsgb3ZlcmZsb3c6IGhpZGRlbjsi PgorPGRpdiBzdHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDk1cHg7IG92ZXJmbG93OiBoaWRk ZW47Ij4KIDxkaXYgc3R5bGU9InRleHQtZGVjb3JhdGlvbjogdW5kZXJsaW5lOyBmb250LXNpemU6 IDEwMHB4OyAtd2Via2l0LXRleHQtZGVjb3JhdGlvbi1zdHlsZTogZG91YmxlOyBmb250LWZhbWls eTogQWhlbTsiPiZuYnNwOzwvZGl2PgogPC9kaXY+CiA8L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRp b24tdGhpY2tuZXNzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NzczMtdGV4dC9jc3MzLXRleHQt ZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tdGhpY2tuZXNzLmh0bWwKaW5kZXggZDc3MzYzNzA3 MDg5MTc1Zjc1YzkwZDQyZjI2OTczMTFmOTIxY2VhYi4uZGZkZDY0OGU0MjU1NmQwODg3MzRjOWIw ODI3MTFhYjBhNmRhMTAxMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MzLXRleHQv Y3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXRoaWNrbmVzcy5odG1sCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNvcmF0aW9uL3RleHQtZGVj b3JhdGlvbi10aGlja25lc3MuaHRtbApAQCAtNyw3ICs3LDcgQEAgVGhpcyB0ZXN0IGRyYXdzIHVu ZGVybGluZWQgdGV4dCBhdCBhIHZlcnkgbGFyZ2UgZm9udCBzaXplLiBJdCB0aGVuIHBvc2l0aW9u cyBhbmQKIHRoZSB0ZXh0IHNvIHRoYXQgdGhlIHVuZGVybGluZSBzaG91bGQgZmlsbCBhIGJveCBp ZiB0aGUgdW5kZXJsaW5lIGdyb3dzIGluIHByb3BvcnRpb24KIHRvIHRleHQgc2l6ZS4gVGhlIGNv bXBhcmlzb24gaXMgdG8gYSBib3ggdGhhdCBoYXMgaXRzIGJhY2tncm91bmQgY29sb3Igc2V0Lgog PGRpdiBzdHlsZT0icG9zaXRpb246IHJlbGF0aXZlOyB3aWR0aDogNjAwcHg7IGhlaWdodDogNjAw cHg7IG92ZXJmbG93OiBoaWRkZW47Ij4KLTxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBBaGVtOyB0 ZXh0LWRlY29yYXRpb246IHVuZGVybGluZTsgZm9udC1zaXplOiAxMDAwMHB4OyBwb3NpdGlvbjog YWJzb2x1dGU7IGxlZnQ6IDBweDsgdG9wOiAtODY1MHB4OyI+Jm5ic3A7PC9kaXY+Cis8ZGl2IHN0 eWxlPSJmb250LWZhbWlseTogQWhlbTsgdGV4dC1kZWNvcmF0aW9uOiB1bmRlcmxpbmU7IGZvbnQt c2l6ZTogMTAwMDBweDsgcG9zaXRpb246IGFic29sdXRlOyBsZWZ0OiAwcHg7IHRvcDogLTgzNTBw eDsiPiZuYnNwOzwvZGl2PgogPC9kaXY+CiA8L2JvZHk+CiA8L2h0bWw+Cg==