132768 2014-05-09 21:46:18 -0700 [iOS][WK2] Fix bugs exposed by r168556 2014-05-09 22:14:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1008205 0 benjamin 2014-05-09 21:46:18 -0700 [iOS][WK2] Fix bugs exposed by r168556 1008210 1 231213 benjamin 2014-05-09 21:52:09 -0700 Created attachment 231213 Patch 1008213 2 231213 rniwa 2014-05-09 22:02:15 -0700 Comment on attachment 231213 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231213&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1896 > + return fabs(a - b) < std::numeric_limits<float>::epsilon(); It'll be nice if we could share this with e.g. FloatSize.cpp but I guess we can do that in a separate patch. 1008216 3 231213 benjamin 2014-05-09 22:14:48 -0700 Comment on attachment 231213 Patch Clearing flags on attachment: 231213 Committed r168572: <http://trac.webkit.org/changeset/168572> 1008217 4 benjamin 2014-05-09 22:14:51 -0700 All reviewed patches have been landed. Closing bug. 231213 2014-05-09 21:52:09 -0700 2014-05-09 22:14:48 -0700 Patch bug-132768-20140509215146.patch text/plain 3539 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTFiMmU3MGUwYTYwYmE5 YzE4ZmU4NzIwOTZiZTcxMGMyNzAxNWFiYy4uOWY4NjUyYmMyMWU0MmY4NWFmNTFmYjJhMzRjM2Mz ODgxOTk0M2I1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA1LTA5ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g Rml4IGJ1Z3MgZXhwb3NlZCBieSByMTY4NTU2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI3NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggdHdvIGJ1Z3MgZXhwb3NlZCBieSByMTY4NTU2LgorICAg ICAgICAxKSBXZSB3ZXJlIG9ubHkgY2hhbmdpbmcgdGhlIHBhZ2Ugc2NhbGUgZmFjdG9yIHdoZW4g dGhlIHNjYWxlIHdhcyBub3QgYWRqdXN0ZWQgYnkgbGl2ZQorICAgICAgICAgICByZXNpemUuIFRo ZSBpZGVhIHdhcyB0aGF0IHRoZSBzY2FsZSB3b3VsZCBlaXRoZXIgYmUgdGhlIHNhbWUgKHJlc3Bv bnNpdmUgY29udGVudCkKKyAgICAgICAgICAgb3IgdGhhdCBpdCB3b3VsZCBiZSBkZWZpbmVkIGJ5 IHRoZSBuZXh0IHZpZXdDb250ZW50UmVjdFVwZGF0ZS4KKworICAgICAgICAgICBOb3cgdGhhdCB3 ZSBhbHNvIHNlbmQgcmVzaXplIGFuZCBzY3JvbGwgZXZlbnRzLCB3ZSBtdXN0IGFsd2F5cyB1cGRh dGUgdGhlIHNjYWxlIHNpbmNlCisgICAgICAgICAgIGl0IGFmZmVjdHMgc29tZSBBUElzIG9ic2Vy dmFibGUgZnJvbSBKYXZhU2NyaXB0IChsaWtlIHNjcm9sbGluZyBib3VuZHMpLgorCisgICAgICAg IDIpIEludGVybmFsbHksIFBhZ2UncyBzY2FsZUZhY3RvciBpcyBzdG9yZWQgYXMgYSBmbG9hdCBh bmQgbm90IGRvdWJsZS4gVGhlIHJvdW5kaW5nIGVycm9yCisgICAgICAgICAgIHdlcmUgY2F1c2lu ZyB1cyB0byBzZW5kIER5bmFtaWNWaWV3cG9ydFVwZGF0ZUNoYW5nZWRUYXJnZXQoKSBpbiBjYXNl cyB3ZXJlIHRoZXJlIGlzIG5vIGNoYW5nZQorICAgICAgICAgICBvZiB0YXJnZXQuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJL aXQ6OndpdGhpbkVwc2lsb24pOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkeW5hbWljVmll d3BvcnRTaXplVXBkYXRlKToKKwogMjAxNC0wNS0wOSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmph bWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2lPU11bV0syXSBSZXNldCB0aGUgc2Nyb2xsIHBv c2l0aW9uIG9uIHRoZSBmaXJzdCBmcmFtZSBhZnRlciBkaWRDb21taXRMb2FkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXgg ZTk3MjUyZWI4YTY4YjgwOTNlNDg1OWJhNGNiMjhkNDgzOTMwNTdiNS4uZWNhMGUzMGE4YmE3OTFl ZTdhZmM3NjhmMDNmY2EwN2Q0MmRkYTBlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtMTg5MSw2ICsxODkxLDExIEBA IHZvaWQgV2ViUGFnZTo6c2V0TWluaW11bUxheW91dFNpemVGb3JNaW5pbWFsVUkoY29uc3QgRmxv YXRTaXplJiBzaXplKQogICAgIHZpZXdwb3J0Q29uZmlndXJhdGlvbkNoYW5nZWQoKTsKIH0KIAor c3RhdGljIGlubGluZSBib29sIHdpdGhpbkVwc2lsb24oZmxvYXQgYSwgZmxvYXQgYikKK3sKKyAg ICByZXR1cm4gZmFicyhhIC0gYikgPCBzdGQ6Om51bWVyaWNfbGltaXRzPGZsb2F0Pjo6ZXBzaWxv bigpOworfQorCiB2b2lkIFdlYlBhZ2U6OmR5bmFtaWNWaWV3cG9ydFNpemVVcGRhdGUoY29uc3Qg RmxvYXRTaXplJiBtaW5pbXVtTGF5b3V0U2l6ZSwgY29uc3QgRmxvYXRSZWN0JiB0YXJnZXRFeHBv c2VkQ29udGVudFJlY3QsIGNvbnN0IEZsb2F0UmVjdCYgdGFyZ2V0VW5vYnNjdXJlZFJlY3QsIGNv bnN0IFdlYkNvcmU6OkZsb2F0UmVjdCYgdGFyZ2V0VW5vYnNjdXJlZFJlY3RJblNjcm9sbFZpZXdD b29yZGluYXRlcywgZG91YmxlIHRhcmdldFNjYWxlKQogewogICAgIFRlbXBvcmFyeUNoYW5nZTxi b29sPiBkeW5hbWljU2l6ZVVwZGF0ZUd1YXJkKG1faW5EeW5hbWljU2l6ZVVwZGF0ZSwgdHJ1ZSk7 CkBAIC0yMDMxLDE1ICsyMDM2LDE0IEBAIHZvaWQgV2ViUGFnZTo6ZHluYW1pY1ZpZXdwb3J0U2l6 ZVVwZGF0ZShjb25zdCBGbG9hdFNpemUmIG1pbmltdW1MYXlvdXRTaXplLCBjb25zCiAgICAgZnJh bWVWaWV3LnNldFVub2JzY3VyZWRDb250ZW50UmVjdChyb3VuZGVkVW5vYnNjdXJlZENvbnRlbnRS ZWN0KTsKICAgICBtX2RyYXdpbmdBcmVhLT5zZXRFeHBvc2VkQ29udGVudFJlY3QobmV3RXhwb3Nl ZENvbnRlbnRSZWN0KTsKIAotICAgIGlmIChzY2FsZSA9PSB0YXJnZXRTY2FsZSkKLSAgICAgICAg c2NhbGVQYWdlKHNjYWxlLCByb3VuZGVkVW5vYnNjdXJlZENvbnRlbnRSZWN0LmxvY2F0aW9uKCkp OworICAgIHNjYWxlUGFnZShzY2FsZSwgcm91bmRlZFVub2JzY3VyZWRDb250ZW50UmVjdC5sb2Nh dGlvbigpKTsKIAogICAgIEZsb2F0U2l6ZSB1bm9ic2N1cmVkQ29udGVudFJlY3RTaXplSW5Db250 ZW50Q29vcmRpbmF0ZXMgPSBuZXdVbm9ic2N1cmVkQ29udGVudFJlY3Quc2l6ZSgpOwogICAgIHVu b2JzY3VyZWRDb250ZW50UmVjdFNpemVJbkNvbnRlbnRDb29yZGluYXRlcy5zY2FsZShzY2FsZSk7 CiAgICAgZnJhbWVWaWV3LnNldEN1c3RvbVNpemVGb3JSZXNpemVFdmVudChleHBhbmRlZEludFNp emUodW5vYnNjdXJlZENvbnRlbnRSZWN0U2l6ZUluQ29udGVudENvb3JkaW5hdGVzKSk7CiAgICAg ZnJhbWVWaWV3LnNldFNjcm9sbE9mZnNldChyb3VuZGVkVW5vYnNjdXJlZENvbnRlbnRSZWN0Lmxv Y2F0aW9uKCkpOwogCi0gICAgaWYgKHBhZ2VTY2FsZUZhY3RvcigpICE9IHRhcmdldFNjYWxlIHx8 IHJvdW5kZWRJbnRQb2ludCh0YXJnZXRVbm9ic2N1cmVkUmVjdC5sb2NhdGlvbigpKSAhPSBmcmFt ZVZpZXcuc2Nyb2xsUG9zaXRpb24oKSkKKyAgICBpZiAoIXdpdGhpbkVwc2lsb24ocGFnZVNjYWxl RmFjdG9yKCksIHRhcmdldFNjYWxlKSB8fCByb3VuZGVkSW50UG9pbnQodGFyZ2V0VW5vYnNjdXJl ZFJlY3QubG9jYXRpb24oKSkgIT0gZnJhbWVWaWV3LnNjcm9sbFBvc2l0aW9uKCkpCiAgICAgICAg IHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RHluYW1pY1ZpZXdwb3J0VXBkYXRlQ2hhbmdl ZFRhcmdldChwYWdlU2NhbGVGYWN0b3IoKSwgZnJhbWVWaWV3LnNjcm9sbFBvc2l0aW9uKCkpKTsK IH0KIAo=