<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>132766</bug_id>
          
          <creation_ts>2014-05-09 19:43:04 -0700</creation_ts>
          <short_desc>Subpixel (?) errors in high-dpi filters tests</short_desc>
          <delta_ts>2021-12-29 08:56:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=232384</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>93471</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dean Jackson">dino</reporter>
          <assigned_to name="Simon Fraser (smfr)">simon.fraser</assigned_to>
          <cc>ap</cc>
    
    <cc>jonlee</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1008192</commentid>
    <comment_count>0</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-05-09 19:43:04 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=93471 is adding some new tests that fail with very small image differences on Mac WK2. It looks like the anti-aliasing is slightly wrong on the edge of the text object. Could this be subpixel?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008196</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-05-09 19:52:39 -0700</bug_when>
    <thetext>&lt;rdar://problem/16875024&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008202</commentid>
    <comment_count>2</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2014-05-09 20:50:16 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; https://bugs.webkit.org/show_bug.cgi?id=93471 is adding some new tests that fail with very small image differences on Mac WK2. It looks like the anti-aliasing is slightly wrong on the edge of the text object. Could this be subpixel?

Yes it could, though if you wanna do hiDPI test, you should prefix it with hidpi- instead (see http://trac.webkit.org/changeset/165470). It automatically turns DumpRenderTree/WebKitTestRunner into hidpi mode and runs the test (not sure what the ensure-hidpi.js does or if it works properly at all)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008249</commentid>
    <comment_count>3</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2014-05-10 02:40:41 -0700</bug_when>
    <thetext>Ooh, you told me this already - I forgot, sorry :(

I&apos;ll fix the test names.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1008257</commentid>
    <comment_count>4</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2014-05-10 07:25:35 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Ooh, you told me this already - I forgot, sorry :(
&gt; 
&gt; I&apos;ll fix the test names.
I really need to do this. https://bugs.webkit.org/show_bug.cgi?id=132775</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1023717</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-07-21 11:01:30 -0700</bug_when>
    <thetext>&lt;rdar://problem/17749324&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1023718</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-07-21 11:01:39 -0700</bug_when>
    <thetext>&lt;rdar://problem/17749328&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1826212</commentid>
    <comment_count>7</comment_count>
      <attachid>447778</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-12-21 20:55:30 -0800</bug_when>
    <thetext>Created attachment 447778
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1827178</commentid>
    <comment_count>8</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2021-12-29 08:44:36 -0800</bug_when>
    <thetext>(In reply to zalan from comment #4)
&gt; (In reply to comment #3)
&gt; &gt; Ooh, you told me this already - I forgot, sorry :(
&gt; &gt; 
&gt; &gt; I&apos;ll fix the test names.
&gt; I really need to do this. https://bugs.webkit.org/show_bug.cgi?id=132775

Where do we stand with this comment?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1827179</commentid>
    <comment_count>9</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2021-12-29 08:56:04 -0800</bug_when>
    <thetext>(In reply to Sam Weinig from comment #8)
&gt; (In reply to zalan from comment #4)
&gt; &gt; (In reply to comment #3)
&gt; &gt; &gt; Ooh, you told me this already - I forgot, sorry :(
&gt; &gt; &gt; 
&gt; &gt; &gt; I&apos;ll fix the test names.
&gt; &gt; I really need to do this. https://bugs.webkit.org/show_bug.cgi?id=132775
&gt; 
&gt; Where do we stand with this comment?
I don&apos;t think I am going to be working on it anytime soon; not sure about if others have plans.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>447778</attachid>
            <date>2021-12-21 20:55:30 -0800</date>
            <delta_ts>2021-12-29 08:43:54 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-132766-20211221205529.patch</filename>
            <type>text/plain</type>
            <size>1730</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MzIzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTNhN2VkOWQyMjRiY2E1OTUzYmFi
N2UxMzZkOTgxY2E3NjM2NzY3ZC4uYzU5MzZlMTVkNWZkNjlmNDg5NjBmODM1YTEyZmUxZWYzMmJi
ZDk2ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTIxICBTaW1vbiBGcmFzZXIgIDxz
aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFN1YnBpeGVsICg/KSBlcnJvcnMgaW4g
aGlnaC1kcGkgZmlsdGVycyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTMyNzY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgVGhlc2UgdGVzdHMgZG9uJ3Qgc2VlbSB0byBmYWlsIGFueSBtb3JlLgor
CisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIxLTEy
LTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZ1
enp5IHBpeGVsIGRhdGEgbmVlZCB0byBiZSBjb21wdXRlZCBpbiB0ZXJtcyBvZiBDU1MgcGl4ZWxz
CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv
bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg
ZWYxZWJiMDc2Y2RhYjRiNWI4NjhiZDhmMThkYTBiNDU3ZTI3Y2ZiMy4uZGE2MTlhM2I0ZWNlYTU1
OGZkMTExYTVhYmQwYzVhM2NlODhhZmQ4ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h
Yy13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNTk0LDEyICs1OTQsNiBAQCBlZGl0aW5nL21hYy9p
bnB1dC91bmNvbmZpcm1lZC10ZXh0LW5hdmlnYXRpb24td2l0aC1wYWdlLWNhY2hlLmh0bWwgWyBG
YWlsdXJlIF0KICMgdGVzdCByZXN1bHRzIGluIERSVCBkb24ndCBtYXRjaCBpbiBicm93c2VyIGJl
aGF2aW9yLCB0ZXN0IHNlZW1zIGJyb2tlbgogZmFzdC9kb20vV2luZG93L21vemlsbGEtZm9jdXMt
Ymx1ci5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzEzMjc2NiBmYXN0L2hp
ZHBpL2ZpbHRlcnMtYmx1ci5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2Iv
MTMyNzY2IGZhc3QvaGlkcGkvZmlsdGVycy1odWUtcm90YXRlLmh0bWwgWyBJbWFnZU9ubHlGYWls
dXJlIF0KLXdlYmtpdC5vcmcvYi8xMzI3NjYgZmFzdC9oaWRwaS9maWx0ZXJzLWludmVydC5odG1s
IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTMyNzY2IGZhc3QvaGlkcGkvZmls
dGVycy1tdWx0aXBsZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTMy
NzY2IGZhc3QvaGlkcGkvZmlsdGVycy1yZWZlcmVuY2UuaHRtbCBbIEltYWdlT25seUZhaWx1cmUg
XQotCiBmYXN0L2RvbS9mcmFtZS1sb2FkaW5nLXZpYS1kb2N1bWVudC13cml0ZS5odG1sIFsgVGlt
ZW91dCBdCiAKIGZhc3Qvc3BlZWNoc3ludGhlc2lzL3NwZWVjaC1zeW50aGVzaXMtY2FuY2VsLmh0
bWwgWyBQYXNzIFRpbWVvdXQgXQo=
</data>
<flag name="review"
          id="473496"
          type_id="1"
          status="+"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>