132751 2014-05-09 15:10:36 -0700 JSDOMWindow should disable property caching after a certain point 2014-05-09 17:07:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 132705 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 1008109 0 mhahnenberg 2014-05-09 15:10:36 -0700 This is part of removing HasImpureGetOwnPropertySlot from JSDOMWindow. After the lookup in the static hash table for JSDOMWindow fails we want to disable property caching even if the code that follows thinks that it has provided a cacheable value. 1008110 1 231187 mhahnenberg 2014-05-09 15:11:52 -0700 Created attachment 231187 Patch 1008149 2 231187 commit-queue 2014-05-09 17:07:21 -0700 Comment on attachment 231187 Patch Clearing flags on attachment: 231187 Committed r168558: <http://trac.webkit.org/changeset/168558> 1008150 3 commit-queue 2014-05-09 17:07:26 -0700 All reviewed patches have been landed. Closing bug. 231187 2014-05-09 15:11:52 -0700 2014-05-09 17:07:20 -0700 Patch bug-132751-20140509150958.patch text/plain 4631 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4NTU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTA1LTA5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSlNET01XaW5kb3cgc2hvdWxkIGRpc2FibGUgcHJvcGVydHkgY2FjaGluZyBhZnRl ciBhIGNlcnRhaW4gcG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMjc1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgaXMgcGFydCBvZiByZW1vdmluZyBIYXNJbXB1cmVHZXRPd25Qcm9wZXJ0 eVNsb3QgZnJvbSBKU0RPTVdpbmRvdy4gQWZ0ZXIgdGhlIGxvb2t1cCBpbiB0aGUgc3RhdGljIAor ICAgICAgICBoYXNoIHRhYmxlIGZvciBKU0RPTVdpbmRvdyBmYWlscyB3ZSB3YW50IHRvIGRpc2Fi bGUgcHJvcGVydHkgY2FjaGluZyBldmVuIGlmIHRoZSBjb2RlIHRoYXQgZm9sbG93cyB0aGlua3Mg CisgICAgICAgIHRoYXQgaXQgaGFzIHByb3ZpZGVkIGEgY2FjaGVhYmxlIHZhbHVlLgorCisgICAg ICAgICogcnVudGltZS9Qcm9wZXJ0eVNsb3QuaDoKKyAgICAgICAgKEpTQzo6UHJvcGVydHlTbG90 OjpQcm9wZXJ0eVNsb3QpOgorICAgICAgICAoSlNDOjpQcm9wZXJ0eVNsb3Q6OmlzQ2FjaGVhYmxl KToKKyAgICAgICAgKEpTQzo6UHJvcGVydHlTbG90OjpkaXNhYmxlQ2FjaGluZyk6CisKIDIwMTQt MDUtMDkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIDguOCUg c3BlbnQgaW4gT2JqZWN0LnByb3RvdHlwZS5oYXNPd25Qcm9wZXJ0eSgpIG9uIHNicGVyZnRlc3Qu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaAko cmV2aXNpb24gMTY4NTUwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVy dHlTbG90LmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDEyICs1NiwxOCBAQCBjbGFzcyBQcm9wZXJ0 eVNsb3QgewogICAgICAgICBUeXBlQ3VzdG9tSW5kZXgKICAgICB9OwogCisgICAgZW51bSBDYWNo ZWFiaWxpdHlUeXBlIHsKKyAgICAgICAgQ2FjaGluZ0Rpc2FsbG93ZWQsCisgICAgICAgIENhY2hp bmdBbGxvd2VkCisgICAgfTsKKwogcHVibGljOgogICAgIGV4cGxpY2l0IFByb3BlcnR5U2xvdChj b25zdCBKU1ZhbHVlIHRoaXNWYWx1ZSkKICAgICAgICAgOiBtX3Byb3BlcnR5VHlwZShUeXBlVW5z ZXQpCiAgICAgICAgICwgbV9vZmZzZXQoaW52YWxpZE9mZnNldCkKICAgICAgICAgLCBtX3RoaXNW YWx1ZSh0aGlzVmFsdWUpCiAgICAgICAgICwgbV93YXRjaHBvaW50U2V0KG51bGxwdHIpCisgICAg ICAgICwgbV9jYWNoZWFiaWxpdHkoQ2FjaGluZ0FsbG93ZWQpCiAgICAgewogICAgIH0KIApAQCAt NzEsNyArNzcsNyBAQCBwdWJsaWM6CiAgICAgSlNWYWx1ZSBnZXRWYWx1ZShFeGVjU3RhdGUqLCBQ cm9wZXJ0eU5hbWUpIGNvbnN0OwogICAgIEpTVmFsdWUgZ2V0VmFsdWUoRXhlY1N0YXRlKiwgdW5z aWduZWQgcHJvcGVydHlOYW1lKSBjb25zdDsKIAotICAgIGJvb2wgaXNDYWNoZWFibGUoKSBjb25z dCB7IHJldHVybiBtX29mZnNldCAhPSBpbnZhbGlkT2Zmc2V0OyB9CisgICAgYm9vbCBpc0NhY2hl YWJsZSgpIGNvbnN0IHsgcmV0dXJuIG1fY2FjaGVhYmlsaXR5ID09IENhY2hpbmdBbGxvd2VkICYm IG1fb2Zmc2V0ICE9IGludmFsaWRPZmZzZXQ7IH0KICAgICBib29sIGlzVmFsdWUoKSBjb25zdCB7 IHJldHVybiBtX3Byb3BlcnR5VHlwZSA9PSBUeXBlVmFsdWU7IH0KICAgICBib29sIGlzQWNjZXNz b3IoKSBjb25zdCB7IHJldHVybiBtX3Byb3BlcnR5VHlwZSA9PSBUeXBlR2V0dGVyOyB9CiAgICAg Ym9vbCBpc0N1c3RvbSgpIGNvbnN0IHsgcmV0dXJuIG1fcHJvcGVydHlUeXBlID09IFR5cGVDdXN0 b207IH0KQEAgLTc5LDYgKzg1LDExIEBAIHB1YmxpYzoKICAgICBib29sIGlzQ2FjaGVhYmxlR2V0 dGVyKCkgY29uc3QgeyByZXR1cm4gaXNDYWNoZWFibGUoKSAmJiBpc0FjY2Vzc29yKCk7IH0KICAg ICBib29sIGlzQ2FjaGVhYmxlQ3VzdG9tKCkgY29uc3QgeyByZXR1cm4gaXNDYWNoZWFibGUoKSAm JiBpc0N1c3RvbSgpOyB9CiAKKyAgICB2b2lkIGRpc2FibGVDYWNoaW5nKCkKKyAgICB7CisgICAg ICAgIG1fY2FjaGVhYmlsaXR5ID0gQ2FjaGluZ0Rpc2FsbG93ZWQ7CisgICAgfQorCiAgICAgdW5z aWduZWQgYXR0cmlidXRlcygpIGNvbnN0IHsgcmV0dXJuIG1fYXR0cmlidXRlczsgfQogCiAgICAg UHJvcGVydHlPZmZzZXQgY2FjaGVkT2Zmc2V0KCkgY29uc3QKQEAgLTI0NCw2ICsyNTUsNyBAQCBw cml2YXRlOgogICAgIGNvbnN0IEpTVmFsdWUgbV90aGlzVmFsdWU7CiAgICAgSlNPYmplY3QqIG1f c2xvdEJhc2U7CiAgICAgV2F0Y2hwb2ludFNldCogbV93YXRjaHBvaW50U2V0OworICAgIENhY2hl YWJpbGl0eVR5cGUgbV9jYWNoZWFiaWxpdHk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODU1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTA5ICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSlNET01XaW5kb3cgc2hv dWxkIGRpc2FibGUgcHJvcGVydHkgY2FjaGluZyBhZnRlciBhIGNlcnRhaW4gcG9pbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjc1MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4K KworICAgICAgICBUaGlzIGlzIHBhcnQgb2YgcmVtb3ZpbmcgSGFzSW1wdXJlR2V0T3duUHJvcGVy dHlTbG90IGZyb20gSlNET01XaW5kb3cuIEFmdGVyIHRoZSBsb29rdXAgaW4gdGhlIHN0YXRpYyAK KyAgICAgICAgaGFzaCB0YWJsZSBmb3IgSlNET01XaW5kb3cgZmFpbHMgd2Ugd2FudCB0byBkaXNh YmxlIHByb3BlcnR5IGNhY2hpbmcgZXZlbiBpZiB0aGUgY29kZSB0aGF0IGZvbGxvd3MgdGhpbmtz IAorICAgICAgICB0aGF0IGl0IGhhcyBwcm92aWRlZCBhIGNhY2hlYWJsZSB2YWx1ZS4KKworICAg ICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkpTRE9NV2luZG93OjpnZXRPd25Qcm9wZXJ0eVNsb3QpOgorCiAyMDE0LTA1LTA5ICBBbGV4 ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIx Njg1MTgpOiBNdWx0aXBsZSB0ZXN0cyBmb3Igd29ya2VycyBpbiBibG9icyBhc3NlcnQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAJ KHJldmlzaW9uIDE2ODU1MCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2lu ZG93Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk2LDYgKzE5NiwxMiBAQCBib29sIEpT RE9NV2luZG93OjpnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPCiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KIAorICAgIC8vIEFmdGVyIHRoaXMgcG9pbnQgaXQgaXMgbm8gbG9uZ2VyIHZhbGlkIHRv IGNhY2hlIGFueSByZXN1bHRzIGJlY2F1c2Ugb2YKKyAgICAvLyB0aGUgaW1wdXJlIG5hdHVyZSBv ZiB0aGUgcHJvcGVydHkgYWNjZXNzZXMgd2hpY2ggZm9sbG93LiBXZSBjYW4gbW92ZSB0aGlzIAor ICAgIC8vIHN0YXRlbWVudCBmdXJ0aGVyIGRvd24gd2hlbiB3ZSBhZGQgd2F5cyB0byBtaXRpZ2F0 ZSB0aGVzZSBpbXB1cml0aWVzIHdpdGgsIAorICAgIC8vIGZvciBleGFtcGxlLCB3YXRjaHBvaW50 cy4KKyAgICBzbG90LmRpc2FibGVDYWNoaW5nKCk7CisKICAgICAvLyBDaGVjayBmb3IgY2hpbGQg ZnJhbWVzIGJ5IG5hbWUgYmVmb3JlIGJ1aWx0LWluIHByb3BlcnRpZXMgdG8KICAgICAvLyBtYXRj aCBNb3ppbGxhLiBUaGlzIGRvZXMgbm90IG1hdGNoIElFLCBidXQgc29tZSBzaXRlcyBlbmQgdXAK ICAgICAvLyBuYW1pbmcgZnJhbWVzIHRoaW5ncyB0aGF0IGNvbmZsaWN0IHdpdGggd2luZG93IHBy b3BlcnRpZXMgdGhhdAo=