132746 2014-05-09 11:53:54 -0700 {TelephoneNumber, Selection}OverlayControllerMac don't handle tiled drawing properly 2014-05-09 13:58:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham beidson bfulgham simon.fraser thorton oldest_to_newest 1008052 0 bfulgham 2014-05-09 11:53:54 -0700 The drawing method for TelephoneNumberOverlayControllerMac draws more often than it needs to. It also improperly restricts the region that the UI uses to layout the data detector interface, resulting in strange drawing effects if a phone number spans two (or more) tiles. 1008053 1 bfulgham 2014-05-09 11:54:14 -0700 <rdar://problem/16789588> 1008058 2 231175 bfulgham 2014-05-09 12:00:51 -0700 Created attachment 231175 Patch 1008059 3 231175 simon.fraser 2014-05-09 12:03:35 -0700 Comment on attachment 231175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231175&action=review > Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:102 > + // Don't give the tile rect to the highlight drawing function. It will try to be smart and place the data detector arrow on > + // the left side of the highlight if we happen to cross a tile boundary. Instead, allow it to draw over the whole frame bounds, > + // and allow the context clipping to limit the drawing to the region we want to see. I don't think this comment is necessary. It explains why you fix this bug, but I don't think it adds value for the future. 1008065 4 231175 bfulgham 2014-05-09 12:16:41 -0700 Comment on attachment 231175 Patch I don't think the gtk-wk2 build failure is due to this change. 1008090 5 231184 bfulgham 2014-05-09 13:53:26 -0700 Created attachment 231184 Patch 1008092 6 bfulgham 2014-05-09 13:58:27 -0700 Committed r168551: <http://trac.webkit.org/changeset/168551> 231175 2014-05-09 12:00:51 -0700 2014-05-09 13:53:24 -0700 Patch bug-132746-20140509120028.patch text/plain 2766 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODU0MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA1LTA5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFRlbGVwaG9uZU51bWJlck92 ZXJsYXlDb250cm9sbGVyTWFjIGRvZXNuJ3QgaGFuZGxlIHRpbGVkIGRyYXdpbmcgcHJvcGVybHku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI3NDYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2Nzg5NTg4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHRyeSB0byBkcmF3IHRoZSBkZXRlY3Rv ciBVSSBpZiBubyBwYXJ0IG9mIHRoZSBzZWxlY3Rpb24gYm91bmRzIGFyZSBpbnNpZGUKKyAgICAg ICAgdGhlIGN1cnJlbnQgdGlsZS4gRG9uJ3QgbGltaXQgdGhlIGRldGVjdG9yIFVJIHRvIHRoZSBi b3VuZHMgb2YgdGhpcyB0aWxlLCBvciBlbHNlCisgICAgICAgIGl0IHdpbGwgYXR0ZW1wdCB0byBz cXVlZXplIGl0c2VsZiBpbnRvIHRoZSBwb3NzaWJseSBzbWFsbCBzcGFjZSBhdmFpbGFibGUuIExl dCBpdAorICAgICAgICBkcmF3IGFzIGlmIGl0IGhhZCB0aGUgd2hvbGUgc2NyZWVuLCBhbmQgcmVs eSBvbiB0aGUgY29udGV4dCBjbGlwIHJlZ2lvbiB0bworICAgICAgICBhdm9pZCBvdmVyZHJhd2lu Zy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGVsZXBob25lTnVtYmVyT3Zl cmxheUNvbnRyb2xsZXJNYWMubW06CisgICAgICAgIChXZWJLaXQ6OlRlbGVwaG9uZU51bWJlck92 ZXJsYXlDb250cm9sbGVyOjpkcmF3UmVjdCk6CisKIDIwMTQtMDUtMDkgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgV2ViS2l0Mi5mcmFtZXdv cmsgdG8gV2ViS2l0LmZyYW1ld29yawpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL21hYy9UZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJvbGxlck1hYy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9uZU51 bWJlck92ZXJsYXlDb250cm9sbGVyTWFjLm1tCShyZXZpc2lvbiAxNjg1MzMpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9uZU51bWJlck92ZXJsYXlDb250 cm9sbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05MSw5ICs5MSwxNiBAQCB2b2lkIFRlbGVw aG9uZU51bWJlck92ZXJsYXlDb250cm9sbGVyOjpkCiAgICAgICAgIEZyYW1lVmlldyYgbWFpbkZy YW1lVmlldyA9ICptX3dlYlBhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnZpZXcoKTsKICAg ICAgICAgcmVjdC5zZXRMb2NhdGlvbihtYWluRnJhbWVWaWV3LndpbmRvd1RvQ29udGVudHModmll d0ZvclJhbmdlLT5jb250ZW50c1RvV2luZG93KHJlY3QubG9jYXRpb24oKSkpKTsKIAorICAgICAg ICAvLyBJZiB0aGUgc2VsZWN0aW9uIHJlY3QgaXMgY29tcGxldGVseSBvdXRzaWRlIHRoaXMgZHJh d2luZyB0aWxlLCBkb24ndCBwcm9jZXNzIGl0IGZ1cnRoZXIKKyAgICAgICAgaWYgKCFyZWN0Lmlu dGVyc2VjdHMoZGlydHlSZWN0KSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIENH UmVjdCBjZ1JlY3RzW10gPSB7IChDR1JlY3QpcmVjdCB9OwogCi0gICAgICAgIFJldGFpblB0cjxE REhpZ2hsaWdodFJlZj4gaGlnaGxpZ2h0ID0gYWRvcHRDRihEREhpZ2hsaWdodENyZWF0ZVdpdGhS ZWN0c0luVmlzaWJsZVJlY3QobnVsbHB0ciwgY2dSZWN0cywgMSwgKENHUmVjdClkaXJ0eVJlY3Qs IHRydWUpKTsKKyAgICAgICAgLy8gRG9uJ3QgZ2l2ZSB0aGUgdGlsZSByZWN0IHRvIHRoZSBoaWdo bGlnaHQgZHJhd2luZyBmdW5jdGlvbi4gSXQgd2lsbCB0cnkgdG8gYmUgc21hcnQgYW5kIHBsYWNl IHRoZSBkYXRhIGRldGVjdG9yIGFycm93IG9uCisgICAgICAgIC8vIHRoZSBsZWZ0IHNpZGUgb2Yg dGhlIGhpZ2hsaWdodCBpZiB3ZSBoYXBwZW4gdG8gY3Jvc3MgYSB0aWxlIGJvdW5kYXJ5LiBJbnN0 ZWFkLCBhbGxvdyBpdCB0byBkcmF3IG92ZXIgdGhlIHdob2xlIGZyYW1lIGJvdW5kcywKKyAgICAg ICAgLy8gYW5kIGFsbG93IHRoZSBjb250ZXh0IGNsaXBwaW5nIHRvIGxpbWl0IHRoZSBkcmF3aW5n IHRvIHRoZSByZWdpb24gd2Ugd2FudCB0byBzZWUuCisgICAgICAgIFJldGFpblB0cjxEREhpZ2hs aWdodFJlZj4gaGlnaGxpZ2h0ID0gYWRvcHRDRihEREhpZ2hsaWdodENyZWF0ZVdpdGhSZWN0c0lu VmlzaWJsZVJlY3QobnVsbHB0ciwgY2dSZWN0cywgMSwgdmlld0ZvclJhbmdlLT5ib3VuZHNSZWN0 KCksIHRydWUpKTsKICAgICAgICAgUmVmUHRyPFRlbGVwaG9uZU51bWJlckRhdGE+IHRlbGVwaG9u ZU51bWJlckRhdGEgPSBUZWxlcGhvbmVOdW1iZXJEYXRhOjpjcmVhdGUocmFuZ2UuZ2V0KCksIGhp Z2hsaWdodC5nZXQoKSk7CiAgICAgICAgIG1fdGVsZXBob25lTnVtYmVyRGF0YXMuYXBwZW5kKHRl bGVwaG9uZU51bWJlckRhdGEpOwogICAgICAgICAK 231184 2014-05-09 13:53:26 -0700 2014-05-09 13:55:35 -0700 Patch bug-132746-20140509135303.patch text/plain 4457 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODU0MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA1LTA5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIHtUZWxlcGhvbmVOdW1iZXIs IFNlbGVjdGlvbn1Db250cm9sbGVyTWFjIGltcGxlbWVudGF0aW9ucyBkb3NuJ3QgaGFuZGxlIHRp bGVkIGRyYXdpbmcgcHJvcGVybHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzI3NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2Nzg5NTg4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHRy eSB0byBkcmF3IHRoZSBkZXRlY3RvciBVSSBpZiBubyBwYXJ0IG9mIHRoZSBzZWxlY3Rpb24gYm91 bmRzIGFyZSBpbnNpZGUKKyAgICAgICAgdGhlIGN1cnJlbnQgdGlsZS4gRG9uJ3QgbGltaXQgdGhl IGRldGVjdG9yIFVJIHRvIHRoZSBib3VuZHMgb2YgdGhpcyB0aWxlLCBvciBlbHNlCisgICAgICAg IGl0IHdpbGwgYXR0ZW1wdCB0byBzcXVlZXplIGl0c2VsZiBpbnRvIHRoZSBwb3NzaWJseSBzbWFs bCBzcGFjZSBhdmFpbGFibGUuIExldCBpdAorICAgICAgICBkcmF3IGFzIGlmIGl0IGhhZCB0aGUg d2hvbGUgc2NyZWVuLCBhbmQgcmVseSBvbiB0aGUgY29udGV4dCBjbGlwIHJlZ2lvbiB0bworICAg ICAgICBhdm9pZCBvdmVyZHJhd2luZy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9t YWMvVGVsZXBob25lTnVtYmVyT3ZlcmxheUNvbnRyb2xsZXJNYWMubW06CisgICAgICAgIChXZWJL aXQ6OlRlbGVwaG9uZU51bWJlck92ZXJsYXlDb250cm9sbGVyOjpkcmF3UmVjdCk6IENvcnJlY3Qg dGlsZWQgZHJhd2luZyBiZWhhdmlvci4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1NlbGVjdGlvbk92ZXJsYXlDb250cm9sbGVyTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpTZWxl Y3Rpb25PdmVybGF5Q29udHJvbGxlcjo6ZHJhd1JlY3QpOiBEaXR0by4KKwogMjAxNC0wNS0wOSAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBX ZWJLaXQyLmZyYW1ld29yayB0byBXZWJLaXQuZnJhbWV3b3JrCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlbGVjdGlvbk92ZXJsYXlDb250cm9sbGVyTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2Vs ZWN0aW9uT3ZlcmxheUNvbnRyb2xsZXJNYWMubW0JKHJldmlzaW9uIDE2ODUzMykKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VsZWN0aW9uT3ZlcmxheUNvbnRyb2xs ZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTcxLDE2ICs3MSwyNSBAQCB2b2lkIFNlbGVjdGlv bk92ZXJsYXlDb250cm9sbGVyOjpkcmF3UmVjCiAgICAgICAgIFZlY3RvcjxDR1JlY3Q+IGNnUmVj dHM7CiAgICAgICAgIGNnUmVjdHMucmVzZXJ2ZUNhcGFjaXR5KG1fY3VycmVudFNlbGVjdGlvblJl Y3RzLnNpemUoKSk7CiAKLSAgICAgICAgZm9yIChhdXRvJiByZWN0IDogbV9jdXJyZW50U2VsZWN0 aW9uUmVjdHMpCisgICAgICAgIGZvciAoYXV0byYgcmVjdCA6IG1fY3VycmVudFNlbGVjdGlvblJl Y3RzKSB7CisgICAgICAgICAgICBJbnRSZWN0IHNlbGVjdGlvblJlY3QocmVjdC5waXhlbFNuYXBw ZWRMb2NhdGlvbigpLCByZWN0LnBpeGVsU25hcHBlZFNpemUoKSk7CisKKyAgICAgICAgICAgIGlm ICghc2VsZWN0aW9uUmVjdC5pbnRlcnNlY3RzKGRpcnR5UmVjdCkpCisgICAgICAgICAgICAgICAg Y29udGludWU7CisKICAgICAgICAgICAgIGNnUmVjdHMuYXBwZW5kKChDR1JlY3QpcGl4ZWxTbmFw cGVkSW50UmVjdChyZWN0KSk7CisgICAgICAgIH0KIAotICAgICAgICBtX2N1cnJlbnRIaWdobGln aHQgPSBhZG9wdENGKERESGlnaGxpZ2h0Q3JlYXRlV2l0aFJlY3RzSW5WaXNpYmxlUmVjdChudWxs cHRyLCBjZ1JlY3RzLmJlZ2luKCksIGNnUmVjdHMuc2l6ZSgpLCAoQ0dSZWN0KWRpcnR5UmVjdCwg dHJ1ZSkpOwotICAgICAgICBtX2N1cnJlbnRIaWdobGlnaHRJc0RpcnR5ID0gZmFsc2U7CisgICAg ICAgIGlmICghY2dSZWN0cy5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgIENHUmVjdCBib3VuZHMg PSBtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnZpZXcoKS0+Ym91bmRzUmVjdCgp OworICAgICAgICAgICAgbV9jdXJyZW50SGlnaGxpZ2h0ID0gYWRvcHRDRihEREhpZ2hsaWdodENy ZWF0ZVdpdGhSZWN0c0luVmlzaWJsZVJlY3QobnVsbHB0ciwgY2dSZWN0cy5iZWdpbigpLCBjZ1Jl Y3RzLnNpemUoKSwgYm91bmRzLCB0cnVlKSk7CisgICAgICAgICAgICBtX2N1cnJlbnRIaWdobGln aHRJc0RpcnR5ID0gZmFsc2U7CiAKLSAgICAgICAgQm9vbGVhbiBvbkJ1dHRvbjsKLSAgICAgICAg bV9tb3VzZUlzT3ZlckhpZ2hsaWdodCA9IERESGlnaGxpZ2h0UG9pbnRJc09uSGlnaGxpZ2h0KG1f Y3VycmVudEhpZ2hsaWdodC5nZXQoKSwgKENHUG9pbnQpbV9tb3VzZVBvc2l0aW9uLCAmb25CdXR0 b24pOworICAgICAgICAgICAgQm9vbGVhbiBvbkJ1dHRvbjsKKyAgICAgICAgICAgIG1fbW91c2VJ c092ZXJIaWdobGlnaHQgPSBEREhpZ2hsaWdodFBvaW50SXNPbkhpZ2hsaWdodChtX2N1cnJlbnRI aWdobGlnaHQuZ2V0KCksIChDR1BvaW50KW1fbW91c2VQb3NpdGlvbiwgJm9uQnV0dG9uKTsKIAot ICAgICAgICBtb3VzZUhvdmVyU3RhdGVDaGFuZ2VkKCk7CisgICAgICAgICAgICBtb3VzZUhvdmVy U3RhdGVDaGFuZ2VkKCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICAvLyBJZiB0aGUgVUkgaXMg bm90IHZpc2liaWxlIG9yIGlmIHRoZSBtb3VzZSBpcyBub3Qgb3ZlciB0aGUgRERIaWdobGlnaHQg d2UgaGF2ZSBubyBkcmF3aW5nIHRvIGRvLgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9UZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJvbGxlck1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9u ZU51bWJlck92ZXJsYXlDb250cm9sbGVyTWFjLm1tCShyZXZpc2lvbiAxNjg1MzMpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9uZU51bWJlck92ZXJsYXlD b250cm9sbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05MSw5ICs5MSwxMyBAQCB2b2lkIFRl bGVwaG9uZU51bWJlck92ZXJsYXlDb250cm9sbGVyOjpkCiAgICAgICAgIEZyYW1lVmlldyYgbWFp bkZyYW1lVmlldyA9ICptX3dlYlBhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnZpZXcoKTsK ICAgICAgICAgcmVjdC5zZXRMb2NhdGlvbihtYWluRnJhbWVWaWV3LndpbmRvd1RvQ29udGVudHMo dmlld0ZvclJhbmdlLT5jb250ZW50c1RvV2luZG93KHJlY3QubG9jYXRpb24oKSkpKTsKIAorICAg ICAgICAvLyBJZiB0aGUgc2VsZWN0aW9uIHJlY3QgaXMgY29tcGxldGVseSBvdXRzaWRlIHRoaXMg ZHJhd2luZyB0aWxlLCBkb24ndCBwcm9jZXNzIGl0IGZ1cnRoZXIKKyAgICAgICAgaWYgKCFyZWN0 LmludGVyc2VjdHMoZGlydHlSZWN0KSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAg IENHUmVjdCBjZ1JlY3RzW10gPSB7IChDR1JlY3QpcmVjdCB9OwogCi0gICAgICAgIFJldGFpblB0 cjxEREhpZ2hsaWdodFJlZj4gaGlnaGxpZ2h0ID0gYWRvcHRDRihEREhpZ2hsaWdodENyZWF0ZVdp dGhSZWN0c0luVmlzaWJsZVJlY3QobnVsbHB0ciwgY2dSZWN0cywgMSwgKENHUmVjdClkaXJ0eVJl Y3QsIHRydWUpKTsKKyAgICAgICAgUmV0YWluUHRyPERESGlnaGxpZ2h0UmVmPiBoaWdobGlnaHQg PSBhZG9wdENGKERESGlnaGxpZ2h0Q3JlYXRlV2l0aFJlY3RzSW5WaXNpYmxlUmVjdChudWxscHRy LCBjZ1JlY3RzLCAxLCB2aWV3Rm9yUmFuZ2UtPmJvdW5kc1JlY3QoKSwgdHJ1ZSkpOwogICAgICAg ICBSZWZQdHI8VGVsZXBob25lTnVtYmVyRGF0YT4gdGVsZXBob25lTnVtYmVyRGF0YSA9IFRlbGVw aG9uZU51bWJlckRhdGE6OmNyZWF0ZShyYW5nZS5nZXQoKSwgaGlnaGxpZ2h0LmdldCgpKTsKICAg ICAgICAgbV90ZWxlcGhvbmVOdW1iZXJEYXRhcy5hcHBlbmQodGVsZXBob25lTnVtYmVyRGF0YSk7 CiAgICAgICAgIAo=