132718 2014-05-08 17:23:30 -0700 com.apple.iphonesimulator.startSession needs to pass “runtimeIdentifier” 2014-05-09 13:25:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler commit-queue ddkilzer oldest_to_newest 1007832 0 dfarler 2014-05-08 17:23:30 -0700 The simulator runtime may not be able to find a runtime via sdkRoot; its first choice is a runtime identifier keyed off of the SDK version. We should pass this along in the com.apple.iphonesimulator.startSession in old-run-webkit-tests. To allow this, IPhoneSimulatorNotification.pm needs to take all the keys that we give it. It’s currently filtering out a hard-coded list of keys — it won’t hurt to have more items in an NSNotification userInfo dictionary. 1007843 1 231118 dfarler 2014-05-08 17:56:22 -0700 Created attachment 231118 Patch 1008031 2 231118 ddkilzer 2014-05-09 11:00:08 -0700 Comment on attachment 231118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231118&action=review r=me > Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:204 > - my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(4); > - for my $property (qw(applicationArguments applicationEnvironment applicationIdentifier applicationPath deviceFamily deviceInfo productType sessionOwner sessionUUID sdkRoot version waitForDebugger)) { > - if (exists $dict->{$property}) { > - my $key = NSString->stringWithCString_($property); > - my $value = $dict->{$property}; > - $userInfo->setObject_forKey_($value, $key); > - } > + my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(scalar(keys($dict)) + 1); > + foreach my $key (keys($dict)) { > + $userInfo->setObject_forKey_($dict->{$key}, $key); Nice! 1008080 3 231118 commit-queue 2014-05-09 13:25:35 -0700 Comment on attachment 231118 Patch Clearing flags on attachment: 231118 Committed r168547: <http://trac.webkit.org/changeset/168547> 1008081 4 commit-queue 2014-05-09 13:25:37 -0700 All reviewed patches have been landed. Closing bug. 231118 2014-05-08 17:56:22 -0700 2014-05-09 13:25:34 -0700 Patch bug-132718-20140508175559.patch text/plain 4197 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWY0NzY0OTNlNjAyN2NkY2JlYjg1MDYwNTM5MmVmZTk2 ZjQzZGFmNi4uODRiMGM4Nzg4ZTMyNGU5NWFjN2FkZjE3N2U2NzRkODY3YjVjOWExMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMw IEBACiAyMDE0LTA1LTA4ICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KIAorICAg ICAgICBjb20uYXBwbGUuaXBob25lc2ltdWxhdG9yLnN0YXJ0U2Vzc2lvbiBuZWVkcyB0byBwYXNz ICJSdW50aW1lSWRlbnRpZmllciIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMjcxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBzaW11bGF0b3IgbWF5IG5vdCBiZSBhYmxlIHRvIGxvb2sgdXAgcnVu dGltZXMgYnkgU0RLIHBhdGhzCisgICAgICAgIGFuZCBpbnN0ZWFkIHdpbGwgbWFwIFNESyB2ZXJz aW9ucyB0byBydW50aW1lcyBpbnN0ZWFkLiBJbgorICAgICAgICBjb20uYXBwbGUuaXBob25lc2lt dWxhdG9yLnN0YXJ0U2Vzc2lvbiBub3RpZmljYXRpb25zLAorICAgICAgICAncnVudGltZUlkZW50 aWZpZXInIChTREsgdmVyc2lvbiBzdHJpbmcpIGlzIHByZWZlcnJlZCBvdmVyCisgICAgICAgICdz ZGtSb290JyAoU0RLIHBhdGgpIGFueXdheS4gSW5jbHVkZSB0aGUgJ3J1bnRpbWVJZGVudGlmaWVy JyBrZXkKKyAgICAgICAgd2hlbiBjcmVhdGluZyBhIG5ldyBEUlQgb3IgV0tUUiBzaW11bGF0b3Ig c2Vzc2lvbi4KKworICAgICAgICBJUGhvbmVTaW11bGF0b3JOb3RpZmljYXRpb24ucG0gZmlsdGVy cyBvdXQga2V5cyBmb3IgdGhpcworICAgICAgICBub3RpZmljYXRpb24ncyB1c2VySW5mbyB3aXRo IGEgaGFyZC1jb2RlZCBsaXN0LiBUaGVyZSdzIG5vIGhhcm0KKyAgICAgICAgaW4gaW5jbHVkaW5n IGV4dHJhIGtleS12YWx1ZSBwYWlycyBpbiBhbiBOU05vdGlmaWNhdGlvbiB1c2VySW5mbworICAg ICAgICBkaWN0aW9uYXJ5IGFueXdheSBhbmQgdGhlIHNpbXVsYXRvciBtYXkgYWdhaW4gY2hhbmdl IGl0cworICAgICAgICB1c2VySW5mbyBzY2hlbWEgZm9yIHRoaXMgbm90aWZpY2F0aW9uLgorCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvaW9zL1BlcmxTdXBwb3J0L0lQaG9uZVNpbXVsYXRvck5v dGlmaWNhdGlvbi9saWIvSVBob25lU2ltdWxhdG9yTm90aWZpY2F0aW9uLnBtOgorICAgICAgICAo cG9zdFN0YXJ0U2Vzc2lvbk5vdGlmaWNhdGlvbik6CisgICAgICAgICogU2NyaXB0cy9vbGQtcnVu LXdlYmtpdC10ZXN0czoKKyAgICAgICAgKGluc3RhbGxBbmRMYXVuY2hEdW1wVG9vbEFwcFVzaW5n Tm90aWZpY2F0aW9uKToKKworMjAxNC0wNS0wOCAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBs ZS5jb20+CisKICAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHM6IHVwZGF0ZSBzdHJpbmdzIGZv ciBzaW11bGF0b3IgZGV2aWNlcyBhbmQgYXBwIG5hbWUKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjY4NwogCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9pb3MvUGVybFN1cHBvcnQvSVBob25lU2ltdWxhdG9yTm90aWZpY2F0aW9uL2xp Yi9JUGhvbmVTaW11bGF0b3JOb3RpZmljYXRpb24ucG0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9p b3MvUGVybFN1cHBvcnQvSVBob25lU2ltdWxhdG9yTm90aWZpY2F0aW9uL2xpYi9JUGhvbmVTaW11 bGF0b3JOb3RpZmljYXRpb24ucG0KaW5kZXggYjYzMGI3NGU4ZmUzZTJmOGFmZTEwNmE2ZTZmOTFk MTYzODkzY2UwYy4uOTkzZGRhYzI2NjhmMjYxNmQwNjk2YWE5ZTliZTUzZmYzY2NhNGU4YyAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL1BlcmxTdXBwb3J0L0lQaG9uZVNpbXVs YXRvck5vdGlmaWNhdGlvbi9saWIvSVBob25lU2ltdWxhdG9yTm90aWZpY2F0aW9uLnBtCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2lvcy9QZXJsU3VwcG9ydC9JUGhvbmVTaW11bGF0b3JOb3Rp ZmljYXRpb24vbGliL0lQaG9uZVNpbXVsYXRvck5vdGlmaWNhdGlvbi5wbQpAQCAtMTk5LDEzICsx OTksOSBAQCBzdWIgcG9zdFN0YXJ0U2Vzc2lvbk5vdGlmaWNhdGlvbgogICAgIG15ICRzZWxmID0g c2hpZnQ7CiAgICAgbXkgJGRpY3QgPSBzaGlmdDsKIAotICAgIG15ICR1c2VySW5mbyA9IE5TTXV0 YWJsZURpY3Rpb25hcnktPmRpY3Rpb25hcnlXaXRoQ2FwYWNpdHlfKDQpOwotICAgIGZvciBteSAk cHJvcGVydHkgKHF3KGFwcGxpY2F0aW9uQXJndW1lbnRzIGFwcGxpY2F0aW9uRW52aXJvbm1lbnQg YXBwbGljYXRpb25JZGVudGlmaWVyIGFwcGxpY2F0aW9uUGF0aCBkZXZpY2VGYW1pbHkgZGV2aWNl SW5mbyBwcm9kdWN0VHlwZSBzZXNzaW9uT3duZXIgc2Vzc2lvblVVSUQgc2RrUm9vdCB2ZXJzaW9u IHdhaXRGb3JEZWJ1Z2dlcikpIHsKLSAgICAgICAgaWYgKGV4aXN0cyAkZGljdC0+eyRwcm9wZXJ0 eX0pIHsKLSAgICAgICAgICAgIG15ICRrZXkgPSBOU1N0cmluZy0+c3RyaW5nV2l0aENTdHJpbmdf KCRwcm9wZXJ0eSk7Ci0gICAgICAgICAgICBteSAkdmFsdWUgPSAkZGljdC0+eyRwcm9wZXJ0eX07 Ci0gICAgICAgICAgICAkdXNlckluZm8tPnNldE9iamVjdF9mb3JLZXlfKCR2YWx1ZSwgJGtleSk7 Ci0gICAgICAgIH0KKyAgICBteSAkdXNlckluZm8gPSBOU011dGFibGVEaWN0aW9uYXJ5LT5kaWN0 aW9uYXJ5V2l0aENhcGFjaXR5XyhzY2FsYXIoa2V5cygkZGljdCkpICsgMSk7CisgICAgZm9yZWFj aCBteSAka2V5IChrZXlzKCRkaWN0KSkgeworICAgICAgICAkdXNlckluZm8tPnNldE9iamVjdF9m b3JLZXlfKCRkaWN0LT57JGtleX0sICRrZXkpOwogICAgIH0KICAgICAkdXNlckluZm8tPnNldE9i amVjdF9mb3JLZXlfKE5TTnVtYmVyLT5udW1iZXJXaXRoSW50XygxKSwgTlNTdHJpbmctPnN0cmlu Z1dpdGhDU3RyaW5nXygidmVyc2lvbiIpKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9v bGQtcnVuLXdlYmtpdC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMK aW5kZXggYWI1MDcxODljMTdlMmZmZjBjNWI3MTMwM2EyMzg5N2RkOTdmZWYzOC4uZDM4YjFlNjU1 MWFjMDQ1NDAwMDM3NzhlM2ExNTk5NGJmNDAyNzQxMCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy9vbGQtcnVuLXdlYmtpdC10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0 LXRlc3RzCkBAIC0xMzkyLDEyICsxMzkyLDE1IEBAIHN1YiBpbnN0YWxsQW5kTGF1bmNoRHVtcFRv b2xBcHBVc2luZ05vdGlmaWNhdGlvbigkJCkKICAgICAgICAgJGFwcGxpY2F0aW9uUGF0aCA9ICIk cHJvZHVjdERpci9EdW1wUmVuZGVyVHJlZS5hcHAiOwogICAgIH0KIAorICAgIGNob21wKG15ICRz ZGtWZXJzaW9uID0gYHhjcnVuIC0tc2RrIGlwaG9uZXNpbXVsYXRvciAtLXNob3ctc2RrLXZlcnNp b25gKTsKKwogICAgIG15ICRkaWN0ID0gewogICAgICAgICBhcHBsaWNhdGlvbkFyZ3VtZW50cyA9 PiAmJG1ha2VOU0FycmF5RnJvbUFycmF5KCRhcmdzKSwKICAgICAgICAgYXBwbGljYXRpb25FbnZp cm9ubWVudCA9PiAmJG1ha2VOU0RpY3Rpb25hcnlGcm9tSGFzaCgkY2xlYW5FbnYpLAogICAgICAg ICBhcHBsaWNhdGlvbklkZW50aWZpZXIgPT4gTlNTdHJpbmctPnN0cmluZ1dpdGhDU3RyaW5nXygk aWRlbnRpZmllciksCiAgICAgICAgIGFwcGxpY2F0aW9uUGF0aCA9PiBOU1N0cmluZy0+c3RyaW5n V2l0aENTdHJpbmdfKCRhcHBsaWNhdGlvblBhdGgpLAogICAgICAgICBkZXZpY2VJbmZvID0+IE5T U3RyaW5nLT5zdHJpbmdXaXRoQ1N0cmluZ18oJGRldmljZU5hbWUpLAorICAgICAgICBydW50aW1l SWRlbnRpZmllciA9PiBOU1N0cmluZy0+c3RyaW5nV2l0aENTdHJpbmdfKCRzZGtWZXJzaW9uKSwK ICAgICAgICAgc2Vzc2lvbk93bmVyID0+IE5TU3RyaW5nLT5zdHJpbmdXaXRoQ1N0cmluZ18oJHBy b2dyYW1OYW1lKSwKICAgICAgICAgc2Vzc2lvblVVSUQgPT4gTlNTdHJpbmctPnN0cmluZ1dpdGhD U3RyaW5nXyhzaW11bGF0b3JTZXNzaW9uVVVJRCgpKSwKICAgICAgICAgc2RrUm9vdCA9PiBOU1N0 cmluZy0+c3RyaW5nV2l0aENTdHJpbmdfKCRzZGtSb290KSwK