132712 2014-05-08 16:19:38 -0700 [EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT. 2014-05-09 08:54:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson glenn philipj sergio oldest_to_newest 1007800 0 jer.noble 2014-05-08 16:19:38 -0700 [EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT. 1007801 1 231108 jer.noble 2014-05-08 16:23:15 -0700 Created attachment 231108 Patch 1007851 2 231108 eric.carlson 2014-05-08 18:16:48 -0700 Comment on attachment 231108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44 > + session->suspendIfNeeded(); Why not do this in the constructor? 1007990 3 jer.noble 2014-05-09 08:21:50 -0700 (In reply to comment #2) > (From update of attachment 231108 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review > > > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44 > > + session->suspendIfNeeded(); > > Why not do this in the constructor? We could, but it's generally a bad idea to call virtual functions in the constructor. 1007993 4 231108 commit-queue 2014-05-09 08:54:34 -0700 Comment on attachment 231108 Patch Clearing flags on attachment: 231108 Committed r168533: <http://trac.webkit.org/changeset/168533> 1007994 5 commit-queue 2014-05-09 08:54:37 -0700 All reviewed patches have been landed. Closing bug. 231108 2014-05-08 16:23:15 -0700 2014-05-09 08:54:34 -0700 Patch bug-132712-20140508162252.patch text/plain 1771 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGIxNzk3YTA4YTJkYzNm MTIwODc0N2E1NTRiZTg4MjUyZDM4MmI1OC4uNTg4NWE1OTVmYzllMzEzMWNhMTc3NmQyYTY3OTNm ODAyMmNiYjhlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTA1LTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtFTUVdIENhbGwgc3VzcGVu ZElmTmVlZGVkKCkgaW4gdGhlIE1lZGlhS2V5U2Vzc2lvbiBjcmVhdGUoKSBtZXRob2QgdG8gYXZv aWQgYW4gQVNTRVJULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMyNzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsIEFjdGl2ZURPTU9iamVjdCBzdWJjbGFzc2VzIG11c3QgY2FsbCBzdXNwZW5kSWZO ZWVkZWQoKSBpbW1lZGlhdGVseSBhZnRlciBjcmVhdGlvbi4KKworICAgICAgICAqIE1vZHVsZXMv ZW5jcnlwdGVkbWVkaWEvTWVkaWFLZXlTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1l ZGlhS2V5U2Vzc2lvbjo6TWVkaWFLZXlTZXNzaW9uKToKKworMjAxNC0wNS0wOCAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBbTVNFXVtNYWNdIERlc3Ryb3kgdGhl IEFWU3RyZWFtRGF0YVBhcnNlciB3aGVuIHRoZSBTb3VyY2VCdWZmZXIgaXMgcmVtb3ZlZCBmcm9t IGl0cyBNZWRpYVNvdXJjZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMjcxMAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Vu Y3J5cHRlZG1lZGlhL01lZGlhS2V5U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2VuY3J5cHRlZG1lZGlhL01lZGlhS2V5U2Vzc2lvbi5jcHAKaW5kZXggMjNjOTcwZGY2NDE5OGUw M2ExNGRkNzBhYjQ2ZmU1MTU1NDkyNWEzYy4uNThjYmFkNzNiYmNlZGNmYjFhNzI0NzEwZDVmMWY1 YWQ4OGNjMmUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9lbmNyeXB0ZWRt ZWRpYS9NZWRpYUtleVNlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZW5j cnlwdGVkbWVkaWEvTWVkaWFLZXlTZXNzaW9uLmNwcApAQCAtNDAsNyArNDAsOSBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIFBhc3NSZWZQdHI8TWVkaWFLZXlTZXNzaW9uPiBNZWRpYUtleVNlc3Np b246OmNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBNZWRpYUtleXMqIGtl eXMsIGNvbnN0IFN0cmluZyYga2V5U3lzdGVtKQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcg TWVkaWFLZXlTZXNzaW9uKGNvbnRleHQsIGtleXMsIGtleVN5c3RlbSkpOworICAgIGF1dG8gc2Vz c2lvbiA9IGFkb3B0UmVmKG5ldyBNZWRpYUtleVNlc3Npb24oY29udGV4dCwga2V5cywga2V5U3lz dGVtKSk7CisgICAgc2Vzc2lvbi0+c3VzcGVuZElmTmVlZGVkKCk7CisgICAgcmV0dXJuIHNlc3Np b247CiB9CiAKIE1lZGlhS2V5U2Vzc2lvbjo6TWVkaWFLZXlTZXNzaW9uKFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIGNvbnRleHQsIE1lZGlhS2V5cyoga2V5cywgY29uc3QgU3RyaW5nJiBrZXlTeXN0 ZW0pCg==