132709 2014-05-08 15:09:02 -0700 Expose functions necessary for copying favicon between IconDatabases. 2014-05-14 11:01:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 gordon_sheridan gordon_sheridan beidson commit-queue jberlin matthew_hanson webkit-bug-importer oldest_to_newest 1007783 0 gordon_sheridan 2014-05-08 15:09:02 -0700 In order to copy a favicon between icon databases, we need to surface WebIconDatabase::setIconURLForPageURL() and WebIconDatabase::synchronousIconURLForPageURL(). 1007787 1 231104 gordon_sheridan 2014-05-08 15:29:05 -0700 Created attachment 231104 Patch 1007855 2 jberlin 2014-05-08 18:55:41 -0700 <rdar://problem/16138065> 1007872 3 231104 jberlin 2014-05-08 20:17:58 -0700 Comment on attachment 231104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231104&action=review > Source/WebKit2/UIProcess/API/C/WKIconDatabase.cpp:65 > +WKURLRef WKIconDatabaseSynchronousIconURLForPageURL(WKIconDatabaseRef iconDatabaseRef, WKURLRef pageURLRef) This should be something like WKIconDatabaseSynchronousCopyIconURLForPageURL since it returns a copy. > Source/WebKit2/UIProcess/API/C/WKIconDatabase.h:84 > +WK_EXPORT void WKIconDatabaseSetIconURLForPageURL(WKIconDatabaseRef iconDatabaseRef, WKURLRef iconURLRef, WKURLRef pageURLRef); Is there a reason you called out "ForPageURL"? The other functions are just "ForURL". > Source/WebKit2/UIProcess/API/C/WKIconDatabase.h:85 > +WK_EXPORT WKURLRef WKIconDatabaseSynchronousIconURLForPageURL(WKIconDatabaseRef iconDatabaseRef, WKURLRef pageURLRef); Is it important and/or right for it to have "Synchronous" in the title? It seems like that should be more of a comment, or just entirely be implied by the fact that it returns the WKURLRef. I don't see any of our other WK2 C API doing this. 1007881 4 231128 gordon_sheridan 2014-05-08 21:02:40 -0700 Created attachment 231128 Patch 1007882 5 gordon_sheridan 2014-05-08 21:10:36 -0700 Jessie, I updated the patch to incorporate your suggestion to replace 'Synchronous' with 'Copy' in WKIconDatabaseSynchronousIconURLForPageURL(). I'm keeping the 'PageURL' portion instead of condensing it to just 'URL' because there are two URLs in these parameter lists, it matches the underlying method names these are wrapping, and there seemed to be a precedent of using 'PageURL' in two of the IconDatabase client callbacks (WKIconDatabaseDidChangeIconForPageURLCallback and WKIconDatabaseIconDataReadyForPageURLCallback). That said, I'm fine with changing them to whatever the WebKit folks want. 1008086 6 231128 beidson 2014-05-09 13:49:40 -0700 Comment on attachment 231128 Patch These names are fine. 1008095 7 231128 commit-queue 2014-05-09 14:20:41 -0700 Comment on attachment 231128 Patch Clearing flags on attachment: 231128 Committed r168553: <http://trac.webkit.org/changeset/168553> 1008096 8 commit-queue 2014-05-09 14:20:43 -0700 All reviewed patches have been landed. Closing bug. 231104 2014-05-08 15:29:05 -0700 2014-05-08 21:02:38 -0700 Patch bug-132709-20140508152843.patch text/plain 3373 gordon_sheridan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZhNDlmNjNkZGM4NmU2 Mzg1MjM3MjUzYzdhZjM0OGU5MWQ2M2IyOC4uOWQ5ZmU4NjVhOWU0YjdjZTExZTFiYjMxMGZiOGNi ZjM4N2JiYjg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA1LTA4ICBHb3Jk b24gU2hlcmlkYW4gIDxnb3Jkb25fc2hlcmlkYW5AYXBwbGUuY29tPgorCisgICAgICAgIEV4cG9z ZSBmdW5jdGlvbnMgbmVjZXNzYXJ5IGZvciBjb3B5aW5nIGZhdmljb24gYmV0d2VlbiBJY29uRGF0 YWJhc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyNzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL0MvV0tJY29uRGF0YWJhc2UuY3BwOgorICAgICAgICAoV0tJY29uRGF0 YWJhc2VTZXRJY29uVVJMRm9yUGFnZVVSTCk6CisgICAgICAgIEFkZCBDIEFQSSB3cmFwcGVyIGZv ciBXZWJJY29uRGF0YWJhc2U6OnNldEljb25VUkxGb3JQYWdlVVJMKCkuCisKKyAgICAgICAgKFdL SWNvbkRhdGFiYXNlU3luY2hyb25vdXNJY29uVVJMRm9yUGFnZVVSTCk6CisgICAgICAgIEFkZCBD IEFQSSB3cmFwcGVyIGZvciBXZWJJY29uRGF0YWJhc2U6OnN5bmNocm9ub3VzSWNvblVSTEZvclBh Z2VVUkwoKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0ljb25EYXRhYmFzZS5oOgor ICAgICAgICBBZGRlZCBkZWNsYXJhdGlvbnMgZm9yIHdyYXBwZXIgZnVuY3Rpb25zIGFib3ZlLgor CiAyMDE0LTA1LTA4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAg ICAgIE1ha2UgQmxvYkRhdGFGaWxlUmVmZXJlbmNlIG1hbmFnZSBpdHMgc2FuZGJveCBleHRlbnNp b24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ljb25EYXRh YmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tJY29uRGF0YWJhc2Uu Y3BwCmluZGV4IGE0NzI5MDA3MzJmNjc3MGZiNzUzY2QyNTEzOTYyZDdkZjRlODc0YTUuLjQyN2Y2 M2NjZjM1NzJhMjJiN2QyNTFiODFiNWQ0ZDQ0ZTM5M2ZiOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ljb25EYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmNwcApAQCAtNTcsNiArNTcsMTgg QEAgdm9pZCBXS0ljb25EYXRhYmFzZVNldEljb25EYXRhRm9ySWNvblVSTChXS0ljb25EYXRhYmFz ZVJlZiBpY29uRGF0YWJhc2VSZWYsIFdLRGEKICAgICB0b0ltcGwoaWNvbkRhdGFiYXNlUmVmKS0+ c2V0SWNvbkRhdGFGb3JJY29uVVJMKHRvSW1wbChpY29uRGF0YVJlZiktPmRhdGFSZWZlcmVuY2Uo KSwgdG9XVEZTdHJpbmcoaWNvblVSTFJlZikpOwogfQogCit2b2lkIFdLSWNvbkRhdGFiYXNlU2V0 SWNvblVSTEZvclBhZ2VVUkwoV0tJY29uRGF0YWJhc2VSZWYgaWNvbkRhdGFiYXNlUmVmLCBXS1VS TFJlZiBpY29uVVJMUmVmLCBXS1VSTFJlZiBwYWdlVVJMUmVmKQoreworICAgIHRvSW1wbChpY29u RGF0YWJhc2VSZWYpLT5zZXRJY29uVVJMRm9yUGFnZVVSTCh0b1dURlN0cmluZyhpY29uVVJMUmVm KSwgdG9XVEZTdHJpbmcocGFnZVVSTFJlZikpOworfQorCitXS1VSTFJlZiBXS0ljb25EYXRhYmFz ZVN5bmNocm9ub3VzSWNvblVSTEZvclBhZ2VVUkwoV0tJY29uRGF0YWJhc2VSZWYgaWNvbkRhdGFi YXNlUmVmLCBXS1VSTFJlZiBwYWdlVVJMUmVmKQoreworICAgIFN0cmluZyBpY29uVVJMU3RyaW5n OworICAgIHRvSW1wbChpY29uRGF0YWJhc2VSZWYpLT5zeW5jaHJvbm91c0ljb25VUkxGb3JQYWdl VVJMKHRvV1RGU3RyaW5nKHBhZ2VVUkxSZWYpLCBpY29uVVJMU3RyaW5nKTsKKyAgICByZXR1cm4g dG9Db3BpZWRVUkxBUEkoaWNvblVSTFN0cmluZyk7Cit9CisKIHZvaWQgV0tJY29uRGF0YWJhc2VF bmFibGVEYXRhYmFzZUNsZWFudXAoV0tJY29uRGF0YWJhc2VSZWYgaWNvbkRhdGFiYXNlUmVmKQog ewogICAgIHRvSW1wbChpY29uRGF0YWJhc2VSZWYpLT5lbmFibGVEYXRhYmFzZUNsZWFudXAoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ljb25EYXRhYmFz ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmgKaW5k ZXggMGExMGY2NTk2MzJkOGVhNTFjNTY1YmEyOWVhYzIwNDkxMTQzMGIxNi4uMzQ1YzE5ZTU0MjFh ZGVmOWJmMmRjMGY2Nzc3NWNhNmI5MGE2NjEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmgKQEAgLTgxLDYgKzgxLDkgQEAgV0tfRVhQT1JU IHZvaWQgV0tJY29uRGF0YWJhc2VTZXRJY29uRGF0YWJhc2VDbGllbnQoV0tJY29uRGF0YWJhc2VS ZWYgaWNvbkRhdGFiYXMKIFdLX0VYUE9SVCB2b2lkIFdLSWNvbkRhdGFiYXNlUmV0YWluSWNvbkZv clVSTChXS0ljb25EYXRhYmFzZVJlZiBpY29uRGF0YWJhc2UsIFdLVVJMUmVmIHBhZ2VVUkwpOwog V0tfRVhQT1JUIHZvaWQgV0tJY29uRGF0YWJhc2VSZWxlYXNlSWNvbkZvclVSTChXS0ljb25EYXRh YmFzZVJlZiBpY29uRGF0YWJhc2UsIFdLVVJMUmVmIHBhZ2VVUkwpOwogV0tfRVhQT1JUIHZvaWQg V0tJY29uRGF0YWJhc2VTZXRJY29uRGF0YUZvckljb25VUkwoV0tJY29uRGF0YWJhc2VSZWYgaWNv bkRhdGFiYXNlLCBXS0RhdGFSZWYgaWNvbkRhdGEsIFdLVVJMUmVmIGljb25VUkwpOworV0tfRVhQ T1JUIHZvaWQgV0tJY29uRGF0YWJhc2VTZXRJY29uVVJMRm9yUGFnZVVSTChXS0ljb25EYXRhYmFz ZVJlZiBpY29uRGF0YWJhc2VSZWYsIFdLVVJMUmVmIGljb25VUkxSZWYsIFdLVVJMUmVmIHBhZ2VV UkxSZWYpOworV0tfRVhQT1JUIFdLVVJMUmVmIFdLSWNvbkRhdGFiYXNlU3luY2hyb25vdXNJY29u VVJMRm9yUGFnZVVSTChXS0ljb25EYXRhYmFzZVJlZiBpY29uRGF0YWJhc2VSZWYsIFdLVVJMUmVm IHBhZ2VVUkxSZWYpOworCiBXS19FWFBPUlQgdm9pZCBXS0ljb25EYXRhYmFzZUVuYWJsZURhdGFi YXNlQ2xlYW51cChXS0ljb25EYXRhYmFzZVJlZiBpY29uRGF0YWJhc2UpOwogCiBXS19FWFBPUlQg dm9pZCBXS0ljb25EYXRhYmFzZVJlbW92ZUFsbEljb25zKFdLSWNvbkRhdGFiYXNlUmVmIGljb25E YXRhYmFzZSk7Cg== 231128 2014-05-08 21:02:40 -0700 2014-05-09 14:20:40 -0700 Patch bug-132709-20140508210218.patch text/plain 3352 gordon_sheridan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZhNDlmNjNkZGM4NmU2 Mzg1MjM3MjUzYzdhZjM0OGU5MWQ2M2IyOC4uMjVlMjcwNGY2NjI3Y2Q5MzRlNDU3NTYxZDNiZjhh ZGZjMjgxZWJjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA1LTA4ICBHb3Jk b24gU2hlcmlkYW4gIDxnb3Jkb25fc2hlcmlkYW5AYXBwbGUuY29tPgorCisgICAgICAgIEV4cG9z ZSBmdW5jdGlvbnMgbmVjZXNzYXJ5IGZvciBjb3B5aW5nIGZhdmljb24gYmV0d2VlbiBJY29uRGF0 YWJhc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyNzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL0MvV0tJY29uRGF0YWJhc2UuY3BwOgorICAgICAgICAoV0tJY29uRGF0 YWJhc2VTZXRJY29uVVJMRm9yUGFnZVVSTCk6CisgICAgICAgIEFkZCBDIEFQSSB3cmFwcGVyIGZv ciBXZWJJY29uRGF0YWJhc2U6OnNldEljb25VUkxGb3JQYWdlVVJMKCkuCisKKyAgICAgICAgKFdL SWNvbkRhdGFiYXNlQ29weUljb25VUkxGb3JQYWdlVVJMKToKKyAgICAgICAgQWRkIEMgQVBJIHdy YXBwZXIgZm9yIFdlYkljb25EYXRhYmFzZTo6c3luY2hyb25vdXNJY29uVVJMRm9yUGFnZVVSTCgp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmg6CisgICAgICAg IEFkZGVkIGRlY2xhcmF0aW9ucyBmb3Igd3JhcHBlciBmdW5jdGlvbnMgYWJvdmUuCisKIDIwMTQt MDUtMDggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgTWFr ZSBCbG9iRGF0YUZpbGVSZWZlcmVuY2UgbWFuYWdlIGl0cyBzYW5kYm94IGV4dGVuc2lvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ljb25EYXRhYmFzZS5jcHAKaW5k ZXggYTQ3MjkwMDczMmY2NzcwZmI3NTNjZDI1MTM5NjJkN2RmNGU4NzRhNS4uMTQyZDEyZGE2MmQ4 ZTQ4YmJmZGQ4ZGMzZTI2MjYwZDIyZDVmMDYwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLSWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tJY29uRGF0YWJhc2UuY3BwCkBAIC01Nyw2ICs1NywxOCBAQCB2b2lk IFdLSWNvbkRhdGFiYXNlU2V0SWNvbkRhdGFGb3JJY29uVVJMKFdLSWNvbkRhdGFiYXNlUmVmIGlj b25EYXRhYmFzZVJlZiwgV0tEYQogICAgIHRvSW1wbChpY29uRGF0YWJhc2VSZWYpLT5zZXRJY29u RGF0YUZvckljb25VUkwodG9JbXBsKGljb25EYXRhUmVmKS0+ZGF0YVJlZmVyZW5jZSgpLCB0b1dU RlN0cmluZyhpY29uVVJMUmVmKSk7CiB9CiAKK3ZvaWQgV0tJY29uRGF0YWJhc2VTZXRJY29uVVJM Rm9yUGFnZVVSTChXS0ljb25EYXRhYmFzZVJlZiBpY29uRGF0YWJhc2VSZWYsIFdLVVJMUmVmIGlj b25VUkxSZWYsIFdLVVJMUmVmIHBhZ2VVUkxSZWYpCit7CisgICAgdG9JbXBsKGljb25EYXRhYmFz ZVJlZiktPnNldEljb25VUkxGb3JQYWdlVVJMKHRvV1RGU3RyaW5nKGljb25VUkxSZWYpLCB0b1dU RlN0cmluZyhwYWdlVVJMUmVmKSk7Cit9CisKK1dLVVJMUmVmIFdLSWNvbkRhdGFiYXNlQ29weUlj b25VUkxGb3JQYWdlVVJMKFdLSWNvbkRhdGFiYXNlUmVmIGljb25EYXRhYmFzZVJlZiwgV0tVUkxS ZWYgcGFnZVVSTFJlZikKK3sKKyAgICBTdHJpbmcgaWNvblVSTFN0cmluZzsKKyAgICB0b0ltcGwo aWNvbkRhdGFiYXNlUmVmKS0+c3luY2hyb25vdXNJY29uVVJMRm9yUGFnZVVSTCh0b1dURlN0cmlu ZyhwYWdlVVJMUmVmKSwgaWNvblVSTFN0cmluZyk7CisgICAgcmV0dXJuIHRvQ29waWVkVVJMQVBJ KGljb25VUkxTdHJpbmcpOworfQorCiB2b2lkIFdLSWNvbkRhdGFiYXNlRW5hYmxlRGF0YWJhc2VD bGVhbnVwKFdLSWNvbkRhdGFiYXNlUmVmIGljb25EYXRhYmFzZVJlZikKIHsKICAgICB0b0ltcGwo aWNvbkRhdGFiYXNlUmVmKS0+ZW5hYmxlRGF0YWJhc2VDbGVhbnVwKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tJY29uRGF0YWJhc2UuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ljb25EYXRhYmFzZS5oCmluZGV4IDBhMTBmNjU5NjMy ZDhlYTUxYzU2NWJhMjllYWMyMDQ5MTE0MzBiMTYuLjI0ZTA0NGU3ZTBiMGM3NGI1OTFiYTJlZTE3 MDA2OTFlYzRmOTI4YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Qy9XS0ljb25EYXRhYmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S0ljb25EYXRhYmFzZS5oCkBAIC04MSw2ICs4MSw5IEBAIFdLX0VYUE9SVCB2b2lkIFdLSWNvbkRh dGFiYXNlU2V0SWNvbkRhdGFiYXNlQ2xpZW50KFdLSWNvbkRhdGFiYXNlUmVmIGljb25EYXRhYmFz CiBXS19FWFBPUlQgdm9pZCBXS0ljb25EYXRhYmFzZVJldGFpbkljb25Gb3JVUkwoV0tJY29uRGF0 YWJhc2VSZWYgaWNvbkRhdGFiYXNlLCBXS1VSTFJlZiBwYWdlVVJMKTsKIFdLX0VYUE9SVCB2b2lk IFdLSWNvbkRhdGFiYXNlUmVsZWFzZUljb25Gb3JVUkwoV0tJY29uRGF0YWJhc2VSZWYgaWNvbkRh dGFiYXNlLCBXS1VSTFJlZiBwYWdlVVJMKTsKIFdLX0VYUE9SVCB2b2lkIFdLSWNvbkRhdGFiYXNl U2V0SWNvbkRhdGFGb3JJY29uVVJMKFdLSWNvbkRhdGFiYXNlUmVmIGljb25EYXRhYmFzZSwgV0tE YXRhUmVmIGljb25EYXRhLCBXS1VSTFJlZiBpY29uVVJMKTsKK1dLX0VYUE9SVCB2b2lkIFdLSWNv bkRhdGFiYXNlU2V0SWNvblVSTEZvclBhZ2VVUkwoV0tJY29uRGF0YWJhc2VSZWYgaWNvbkRhdGFi YXNlUmVmLCBXS1VSTFJlZiBpY29uVVJMUmVmLCBXS1VSTFJlZiBwYWdlVVJMUmVmKTsKK1dLX0VY UE9SVCBXS1VSTFJlZiBXS0ljb25EYXRhYmFzZUNvcHlJY29uVVJMRm9yUGFnZVVSTChXS0ljb25E YXRhYmFzZVJlZiBpY29uRGF0YWJhc2VSZWYsIFdLVVJMUmVmIHBhZ2VVUkxSZWYpOworCiBXS19F WFBPUlQgdm9pZCBXS0ljb25EYXRhYmFzZUVuYWJsZURhdGFiYXNlQ2xlYW51cChXS0ljb25EYXRh YmFzZVJlZiBpY29uRGF0YWJhc2UpOwogCiBXS19FWFBPUlQgdm9pZCBXS0ljb25EYXRhYmFzZVJl bW92ZUFsbEljb25zKFdLSWNvbkRhdGFiYXNlUmVmIGljb25EYXRhYmFzZSk7Cg==