132706 2014-05-08 14:31:29 -0700 REGRESSION (r168053): Phone number detection boxes are wrong when scrolled 2014-05-09 07:39:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned bdakin beidson simon.fraser thorton oldest_to_newest 1007773 0 bdakin 2014-05-08 14:31:29 -0700 REGRESSION (r168053): Phone number detection boxes are wrong when scrolled <rdar://problem/16787957> 1007775 1 231101 bdakin 2014-05-08 14:38:18 -0700 Created attachment 231101 Patch 1007789 2 bdakin 2014-05-08 15:30:08 -0700 Thanks Tim! http://trac.webkit.org/changeset/168499 1007980 3 231101 darin 2014-05-09 07:39:45 -0700 Comment on attachment 231101 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231101&action=review > Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:66 > + size_t size = textQuads.size(); > + for (size_t i = 0; i < size; ++i) > + boundingRect.unite(textQuads[i].boundingBox()); Should use a modern for loop: for (auto& quad : textQuads) boundingRect.unit(quad.boundingBox()); 231101 2014-05-08 14:38:18 -0700 2014-05-09 07:39:45 -0700 Patch for-review.txt text/plain 4872 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODQ5NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTA4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTY4MDUzKTog UGhvbmUgbnVtYmVyIGRldGVjdGlvbiBib3hlcyBhcmUgd3Jvbmcgd2hlbiBzY3JvbGxlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNzA2CisgICAg ICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2Nzg3OTU3 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5l ZWQgdG8gcGFpbnQgdGhlIGJveGVzIGluIERvY3VtZW50IGNvb3JkaW5hdGVzLiBSYW5nZTo6Ym91 bmRpbmdSZWN0KCkgd2FzIAorICAgICAgICBnaXZpbmcgdXMgYSBwb2ludCB0aGF0IHRvb2sgc2Ny b2xsIHBvc2l0aW9uIGludG8gYWNjb3VudCwgYW5kIHRoYXTigJlzIG5vdCB3aGF0IHdlIAorICAg ICAgICB3YW50LiBIZXJlIHdlIHVzZSBSYW5nZTo6dGV4dFF1YWRzKCkgaW5zdGVhZCBzbyB0aGF0 IHdlIGNhbiBnZXQgc29tZXRoaW5nIGluIAorICAgICAgICBEb2N1bWVudCBjb29yZGluYXRlcywg YW5kIHRoZW4gd2UgbmVlZCB0byBjb252ZXJ0IHRoYXQgdXAgdG8gdGhlIG1haW4gRG9jdW1lbnTi gJlzIAorICAgICAgICBjb29yZGluYXRlcy4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv bWFjL1RlbGVwaG9uZU51bWJlck92ZXJsYXlDb250cm9sbGVyTWFjLm1tOgorICAgICAgICAoV2Vi S2l0Ojp0ZXh0UXVhZHNUb0JvdW5kaW5nUmVjdEZvclJhbmdlKToKKyAgICAgICAgKFdlYktpdDo6 VGVsZXBob25lTnVtYmVyT3ZlcmxheUNvbnRyb2xsZXI6OmRyYXdSZWN0KToKKworICAgICAgICBU aGUgdGVsZXBob25lIGNsaWNrIGZ1bmN0aW9uIHdhbnRzIGEgcG9pbnQgaW4gV2luZG93IGNvb3Jk aW5hdGVzLgorICAgICAgICAoV2ViS2l0OjpUZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJvbGxl cjo6bW91c2VFdmVudCk6CisKIDIwMTQtMDUtMDggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRv bkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBXZWJLaXQyXSBGbHVzaCBSZW1vdGVMYXllckJh Y2tpbmdTdG9yZSBjb250ZXh0cyBvbiBhIHNlY29uZGFyeSBxdWV1ZQpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJv bGxlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1RlbGVwaG9uZU51bWJlck92ZXJsYXlDb250cm9sbGVyTWFjLm1tCShyZXZpc2lvbiAx Njg0NzYpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9u ZU51bWJlck92ZXJsYXlDb250cm9sbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsy OSw3IEBACiAjaWYgRU5BQkxFKFRFTEVQSE9ORV9OVU1CRVJfREVURUNUSU9OKSAmJiBQTEFURk9S TShNQUMpCiAKICNpbXBvcnQgPFdlYkNvcmUvRG9jdW1lbnQuaD4KKyNpbXBvcnQgPFdlYkNvcmUv RmxvYXRRdWFkLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0ZyYW1lVmlldy5oPgogI2ltcG9ydCA8V2Vi Q29yZS9HcmFwaGljc0NvbnRleHQuaD4KICNpbXBvcnQgPFdlYkNvcmUvTWFpbkZyYW1lLmg+CkBA IC01NSw2ICs1NiwxNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdl YktpdCB7CiAKK3N0YXRpYyBJbnRSZWN0IHRleHRRdWFkc1RvQm91bmRpbmdSZWN0Rm9yUmFuZ2Uo UmFuZ2UqIHJhbmdlKQoreworICAgIFZlY3RvcjxGbG9hdFF1YWQ+IHRleHRRdWFkczsKKyAgICBy YW5nZS0+dGV4dFF1YWRzKHRleHRRdWFkcyk7CisgICAgRmxvYXRSZWN0IGJvdW5kaW5nUmVjdDsK KyAgICBzaXplX3Qgc2l6ZSA9IHRleHRRdWFkcy5zaXplKCk7CisgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCBzaXplOyArK2kpCisgICAgICAgIGJvdW5kaW5nUmVjdC51bml0ZSh0ZXh0UXVhZHNb aV0uYm91bmRpbmdCb3goKSk7CisgICAgcmV0dXJuIGVuY2xvc2luZ0ludFJlY3QoYm91bmRpbmdS ZWN0KTsKK30KKwogdm9pZCBUZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJvbGxlcjo6ZHJhd1Jl Y3QoUGFnZU92ZXJsYXkqIG92ZXJsYXksIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCYgZ3JhcGhp Y3NDb250ZXh0LCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBkaXJ0eVJlY3QpCiB7CiAgICAgaWYg KG1fY3VycmVudFNlbGVjdGlvblJhbmdlcy5pc0VtcHR5KCkpCkBAIC02NywxNCArNzksMTcgQEAg dm9pZCBUZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJvbGxlcjo6ZAogICAgIGZvciAoYXV0byYg cmFuZ2UgOiBtX2N1cnJlbnRTZWxlY3Rpb25SYW5nZXMpIHsKICAgICAgICAgLy8gRklYTUU6IFRo aXMgd2lsbCBjaG9rZSBpZiB0aGUgcmFuZ2Ugd3JhcHMgYXJvdW5kIHRoZSBlZGdlIG9mIHRoZSB2 aWV3LgogICAgICAgICAvLyBXaGF0IHNob3VsZCB3ZSBkbyBpbiB0aGF0IGNhc2U/Ci0gICAgICAg IEludFJlY3QgcmVjdCA9IGVuY2xvc2luZ0ludFJlY3QocmFuZ2UtPmJvdW5kaW5nUmVjdCgpKTsK KyAgICAgICAgSW50UmVjdCByZWN0ID0gdGV4dFF1YWRzVG9Cb3VuZGluZ1JlY3RGb3JSYW5nZShy YW5nZS5nZXQoKSk7CiAKICAgICAgICAgLy8gQ29udmVydCB0byB0aGUgbWFpbiBkb2N1bWVudCdz IGNvb3JkaW5hdGUgc3BhY2UuCisgICAgICAgIC8vIEZJWE1FOiBJdCdzIGEgbGl0dGxlIGNyYXp5 IHRvIGNhbGwgY29udGVudHNUb1dpbmRvdyBhbmQgdGhlbiB3aW5kb3dUb0NvbnRlbnRzIGluIG9y ZGVyIHRvIGdldCB0aGUgcmlnaHQgY29vcmRpbmF0ZSBzcGFjZS4KKyAgICAgICAgLy8gV2Ugc2hv dWxkIGNvbnNpZGVyIGFkZGluZyBjb252ZXJzaW9uIGZ1bmN0aW9ucyB0byBTY3JvbGxWaWV3IGZv ciBjb250ZW50c1RvRG9jdW1lbnQoKS4gUmlnaHQgbm93LCBjb250ZW50c1RvUm9vdFZpZXcoKSBp cworICAgICAgICAvLyBub3QgZXF1aXZhbGVudCB0byB3aGF0IHdlIG5lZWQgd2hlbiB5b3UgaGF2 ZSBhIHRvcENvbnRlbnRJbnNldCBvciBhIGhlYWRlciBiYW5uZXIuCiAgICAgICAgIEZyYW1lVmll dyogdmlld0ZvclJhbmdlID0gcmFuZ2UtPm93bmVyRG9jdW1lbnQoKS52aWV3KCk7CiAgICAgICAg IGlmICghdmlld0ZvclJhbmdlKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBGcmFtZVZp ZXcmIG1haW5GcmFtZVZpZXcgPSAqbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5tYWluRnJhbWUoKS52 aWV3KCk7Ci0gICAgICAgIHJlY3Quc2V0TG9jYXRpb24obWFpbkZyYW1lVmlldy5jb252ZXJ0Q2hp bGRUb1NlbGYodmlld0ZvclJhbmdlLCByZWN0LmxvY2F0aW9uKCkpKTsKKyAgICAgICAgcmVjdC5z ZXRMb2NhdGlvbihtYWluRnJhbWVWaWV3LndpbmRvd1RvQ29udGVudHModmlld0ZvclJhbmdlLT5j b250ZW50c1RvV2luZG93KHJlY3QubG9jYXRpb24oKSkpKTsKIAogICAgICAgICBDR1JlY3QgY2dS ZWN0c1tdID0geyAoQ0dSZWN0KXJlY3QgfTsKIApAQCAtMTIyLDcgKzEzNyw3IEBAIHZvaWQgVGVs ZXBob25lTnVtYmVyT3ZlcmxheUNvbnRyb2xsZXI6OmgKIGJvb2wgVGVsZXBob25lTnVtYmVyT3Zl cmxheUNvbnRyb2xsZXI6Om1vdXNlRXZlbnQoUGFnZU92ZXJsYXkqLCBjb25zdCBXZWJNb3VzZUV2 ZW50JiBldmVudCkKIHsKICAgICBJbnRQb2ludCBtb3VzZVBvc2l0aW9uID0gbV93ZWJQYWdlLT5j b3JlUGFnZSgpLT5tYWluRnJhbWUoKS52aWV3KCktPnJvb3RWaWV3VG9Db250ZW50cyhldmVudC5w b3NpdGlvbigpKTsKLSAgICAKKwogICAgIC8vIElmIHRoaXMgZXZlbnQgaGFzIG5vdGhpbmcgdG8g ZG8gd2l0aCB0aGUgbGVmdCBidXR0b24sIGl0IGNsZWFycyB0aGUgY3VycmVudCBtb3VzZSBkb3du IHRyYWNraW5nIGFuZCB3ZSdyZSBkb25lIHByb2Nlc3NpbmcgaXQuCiAgICAgaWYgKGV2ZW50LmJ1 dHRvbigpICE9IFdlYk1vdXNlRXZlbnQ6OkxlZnRCdXR0b24pIHsKICAgICAgICAgY2xlYXJNb3Vz ZURvd25JbmZvcm1hdGlvbigpOwpAQCAtMTM4LDcgKzE1Myw3IEBAIGJvb2wgVGVsZXBob25lTnVt YmVyT3ZlcmxheUNvbnRyb2xsZXI6Om0KICAgICAgICAgLy8gSWYgdGhlIG1vdXNlIGxpZnRlZCB3 aGlsZSBzdGlsbCBvdmVyIHRoZSBoaWdobGlnaHQgYnV0dG9uIHRoYXQgaXQgd2VudCBkb3duIG9u LCB0aGVuIHRoYXQgaXMgYSBjbGljay4KICAgICAgICAgQm9vbGVhbiBvbkJ1dHRvbjsKICAgICAg ICAgaWYgKERESGlnaGxpZ2h0UG9pbnRJc09uSGlnaGxpZ2h0KGN1cnJlbnROdW1iZXItPmhpZ2hs aWdodCgpLCAoQ0dQb2ludCltb3VzZVBvc2l0aW9uLCAmb25CdXR0b24pICYmIG9uQnV0dG9uKSB7 Ci0gICAgICAgICAgICBoYW5kbGVUZWxlcGhvbmVDbGljayhjdXJyZW50TnVtYmVyLmdldCgpLCBt b3VzZVBvc2l0aW9uKTsKKyAgICAgICAgICAgIGhhbmRsZVRlbGVwaG9uZUNsaWNrKGN1cnJlbnRO dW1iZXIuZ2V0KCksIG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZyYW1lKCkudmlldygpLT5j b250ZW50c1RvV2luZG93KG1vdXNlUG9zaXRpb24pKTsKICAgICAgICAgICAgIAogICAgICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0K