132703 2014-05-08 13:21:24 -0700 Web Inspector: Console error when launching Web Inspector "Mode htmlmixed failed to advance stream" 2014-05-08 14:08:29 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jonowells webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1007748 0 jonowells 2014-05-08 13:21:24 -0700 <rdar://problem/16743677> 1007751 1 jonowells 2014-05-08 13:22:28 -0700 Codemirror 4 made a slight change to how empty quote pairs are handled. CodeMirrorAdditions.js needs to be adjusted to handle this edge case. 1007756 2 231099 jonowells 2014-05-08 13:28:38 -0700 Created attachment 231099 [PATCH] Proposed Fix: Change to XML mode extension. 1007765 3 231099 commit-queue 2014-05-08 14:08:26 -0700 Comment on attachment 231099 [PATCH] Proposed Fix: Change to XML mode extension. Clearing flags on attachment: 231099 Committed r168494: <http://trac.webkit.org/changeset/168494> 1007766 4 commit-queue 2014-05-08 14:08:29 -0700 All reviewed patches have been landed. Closing bug. 231099 2014-05-08 13:28:38 -0700 2014-05-08 14:08:25 -0700 [PATCH] Proposed Fix: Change to XML mode extension. htmlmixed.diff text/plain 3719 jonowells ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA5YTI2ZDcuLjg2ZTBkZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA1LTA4ICBKb25vIFdlbGxzICA8 am9ub3dlbGxzQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb25zb2xlIGVy cm9yIHdoZW4gbGF1bmNoaW5nIFdlYiBJbnNwZWN0b3IgIk1vZGUgaHRtbG1peGVkIGZhaWxlZCB0 byBhZHZhbmNlIHN0cmVhbSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMjcwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBDb2RlTWlycm9yIDQgdXBkYXRlIGJyb3VnaHQgd2l0aCBpdCBhIGNoYW5n ZSBpbiB0aGUgWE1MIG1vZGUgdGhhdCAKKyAgICAgICAgY2F1c2VzIG91ciBYTUwgbW9kZSBleHRl bnNpb24gdG8gZmFpbCB0byBjb25zdW1lIGVtcHR5IHBhaXJlZCBxdW90ZXMKKyAgICAgICAgY29y cmVjdGx5LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yQWRkaXRp b25zLmpzOgorICAgICAgICBVcGRhdGVkIGV4dGVuZGVkWE1MVG9rZW4oKSB0byBwcm9wZXJseSBo YW5kbGUgZW1wdHkgcGFpcmVkIHF1b3Rlcy4KKworMjAxNC0wNS0wOCAgSm9ubyBXZWxscyAgPGpv bm93ZWxsc0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2VsZWN0aW5nIGZy YW1lIGluIGRlYnVnZ2VyIHNpZGViYXIgZG9lc24ndCByZXZlYWwgY29kZQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMTEyCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JBZGRp dGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2Rl TWlycm9yQWRkaXRpb25zLmpzCmluZGV4IGM4ZTRmOTAuLjcxNjcwZTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JBZGRpdGlv bnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29k ZU1pcnJvckFkZGl0aW9ucy5qcwpAQCAtODAsNyArODAsNiBAQAogICAgICAgICAvLyBSZW1lbWJl ciB0aGUgc3RhcnQgcG9zaXRpb24gc28gd2UgY2FuIHJld2luZCBpZiBuZWVkZWQuCiAgICAgICAg IHZhciBzdGFydFBvc2l0aW9uID0gc3RyZWFtLnBvczsKICAgICAgICAgdmFyIHN0eWxlID0gdGhp cy5fdG9rZW4oc3RyZWFtLCBzdGF0ZSk7Ci0KICAgICAgICAgaWYgKHN0eWxlID09PSAiYXR0cmli dXRlIikgewogICAgICAgICAgICAgLy8gTG9vayBmb3IgImhyZWYiIG9yICJzcmMiIGF0dHJpYnV0 ZXMuIElmIGZvdW5kIHRoZW4gd2Ugc2hvdWxkCiAgICAgICAgICAgICAvLyBleHBlY3QgYSBzdHJp bmcgbGF0ZXIgdGhhdCBzaG91bGQgZ2V0IHRoZSAibGluayIgc3R5bGUgaW5zdGVhZC4KQEAgLTkw LDIzICs4OSwzMCBAQAogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIGRlbGV0ZSBz dGF0ZS5fZXhwZWN0TGluazsKICAgICAgICAgfSBlbHNlIGlmIChzdGF0ZS5fZXhwZWN0TGluayAm JiBzdHlsZSA9PT0gInN0cmluZyIpIHsKLSAgICAgICAgICAgIGRlbGV0ZSBzdGF0ZS5fZXhwZWN0 TGluazsKKyAgICAgICAgICAgIHZhciBjdXJyZW50ID0gc3RyZWFtLmN1cnJlbnQoKTsKKworICAg ICAgICAgICAgLy8gVW5sZXNzIGN1cnJlbnQgdG9rZW4gaXMgZW1wdHkgcXVvdGVzLCBjb25zdW1l IHF1b3RlIGNoYXJhY3RlcgorICAgICAgICAgICAgLy8gYW5kIHRva2VuaXplIGxpbmsgbmV4dC4K KyAgICAgICAgICAgIGlmIChjdXJyZW50ICE9PSAiXCJcIiIgJiYgY3VycmVudCAhPT0gIicnIikg eworICAgICAgICAgICAgICAgIGRlbGV0ZSBzdGF0ZS5fZXhwZWN0TGluazsKIAotICAgICAgICAg ICAgLy8gVGhpcyBpcyBhIGxpbmssIHNvIHNldHVwIHRoZSBzdGF0ZSB0byBwcm9jZXNzIGl0IG5l eHQuCi0gICAgICAgICAgICBzdGF0ZS5fbGlua1Rva2VuaXplID0gdG9rZW5pemVMaW5rU3RyaW5n OwotICAgICAgICAgICAgc3RhdGUuX2xpbmtCYXNlU3R5bGUgPSBzdHlsZTsKKyAgICAgICAgICAg ICAgICAvLyBUaGlzIGlzIGEgbGluaywgc28gc2V0dXAgdGhlIHN0YXRlIHRvIHByb2Nlc3MgaXQg bmV4dC4KKyAgICAgICAgICAgICAgICBzdGF0ZS5fbGlua1Rva2VuaXplID0gdG9rZW5pemVMaW5r U3RyaW5nOworICAgICAgICAgICAgICAgIHN0YXRlLl9saW5rQmFzZVN0eWxlID0gc3R5bGU7CiAK LSAgICAgICAgICAgIC8vIFRoZSBhdHRyaWJ1dGUgbWF5IG9yIG1heSBub3QgYmUgcXVvdGVkLgot ICAgICAgICAgICAgdmFyIHF1b3RlID0gc3RyZWFtLmN1cnJlbnQoKVswXTsKLSAgICAgICAgICAg IHN0YXRlLl9saW5rUXVvdGVDaGFyYWN0ZXIgPSBxdW90ZSA9PT0gIiciIHx8IHF1b3RlID09PSAi XCIiID8gcXVvdGUgOiBudWxsOworICAgICAgICAgICAgICAgIC8vIFRoZSBhdHRyaWJ1dGUgbWF5 IG9yIG1heSBub3QgYmUgcXVvdGVkLgorICAgICAgICAgICAgICAgIHZhciBxdW90ZSA9IGN1cnJl bnRbMF07CiAKLSAgICAgICAgICAgIC8vIFJld2luZCB0aGUgc3RlYW0gdG8gdGhlIHN0YXJ0IG9m IHRoaXMgdG9rZW4uCi0gICAgICAgICAgICBzdHJlYW0ucG9zID0gc3RhcnRQb3NpdGlvbjsKKyAg ICAgICAgICAgICAgICBzdGF0ZS5fbGlua1F1b3RlQ2hhcmFjdGVyID0gcXVvdGUgPT09ICInIiB8 fCBxdW90ZSA9PT0gIlwiIiA/IHF1b3RlIDogbnVsbDsKIAotICAgICAgICAgICAgLy8gRWF0IHRo ZSBvcGVuIHF1b3RlIG9mIHRoZSBzdHJpbmcgc28gdGhlIHN0cmluZyBzdHlsZQotICAgICAgICAg ICAgLy8gd2lsbCBiZSB1c2VkIGZvciB0aGUgcXVvdGUgY2hhcmFjdGVyLgotICAgICAgICAgICAg aWYgKHN0YXRlLl9saW5rUXVvdGVDaGFyYWN0ZXIpCi0gICAgICAgICAgICAgICAgc3RyZWFtLmVh dChzdGF0ZS5fbGlua1F1b3RlQ2hhcmFjdGVyKTsKKyAgICAgICAgICAgICAgICAvLyBSZXdpbmQg dGhlIHN0ZWFtIHRvIHRoZSBzdGFydCBvZiB0aGlzIHRva2VuLgorICAgICAgICAgICAgICAgIHN0 cmVhbS5wb3MgPSBzdGFydFBvc2l0aW9uOworCisgICAgICAgICAgICAgICAgLy8gRWF0IHRoZSBv cGVuIHF1b3RlIG9mIHRoZSBzdHJpbmcgc28gdGhlIHN0cmluZyBzdHlsZQorICAgICAgICAgICAg ICAgIC8vIHdpbGwgYmUgdXNlZCBmb3IgdGhlIHF1b3RlIGNoYXJhY3Rlci4KKyAgICAgICAgICAg ICAgICBpZiAoc3RhdGUuX2xpbmtRdW90ZUNoYXJhY3RlcikKKyAgICAgICAgICAgICAgICAgICAg c3RyZWFtLmVhdChzdGF0ZS5fbGlua1F1b3RlQ2hhcmFjdGVyKTsKKyAgICAgICAgICAgIH0KICAg ICAgICAgfSBlbHNlIGlmIChzdHlsZSkgewogICAgICAgICAgICAgLy8gV2UgZG9uJ3QgZXhwZWN0 IG90aGVyIHRva2VucyBiZXR3ZWVuIGF0dHJpYnV0ZSBhbmQgc3RyaW5nIHNpbmNlCiAgICAgICAg ICAgICAvLyBzcGFjZXMgYW5kIHRoZSBlcXVhbCBjaGFyYWN0ZXIgYXJlIG5vdCB0b2tlbml6ZWQu IFNvIGlmIHdlIGdldAo=