132697 2014-05-08 11:57:43 -0700 Web Inspector: InspectorDOMAgent::getAccessibilityPropertiesForNode should gracefully handle bad node 2014-05-08 14:20:43 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts jcraig joepeck timothy webkit-bug-importer oldest_to_newest 1007700 0 joepeck 2014-05-08 11:57:43 -0700 Saw the following: ASSERTION FAILED: node Source/WebCore/inspector/InspectorDOMAgent.cpp(1435) : PassRefPtr<TypeBuilder::DOM::AccessibilityProperties> WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties(WebCore::Node *) 1 0x1030b4c00 WTFCrash 2 0x104f83a21 WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties(WebCore::Node*) 3 0x104f8399b WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode(WTF::String*, int, WTF::RefPtr<Inspector::TypeBuilder::DOM::AccessibilityProperties>&) 4 0x104f84cdd non-virtual thunk to WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode(WTF::String*, int, WTF::RefPtr<Inspector::TypeBuilder::DOM::AccessibilityProperties>&) 5 0x1050338e8 Inspector::InspectorDOMBackendDispatcher::getAccessibilityPropertiesForNode(long, Inspector::InspectorObject const&) 6 0x105030fb6 Inspector::InspectorDOMBackendDispatcher::dispatch(long, WTF::String const&, WTF::PassRefPtr<Inspector::InspectorObject>) 7 0x102ce205c Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) 8 0x104f44661 WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 9 0x105928a09 WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend(WTF::String const&) 10 0x102fff326 invocation function for block in Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend(NSString*) 11 0x103000624 Inspector::RemoteInspectorBlock::operator()() const 12 0x102fff895 Inspector::RemoteInspectorHandleRunSource(void*) 13 0x7fff910b34f1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 14 0x7fff910a4d4d __CFRunLoopDoSources0 15 0x7fff910a44eb __CFRunLoopRun 16 0x7fff910a3d88 CFRunLoopRunSpecific 17 0x7fff8ece8125 RunCurrentEventLoopInMode 18 0x7fff8ece7eae ReceiveNextEventCommon 19 0x7fff8ece7cee _BlockUntilNextEventMatchingListInModeWithFilter 20 0x7fff90257bc0 _DPSNextEvent 21 0x7fff902573c4 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 22 0x7fff9024b241 -[NSApplication run] 23 0x7fff90236cb7 NSApplicationMain 24 0x1000013b2 main 25 0x7fff923ad5c9 start 1007701 1 webkit-bug-importer 2014-05-08 11:58:22 -0700 <rdar://problem/16856404> 1007703 2 231087 joepeck 2014-05-08 12:00:42 -0700 Created attachment 231087 [PATCH] Proposed Fix In release builds buildObjectForAccessibilityProperties would return nullptr. In debug builds we would assert if we passed a null node to buildObjectForAccessibilityProperties. So more gracefully handle a null node before calling the function. 1007768 3 231087 commit-queue 2014-05-08 14:20:40 -0700 Comment on attachment 231087 [PATCH] Proposed Fix Clearing flags on attachment: 231087 Committed r168495: <http://trac.webkit.org/changeset/168495> 1007769 4 commit-queue 2014-05-08 14:20:43 -0700 All reviewed patches have been landed. Closing bug. 231087 2014-05-08 12:00:42 -0700 2014-05-08 14:20:40 -0700 [PATCH] Proposed Fix fix.patch text/plain 1419 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOGVlNzgwLi4xNGU3M2Q4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDUtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3JET01BZ2VudDo6Z2V0QWNjZXNzaWJpbGl0 eVByb3BlcnRpZXNGb3JOb2RlIHNob3VsZCBncmFjZWZ1bGx5IGhhbmRsZSBiYWQgbm9kZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNjk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv SW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdl bnQ6OmdldEFjY2Vzc2liaWxpdHlQcm9wZXJ0aWVzRm9yTm9kZSk6CisgICAgICAgIEdyYWNlZnVs bHkgaGFuZGxlIG5vIG5vZGUuCisKIDIwMTQtMDQtMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBbGxvdyBSZW1vdGUgSW5z cGVjdG9yIHRvIGVudGl0bGVtZW50IGNoZWNrIFVJUHJvY2VzcyB0aHJvdWdoIFdlYlByb2Nlc3MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4 IDVhMDcxNWYuLjY4MTFjMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckRPTUFnZW50LmNwcApAQCAtODc4LDYgKzg3OCw5IEBAIHZvaWQgSW5zcGVjdG9yRE9NQWdl bnQ6OmdldEV2ZW50TGlzdGVuZXJzKE5vZGUqIG5vZGUsIFZlY3RvcjxFdmVudExpc3RlbmVySW5m bz4mCiB2b2lkIEluc3BlY3RvckRPTUFnZW50OjpnZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zv ck5vZGUoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5nLCBpbnQgbm9kZUlkLCBSZWZQdHI8SW5zcGVj dG9yOjpUeXBlQnVpbGRlcjo6RE9NOjpBY2Nlc3NpYmlsaXR5UHJvcGVydGllcz4mIGF4UHJvcGVy dGllcykKIHsKICAgICBOb2RlKiBub2RlID0gYXNzZXJ0Tm9kZShlcnJvclN0cmluZywgbm9kZUlk KTsKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJldHVybjsKKwogICAgIGF4UHJvcGVydGllcyA9 IGJ1aWxkT2JqZWN0Rm9yQWNjZXNzaWJpbGl0eVByb3BlcnRpZXMobm9kZSk7CiB9CiAK