132696 2014-05-08 11:51:21 -0700 Cue display events may not be registered during page load 2014-05-08 12:04:09 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 1007698 0 bfulgham 2014-05-08 11:51:21 -0700 Because of the way 'cuechange' events are processed in the new Media Script controls code, it's possible to have a page where text tracks are added to the DOM before the handlers for add-and-remove tracks are ready. When this happens, the "cue change" events that WebKit relies on to generate the tracks for display do not get added, and captions do not get displayed. This patch changes WebKit so that we handle cue display events in the back end, which bypasses this potential start-up issue and ensure proper caption display. 1007699 1 bfulgham 2014-05-08 11:55:38 -0700 <rdar://problem/16652874> 1007702 2 231086 bfulgham 2014-05-08 12:00:22 -0700 Created attachment 231086 Patch 1007705 3 bfulgham 2014-05-08 12:04:09 -0700 Committed r168479: <http://trac.webkit.org/changeset/168479> 231086 2014-05-08 12:00:22 -0700 2014-05-08 12:03:19 -0700 Patch bug-132696-20140508120000.patch text/plain 3676 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODQ3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA1LTA4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEN1ZSBkaXNwbGF5IGV2ZW50 cyBtYXkgbm90IGJlIHJlZ2lzdGVyZWQgZHVyaW5nIHBhZ2UgbG9hZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjY5NgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTY2NTI4NzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpz OgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuaGFuZGxlVGV4dFRyYWNrQWRkKTogRG9u J3QgcmVnaXN0ZXIKKyAgICAgICAgZm9yICdjdWVjaGFuZ2UnIGV2ZW50cyBhbnltb3JlLgorICAg ICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuaGFuZGxlVGV4dFRyYWNrUmVtb3ZlKTogRGl0dG8u CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVDYXB0aW9uQ29udGFpbmVyKTog UmVkdWNlIENTUworICAgICAgICBjaHVybiBieSBub3QgYWRkaW5nL3JlbW92aW5nICdIaWRkZW4n IGNsYXNzIGV2ZXJ5IHRpbWUgYQorICAgICAgICBuZXcgY3VlIGlzIHByb2Nlc3NlZC4gT25seSBk byB0aGlzIHdoZW4gdHJhbnNpdGlvbmluZworICAgICAgICB0cmFjayBkaXNwbGF5IHN0YXRlLgor ICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuaGFuZGxlVGV4dFRyYWNrQ3VlQ2hhbmdlKTog RGVsZXRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlVGV4dFRyYWNrRGlzcGxheSk6IENhbGwK KyAgICAgICAgJ3VwZGF0ZVRleHRUcmFja0NvbnRhaW5lcicgZGlyZWN0b3J5IHdoZW4gcHJvY2Vz c2luZyBjdWVzLAorICAgICAgICByYXRoZXIgdGhhbiB0cmFtcG9saW5pbmcgdGhyb3VnaCB0aGUg SlMgbGF5ZXIuCisKIDIwMTQtMDUtMDggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgTWFrZSBCbG9iRGF0YUZpbGVSZWZlcmVuY2UgbWFuYWdlIGl0cyBzYW5k Ym94IGV4dGVuc2lvbgpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNBcHBsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCShyZXZpc2lvbiAxNjg0NDYp CisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw cGxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC01NzEsNyArNTcxLDYgQEAgQ29udHJvbGxlci5wcm90 b3R5cGUgPSB7CiAgICAgaGFuZGxlVGV4dFRyYWNrQWRkOiBmdW5jdGlvbihldmVudCkKICAgICB7 CiAgICAgICAgIHZhciB0cmFjayA9IGV2ZW50LnRyYWNrOwotICAgICAgICB0aGlzLmxpc3RlbkZv cih0cmFjaywgJ2N1ZWNoYW5nZScsIHRoaXMuaGFuZGxlVGV4dFRyYWNrQ3VlQ2hhbmdlKTsKIAog ICAgICAgICBpZiAodGhpcy50cmFja0hhc1RodW1ibmFpbHModHJhY2spICYmIHRyYWNrLm1vZGUg PT09ICdkaXNhYmxlZCcpCiAgICAgICAgICAgICB0cmFjay5tb2RlID0gJ2hpZGRlbic7CkBAIC01 ODMsMTggKzU4MiwxMSBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKIAogICAgIGhhbmRsZVRl eHRUcmFja1JlbW92ZTogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAgICB2YXIgdHJhY2sg PSBldmVudC50cmFjazsKLSAgICAgICAgdGhpcy5zdG9wTGlzdGVuaW5nRm9yKHRyYWNrLCAnY3Vl Y2hhbmdlJywgdGhpcy5oYW5kbGVUZXh0VHJhY2tDdWVDaGFuZ2UpOwogICAgICAgICB0aGlzLnVw ZGF0ZVRodW1ibmFpbCgpOwogICAgICAgICB0aGlzLnVwZGF0ZUNhcHRpb25CdXR0b24oKTsKICAg ICAgICAgdGhpcy51cGRhdGVDYXB0aW9uQ29udGFpbmVyKCk7CiAgICAgfSwKIAotICAgIGhhbmRs ZVRleHRUcmFja0N1ZUNoYW5nZTogZnVuY3Rpb24oZXZlbnQpCi0gICAgewotICAgICAgICB0aGlz LnVwZGF0ZUNhcHRpb25Db250YWluZXIoKTsKLSAgICB9LAotCiAgICAgaXNGdWxsU2NyZWVuOiBm dW5jdGlvbigpCiAgICAgewogICAgICAgICByZXR1cm4gZG9jdW1lbnQud2Via2l0Q3VycmVudEZ1 bGxTY3JlZW5FbGVtZW50ID09PSB0aGlzLnZpZGVvOwpAQCAtMTA0OSw5ICsxMDQxLDEyIEBAIENv bnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICBpZiAoIXRoaXMuaG9zdC50ZXh0VHJhY2tD b250YWluZXIpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKHRoaXMudmlkZW8u d2Via2l0SGFzQ2xvc2VkQ2FwdGlvbnMpCisgICAgICAgIHZhciBoYXNDbG9zZWRDYXB0aW9ucyA9 IHRoaXMudmlkZW8ud2Via2l0SGFzQ2xvc2VkQ2FwdGlvbnM7CisgICAgICAgIHZhciBoYXNIaWRk ZW5DbGFzcyA9IHRoaXMuaG9zdC50ZXh0VHJhY2tDb250YWluZXIuY2xhc3NMaXN0LmNvbnRhaW5z KHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4pOworCisgICAgICAgIGlmIChoYXNDbG9zZWRDYXB0aW9u cyAmJiBoYXNIaWRkZW5DbGFzcykKICAgICAgICAgICAgIHRoaXMuaG9zdC50ZXh0VHJhY2tDb250 YWluZXIuY2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFtZXMuaGlkZGVuKTsKLSAgICAgICAg ZWxzZQorICAgICAgICBlbHNlIGlmICghaGFzQ2xvc2VkQ2FwdGlvbnMgJiYgIWhhc0hpZGRlbkNs YXNzKQogICAgICAgICAgICAgdGhpcy5ob3N0LnRleHRUcmFja0NvbnRhaW5lci5jbGFzc0xpc3Qu YWRkKHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4pOwogCiAgICAgICAgIHRoaXMudXBkYXRlQmFzZSgp OwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lv biAxNjg0NDYpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00OTM5LDYgKzQ5MzksOCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OnVwZGF0ZVRleHRUcmFja0RpCiB7CiAjaWYgRU5BQkxFKE1FRElBX0NPTlRST0xTX1NDUklQVCkK ICAgICBlbnN1cmVVc2VyQWdlbnRTaGFkb3dSb290KCk7CisgICAgQVNTRVJUKG1fbWVkaWFDb250 cm9sc0hvc3QpOworICAgIG1fbWVkaWFDb250cm9sc0hvc3QtPnVwZGF0ZVRleHRUcmFja0NvbnRh aW5lcigpOwogICAgIHJldHVybjsKICNlbmRpZgogICAgIGlmICghaGFzTWVkaWFDb250cm9scygp ICYmICFjcmVhdGVNZWRpYUNvbnRyb2xzKCkpCg==