132694 2014-05-08 11:26:28 -0700 Wrap a new class definition with __has_include() 2014-05-08 12:16:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson thorton oldest_to_newest 1007686 0 beidson 2014-05-08 11:26:28 -0700 Wrap a new class definition with __has_include(), as the include might be on some systems. <rdar://problem/16852395> 1007687 1 231082 beidson 2014-05-08 11:29:02 -0700 Created attachment 231082 Patch v1 1007689 2 231082 thorton 2014-05-08 11:30:08 -0700 Comment on attachment 231082 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231082&action=review > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:58 > // FIXME: We should properly disable code that interacts with NSItemProvider/NSSharingServicePicker in 32-bit. we may have done this? 1007691 3 beidson 2014-05-08 11:34:26 -0700 (In reply to comment #2) > (From update of attachment 231082 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231082&action=review > > > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:58 > > // FIXME: We should properly disable code that interacts with NSItemProvider/NSSharingServicePicker in 32-bit. > > we may have done this? We disabled some code. I haven't looked to make sure we did it "properly" 1007713 4 beidson 2014-05-08 12:16:19 -0700 http://trac.webkit.org/changeset/168482 231082 2014-05-08 11:29:02 -0700 2014-05-08 11:30:08 -0700 Patch v1 patch text/plain 1685 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCAxOGNkMmRkLi41ZWVhNzZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTQtMDUtMDggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFdyYXAgYSBuZXcgY2xhc3MgZGVmaW5pdGlvbiB3aXRoIF9faGFzX2lu Y2x1ZGUoKQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY4NTIzOTU+IGFuZCBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNjk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaXNjL1dlYlNoYXJpbmdTZXJ2aWNlUGlj a2VyQ29udHJvbGxlci5tbToKKwogMjAxNC0wNS0wNyAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5r aUBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIHN5c3RlbSBkZWZhdWx0cyBmb3IgaGFyZHdhcmUg anBlZyBkZWNvZGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJTaGFy aW5nU2VydmljZVBpY2tlckNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dl YlNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlci5tbQppbmRleCAzNDE1NWM0Li4xMjZmYWI2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYlNoYXJpbmdTZXJ2aWNlUGlj a2VyQ29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYlNoYXJpbmdT ZXJ2aWNlUGlja2VyQ29udHJvbGxlci5tbQpAQCAtNTIsMTMgKzUyLDE2IEBAIC0gKE5TTWVudSAq KW1lbnU7CiBAZW5kCiAjZW5kaWYKIAotLy8gRklYTUU6IFdlIHNob3VsZCBpbXBvcnQgdGhlIHBy aXZhdGUgaGVhZGVyIGlmIHdlIGhhdmUgaXQuCisjaWYgX19oYXNfaW5jbHVkZSg8QXBwS2l0L05T SXRlbVByb3ZpZGVyLmg+KQorI2ltcG9ydCA8QXBwS2l0L05TSXRlbVByb3ZpZGVyLmg+CisjZWxz ZQogLy8gRklYTUU6IFdlIHNob3VsZCBwcm9wZXJseSBkaXNhYmxlIGNvZGUgdGhhdCBpbnRlcmFj dHMgd2l0aCBOU0l0ZW1Qcm92aWRlci9OU1NoYXJpbmdTZXJ2aWNlUGlja2VyIGluIDMyLWJpdC4K IEBpbnRlcmZhY2UgTlNJdGVtUHJvdmlkZXIgOiBOU09iamVjdAogQHByb3BlcnR5IChjb3B5LCBy ZWFkb25seSkgTlNBcnJheSAqcmVnaXN0ZXJlZFR5cGVJZGVudGlmaWVyczsKIC0gKGluc3RhbmNl dHlwZSlpbml0V2l0aEl0ZW06KGlkIDxOU1NlY3VyZUNvZGluZz4paXRlbSB0eXBlSWRlbnRpZmll cjooTlNTdHJpbmcgKil0eXBlSWRlbnRpZmllcjsKIC0gKHZvaWQpbG9hZEl0ZW1Gb3JUeXBlSWRl bnRpZmllcjooTlNTdHJpbmcgKil0eXBlSWRlbnRpZmllciBvcHRpb25zOihOU0RpY3Rpb25hcnkg KilvcHRpb25zIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShpZCA8TlNTZWN1cmVDb2Rpbmc+ IGl0ZW0sIE5TRXJyb3IgKmVycm9yKSljb21wbGV0aW9uSGFuZGxlcjsKIEBlbmQKKyNlbmRpZgog CiBzdGF0aWMgTlNTdHJpbmcgKnNlcnZpY2VDb250cm9sc1Bhc3RlYm9hcmROYW1lID0gQCJXZWJL aXRTZXJ2aWNlQ29udHJvbHNQYXN0ZWJvYXJkIjsKIAo=