132685 2014-05-08 09:11:40 -0700 REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary 2014-05-10 00:17:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 132686 1 cgarcia webkit-unassigned bunhere commit-queue gustavo gyuyoung.kim mrobinson pnormand rakuco sergio oldest_to_newest 1007637 0 cgarcia 2014-05-08 09:11:40 -0700 We used to build all WebKit2 C API tests into a single binary TestWebKit2 to reduce the build time. We also adapted the run-gtk-tests script to run the tests individually to apply the timous for every test, so I think it's worth bringin back the single binary. 1007710 1 mrobinson 2014-05-08 12:11:01 -0700 It's kind of nice that we can share the build instructions with other ports, so we should weigh the options carefully. 1007910 2 cgarcia 2014-05-08 23:58:08 -0700 (In reply to comment #1) > It's kind of nice that we can share the build instructions with other ports, so we should weigh the options carefully. But we are building the WTF tests as a single binary, I don't understand why this inconsistency. I'm not sure what we are sharing for the WebKit2 test, because we have a list of binaries in our PlatformGTK file. 1007948 3 231144 cgarcia 2014-05-09 05:08:04 -0700 Created attachment 231144 Patch This would also fix bug #132684, since the single binary is TestWebKit2 1008004 4 231144 mrobinson 2014-05-09 09:31:37 -0700 Comment on attachment 231144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review > Tools/TestWebKitAPI/PlatformGTK.cmake:107 > +add_test(TestWebKit2 ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2) > +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60) > +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2) We don't actually need these lines since we don't use the CMake's 'make test.' 1008225 5 cgarcia 2014-05-09 23:40:06 -0700 (In reply to comment #4) > (From update of attachment 231144 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231144&action=review > > > Tools/TestWebKitAPI/PlatformGTK.cmake:107 > > +add_test(TestWebKit2 ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2/TestWebKit2) > > +set_tests_properties(TestWebKit2 PROPERTIES TIMEOUT 60) > > +set_target_properties(TestWebKit2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit2) > > We don't actually need these lines since we don't use the CMake's 'make test.' I copy pasted like a monkey :-P I guess it doesn't hurt in any case and it's consistent with the other tests 1008232 6 cgarcia 2014-05-10 00:17:35 -0700 Committed r168574: <http://trac.webkit.org/changeset/168574> 231144 2014-05-09 05:08:04 -0700 2014-05-09 09:31:37 -0700 Patch wk2-c-api-tests.diff text/plain 6139 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNjQy ODQ5Li5jNjBkMjFmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTQtMDUtMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04oQ01BS0UpOiBbR1RL XSBXZWJLaXQyIEMgQVBJIHRlc3RzIGFyZSBub3QgbG9uZ2VyIGJ1aWx0IGluIHRoZSBzYW1lIGJp bmFyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMy Njg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IGEgc2luZ2xlIFRlc3RXZWJLaXQyIGJpbmFyeSBmb3IgYWxsIFdlYktpdDIgQyBBUEkgdGVzdHMu CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlOgorCisyMDE0LTA1 LTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAg ICBSRUdSRVNTSU9OKENNQUtFKTogW0dUS10gcnVuLWd0ay10ZXN0cyBkb2Vzbid0IHNldCB0aGUg cmlnaHQgaW5qZWN0ZWQgYnVuZGxlIHBhdGgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMjczNgogCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1BsYXRmb3JtR1RLLmNtYWtlIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUdUSy5j bWFrZQppbmRleCAxOTBiMWZlLi45MzhlYTlmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1H VEsuY21ha2UKQEAgLTMyLDcgKzMyLDYgQEAgc2V0KGJ1bmRsZV9oYXJuZXNzX1NPVVJDRVMKIHNl dCh3ZWJraXQyX2FwaV9oYXJuZXNzX1NPVVJDRVMKICAgICAke1RFU1RXRUJLSVRBUElfRElSfS9n dGsvUGxhdGZvcm1VdGlsaXRpZXNHdGsuY3BwCiAgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vZ3Rr L1BsYXRmb3JtV2ViVmlld0d0ay5jcHAKLSAgICAke1RFU1RXRUJLSVRBUElfRElSfS9ndGsvUGxh dGZvcm1XZWJWaWV3R3RrLmNwcAogKQogCiBsaXN0KEFQUEVORCB0ZXN0X3d0Zl9MSUJSQVJJRVMK QEAgLTU2LDYgKzU1LDU3IEBAIGxpc3QoQVBQRU5EIFRlc3RXZWJLaXRBUElfTElCUkFSSUVTCiAg ICAgJHtHVEszX0xJQlJBUklFU30KICkKIAorYWRkX2V4ZWN1dGFibGUoVGVzdFdlYktpdDIKKyAg ICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0Fib3V0QmxhbmtMb2FkLmNwcAor ICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIvQ2FuSGFuZGxlUmVxdWVzdC5j cHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0Nvb2tpZU1hbmFnZXIu Y3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9Eb2N1bWVudFN0YXJ0 VXNlclNjcmlwdEFsZXJ0Q3Jhc2guY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMv V2ViS2l0Mi9ET01XaW5kb3dFeHRlbnNpb25CYXNpYy5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElf RElSfS9UZXN0cy9XZWJLaXQyL0RPTVdpbmRvd0V4dGVuc2lvbk5vQ2FjaGUuY3BwCisgICAgJHtU RVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9Eb3dubG9hZERlY2lkZURlc3RpbmF0aW9u Q3Jhc2guY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9FdmFsdWF0 ZUphdmFTY3JpcHQuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9G YWlsZWRMb2FkLmNwcAorICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIvRmlu ZC5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0ZvcmNlUmVwYWlu dC5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0ZyYW1lTUlNRVR5 cGVIVE1MLmNwcAorICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIvRnJhbWVN SU1FVHlwZVBORy5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0dl b2xvY2F0aW9uLmNwcAorICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIvR2V0 SW5qZWN0ZWRCdW5kbGVJbml0aWFsaXphdGlvblVzZXJEYXRhQ2FsbGJhY2suY3BwCisgICAgJHtU RVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9IaXRUZXN0UmVzdWx0Tm9kZUhhbmRsZS5j cHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0luamVjdGVkQnVuZGxl QmFzaWMuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9JbmplY3Rl ZEJ1bmRsZUZyYW1lSGl0VGVzdC5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9X ZWJLaXQyL0luamVjdGVkQnVuZGxlSW5pdGlhbGl6YXRpb25Vc2VyRGF0YUNhbGxiYWNrV2lucy5j cHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0xvYWRBbHRlcm5hdGVI VE1MU3RyaW5nV2l0aE5vbkRpcmVjdG9yeVVSTC5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElS fS9UZXN0cy9XZWJLaXQyL0xvYWRDYW5jZWxlZE5vU2VydmVyUmVkaXJlY3RDYWxsYmFjay5jcHAK KyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL0xvYWRQYWdlT25DcmFzaC5j cHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL01vdXNlTW92ZUFmdGVy Q3Jhc2guY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9OZXdGaXJz dFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVz dHMvV2ViS2l0Mi9OZXdGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRGYWlscy5jcHAKKyAgICAk e1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL05ld0ZpcnN0VmlzdWFsbHlOb25FbXB0 eUxheW91dEZvckltYWdlcy5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJL aXQyL05ld0ZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZyYW1lcy5jcHAKKyAgICAke1RFU1RX RUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL1BhZ2VMb2FkQmFzaWMuY3BwCisgICAgJHtURVNU V0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9QYWdlTG9hZERpZENoYW5nZUxvY2F0aW9uV2l0 aGluUGFnZUZvckZyYW1lLmNwcAorICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktp dDIvUGFyZW50RnJhbWUuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0 Mi9QcmV2ZW50RW1wdHlVc2VyQWdlbnQuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVz dHMvV2ViS2l0Mi9Qcml2YXRlQnJvd3NpbmdQdXNoU3RhdGVOb0hpc3RvcnlDYWxsYmFjay5jcHAK KyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL1JlbG9hZFBhZ2VBZnRlckNy YXNoLmNwcAorICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIvUmVzaXplV2lu ZG93QWZ0ZXJDcmFzaC5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQy L1Jlc3RvcmVTZXNzaW9uU3RhdGVDb250YWluaW5nRm9ybURhdGEuY3BwCisgICAgJHtURVNUV0VC S0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi9TaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbS5j cHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL1VzZXJNZXNzYWdlLmNw cAorICAgICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIvV2lsbFNlbmRTdWJtaXRF dmVudC5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyL1dLUGFnZUdl dFNjYWxlRmFjdG9yTm90WmVyby5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9X ZWJLaXQyL1dLUHJlZmVyZW5jZXMuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMv V2ViS2l0Mi9XS1N0cmluZy5jcHAKKyAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJL aXQyL1dLU3RyaW5nSlNTdHJpbmcuY3BwCisgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMv V2ViS2l0Mi9XS1VSTC5jcHAKKykKKwordGFyZ2V0X2xpbmtfbGlicmFyaWVzKFRlc3RXZWJLaXQy ICR7dGVzdF93ZWJraXQyX2FwaV9MSUJSQVJJRVN9KQorYWRkX3Rlc3QoVGVzdFdlYktpdDIgJHtU RVNUV0VCS0lUQVBJX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWX0vV2ViS2l0Mi9UZXN0V2ViS2l0 MikKK3NldF90ZXN0c19wcm9wZXJ0aWVzKFRlc3RXZWJLaXQyIFBST1BFUlRJRVMgVElNRU9VVCA2 MCkKK3NldF90YXJnZXRfcHJvcGVydGllcyhUZXN0V2ViS2l0MiBQUk9QRVJUSUVTIFJVTlRJTUVf T1VUUFVUX0RJUkVDVE9SWSAke1RFU1RXRUJLSVRBUElfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZ fS9XZWJLaXQyKQorCiAjIFRoZSBsaXN0IGJlbG93IHdvcmtzIGxpa2UgYSB0ZXN0IGV4cGVjdGF0 aW9uLiBUZXN0cyBpbiB0aGUKICMgdGVzdF97d2Via2l0Ml9hcGl8d2ViY29yZX1fQklOQVJJRVMg bGlzdCBhcmUgYWRkZWQgdG8gdGhlIHRlc3QgcnVubmVyIGFuZAogIyB0cmllZCBvbiB0aGUgYm90 cyBvbiBldmVyeSBidWlsZC4gVGVzdHMgaW4gdGVzdF97d2Via2l0Ml9hcGl8d2ViY29yZX1fQklO QVJJRVMKQEAgLTY5LDQ4ICsxMTksMyBAQCBzZXQodGVzdF93ZWJjb3JlX0JJTkFSSUVTCiAgICAg VVJMCiApCiAKLXNldCh0ZXN0X3dlYmtpdDJfYXBpX0JJTkFSSUVTCi0gICAgQWJvdXRCbGFua0xv YWQKLSAgICBDYW5IYW5kbGVSZXF1ZXN0Ci0gICAgQ29va2llTWFuYWdlcgotICAgIERvY3VtZW50 U3RhcnRVc2VyU2NyaXB0QWxlcnRDcmFzaAotICAgIERPTVdpbmRvd0V4dGVuc2lvbkJhc2ljCi0g ICAgRE9NV2luZG93RXh0ZW5zaW9uTm9DYWNoZQotICAgIERvd25sb2FkRGVjaWRlRGVzdGluYXRp b25DcmFzaAotICAgIEV2YWx1YXRlSmF2YVNjcmlwdAotICAgIEZhaWxlZExvYWQKLSAgICBGaW5k Ci0gICAgRm9yY2VSZXBhaW50Ci0gICAgRnJhbWVNSU1FVHlwZUhUTUwKLSAgICBGcmFtZU1JTUVU eXBlUE5HCi0gICAgR2VvbG9jYXRpb24KLSAgICBHZXRJbmplY3RlZEJ1bmRsZUluaXRpYWxpemF0 aW9uVXNlckRhdGFDYWxsYmFjawotICAgIEhpdFRlc3RSZXN1bHROb2RlSGFuZGxlCi0gICAgSW5q ZWN0ZWRCdW5kbGVCYXNpYwotICAgIEluamVjdGVkQnVuZGxlRnJhbWVIaXRUZXN0Ci0gICAgSW5q ZWN0ZWRCdW5kbGVJbml0aWFsaXphdGlvblVzZXJEYXRhQ2FsbGJhY2tXaW5zCi0gICAgTG9hZEFs dGVybmF0ZUhUTUxTdHJpbmdXaXRoTm9uRGlyZWN0b3J5VVJMCi0gICAgTG9hZENhbmNlbGVkTm9T ZXJ2ZXJSZWRpcmVjdENhbGxiYWNrCi0gICAgTG9hZFBhZ2VPbkNyYXNoCi0gICAgTW91c2VNb3Zl QWZ0ZXJDcmFzaAotICAgIE5ld0ZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dAotICAgIE5ld0Zp cnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZhaWxzCi0gICAgTmV3Rmlyc3RWaXN1YWxseU5vbkVt cHR5TGF5b3V0Rm9ySW1hZ2VzCi0gICAgTmV3Rmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0RnJh bWVzCi0gICAgUGFnZUxvYWRCYXNpYwotICAgIFBhZ2VMb2FkRGlkQ2hhbmdlTG9jYXRpb25XaXRo aW5QYWdlRm9yRnJhbWUKLSAgICBQYXJlbnRGcmFtZQotICAgIFByZXZlbnRFbXB0eVVzZXJBZ2Vu dAotICAgIFByaXZhdGVCcm93c2luZ1B1c2hTdGF0ZU5vSGlzdG9yeUNhbGxiYWNrCi0gICAgUmVs b2FkUGFnZUFmdGVyQ3Jhc2gKLSAgICBSZXNpemVXaW5kb3dBZnRlckNyYXNoCi0gICAgUmVzdG9y ZVNlc3Npb25TdGF0ZUNvbnRhaW5pbmdGb3JtRGF0YQotICAgIFNob3VsZEdvVG9CYWNrRm9yd2Fy ZExpc3RJdGVtCi0gICAgVXNlck1lc3NhZ2UKLSAgICBXaWxsU2VuZFN1Ym1pdEV2ZW50Ci0gICAg V0tQYWdlR2V0U2NhbGVGYWN0b3JOb3RaZXJvCi0gICAgV0tQcmVmZXJlbmNlcwotICAgIFdLU3Ry aW5nCi0gICAgV0tTdHJpbmdKU1N0cmluZwotICAgIFdLVVJMCi0pCg==