132663 2014-05-07 14:06:30 -0700 Image menu is offset by the amount the view is scrolled 2014-05-07 14:18:59 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson bdakin oldest_to_newest 1007432 0 beidson 2014-05-07 14:06:30 -0700 Image menu is offset by the amount the view is scrolled <rdar://problem/16818966> 1007433 1 231021 beidson 2014-05-07 14:08:07 -0700 Created attachment 231021 Patch v1 1007434 2 231021 thorton 2014-05-07 14:09:50 -0700 Comment on attachment 231021 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231021&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:433 > IntPoint point = frameView->contentsToRootView(page->contextMenuController().hitTestResult().roundedPointInInnerNodeFrame()); > + point.moveBy(frameView->scrollPosition()); I think you want contentsToWindow instead of contentsToRootView, right? And then you won't need to remove the scrollPosition yourself. 1007437 3 beidson 2014-05-07 14:18:59 -0700 http://trac.webkit.org/changeset/168438 231021 2014-05-07 14:08:07 -0700 2014-05-07 14:09:49 -0700 Patch v1 patch text/plain 1545 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCA2MjE4MjU2Li45NDM1NjgxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTQtMDUtMDcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIEltYWdlIG1lbnUgaXMgb2Zmc2V0IGJ5IHRoZSBhbW91bnQgdGhlIHZp ZXcgaXMgc2Nyb2xsZWQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2ODE4OTY2PiBhbmQgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjY2MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2Vi Q29udGV4dE1lbnVDbGllbnQubW06CisgICAgICAgIChXZWJDb250ZXh0TWVudUNsaWVudDo6c2hv d0NvbnRleHRNZW51KTogQWRqdXN0IHRoZSBwb2ludCBieSB0aGUgc2Nyb2xsIHBvc2l0aW9uLgor CiAyMDE0LTA1LTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYktpdDEgaXMgZmxhc2h5IHdoZW4gY29tcG9zaXRpbmcgbGF5ZXJzIGNvbWUgYW5k IGdvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250 ZXh0TWVudUNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNv bnRleHRNZW51Q2xpZW50Lm1tCmluZGV4IGRhNzRmNWEuLmFkMGFiY2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50 Lm1tCkBAIC00MzAsNiArNDMwLDcgQEAgdm9pZCBXZWJDb250ZXh0TWVudUNsaWVudDo6c2hvd0Nv bnRleHRNZW51KCkKIAogICAgIE5TVmlldyogdmlldyA9IGZyYW1lVmlldy0+ZG9jdW1lbnRWaWV3 KCk7CiAgICAgSW50UG9pbnQgcG9pbnQgPSBmcmFtZVZpZXctPmNvbnRlbnRzVG9Sb290Vmlldyhw YWdlLT5jb250ZXh0TWVudUNvbnRyb2xsZXIoKS5oaXRUZXN0UmVzdWx0KCkucm91bmRlZFBvaW50 SW5Jbm5lck5vZGVGcmFtZSgpKTsKKyAgICBwb2ludC5tb3ZlQnkoZnJhbWVWaWV3LT5zY3JvbGxQ b3NpdGlvbigpKTsKICAgICBOU1BvaW50IG5zU2NyZWVuUG9pbnQgPSBbdmlldyBjb252ZXJ0UG9p bnQ6cG9pbnQgdG9WaWV3Om5pbF07CiAgICAgTlNFdmVudCogZXZlbnQgPSBbTlNFdmVudCBtb3Vz ZUV2ZW50V2l0aFR5cGU6TlNSaWdodE1vdXNlRG93biBsb2NhdGlvbjpuc1NjcmVlblBvaW50IG1v ZGlmaWVyRmxhZ3M6MCB0aW1lc3RhbXA6MCB3aW5kb3dOdW1iZXI6W1t2aWV3IHdpbmRvd10gd2lu ZG93TnVtYmVyXSBjb250ZXh0OjAgZXZlbnROdW1iZXI6MCBjbGlja0NvdW50OjEgcHJlc3N1cmU6 MV07CiAK