132646 2014-05-07 04:32:14 -0700 [EFL][WK1] Enable region based columns 2014-05-12 07:31:24 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 k.wolanski webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1007292 0 k.wolanski 2014-05-07 04:32:14 -0700 Enable new multi-column mode as it was enabled in WK2 (r168046). 1007293 1 230989 k.wolanski 2014-05-07 04:33:35 -0700 Created attachment 230989 proposed patch 1007909 2 230989 gyuyoung.kim 2014-05-08 23:47:21 -0700 Comment on attachment 230989 proposed patch Is there any regression on layout test when enabling it ? 1008499 3 k.wolanski 2014-05-12 00:48:32 -0700 Now there is regression on efl-wk1, after enabling it tests from https://bugs.webkit.org/show_bug.cgi?id=132679 will pass. 1008556 4 230989 gyuyoung.kim 2014-05-12 06:14:47 -0700 Comment on attachment 230989 proposed patch r=me based on rebaseline by r168470. 1008589 5 230989 commit-queue 2014-05-12 07:31:20 -0700 Comment on attachment 230989 proposed patch Clearing flags on attachment: 230989 Committed r168620: <http://trac.webkit.org/changeset/168620> 1008590 6 commit-queue 2014-05-12 07:31:24 -0700 All reviewed patches have been landed. Closing bug. 230989 2014-05-07 04:33:35 -0700 2014-05-12 07:31:19 -0700 proposed patch TurnOnRegionBasedColumnsEnabled.patch text/plain 1338 k.wolanski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmNTI0OTcyLi5hOTc3YWFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTQtMDUtMDcgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5z a2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0sxXSBFbmFibGUgcmVnaW9uIGJhc2Vk IGNvbHVtbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMjY0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEVuYWJsZSBuZXcgbXVsdGktY29sdW1uIG1vZGUgYXMgaXQgd2FzIGVuYWJsZWQgaW4gV0syIChy MTY4MDQ2KS4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChfZXdrX3Zp ZXdfcHJpdl9uZXcpOgorCiAyMDE0LTA1LTA3ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVn b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIFJlbW92ZSBydW50aW1l IGZlYXR1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IGJlYTU2YTEuLjc1ZmY4 ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtNjc2LDYgKzY3Niw3IEBAIHN0 YXRpYyBFd2tfVmlld19Qcml2YXRlX0RhdGEqIF9ld2tfdmlld19wcml2X25ldyhFd2tfVmlld19T bWFydF9EYXRhKiBzbWFydERhdGEpCiAgICAgYm9vbCBzaG93RGVidWdWaXN1YWxzID0gZGVidWdW aXN1YWxzRW52aXJvbm1lbnQgJiYgIXN0cmNtcChkZWJ1Z1Zpc3VhbHNFbnZpcm9ubWVudCwgIjEi KTsKICAgICBwYWdlU2V0dGluZ3Muc2V0U2hvd0RlYnVnQm9yZGVycyhzaG93RGVidWdWaXN1YWxz KTsKICAgICBwYWdlU2V0dGluZ3Muc2V0U2hvd1JlcGFpbnRDb3VudGVyKHNob3dEZWJ1Z1Zpc3Vh bHMpOworICAgIHBhZ2VTZXR0aW5ncy5zZXRSZWdpb25CYXNlZENvbHVtbnNFbmFibGVkKHRydWUp OwogCiAgICAgdXJsID0gcGFnZVNldHRpbmdzLnVzZXJTdHlsZVNoZWV0TG9jYXRpb24oKTsKICAg ICBwcml2LT5zZXR0aW5ncy51c2VyU3R5bGVzaGVldCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKHVy bC5zdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsK