132616 2014-05-06 10:42:48 -0700 ChildNodesLazySnapshot::m_childNodes needs two heap allocations. 2014-05-06 15:14:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc kangil.han kling oldest_to_newest 1007002 0 kling 2014-05-06 10:42:48 -0700 ChildNodesLazySnapshot::m_childNodes needs two heap allocations. 1007003 1 230918 kling 2014-05-06 10:43:17 -0700 Created attachment 230918 Patch 1007004 2 230918 ggaren 2014-05-06 10:46:48 -0700 Comment on attachment 230918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230918&action=review r=me > Source/WebCore/dom/ContainerNode.h:310 > + Vector<RefPtr<Node>> m_childNodes; // Lazily instantiated. I would call this "m_snapshot" -- or call the bool above "m_hasChildNodes". We want the flag to share a name with what it flags. Otherwise, the pickles will not fly over the relish. 1007101 3 kling 2014-05-06 15:14:15 -0700 Committed r168383: <http://trac.webkit.org/changeset/168383> 230918 2014-05-06 10:43:17 -0700 2014-05-06 10:46:48 -0700 Patch bug-132616.diff text/plain 2882 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YWY0Y2ZjLi45NDBhODA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTQtMDUtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIENoaWxkTm9kZXNMYXp5U25hcHNob3Q6Om1fY2hpbGROb2RlcyBuZWVkcyB0d28gaGVhcCBh bGxvY2F0aW9ucy4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzMjYxNj4KKworICAg ICAgICBUaGlzIHNlZW1zIGEgYml0IHNpbGx5LCBzaW5jZSBDaGlsZE5vZGVzTGF6eVNuYXBzaG90 IGlzIGFsd2F5cworICAgICAgICBhbGxvY2F0ZWQgb24gdGhlIHN0YWNrLgorCisgICAgICAgIENo YW5nZSBpdCB0byBiZSBhIGJvb2wgKyBhIFZlY3RvciBpbnN0ZWFkIG9mIHVzaW5nIHRoZSBudWxs aXR5CisgICAgICAgIGFzIGEgcHJlc2VuY2UgaW5kaWNhdG9yLiBUaGlzIHdheSB3ZSBhbHNvIGRv bid0IGVuZCB1cCB3aXRoIGFuCisgICAgICAgIG91dC1vZi1saW5lIH5Pd25QdHIgZm9yIHRoZSBW ZWN0b3IuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBkb20vQ29udGFpbmVyTm9kZS5oOgorICAgICAgICAoV2ViQ29yZTo6Q2hpbGROb2Rlc0xhenlT bmFwc2hvdDo6Q2hpbGROb2Rlc0xhenlTbmFwc2hvdCk6CisgICAgICAgIChXZWJDb3JlOjpDaGls ZE5vZGVzTGF6eVNuYXBzaG90OjpuZXh0Tm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpDaGlsZE5v ZGVzTGF6eVNuYXBzaG90Ojp0YWtlU25hcHNob3QpOgorICAgICAgICAoV2ViQ29yZTo6Q2hpbGRO b2Rlc0xhenlTbmFwc2hvdDo6aGFzU25hcHNob3QpOgorCiAyMDE0LTA1LTA1ICBSeXVhbiBDaG9p ICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBSRUdSRVNTSU9OKDE2 NzE0NSk6IEphdmFTY3JpcHQgbWVkaWEgY29udHJvbHMgYXJlIGJyb2tlbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9D b250YWluZXJOb2RlLmgKaW5kZXggNzUwODA5MS4uNjk1ZGM2OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29u dGFpbmVyTm9kZS5oCkBAIC0yNTIsNiArMjUyLDcgQEAgcHVibGljOgogICAgIGV4cGxpY2l0IENo aWxkTm9kZXNMYXp5U25hcHNob3QoTm9kZSYgcGFyZW50Tm9kZSkKICAgICAgICAgOiBtX2N1cnJl bnROb2RlKHBhcmVudE5vZGUuZmlyc3RDaGlsZCgpKQogICAgICAgICAsIG1fY3VycmVudEluZGV4 KDApCisgICAgICAgICwgbV9oYXNTbmFwc2hvdChmYWxzZSkKICAgICB7CiAgICAgICAgIG1fbmV4 dFNuYXBzaG90ID0gbGF0ZXN0U25hcHNob3Q7CiAgICAgICAgIGxhdGVzdFNuYXBzaG90ID0gdGhp czsKQEAgLTI3MSwyNiArMjcyLDI1IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICBtX2N1cnJl bnROb2RlID0gbm9kZS0+bmV4dFNpYmxpbmcoKTsKICAgICAgICAgICAgIHJldHVybiBub2RlLnJl bGVhc2UoKTsKICAgICAgICAgfQotICAgICAgICBWZWN0b3I8UmVmUHRyPE5vZGU+PiYgbm9kZVZl Y3RvciA9ICptX2NoaWxkTm9kZXM7Ci0gICAgICAgIGlmIChtX2N1cnJlbnRJbmRleCA+PSBub2Rl VmVjdG9yLnNpemUoKSkKKyAgICAgICAgaWYgKG1fY3VycmVudEluZGV4ID49IG1fY2hpbGROb2Rl cy5zaXplKCkpCiAgICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgcmV0dXJuIG5vZGVWZWN0 b3JbbV9jdXJyZW50SW5kZXgrK107CisgICAgICAgIHJldHVybiBtX2NoaWxkTm9kZXNbbV9jdXJy ZW50SW5kZXgrK107CiAgICAgfQogCiAgICAgdm9pZCB0YWtlU25hcHNob3QoKQogICAgIHsKICAg ICAgICAgaWYgKGhhc1NuYXBzaG90KCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIG1f Y2hpbGROb2RlcyA9IGFkb3B0UHRyKG5ldyBWZWN0b3I8UmVmUHRyPE5vZGU+PigpKTsKKyAgICAg ICAgbV9oYXNTbmFwc2hvdCA9IHRydWU7CiAgICAgICAgIE5vZGUqIG5vZGUgPSBtX2N1cnJlbnRO b2RlLmdldCgpOwogICAgICAgICB3aGlsZSAobm9kZSkgewotICAgICAgICAgICAgbV9jaGlsZE5v ZGVzLT5hcHBlbmQobm9kZSk7CisgICAgICAgICAgICBtX2NoaWxkTm9kZXMuYXBwZW5kKG5vZGUp OwogICAgICAgICAgICAgbm9kZSA9IG5vZGUtPm5leHRTaWJsaW5nKCk7CiAgICAgICAgIH0KICAg ICB9CiAKICAgICBDaGlsZE5vZGVzTGF6eVNuYXBzaG90KiBuZXh0U25hcHNob3QoKSB7IHJldHVy biBtX25leHRTbmFwc2hvdDsgfQotICAgIGJvb2wgaGFzU25hcHNob3QoKSB7IHJldHVybiAhIW1f Y2hpbGROb2Rlcy5nZXQoKTsgfQorICAgIGJvb2wgaGFzU25hcHNob3QoKSB7IHJldHVybiBtX2hh c1NuYXBzaG90OyB9CiAKICAgICBzdGF0aWMgdm9pZCB0YWtlQ2hpbGROb2Rlc0xhenlTbmFwc2hv dCgpCiAgICAgewpAQCAtMzA2LDcgKzMwNiw4IEBAIHByaXZhdGU6CiAKICAgICBSZWZQdHI8Tm9k ZT4gbV9jdXJyZW50Tm9kZTsKICAgICB1bnNpZ25lZCBtX2N1cnJlbnRJbmRleDsKLSAgICBPd25Q dHI8VmVjdG9yPFJlZlB0cjxOb2RlPj4+IG1fY2hpbGROb2RlczsgLy8gTGF6aWx5IGluc3RhbnRp YXRlZC4KKyAgICBib29sIG1faGFzU25hcHNob3Q7CisgICAgVmVjdG9yPFJlZlB0cjxOb2RlPj4g bV9jaGlsZE5vZGVzOyAvLyBMYXppbHkgaW5zdGFudGlhdGVkLgogICAgIENoaWxkTm9kZXNMYXp5 U25hcHNob3QqIG1fbmV4dFNuYXBzaG90OwogfTsKIAo=