132613 2014-05-06 10:07:55 -0700 URI doesn't get updated for cached 301 redirects 2014-08-17 02:05:21 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mschiffer webkit-unassigned oldest_to_newest 1006984 0 mschiffer 2014-05-06 10:07:55 -0700 Version: webkit2-gtk3.0 2.4.1 In webkit2, the "uri" property/the URI returned by webkit_web_view_get_uri() doesn't get updated after following a cached 301 redirect. When the request is made for the first time and is thus not cached, it gets updated correctly. I can reproduce this with both Epiphany and my own code. Webkit1 doesn't exhibit this behaviour. 1007597 1 mschiffer 2014-05-08 05:37:10 -0700 I've now further debugged this. The WebKitWebView never gets a load-changed signal with WEBKIT_LOAD_REDIRECTED for cached redirects, as it would normally be triggered by WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad(), which is called by ResourceLoader::willSendRequest(), but the ResourceLoader is not active for cached requests. I think to fix this, it'd be necessary to move the WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad() call to CachedRawResource or DocumentLoader. Does this make sense? I don't know the code very well, but if you agree with my analysis, I can try cooking up a patch. 1007996 2 231159 mschiffer 2014-05-09 09:07:26 -0700 Created attachment 231159 Bugfix This patch fixes the problem for me, both in Epiphany and my own application. 1009961 3 mschiffer 2014-05-17 03:03:51 -0700 Hi, it's been more that a week since I reported this bug *and* provided a patch. Anyone looked at it yet? 1015647 4 mschiffer 2014-06-14 07:31:52 -0700 It'd be really nice if I could a least get a reaction on my bug report, which is now over a month old. 1021831 5 mschiffer 2014-07-11 05:53:18 -0700 Pinging again. Anyone willing to look at this bug report? It's been two months since I provided a patch... 1029659 6 mschiffer 2014-08-17 02:05:21 -0700 I can't reproduce this bug with the current version (webkit2-gtk3 2.4.4) anymore, so I guess it's been fixed. 231159 2014-05-09 09:07:26 -0700 2014-05-09 09:07:26 -0700 Bugfix 0001-Move-redirect-notification-from-ResourceLoader-to-Do.patch text/plain 3280 mschiffer RnJvbSBhZmRhYzM3YmYzZmI3NGE1MWRjNzNiZDc3MmFjNzY3NmQ2OGRhYjE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlkOiA8YWZkYWMzN2JmM2ZiNzRhNTFkYzczYmQ3NzJhYzc2 NzZkNjhkYWIxOS4xMzk5NjQwMDIyLmdpdC5tc2NoaWZmZXJAdW5pdmVyc2UtZmFjdG9yeS5uZXQ+ CkZyb206IE1hdHRoaWFzIFNjaGlmZmVyIDxtc2NoaWZmZXJAdW5pdmVyc2UtZmFjdG9yeS5uZXQ+ CkRhdGU6IEZyaSwgOSBNYXkgMjAxNCAwNzo1Mzo1NCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1v dmUgcmVkaXJlY3Qgbm90aWZpY2F0aW9uIGZyb20gUmVzb3VyY2VMb2FkZXIgdG8KIERvY3VtZW50 TG9hZGVyL0ZyYW1lTG9hZGVyCgpDYWxsaW5nIGRpc3BhdGNoRGlkUmVjZWl2ZVNlcnZlclJlZGly ZWN0Rm9yUHJvdmlzaW9uYWxMb2FkKCkgZGlyZWN0bHkgZnJvbSB0aGUKUmVzb3VyY2VMb2FkZXIg Y2F1c2VkIHRoZSBVSSBwcm9jZXNzIHRvIG5ldmVyIGJlIG5vdGlmaWVkIGFib3V0IHJlZGlyZWN0 cyBmb3IKY2FjaGVkIHJlc291cmNlcyBpbiBXZWJraXQyLgoKTW92ZSBpdCB0byB0aGUgRnJhbWVM b2FkZXIgc28gaXQgaXMgaGFuZGxlZCBzaW1pbGFybHkgdG8gZGlzcGF0Y2hEaWRDb21taXRMb2Fk KCkKYW5kIGhvb2sgaXQgdXAgaW4gdGhlIERvY3VtZW50TG9hZGVyLgotLS0KIFNvdXJjZS9XZWJD b3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAgfCAzICsrKwogU291cmNlL1dlYkNvcmUvbG9h ZGVyL0ZyYW1lTG9hZGVyLmNwcCAgICB8IDUgKysrKysKIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5oICAgICAgfCAxICsKIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxv YWRlci5jcHAgfCAzIC0tLQogNCBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9h ZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXgg OWUwMGU4MS4uOWRhMGUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3Vt ZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIu Y3BwCkBAIC00OTcsNiArNDk3LDkgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6cmVkaXJlY3RSZWNl aXZlZChDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UsIFJlc291cmNlUmVxdWVzdCYKIHsKICAgICBB U1NFUlRfVU5VU0VEKHJlc291cmNlLCByZXNvdXJjZSA9PSBtX21haW5SZXNvdXJjZSk7CiAgICAg d2lsbFNlbmRSZXF1ZXN0KHJlcXVlc3QsIHJlZGlyZWN0UmVzcG9uc2UpOworCisgICAgaWYgKCFp c0NvbW1pdHRlZCgpKQorICAgICAgICBmcmFtZUxvYWRlcigpLT5yZWNlaXZlZFJlZGlyZWN0KCk7 CiB9CiAKIHZvaWQgRG9jdW1lbnRMb2FkZXI6OndpbGxTZW5kUmVxdWVzdChSZXNvdXJjZVJlcXVl c3QmIG5ld1JlcXVlc3QsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2Up CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBhMTQ4OTI1Li42NjE5Mzk4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTY0OSw2ICs2NDksMTEg QEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2xlYXIoRG9jdW1lbnQqIG5ld0RvY3VtZW50LCBib29sIGNs ZWFyV2luZG93UHJvcGVydGllcywgYm9vbAogICAgICAgICBtX3N0YXRlTWFjaGluZS5hZHZhbmNl VG8oRnJhbWVMb2FkZXJTdGF0ZU1hY2hpbmU6OkNvbW1pdHRlZEZpcnN0UmVhbExvYWQpOwogfQog Cit2b2lkIEZyYW1lTG9hZGVyOjpyZWNlaXZlZFJlZGlyZWN0KCkKK3sKKyAgICBtX2NsaWVudC5k aXNwYXRjaERpZFJlY2VpdmVTZXJ2ZXJSZWRpcmVjdEZvclByb3Zpc2lvbmFsTG9hZCgpOworfQor CiB2b2lkIEZyYW1lTG9hZGVyOjpyZWNlaXZlZEZpcnN0RGF0YSgpCiB7CiAgICAgZGlzcGF0Y2hE aWRDb21taXRMb2FkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVM b2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCmluZGV4IDlmOTA3 NzUuLmYxMDI1ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCkBAIC0yMDksNiAr MjA5LDcgQEAgcHVibGljOgogICAgIC8vIENhbGxiYWNrcyBmcm9tIERvY3VtZW50V3JpdGVyCiAg ICAgdm9pZCBkaWRCZWdpbkRvY3VtZW50KGJvb2wgZGlzcGF0Y2hXaW5kb3dPYmplY3RBdmFpbGFi bGUpOwogCisgICAgdm9pZCByZWNlaXZlZFJlZGlyZWN0KCk7CiAgICAgdm9pZCByZWNlaXZlZEZp cnN0RGF0YSgpOwogCiAgICAgdm9pZCBoYW5kbGVkT25sb2FkRXZlbnRzKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCBhOTBmOTFiLi44MjYxYzFkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKQEAgLTI4Myw5ICsyODMsNiBA QCB2b2lkIFJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiBy ZXF1ZXN0LCBjb25zdCBSZXNvdXJjZVJlcwogICAgICAgICBwbGF0Zm9ybVN0cmF0ZWdpZXMoKS0+ bG9hZGVyU3RyYXRlZ3koKS0+cmVzb3VyY2VMb2FkU2NoZWR1bGVyKCktPmNyb3NzT3JpZ2luUmVk aXJlY3RSZWNlaXZlZCh0aGlzLCByZXF1ZXN0LnVybCgpKTsKIAogICAgIG1fcmVxdWVzdCA9IHJl cXVlc3Q7Ci0KLSAgICBpZiAoIXJlZGlyZWN0UmVzcG9uc2UuaXNOdWxsKCkgJiYgIW1fZG9jdW1l bnRMb2FkZXItPmlzQ29tbWl0dGVkKCkpCi0gICAgICAgIGZyYW1lTG9hZGVyKCktPmNsaWVudCgp LmRpc3BhdGNoRGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHJvdmlzaW9uYWxMb2FkKCk7CiB9 CiAKIHZvaWQgUmVzb3VyY2VMb2FkZXI6OmRpZFNlbmREYXRhKHVuc2lnbmVkIGxvbmcgbG9uZywg dW5zaWduZWQgbG9uZyBsb25nKQotLSAKMS45LjIKCg==