132611 2014-05-06 09:35:35 -0700 [CSS Regions] Optimize the number of regions invalidations 2014-05-06 10:31:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 abucur abucur commit-queue esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 1006976 0 abucur 2014-05-06 09:35:35 -0700 Right now we invalidate more than necessary when doing regions layout. Check for invalidation only after the height of the region is fully computed. 1006977 1 230912 abucur 2014-05-06 09:41:00 -0700 Created attachment 230912 Patch 1006978 2 230912 hyatt 2014-05-06 09:43:02 -0700 Comment on attachment 230912 Patch r=me 1006995 3 230912 commit-queue 2014-05-06 10:31:12 -0700 Comment on attachment 230912 Patch Clearing flags on attachment: 230912 Committed r168363: <http://trac.webkit.org/changeset/168363> 1006996 4 commit-queue 2014-05-06 10:31:15 -0700 All reviewed patches have been landed. Closing bug. 230912 2014-05-06 09:41:00 -0700 2014-05-06 10:31:12 -0700 Patch bug-132611-20140506194036.patch text/plain 6215 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMxZTRiYzNhMTFkZjVk ZWVkZTg5N2NhYTBlZTJkZTcyMWQ4ODBiNy4uMGE1ODQxY2JiYmY1NTgxODViNzM1ZjBkMWMzOTRi ZmU1NjMwMGU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA1LTA2ICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gT3B0 aW1pemUgdGhlIG51bWJlciBvZiByZWdpb25zIGludmFsaWRhdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjYxMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIHBvc3NpYmxlIHRvIGludmFs aWRhdGUgdGhlIHJlZ2lvbiBjaGFpbiBvZiBhIGZsb3cgdGhyZWFkCisgICAgICAgIGR1cmluZyB0 aGUgbGF5b3V0IG9mIHRoZSByZWdpb24gd2hlbiBpdHMgaGVpZ2h0IGlzIG5vdCBmaW5hbC4KKwor ICAgICAgICBUaGlzIHBhdGNoIHBsYWNlcyB0aGUgY2hlY2sgYWZ0ZXIgdGhlIGhlaWdodCBvZiB0 aGUgcmVnaW9uCisgICAgICAgIGlzIGRldGVybWluZWQsIHJlZHVjaW5nIHRoZSBudW1iZXIgb2Yg aW52YWxpZGF0aW9ucy4KKworICAgICAgICBUZXN0czogTGVzcyBpbnZhbGlkYXRpb25zIGFuZCBy ZXBhaW50cyBpbiB0aGUgcmVwYWludCB0ZXN0cyBmb3IKKyAgICAgICAgdGhlIGZsb3cgdGhyZWFk cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93Ojp1cGRhdGVMb2dpY2FsSGVpZ2h0KToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTmFtZWRGbG93RnJhZ21lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTmFtZWRGbG93RnJhZ21lbnQ6OmxheW91dEJsb2NrKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck5hbWVkRmxvd0ZyYWdtZW50OjppbnZhbGlkYXRlUmVnaW9uSWZOZWVkZWQpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJOYW1lZEZsb3dGcmFnbWVudC5oOgorCiAyMDE0LTA1 LTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU291 cF0gVXNlIHN0ZDo6dW5pcXVlX3B0cjxjaGFyW10+IGZvciB0aGUgcmVhZCBidWZmZXIgaW4gU29j a2V0U3RyZWFtSGFuZGxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zs b3cuY3BwCmluZGV4IGRkNTU2NWFlMDQzODA5OTljNmQ4NTU1ODIwYWFiNzk0ZThjYjFkMmMuLjhi ZTk3MWU3YTQzZTNhMDY3ZjYwYjEyMTgyOWRkOWMwZTIyMzY1NTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0yOTI1LDggKzI5MjUsMTAgQEAg dm9pZCBSZW5kZXJCbG9ja0Zsb3c6OnVwZGF0ZUxvZ2ljYWxIZWlnaHQoKQogewogICAgIFJlbmRl ckJsb2NrOjp1cGRhdGVMb2dpY2FsSGVpZ2h0KCk7CiAKLSAgICBpZiAocmVuZGVyTmFtZWRGbG93 RnJhZ21lbnQoKSkKKyAgICBpZiAocmVuZGVyTmFtZWRGbG93RnJhZ21lbnQoKSkgewogICAgICAg ICByZW5kZXJOYW1lZEZsb3dGcmFnbWVudCgpLT5zZXRMb2dpY2FsSGVpZ2h0KHN0ZDo6bWF4PExh eW91dFVuaXQ+KDAsIGxvZ2ljYWxIZWlnaHQoKSAtIGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVp Z2h0KCkpKTsKKyAgICAgICAgcmVuZGVyTmFtZWRGbG93RnJhZ21lbnQoKS0+aW52YWxpZGF0ZVJl Z2lvbklmTmVlZGVkKCk7CisgICAgfQogfQogCiB2b2lkIFJlbmRlckJsb2NrRmxvdzo6c2V0UmVu ZGVyTmFtZWRGbG93RnJhZ21lbnQoUmVuZGVyTmFtZWRGbG93RnJhZ21lbnQqIGZsb3dGcmFnbWVu dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJOYW1lZEZsb3dG cmFnbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTmFtZWRGbG93RnJh Z21lbnQuY3BwCmluZGV4IDU1ZDg2Mzc3ZjdmYjczNjUxODkwOTVjMTFkNDc2MmIzMmUxMTRmODIu Ljk3MjgzODMxMjhhN2ExMTk5M2NiYzJiZWY3ZDAxZDI4ZDE2ZWIzMTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJOYW1lZEZsb3dGcmFnbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck5hbWVkRmxvd0ZyYWdtZW50LmNwcApAQCAt MjYyLDEwICsyNjIsNiBAQCB2b2lkIFJlbmRlck5hbWVkRmxvd0ZyYWdtZW50OjpsYXlvdXRCbG9j ayhib29sIHJlbGF5b3V0Q2hpbGRyZW4sIExheW91dFVuaXQpCiAgICAgUmVuZGVyUmVnaW9uOjps YXlvdXRCbG9jayhyZWxheW91dENoaWxkcmVuKTsKIAogICAgIGlmIChpc1ZhbGlkKCkpIHsKLSAg ICAgICAgTGF5b3V0UmVjdCBvbGRSZWdpb25SZWN0KGZsb3dUaHJlYWRQb3J0aW9uUmVjdCgpKTsK LSAgICAgICAgaWYgKCFpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKQotICAgICAgICAgICAgb2xk UmVnaW9uUmVjdCA9IG9sZFJlZ2lvblJlY3QudHJhbnNwb3NlZFJlY3QoKTsKLQogICAgICAgICBp ZiAobV9mbG93VGhyZWFkLT5pbk92ZXJmbG93TGF5b3V0UGhhc2UoKSB8fCBtX2Zsb3dUaHJlYWQt PmluRmluYWxMYXlvdXRQaGFzZSgpKSB7CiAgICAgICAgICAgICBjb21wdXRlT3ZlcmZsb3dGcm9t Rmxvd1RocmVhZCgpOwogICAgICAgICAgICAgdXBkYXRlT3ZlcnNldFN0YXRlKCk7CkBAIC0yNzYs MTEgKzI3MiwyMSBAQCB2b2lkIFJlbmRlck5hbWVkRmxvd0ZyYWdtZW50OjpsYXlvdXRCbG9jayhi b29sIHJlbGF5b3V0Q2hpbGRyZW4sIExheW91dFVuaXQpCiAgICAgICAgICAgICBjbGVhckNvbXB1 dGVkQXV0b0hlaWdodCgpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CisgICAgfQor fQogCi0gICAgICAgIGlmICgob2xkUmVnaW9uUmVjdC53aWR0aCgpICE9IHBhZ2VMb2dpY2FsV2lk dGgoKSB8fCBvbGRSZWdpb25SZWN0LmhlaWdodCgpICE9IHBhZ2VMb2dpY2FsSGVpZ2h0KCkpICYm ICFtX2Zsb3dUaHJlYWQtPmluRmluYWxMYXlvdXRQaGFzZSgpKSB7Ci0gICAgICAgICAgICAvLyBU aGlzIGNhbiBoYXBwZW4gZXZlbiBpZiB3ZSBhcmUgaW4gdGhlIGluQ29uc3RyYWluZWRMYXlvdXRQ aGFzZSBhbmQgaXQgd2lsbCB0cmlnZ2VyIGEgcGF0aG9sb2dpY2FsIGxheW91dCBvZiB0aGUgZmxv dyB0aHJlYWQuCi0gICAgICAgICAgICBtX2Zsb3dUaHJlYWQtPmludmFsaWRhdGVSZWdpb25zKCk7 Ci0gICAgICAgIH0KK3ZvaWQgUmVuZGVyTmFtZWRGbG93RnJhZ21lbnQ6OmludmFsaWRhdGVSZWdp b25JZk5lZWRlZCgpCit7CisgICAgaWYgKCFpc1ZhbGlkKCkpCisgICAgICAgIHJldHVybjsKKwor ICAgIExheW91dFJlY3Qgb2xkUmVnaW9uUmVjdChmbG93VGhyZWFkUG9ydGlvblJlY3QoKSk7Cisg ICAgaWYgKCFpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKQorICAgICAgICBvbGRSZWdpb25SZWN0 ID0gb2xkUmVnaW9uUmVjdC50cmFuc3Bvc2VkUmVjdCgpOworCisgICAgaWYgKChvbGRSZWdpb25S ZWN0LndpZHRoKCkgIT0gcGFnZUxvZ2ljYWxXaWR0aCgpIHx8IG9sZFJlZ2lvblJlY3QuaGVpZ2h0 KCkgIT0gcGFnZUxvZ2ljYWxIZWlnaHQoKSkgJiYgIW1fZmxvd1RocmVhZC0+aW5GaW5hbExheW91 dFBoYXNlKCkpIHsKKyAgICAgICAgLy8gVGhpcyBjYW4gaGFwcGVuIGV2ZW4gaWYgd2UgYXJlIGlu IHRoZSBpbkNvbnN0cmFpbmVkTGF5b3V0UGhhc2UgYW5kIGl0IHdpbGwgdHJpZ2dlciBhIHBhdGhv bG9naWNhbCBsYXlvdXQgb2YgdGhlIGZsb3cgdGhyZWFkLgorICAgICAgICBtX2Zsb3dUaHJlYWQt PmludmFsaWRhdGVSZWdpb25zKCk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTmFtZWRGbG93RnJhZ21lbnQuaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJOYW1lZEZsb3dGcmFnbWVudC5oCmluZGV4IDZjNjZmZmZhOWJlYjY4 N2MxNTU2NDFiNTcwODJkZTQyMTAzZmQ0MTkuLjk5OTVlM2FmYzA3ZGM0YmQxNmNlY2NjNmE4ZGY4 ZDZjZTFmNjhiMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJO YW1lZEZsb3dGcmFnbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJO YW1lZEZsb3dGcmFnbWVudC5oCkBAIC0xMTgsNiArMTE4LDggQEAgcHVibGljOgogCiAgICAgdmly dHVhbCB2b2lkIGFic29sdXRlUXVhZHNGb3JCb3hJblJlZ2lvbihWZWN0b3I8RmxvYXRRdWFkPiYs IGJvb2wqLCBjb25zdCBSZW5kZXJCb3gqLCBmbG9hdCwgZmxvYXQpIG92ZXJyaWRlOwogCisgICAg dm9pZCBpbnZhbGlkYXRlUmVnaW9uSWZOZWVkZWQoKTsKKwogcHJpdmF0ZToKICAgICB2aXJ0dWFs IGNvbnN0IGNoYXIqIHJlbmRlck5hbWUoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiAiUmVuZGVy TmFtZWRGbG93RnJhZ21lbnQiOyB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiZGFmOGY5OWQzZDI2NTk0NDJhMWEwMzFl MTQzN2UwNGIwNmEwNTk4Li5mZjEzNmNmZjViNWY2NzJkNjBiZjRmZDE1YjY2MTM5MWM1YjJmOWY1 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDUtMDYgIEFuZHJlaSBCdWN1ciAgPGFidWN1 ckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBSZWdpb25zXSBPcHRpbWl6ZSB0aGUgbnVtYmVy IG9mIHJlZ2lvbnMgaW52YWxpZGF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmVjYXVzZSB0aGVyZSBhcmUgbGVzcyByZWdpb24gaW52YWxpZGF0 aW9ucyB0aGVyZSBhcmUgbGVzcyByZXBhaW50cworICAgICAgICBvZiB0aGUgZmxvdyB0aHJlYWRz LgorCisgICAgICAgICogZmFzdC9yZWdpb25zL3JlcGFpbnQvcmVwYWludC1yZWdpb25zLW92ZXJm bG93LWV4cGVjdGVkLnR4dDoKKwogMjAxNC0wNS0wNSAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJr aXQub3JnPgogCiAgICAgICAgIEFkYXB0IGlubGluZSBTVkcgc2l6aW5nIGJlaGF2aW9yIHRvIEZp cmVmb3ggYW5kIEJsaW5rCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvcmVw YWludC9yZXBhaW50LXJlZ2lvbnMtb3ZlcmZsb3ctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9yZWdpb25zL3JlcGFpbnQvcmVwYWludC1yZWdpb25zLW92ZXJmbG93LWV4cGVjdGVkLnR4 dAppbmRleCBkYzUzNzkyOTlmMDBjMzM4OGNlMGVjZDBiZjNlN2Y1NzJlYzljYjQ3Li41ZjgwODIw ZjNlN2E3NGIxMTNhMGVjNzIxNzlkNzgxNzkyMjM5ZjIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L3JlZ2lvbnMvcmVwYWludC9yZXBhaW50LXJlZ2lvbnMtb3ZlcmZsb3ctZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9yZXBhaW50L3JlcGFpbnQtcmVnaW9u cy1vdmVyZmxvdy1leHBlY3RlZC50eHQKQEAgLTYsMTcgKzYsMTEgQEAgTEFTVCBMSU5FCiAKIChy ZXBhaW50IHJlY3RzCiAgIChyZWN0IDEwNiAzMDYgMzAwIDE2MCkKLSAgKHJlY3QgMTQgNzIgMzAw IDIxMCkKLSAgKHJlY3QgMTA2IDEyMiAzMDAgMjEwKQotICAocmVjdCAxNCAyOTggMzAwIDE4KQot ICAocmVjdCAxMDYgMzQ4IDMwMCAxOCkKICAgKHJlY3QgMTQgNTYgMzAwIDI2MCkKICAgKHJlY3Qg MTA2IDEwNiAzMDAgMjYwKQogICAocmVjdCA2MCAxNTAgMzEyIDI2NikKICAgKHJlY3QgMTAwIDIw MCAzMTIgMjY2KQogICAocmVjdCAxNCA1NiAzMDAgMjYwKQogICAocmVjdCAxMDYgMTA2IDMwMCAy NjApCi0gIChyZWN0IDE0IDU2IDMwMCAyNjApCi0gIChyZWN0IDEwNiAxMDYgMzAwIDI2MCkKICkK IAo=