132599 2014-05-05 21:40:53 -0700 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja 2016-01-14 08:32:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 nikos.andronikos nikos.andronikos commit-queue dbates mcatanzaro oldest_to_newest 1006856 0 nikos.andronikos 2014-05-05 21:40:53 -0700 Running the command line: Tools/Scripts/build-webkit --gtk Yields the following error: CMake Error: Could not create named generator "Eclipse CDT4 - Ninja" Not searching for unused variables given on the command line. The problem seems to be related to this bug fix: https://bugs.webkit.org/show_bug.cgi?id=132190 I have ninja installed and eclipse installed but cmake does not list the 'Eclipse CDT4 - Ninja' or the 'Ninja' generators (see attachment cmake_help_output.txt of output for "cmake --help" command). 1006857 1 230885 nikos.andronikos 2014-05-05 21:41:46 -0700 Created attachment 230885 cmake help output 1006858 2 230886 nikos.andronikos 2014-05-05 21:46:54 -0700 Created attachment 230886 Patch 1007906 3 nikos.andronikos 2014-05-08 23:28:00 -0700 (In reply to comment #2) > Created an attachment (id=230886) [details] > Patch I'm still getting my head around the build systems and such. Does the red on win indicate this patch broke the build? Or just that the build is broken (and this could have been caused by some other patch). I'm not currently able to reproduce the win breakage. 1035490 4 230886 mrobinson 2014-09-16 10:16:25 -0700 Comment on attachment 230886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230886&action=review One issue here. It looks like the Windows failure is unrelated. > Tools/Scripts/webkitdirs.pm:1818 > - my $willUseNinja = isGtk() && canUseNinja(); > + my $willUseNinja = isGtk() && canUseNinja() && canUseNinjaGenerator(); It looks like you shouldn't change this line, because if Eclipse support is not available it should fall back to the typical ninja generator. 1035642 5 nikos.andronikos 2014-09-16 17:28:39 -0700 (In reply to comment #4) > (From update of attachment 230886 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230886&action=review > > One issue here. It looks like the Windows failure is unrelated. > > > Tools/Scripts/webkitdirs.pm:1818 > > - my $willUseNinja = isGtk() && canUseNinja(); > > + my $willUseNinja = isGtk() && canUseNinja() && canUseNinjaGenerator(); > > It looks like you shouldn't change this line, because if Eclipse support is not available it should fall back to the typical ninja generator. There are 2 functions: 1. canUseNinjaGenerator 2. canUseEclipseNinjaGenerator canUseNinjaGenerator performs an extra check to ensure that a Ninja generator is installed - so this is extra error checking to make sure that cmake supports the Ninja generator which we know is installed (from the canUseNinja check) 1035653 6 238231 nikos.andronikos 2014-09-16 17:59:34 -0700 Created attachment 238231 Patch 1152195 7 238231 mcatanzaro 2016-01-03 17:12:58 -0800 Comment on attachment 238231 Patch Sorry this went unreviewed for so long. This looks fine to me. If the patch still applies on trunk and works, please set cq? to request commit. 1154301 8 268668 nikos.andronikos 2016-01-10 19:00:06 -0800 Created attachment 268668 Patch 1154302 9 268668 nikos.andronikos 2016-01-10 19:02:02 -0800 Comment on attachment 268668 Patch Thanks for the review - I've reapplied the patch to the trunk and updated the style to match the current code. 1155081 10 268668 mcatanzaro 2016-01-13 08:28:28 -0800 Comment on attachment 268668 Patch Unfortunately what I did not realize the first time I reviewed this, is that we can't use grep, because these functions need to work on Windows without Cygwin. The Windows EWS is passing because (a) it currently has Cygwin installed, and (b) it probably doesn't have Ninja installed. So you should try rewriting this without grep. Sorry. :( 1155366 11 268941 nikos.andronikos 2016-01-13 21:57:01 -0800 Created attachment 268941 Patch 1155436 12 268941 mcatanzaro 2016-01-14 07:44:01 -0800 Comment on attachment 268941 Patch Thanks! 1155455 13 268941 commit-queue 2016-01-14 08:32:13 -0800 Comment on attachment 268941 Patch Clearing flags on attachment: 268941 Committed r195057: <http://trac.webkit.org/changeset/195057> 1155456 14 commit-queue 2016-01-14 08:32:15 -0800 All reviewed patches have been landed. Closing bug. 230885 2014-05-05 21:41:46 -0700 2014-05-05 21:41:46 -0700 cmake help output cmake_help_output.txt text/plain 3625 nikos.andronikos Y21ha2UgdmVyc2lvbiAyLjguNwpVc2FnZQoKICBjbWFrZSBbb3B0aW9uc10gPHBhdGgtdG8tc291 cmNlPgogIGNtYWtlIFtvcHRpb25zXSA8cGF0aC10by1leGlzdGluZy1idWlsZD4KCk9wdGlvbnMK ICAtQyA8aW5pdGlhbC1jYWNoZT4gICAgICAgICAgPSBQcmUtbG9hZCBhIHNjcmlwdCB0byBwb3B1 bGF0ZSB0aGUgY2FjaGUuCiAgLUQgPHZhcj46PHR5cGU+PTx2YWx1ZT4gICAgID0gQ3JlYXRlIGEg Y21ha2UgY2FjaGUgZW50cnkuCiAgLVUgPGdsb2JiaW5nX2V4cHI+ICAgICAgICAgID0gUmVtb3Zl IG1hdGNoaW5nIGVudHJpZXMgZnJvbSBDTWFrZSBjYWNoZS4KICAtRyA8Z2VuZXJhdG9yLW5hbWU+ ICAgICAgICAgPSBTcGVjaWZ5IGEgbWFrZWZpbGUgZ2VuZXJhdG9yLgogIC1Xbm8tZGV2ICAgICAg ICAgICAgICAgICAgICA9IFN1cHByZXNzIGRldmVsb3BlciB3YXJuaW5ncy4KICAtV2RldiAgICAg ICAgICAgICAgICAgICAgICAgPSBFbmFibGUgZGV2ZWxvcGVyIHdhcm5pbmdzLgogIC1FICAgICAg ICAgICAgICAgICAgICAgICAgICA9IENNYWtlIGNvbW1hbmQgbW9kZS4KICAtaSAgICAgICAgICAg ICAgICAgICAgICAgICAgPSBSdW4gaW4gd2l6YXJkIG1vZGUuCiAgLUxbQV1bSF0gICAgICAgICAg ICAgICAgICAgID0gTGlzdCBub24tYWR2YW5jZWQgY2FjaGVkIHZhcmlhYmxlcy4KICAtLWJ1aWxk IDxkaXI+ICAgICAgICAgICAgICAgPSBCdWlsZCBhIENNYWtlLWdlbmVyYXRlZCBwcm9qZWN0IGJp bmFyeSB0cmVlLgogIC1OICAgICAgICAgICAgICAgICAgICAgICAgICA9IFZpZXcgbW9kZSBvbmx5 LgogIC1QIDxmaWxlPiAgICAgICAgICAgICAgICAgICA9IFByb2Nlc3Mgc2NyaXB0IG1vZGUuCiAg LS1maW5kLXBhY2thZ2UgICAgICAgICAgICAgID0gUnVuIGluIHBrZy1jb25maWcgbGlrZSBtb2Rl LgogIC0tZ3JhcGh2aXo9W2ZpbGVdICAgICAgICAgICA9IEdlbmVyYXRlIGdyYXBodml6IG9mIGRl cGVuZGVuY2llcy4KICAtLXN5c3RlbS1pbmZvcm1hdGlvbiBbZmlsZV0gPSBEdW1wIGluZm9ybWF0 aW9uIGFib3V0IHRoaXMgc3lzdGVtLgogIC0tZGVidWctdHJ5Y29tcGlsZSAgICAgICAgICA9IERv IG5vdCBkZWxldGUgdGhlIHRyeV9jb21waWxlIGJ1aWxkIHRyZWUuCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgT25seSB1c2VmdWwgb24gb25lIHRyeV9jb21waWxlIGF0IGEgdGltZS4K ICAtLWRlYnVnLW91dHB1dCAgICAgICAgICAgICAgPSBQdXQgY21ha2UgaW4gYSBkZWJ1ZyBtb2Rl LgogIC0tdHJhY2UgICAgICAgICAgICAgICAgICAgICA9IFB1dCBjbWFrZSBpbiB0cmFjZSBtb2Rl LgogIC0td2Fybi11bmluaXRpYWxpemVkICAgICAgICA9IFdhcm4gYWJvdXQgdW5pbml0aWFsaXpl ZCB2YWx1ZXMuCiAgLS13YXJuLXVudXNlZC12YXJzICAgICAgICAgID0gV2FybiBhYm91dCB1bnVz ZWQgdmFyaWFibGVzLgogIC0tbm8td2Fybi11bnVzZWQtY2xpICAgICAgICA9IERvbid0IHdhcm4g YWJvdXQgY29tbWFuZCBsaW5lIG9wdGlvbnMuCiAgLS1jaGVjay1zeXN0ZW0tdmFycyAgICAgICAg ID0gRmluZCBwcm9ibGVtcyB3aXRoIHZhcmlhYmxlIHVzYWdlIGluIHN5c3RlbQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZpbGVzLgogIC0taGVscC1jb21tYW5kIGNtZCBbZmlsZV0g ICA9IFByaW50IGhlbHAgZm9yIGEgc2luZ2xlIGNvbW1hbmQgYW5kIGV4aXQuCiAgLS1oZWxwLWNv bW1hbmQtbGlzdCBbZmlsZV0gID0gTGlzdCBhdmFpbGFibGUgbGlzdGZpbGUgY29tbWFuZHMgYW5k IGV4aXQuCiAgLS1oZWxwLWNvbW1hbmRzIFtmaWxlXSAgICAgID0gUHJpbnQgaGVscCBmb3IgYWxs IGNvbW1hbmRzIGFuZCBleGl0LgogIC0taGVscC1jb21wYXRjb21tYW5kcyBbZmlsZV09IFByaW50 IGhlbHAgZm9yIGNvbXBhdGliaWxpdHkgY29tbWFuZHMuCiAgLS1oZWxwLW1vZHVsZSBtb2R1bGUg W2ZpbGVdID0gUHJpbnQgaGVscCBmb3IgYSBzaW5nbGUgbW9kdWxlIGFuZCBleGl0LgogIC0taGVs cC1tb2R1bGUtbGlzdCBbZmlsZV0gICA9IExpc3QgYXZhaWxhYmxlIG1vZHVsZXMgYW5kIGV4aXQu CiAgLS1oZWxwLW1vZHVsZXMgW2ZpbGVdICAgICAgID0gUHJpbnQgaGVscCBmb3IgYWxsIG1vZHVs ZXMgYW5kIGV4aXQuCiAgLS1oZWxwLWN1c3RvbS1tb2R1bGVzIFtmaWxlXT0gUHJpbnQgaGVscCBm b3IgYWxsIGN1c3RvbSBtb2R1bGVzIGFuZCBleGl0LgogIC0taGVscC1wb2xpY3kgY21wIFtmaWxl XSAgICA9IFByaW50IGhlbHAgZm9yIGEgc2luZ2xlIHBvbGljeSBhbmQgZXhpdC4KICAtLWhlbHAt cG9saWNpZXMgW2ZpbGVdICAgICAgPSBQcmludCBoZWxwIGZvciBhbGwgcG9saWNpZXMgYW5kIGV4 aXQuCiAgLS1oZWxwLXByb3BlcnR5IHByb3AgW2ZpbGVdID0gUHJpbnQgaGVscCBmb3IgYSBzaW5n bGUgcHJvcGVydHkgYW5kIGV4aXQuCiAgLS1oZWxwLXByb3BlcnR5LWxpc3QgW2ZpbGVdID0gTGlz dCBhdmFpbGFibGUgcHJvcGVydGllcyBhbmQgZXhpdC4KICAtLWhlbHAtcHJvcGVydGllcyBbZmls ZV0gICAgPSBQcmludCBoZWxwIGZvciBhbGwgcHJvcGVydGllcyBhbmQgZXhpdC4KICAtLWhlbHAt dmFyaWFibGUgdmFyIFtmaWxlXSAgPSBQcmludCBoZWxwIGZvciBhIHNpbmdsZSB2YXJpYWJsZSBh bmQgZXhpdC4KICAtLWhlbHAtdmFyaWFibGUtbGlzdCBbZmlsZV0gPSBMaXN0IGRvY3VtZW50ZWQg dmFyaWFibGVzIGFuZCBleGl0LgogIC0taGVscC12YXJpYWJsZXMgW2ZpbGVdICAgICA9IFByaW50 IGhlbHAgZm9yIGFsbCB2YXJpYWJsZXMgYW5kIGV4aXQuCiAgLS1jb3B5cmlnaHQgW2ZpbGVdICAg ICAgICAgID0gUHJpbnQgdGhlIENNYWtlIGNvcHlyaWdodCBhbmQgZXhpdC4KICAtLWhlbHAsLWhl bHAsLXVzYWdlLC1oLC1ILC8/PSBQcmludCB1c2FnZSBpbmZvcm1hdGlvbiBhbmQgZXhpdC4KICAt LWhlbHAtZnVsbCBbZmlsZV0gICAgICAgICAgPSBQcmludCBmdWxsIGhlbHAgYW5kIGV4aXQuCiAg LS1oZWxwLWh0bWwgW2ZpbGVdICAgICAgICAgID0gUHJpbnQgZnVsbCBoZWxwIGluIEhUTUwgZm9y bWF0LgogIC0taGVscC1tYW4gW2ZpbGVdICAgICAgICAgICA9IFByaW50IGZ1bGwgaGVscCBhcyBh IFVOSVggbWFuIHBhZ2UgYW5kIGV4aXQuCiAgLS12ZXJzaW9uLC12ZXJzaW9uLC9WIFtmaWxlXT0g U2hvdyBwcm9ncmFtIG5hbWUvdmVyc2lvbiBiYW5uZXIgYW5kIGV4aXQuCgpHZW5lcmF0b3JzCgpU aGUgZm9sbG93aW5nIGdlbmVyYXRvcnMgYXJlIGF2YWlsYWJsZSBvbiB0aGlzIHBsYXRmb3JtOgog IFVuaXggTWFrZWZpbGVzICAgICAgICAgICAgICA9IEdlbmVyYXRlcyBzdGFuZGFyZCBVTklYIG1h a2VmaWxlcy4KICBDb2RlQmxvY2tzIC0gVW5peCBNYWtlZmlsZXMgPSBHZW5lcmF0ZXMgQ29kZUJs b2NrcyBwcm9qZWN0IGZpbGVzLgogIEVjbGlwc2UgQ0RUNCAtIFVuaXggTWFrZWZpbGVzCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgID0gR2VuZXJhdGVzIEVjbGlwc2UgQ0RUIDQuMCBwcm9q ZWN0IGZpbGVzLgogIEtEZXZlbG9wMyAgICAgICAgICAgICAgICAgICA9IEdlbmVyYXRlcyBLRGV2 ZWxvcCAzIHByb2plY3QgZmlsZXMuCiAgS0RldmVsb3AzIC0gVW5peCBNYWtlZmlsZXMgID0gR2Vu ZXJhdGVzIEtEZXZlbG9wIDMgcHJvamVjdCBmaWxlcy4KCg== 230886 2014-05-05 21:46:54 -0700 2014-09-16 17:59:30 -0700 Patch bug-132599-20140507024504.patch text/plain 2292 nikos.andronikos SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2ODM0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTA1LTA2ICBOaWtvcyBBbmRyb25pa29zICA8bmlrb3MuYW5kcm9uaWtv cy13ZWJraXRAY2lzcmEuY2Fub24uY29tLmF1PgorCisgICAgICAgIFtDTWFrZV1bR1RLXSBDTWFr ZSBFcnJvcjogQ291bGQgbm90IGNyZWF0ZSBuYW1lZCBnZW5lcmF0b3IgRWNsaXBzZSBDRFQ0IC0g TmluamEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjU5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo ZWNrIGlmIGNtYWtlIE5pbmphIGdlbmVyYXRvcnMgYXJlIGluc3RhbGxlZC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNhblVzZU5pbmphR2VuZXJhdG9yKToK KyAgICAgICAgKGNhblVzZUVjbGlwc2VOaW5qYUdlbmVyYXRvcik6CisgICAgICAgIChnZW5lcmF0 ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisgICAgICAgIChjYW5Vc2VFY2xpcHNlKTog RGVsZXRlZC4KKwogMjAxNC0wNS0wNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV0YWluUHRyOiBVc2UgYWRvcHRDRiBmdW5jdGlvbiBpbnN0ZWFkIG9mIEFkb3B0 Q0YgY29uc3RydWN0b3IgYXJndW1lbnQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDE2 ODM0MCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAt MTc4MSw5ICsxNzgxLDE3IEBAIHN1YiBjYW5Vc2VOaW5qYShAKQogICAgIHJldHVybiAkPyA9PSAw OwogfQogCi1zdWIgY2FuVXNlRWNsaXBzZShAKQorc3ViIGNhblVzZU5pbmphR2VuZXJhdG9yKEAp CiB7Ci0gICAgc3lzdGVtKCd3aGljaCBlY2xpcHNlID4gL2Rldi9udWxsJyk7CisgICAgIyBDaGVj ayB0aGF0IGEgTmluamEgZ2VuZXJhdG9yIGlzIGluc3RhbGxlZAorICAgIHN5c3RlbSgnY21ha2Ug LS1oZWxwIHwgZ3JlcCBOaW5qYSA+IC9kZXYvbnVsbCcpOworICAgIHJldHVybiAkPyA9PSAwOwor fQorCitzdWIgY2FuVXNlRWNsaXBzZU5pbmphR2VuZXJhdG9yKEApCit7CisgICAgIyBDaGVjayB0 aGF0IGVjbGlwc2UgYW5kIGVjbGlwc2UgTmluamEgZ2VuZXJhdG9yIGlzIGluc3RhbGxlZAorICAg IHN5c3RlbSgnd2hpY2ggZWNsaXBzZSAgPiAvZGV2L251bGwgJiYgY21ha2UgLS1oZWxwIHwgZ3Jl cCBcJ0VjbGlwc2UgQ0RUNCAtIE5pbmphXCcgPiAvZGV2L251bGwnKTsKICAgICByZXR1cm4gJD8g PT0gMDsKIH0KIApAQCAtMTgwNyw3ICsxODE1LDcgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1G cm9tQ01ha2VQcm9qZWN0CiAgICAgY2hkaXIoJGJ1aWxkUGF0aCkgb3IgZGllOwogCiAgICAgIyBG b3IgR1RLKyB3ZSB0cnkgdG8gYmUgc21hcnQgYWJvdXQgd2hlbiB0byByZXJ1biBjbWFrZSwgc28g dGhhdCB3ZSBjYW4gaGF2ZSBmYXN0ZXIgaW5jcmVtZW50YWwgYnVpbGRzLgotICAgIG15ICR3aWxs VXNlTmluamEgPSBpc0d0aygpICYmIGNhblVzZU5pbmphKCk7CisgICAgbXkgJHdpbGxVc2VOaW5q YSA9IGlzR3RrKCkgJiYgY2FuVXNlTmluamEoKSAmJiBjYW5Vc2VOaW5qYUdlbmVyYXRvcigpOwog ICAgIGlmIChpc0d0aygpICYmIC1lIGNtYWtlQ2FjaGVQYXRoKCkgJiYgLWUgY21ha2VHZW5lcmF0 ZWRCdWlsZGZpbGUoJHdpbGxVc2VOaW5qYSkpIHsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQpA QCAtMTgyNSw3ICsxODMzLDcgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9q ZWN0CiAKICAgICBpZiAoJHdpbGxVc2VOaW5qYSkgewogICAgICAgICBwdXNoIEBhcmdzLCAiLUci OwotICAgICAgICBpZiAoY2FuVXNlRWNsaXBzZSgpKSB7CisgICAgICAgIGlmIChjYW5Vc2VFY2xp cHNlTmluamFHZW5lcmF0b3IoKSkgewogICAgICAgICAgICAgcHVzaCBAYXJncywgIidFY2xpcHNl IENEVDQgLSBOaW5qYSciOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgcHVzaCBAYXJn cywgIk5pbmphIjsK 238231 2014-09-16 17:59:34 -0700 2016-01-10 19:00:01 -0800 Patch bug-132599-20140917105547.patch text/plain 2317 nikos.andronikos SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzY4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTA5LTE2ICBOaWtvcyBBbmRyb25pa29zICA8bmlrb3MuYW5kcm9uaWtv cy13ZWJraXRAY2lzcmEuY2Fub24uY29tLmF1PgorCisgICAgICAgIFtDTWFrZV1bR1RLXSBDTWFr ZSBFcnJvcjogQ291bGQgbm90IGNyZWF0ZSBuYW1lZCBnZW5lcmF0b3IgRWNsaXBzZSBDRFQ0IC0g TmluamEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjU5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo ZWNrIGlmIGNtYWtlIE5pbmphIGdlbmVyYXRvcnMgYXJlIGluc3RhbGxlZC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNhblVzZU5pbmphR2VuZXJhdG9yKToK KyAgICAgICAgKGNhblVzZUVjbGlwc2VOaW5qYUdlbmVyYXRvcik6CisgICAgICAgIChnZW5lcmF0 ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisgICAgICAgIChjYW5Vc2VFY2xpcHNlKTog RGVsZXRlZC4KKwogMjAxNC0wOS0xNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPU10gQWRkIGlPUyBTREsgbmFtZSBhbmQgdmVyc2lvbiBzdWZmaXggdG8g V2ViS2l0U3lzdGVtSW50ZXJmYWNlIGRlYnVnL3JlbGVhc2UgcHJvZHVjdCBuYW1lCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCShyZXZpc2lvbiAxNzM2ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTE3NTYsOSArMTc1NiwxNyBAQCBzdWIgY2FuVXNlTmlu amEoQCkKICAgICByZXR1cm4gJD8gPT0gMDsKIH0KIAotc3ViIGNhblVzZUVjbGlwc2UoQCkKK3N1 YiBjYW5Vc2VOaW5qYUdlbmVyYXRvcihAKQogewotICAgIHN5c3RlbSgnd2hpY2ggZWNsaXBzZSA+ IC9kZXYvbnVsbCcpOworICAgICMgQ2hlY2sgdGhhdCBhIE5pbmphIGdlbmVyYXRvciBpcyBpbnN0 YWxsZWQKKyAgICBzeXN0ZW0oJ2NtYWtlIC0taGVscCB8IGdyZXAgTmluamEgPiAvZGV2L251bGwn KTsKKyAgICByZXR1cm4gJD8gPT0gMDsKK30KKworc3ViIGNhblVzZUVjbGlwc2VOaW5qYUdlbmVy YXRvcihAKQoreworICAgICMgQ2hlY2sgdGhhdCBlY2xpcHNlIGFuZCBlY2xpcHNlIE5pbmphIGdl bmVyYXRvciBpcyBpbnN0YWxsZWQKKyAgICBzeXN0ZW0oJ3doaWNoIGVjbGlwc2UgID4gL2Rldi9u dWxsICYmIGNtYWtlIC0taGVscCB8IGdyZXAgXCdFY2xpcHNlIENEVDQgLSBOaW5qYVwnID4gL2Rl di9udWxsJyk7CiAgICAgcmV0dXJuICQ/ID09IDA7CiB9CiAKQEAgLTE3ODIsNyArMTc5MCw3IEBA IHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogICAgIGNoZGlyKCRidWls ZFBhdGgpIG9yIGRpZTsKIAogICAgICMgRm9yIEdUSysgd2UgdHJ5IHRvIGJlIHNtYXJ0IGFib3V0 IHdoZW4gdG8gcmVydW4gY21ha2UsIHNvIHRoYXQgd2UgY2FuIGhhdmUgZmFzdGVyIGluY3JlbWVu dGFsIGJ1aWxkcy4KLSAgICBteSAkd2lsbFVzZU5pbmphID0gaXNHdGsoKSAmJiBjYW5Vc2VOaW5q YSgpOworICAgIG15ICR3aWxsVXNlTmluamEgPSBpc0d0aygpICYmIGNhblVzZU5pbmphKCkgJiYg Y2FuVXNlTmluamFHZW5lcmF0b3IoKTsKICAgICBpZiAoaXNHdGsoKSAmJiAtZSBjbWFrZUNhY2hl UGF0aCgpICYmIC1lIGNtYWtlR2VuZXJhdGVkQnVpbGRmaWxlKCR3aWxsVXNlTmluamEpKSB7CiAg ICAgICAgIHJldHVybiAwOwogICAgIH0KQEAgLTE3OTksNyArMTgwNyw3IEBAIHN1YiBnZW5lcmF0 ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogCiAgICAgaWYgKCR3aWxsVXNlTmluamEpIHsK ICAgICAgICAgcHVzaCBAYXJncywgIi1HIjsKLSAgICAgICAgaWYgKGNhblVzZUVjbGlwc2UoKSkg eworICAgICAgICBpZiAoY2FuVXNlRWNsaXBzZU5pbmphR2VuZXJhdG9yKCkpIHsKICAgICAgICAg ICAgIHB1c2ggQGFyZ3MsICInRWNsaXBzZSBDRFQ0IC0gTmluamEnIjsKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIHB1c2ggQGFyZ3MsICJOaW5qYSI7Cg== 268668 2016-01-10 19:00:06 -0800 2016-01-13 21:56:57 -0800 Patch bug-132599-20160111135859.patch text/plain 2499 nikos.andronikos U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0ODMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2U1YTFlNjhjMjA4ZDBiZjk3OTVmMjhmNDg5YmU5YmM5 Zjg5Mjk5Yi4uNDhmZmJlNTBjNGE4ZmY5MWM4NjFkYzEyNGQyMDE4NjVlN2Y0ZTdhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTAxLTEwICBOaWtvcyBBbmRyb25pa29zICA8bmlrb3MuYW5kcm9uaWtvcy13ZWJr aXRAY2lzcmEuY2Fub24uY29tLmF1PgorCisgICAgICAgIFtDTWFrZV1bR1RLXSBDTWFrZSBFcnJv cjogQ291bGQgbm90IGNyZWF0ZSBuYW1lZCBnZW5lcmF0b3IgRWNsaXBzZSBDRFQ0IC0gTmluamEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjU5OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGlm IGNtYWtlIE5pbmphIGdlbmVyYXRvcnMgYXJlIGluc3RhbGxlZC4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNhblVzZU5pbmphR2VuZXJhdG9yKToKKyAgICAg ICAgKGNhblVzZUVjbGlwc2VOaW5qYUdlbmVyYXRvcik6CisgICAgICAgIChnZW5lcmF0ZUJ1aWxk U3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisgICAgICAgIChjYW5Vc2VFY2xpcHNlKTogRGVsZXRl ZC4KKwogMjAxNi0wMS0xMCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+ CiAKICAgICAgICAgW3dlYmtpdGRpcnNdIFRyeSBhcmNoIGFuZCB1bmFtZSBjb21tYW5kcyBvbiBu b24td2luZG93cyBPUwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDM0YzVjNmY4NTUwZjIxYTIxYmQ5ODdk NjNkYWEzOWM1ZDA2YTM2NmIuLjEyYWM5ZGM4ZTYxNDg5MjI4YzkwYzRjY2VkMWZlOWIzYTU4ZTY3 ZGUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE5MDksOSArMTkwOSwxOCBAQCBzdWIgY2FuVXNlTmlu amEoQCkKICAgICByZXR1cm4gY29tbWFuZEV4aXN0cygibmluamEiKSB8fCBjb21tYW5kRXhpc3Rz KCJuaW5qYS1idWlsZCIpOwogfQogCi1zdWIgY2FuVXNlRWNsaXBzZShAKQorc3ViIGNhblVzZU5p bmphR2VuZXJhdG9yKEApCiB7Ci0gICAgcmV0dXJuIGNvbW1hbmRFeGlzdHMoImVjbGlwc2UiKTsK KyAgICAjIENoZWNrIHRoYXQgYSBOaW5qYSBnZW5lcmF0b3IgaXMgaW5zdGFsbGVkCisgICAgbXkg JGRldm51bGwgPSBGaWxlOjpTcGVjLT5kZXZudWxsKCk7CisgICAgcmV0dXJuIGV4aXRTdGF0dXMo c3lzdGVtKCJjbWFrZSAtLWhlbHAgfCBncmVwIE5pbmphID4kZGV2bnVsbCAyPiYxIikpID09IDA7 Cit9CisKK3N1YiBjYW5Vc2VFY2xpcHNlTmluamFHZW5lcmF0b3IoQCkKK3sKKyAgICAjIENoZWNr IHRoYXQgZWNsaXBzZSBhbmQgZWNsaXBzZSBOaW5qYSBnZW5lcmF0b3IgaXMgaW5zdGFsbGVkCisg ICAgbXkgJGRldm51bGwgPSBGaWxlOjpTcGVjLT5kZXZudWxsKCk7CisgICAgcmV0dXJuIGNvbW1h bmRFeGlzdHMoImVjbGlwc2UiKSAmJiBleGl0U3RhdHVzKHN5c3RlbSgiY21ha2UgLS1oZWxwIHwg Z3JlcCAnRWNsaXBzZSBDRFQ0IC0gTmluamEnID4kZGV2bnVsbCAyPiYxIikpID09IDA7CiB9CiAK IHN1YiBjbWFrZUdlbmVyYXRlZEJ1aWxkZmlsZShAKQpAQCAtMTkzNiw3ICsxOTQ1LDcgQEAgc3Vi IGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgY2hkaXIoJGJ1aWxkUGF0 aCkgb3IgZGllOwogCiAgICAgIyBXZSB0cnkgdG8gYmUgc21hcnQgYWJvdXQgd2hlbiB0byByZXJ1 biBjbWFrZSwgc28gdGhhdCB3ZSBjYW4gaGF2ZSBmYXN0ZXIgaW5jcmVtZW50YWwgYnVpbGRzLgot ICAgIG15ICR3aWxsVXNlTmluamEgPSBjYW5Vc2VOaW5qYSgpOworICAgIG15ICR3aWxsVXNlTmlu amEgPSBjYW5Vc2VOaW5qYSgpICYmIGNhblVzZU5pbmphR2VuZXJhdG9yKCk7CiAgICAgaWYgKC1l IGNtYWtlQ2FjaGVQYXRoKCkgJiYgLWUgY21ha2VHZW5lcmF0ZWRCdWlsZGZpbGUoJHdpbGxVc2VO aW5qYSkpIHsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQpAQCAtMTk1Myw3ICsxOTYyLDcgQEAg c3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAKICAgICBpZiAoJHdpbGxV c2VOaW5qYSkgewogICAgICAgICBwdXNoIEBhcmdzLCAiLUciOwotICAgICAgICBpZiAoY2FuVXNl RWNsaXBzZSgpKSB7CisgICAgICAgIGlmIChjYW5Vc2VFY2xpcHNlTmluamFHZW5lcmF0b3IoKSkg ewogICAgICAgICAgICAgcHVzaCBAYXJncywgIidFY2xpcHNlIENEVDQgLSBOaW5qYSciOwogICAg ICAgICB9IGVsc2UgewogICAgICAgICAgICAgcHVzaCBAYXJncywgIk5pbmphIjsK 268941 2016-01-13 21:57:01 -0800 2016-01-14 08:32:13 -0800 Patch bug-132599-20160114165452.patch text/plain 2487 nikos.andronikos U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MDA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIzNWQzYzQ2Y2MwMTAzNjhlZjVlYjJlOTQ5MmVhYWI1 MzNkYmU3YS4uMGViNzA3OWU1YjJiYWVmN2QwM2Q1MGIyYmRkZDdmZGQzYzViN2E3NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTAxLTEzICBOaWtvcyBBbmRyb25pa29zICA8bmlrb3MuYW5kcm9uaWtvcy13ZWJr aXRAY2lzcmEuY2Fub24uY29tLmF1PgorCisgICAgICAgIFtDTWFrZV1bR1RLXSBDTWFrZSBFcnJv cjogQ291bGQgbm90IGNyZWF0ZSBuYW1lZCBnZW5lcmF0b3IgRWNsaXBzZSBDRFQ0IC0gTmluamEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjU5OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGlm IGNtYWtlIE5pbmphIGdlbmVyYXRvcnMgYXJlIGluc3RhbGxlZC4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNhblVzZU5pbmphR2VuZXJhdG9yKToKKyAgICAg ICAgKGNhblVzZUVjbGlwc2VOaW5qYUdlbmVyYXRvcik6CisgICAgICAgIChnZW5lcmF0ZUJ1aWxk U3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisgICAgICAgIChjYW5Vc2VFY2xpcHNlKTogRGVsZXRl ZC4KKwogMjAxNi0wMS0xMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29t PgogCiAgICAgICAgIFtDb2NvYV0gVGVzdGluZyB3aXRoIGZvbnQgZmFtaWx5IG5hbWUgIlN5c3Rl bSBGb250IiBpcyB1bnVzZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBmYTQ5MjQ2MTE4M2QxYWIyZmZh YjM5NjdkZjIwNGMwMjM1OGU3ZmU0Li4wZTBkNDY3NmMwM2RiY2JhNmJiYzFjMTQ5NjVhZjljZjRj YjNjY2E1IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xOTA5LDkgKzE5MDksMTggQEAgc3ViIGNhblVz ZU5pbmphKEApCiAgICAgcmV0dXJuIGNvbW1hbmRFeGlzdHMoIm5pbmphIikgfHwgY29tbWFuZEV4 aXN0cygibmluamEtYnVpbGQiKTsKIH0KIAotc3ViIGNhblVzZUVjbGlwc2UoQCkKK3N1YiBjYW5V c2VOaW5qYUdlbmVyYXRvcihAKQogewotICAgIHJldHVybiBjb21tYW5kRXhpc3RzKCJlY2xpcHNl Iik7CisgICAgIyBDaGVjayB0aGF0IGEgTmluamEgZ2VuZXJhdG9yIGlzIGluc3RhbGxlZAorICAg IG15ICRkZXZudWxsID0gRmlsZTo6U3BlYy0+ZGV2bnVsbCgpOworICAgIHJldHVybiBleGl0U3Rh dHVzKHN5c3RlbSgiY21ha2UgLU4gLUcgTmluamEgPiRkZXZudWxsIDI+JjEiKSkgPT0gMDsKK30K Kworc3ViIGNhblVzZUVjbGlwc2VOaW5qYUdlbmVyYXRvcihAKQoreworICAgICMgQ2hlY2sgdGhh dCBlY2xpcHNlIGFuZCBlY2xpcHNlIE5pbmphIGdlbmVyYXRvciBpcyBpbnN0YWxsZWQKKyAgICBt eSAkZGV2bnVsbCA9IEZpbGU6OlNwZWMtPmRldm51bGwoKTsKKyAgICByZXR1cm4gY29tbWFuZEV4 aXN0cygiZWNsaXBzZSIpICYmIGV4aXRTdGF0dXMoc3lzdGVtKCJjbWFrZSAtTiAtRyAnRWNsaXBz ZSBDRFQ0IC0gTmluamEnID4kZGV2bnVsbCAyPiYxIikpID09IDA7CiB9CiAKIHN1YiBjbWFrZUdl bmVyYXRlZEJ1aWxkZmlsZShAKQpAQCAtMTkzNiw3ICsxOTQ1LDcgQEAgc3ViIGdlbmVyYXRlQnVp bGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgY2hkaXIoJGJ1aWxkUGF0aCkgb3IgZGllOwog CiAgICAgIyBXZSB0cnkgdG8gYmUgc21hcnQgYWJvdXQgd2hlbiB0byByZXJ1biBjbWFrZSwgc28g dGhhdCB3ZSBjYW4gaGF2ZSBmYXN0ZXIgaW5jcmVtZW50YWwgYnVpbGRzLgotICAgIG15ICR3aWxs VXNlTmluamEgPSBjYW5Vc2VOaW5qYSgpOworICAgIG15ICR3aWxsVXNlTmluamEgPSBjYW5Vc2VO aW5qYSgpICYmIGNhblVzZU5pbmphR2VuZXJhdG9yKCk7CiAgICAgaWYgKC1lIGNtYWtlQ2FjaGVQ YXRoKCkgJiYgLWUgY21ha2VHZW5lcmF0ZWRCdWlsZGZpbGUoJHdpbGxVc2VOaW5qYSkpIHsKICAg ICAgICAgcmV0dXJuIDA7CiAgICAgfQpAQCAtMTk1Myw3ICsxOTYyLDcgQEAgc3ViIGdlbmVyYXRl QnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAKICAgICBpZiAoJHdpbGxVc2VOaW5qYSkgewog ICAgICAgICBwdXNoIEBhcmdzLCAiLUciOwotICAgICAgICBpZiAoY2FuVXNlRWNsaXBzZSgpKSB7 CisgICAgICAgIGlmIChjYW5Vc2VFY2xpcHNlTmluamFHZW5lcmF0b3IoKSkgewogICAgICAgICAg ICAgcHVzaCBAYXJncywgIidFY2xpcHNlIENEVDQgLSBOaW5qYSciOwogICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgcHVzaCBAYXJncywgIk5pbmphIjsK