132579 2014-05-05 13:27:51 -0700 Don't select an image that is about to have its menu shown. 2022-02-28 04:09:19 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson thorton oldest_to_newest 1006717 0 beidson 2014-05-05 13:27:51 -0700 Don't select an image that is about to be serviced. Instead select it afterwards and before pasting the result. <rdar://problem/16807845> 1006971 1 230911 beidson 2014-05-06 09:23:01 -0700 Created attachment 230911 Patch v1 1007035 2 230911 thorton 2014-05-06 12:07:42 -0700 Comment on attachment 230911 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=230911&action=review > Source/WebCore/editing/mac/EditorMac.mm:272 > + if (&(node->document()) != m_frame.document()) Don't think you need the parens. > Source/WebKit/mac/ChangeLog:10 > + Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard. extra space at the beginning of the line > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:125 > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); > + if (node) { if (Node* node = ...) 1007076 3 beidson 2014-05-06 14:09:03 -0700 https://trac.webkit.org/r168378 230911 2014-05-06 09:23:01 -0700 2022-02-28 04:09:19 -0800 Patch v1 patch text/plain 6730 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2M2JhOWNiLi5iOTMwMjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTQtMDUtMDYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIERvbid0IHNlbGVjdCBhbiBpbWFnZSB0aGF0IGlzIGFib3V0IHRvIGhhdmUgaXRzIG1lbnUg c2hvd24uCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjgwNzg0NT4gYW5kIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI1NzkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorCisgICAgICAg ICogZWRpdGluZy9FZGl0b3IuaDoKKyAgICAgICAgKiBlZGl0aW5nL21hYy9FZGl0b3JNYWMubW06 CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OnJlcGxhY2VOb2RlRnJvbVBhc3RlYm9hcmQpOiBO ZXcgbWV0aG9kIHRoYXQgZmlyc3Qgc2VsZWN0cworICAgICAgICAgdGhlIE5vZGUgYW5kIHRoZW4g aW1tZWRpYXRlbHkgcGFzdGVzIG92ZXIgaXQuIFNpbmNlIGl04oCZcyBzeW5jaHJvbm91cyB0aGUg CisgICAgICAgICBzZWxlY3Rpb24gbmV2ZXIgaGFzIGEgY2hhbmNlIHRvIHBhaW50LgorCisgICAg ICAgICogaHRtbC9zaGFkb3cvbWFjL0ltYWdlQ29udHJvbHNCdXR0b25FbGVtZW50TWFjLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkltYWdlQ29udHJvbHNCdXR0b25FbGVtZW50TWFjOjpkZWZhdWx0 RXZlbnRIYW5kbGVyKTogRG9u4oCZdCBzZWxlY3QgdGhlIGltYWdlLgorCiAyMDE0LTA1LTA2ICBD aHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFZvaWNl T3ZlciBkb2VzIG5vdCBhbm5vdW5jZSB0ZXh0IGNoYW5nZXMgZm9yIGNvbnRlbnQgZWRpdGFibGUg cmVnaW9ucyBpbiBTYWZhcmkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXggNmI0Yjk5NC4uOGM1OTVi YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysrIGIvU291cmNl L1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTExNjAsNiArMTE2MCw3IEBAIF9fWk43V2ViQ29y ZTZFZGl0b3IyM3NldEJhc2VXcml0aW5nRGlyZWN0aW9uRTE2V3JpdGluZ0RpcmVjdGlvbgogX19a TjdXZWJDb3JlNkVkaXRvcjI0Y29tcHV0ZUFuZFNldFR5cGluZ1N0eWxlRVBOU18xNVN0eWxlUHJv cGVydGllc0VOU18xMEVkaXRBY3Rpb25FCiBfX1pON1dlYkNvcmU2RWRpdG9yMjRpc1NlbGVjdGlv blVuZ3JhbW1hdGljYWxFdgogX19aTjdXZWJDb3JlNkVkaXRvcjI0cmVwbGFjZVNlbGVjdGlvbldp dGhUZXh0RVJLTjNXVEY2U3RyaW5nRWJiCitfX1pON1dlYkNvcmU2RWRpdG9yMjVyZXBsYWNlTm9k ZUZyb21QYXN0ZWJvYXJkRVBOU180Tm9kZUVSS04zV1RGNlN0cmluZ0UKIF9fWk43V2ViQ29yZTZF ZGl0b3IyNmRlY3JlYXNlU2VsZWN0aW9uTGlzdExldmVsRXYKIF9fWk43V2ViQ29yZTZFZGl0b3Iy NmluY3JlYXNlU2VsZWN0aW9uTGlzdExldmVsRXYKIF9fWk43V2ViQ29yZTZFZGl0b3IyNnRvZ2ds ZU92ZXJ3cml0ZU1vZGVFbmFibGVkRXYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRWRpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCmluZGV4IDhiMDIy ZDMuLmM2OTFjM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgK KysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaApAQCAtNDMyLDYgKzQzMiw3IEBA IHB1YmxpYzoKICAgICBib29sIGNhbkNvcHlFeGNsdWRpbmdTdGFuZGFsb25lSW1hZ2VzKCk7CiAg ICAgdm9pZCB0YWtlRmluZFN0cmluZ0Zyb21TZWxlY3Rpb24oKTsKICAgICB2b2lkIHJlYWRTZWxl Y3Rpb25Gcm9tUGFzdGVib2FyZChjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lKTsKKyAgICB2 b2lkIHJlcGxhY2VOb2RlRnJvbVBhc3RlYm9hcmQoTm9kZSosIGNvbnN0IFN0cmluZyYgcGFzdGVi b2FyZE5hbWUpOwogICAgIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBkYXRhU2VsZWN0aW9uRm9y UGFzdGVib2FyZChjb25zdCBTdHJpbmcmIHBhc3RlYm9hcmROYW1lKTsKICNlbmRpZiAvLyAhUExB VEZPUk0oSU9TKQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21h Yy9FZGl0b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMubW0K aW5kZXggZWEyNTA2Ny4uMGEwZDU1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9tYWMvRWRpdG9yTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0VkaXRv ck1hYy5tbQpAQCAtMjY1LDYgKzI2NSwxOSBAQCB2b2lkIEVkaXRvcjo6cmVhZFNlbGVjdGlvbkZy b21QYXN0ZWJvYXJkKGNvbnN0IFN0cmluZyYgcGFzdGVib2FyZE5hbWUpCiAgICAgICAgIHBhc3Rl QXNQbGFpblRleHRXaXRoUGFzdGVib2FyZChwYXN0ZWJvYXJkKTsKIH0KIAordm9pZCBFZGl0b3I6 OnJlcGxhY2VOb2RlRnJvbVBhc3RlYm9hcmQoTm9kZSogbm9kZSwgY29uc3QgU3RyaW5nJiBwYXN0 ZWJvYXJkTmFtZSkKK3sKKyAgICBBU1NFUlQobm9kZSk7CisKKyAgICBpZiAoJihub2RlLT5kb2N1 bWVudCgpKSAhPSBtX2ZyYW1lLmRvY3VtZW50KCkpCisgICAgICAgIHJldHVybjsKKworICAgIFJl ZlB0cjxSYW5nZT4gcmFuZ2UgPSBSYW5nZTo6Y3JlYXRlKG5vZGUtPmRvY3VtZW50KCksIFBvc2l0 aW9uKG5vZGUsIFBvc2l0aW9uOjpQb3NpdGlvbklzQmVmb3JlQW5jaG9yKSwgUG9zaXRpb24obm9k ZSwgUG9zaXRpb246OlBvc2l0aW9uSXNBZnRlckFuY2hvcikpOworICAgIG1fZnJhbWUuc2VsZWN0 aW9uKCkuc2V0U2VsZWN0aW9uKFZpc2libGVTZWxlY3Rpb24ocmFuZ2UuZ2V0KCkpLCBGcmFtZVNl bGVjdGlvbjo6RG9Ob3RTZXRGb2N1cyk7CisKKyAgICByZWFkU2VsZWN0aW9uRnJvbVBhc3RlYm9h cmQocGFzdGVib2FyZE5hbWUpOworfQorCiAvLyBGSVhNRTogTWFrZXMgbm8gc2Vuc2UgdGhhdCBz ZWxlY3RlZFRleHRGb3JEYXRhVHJhbnNmZXIgYWx3YXlzIGluY2x1ZGVzIGFsdCB0ZXh0LCBidXQg c3RyaW5nU2VsZWN0aW9uRm9yUGFzdGVib2FyZCBkb2VzIG5vdC4KIC8vIFRoaXMgd2FzIGxlZnQg aW4gYSBiYWQgc3RhdGUgd2hlbiBzZWxlY3RlZFRleHRGb3JEYXRhVHJhbnNmZXIgd2FzIGFkZGVk LiBOZWVkIHRvIGxvb2sgb3ZlciBjbGllbnRzIGFuZCBmaXggdGhpcy4KIFN0cmluZyBFZGl0b3I6 OnN0cmluZ1NlbGVjdGlvbkZvclBhc3RlYm9hcmQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvbWFjL0ltYWdlQ29udHJvbHNCdXR0b25FbGVtZW50TWFjLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L21hYy9JbWFnZUNvbnRyb2xzQnV0dG9uRWxlbWVudE1h Yy5jcHAKaW5kZXggMWUwY2Y5MS4uNzU4ZGQyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvbWFjL0ltYWdlQ29udHJvbHNCdXR0b25FbGVtZW50TWFjLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9tYWMvSW1hZ2VDb250cm9sc0J1dHRvbkVsZW1lbnRN YWMuY3BwCkBAIC0xMTEsMjMgKzExMSw2IEBAIHZvaWQgSW1hZ2VDb250cm9sc0J1dHRvbkVsZW1l bnRNYWM6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgICAgICBpZiAoIXBh Z2UpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgQ29udGFpbmVyTm9kZSogcGFyZW50 ID0gcGFyZW50Tm9kZSgpOwotICAgICAgICBFbGVtZW50KiBob3N0RWxlbWVudCA9IG51bGxwdHI7 Ci0gICAgICAgIHdoaWxlIChwYXJlbnQpIHsKLSAgICAgICAgICAgIGlmIChwYXJlbnQtPmlzU2hh ZG93Um9vdCgpKSB7Ci0gICAgICAgICAgICAgICAgaG9zdEVsZW1lbnQgPSBzdGF0aWNfY2FzdDxT aGFkb3dSb290Kj4ocGFyZW50KS0+aG9zdEVsZW1lbnQoKTsKLSAgICAgICAgICAgICAgICBicmVh azsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHBhcmVudCA9IHBhcmVudC0+cGFyZW50Tm9k ZSgpOwotICAgICAgICB9Ci0KLSAgICAgICAgaWYgKCFob3N0RWxlbWVudCkKLSAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgQVNTRVJUKGlzSFRNTEltYWdlRWxlbWVudChob3N0RWxlbWVudCkp OwotCi0gICAgICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSBSYW5nZTo6Y3JlYXRlKGRvY3VtZW50 KCksIFBvc2l0aW9uKGhvc3RFbGVtZW50LCBQb3NpdGlvbjo6UG9zaXRpb25Jc0JlZm9yZUFuY2hv ciksIFBvc2l0aW9uKGhvc3RFbGVtZW50LCBQb3NpdGlvbjo6UG9zaXRpb25Jc0FmdGVyQW5jaG9y KSk7Ci0gICAgICAgIGZyYW1lLT5zZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVj dGlvbihyYW5nZS5nZXQoKSkpOwotCiAgICAgICAgIHBhZ2UtPmNvbnRleHRNZW51Q29udHJvbGxl cigpLnNob3dJbWFnZUNvbnRyb2xzTWVudShldmVudCk7CiAgICAgICAgIGV2ZW50LT5zZXREZWZh dWx0SGFuZGxlZCgpOwogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggYTU2YTJk MC4uMjdiM2Q5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTA2 ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBzZWxl Y3QgYW4gaW1hZ2UgdGhhdCBpcyBhYm91dCB0byBoYXZlIGl0cyBtZW51IHNob3duLgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTY4MDc4NDU+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMyNTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBNaXNjL1dlYlNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlci5t bToKKyAgICAgICAgKC1bV2ViU2hhcmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyIGRpZFNoYXJl SW1hZ2VEYXRhOmNvbmZpcm1EYXRhSXNWYWxpZFRJRkZEYXRhOl0pOgorICAgICAgICAgIENhbGwg dGhlIG5ldyByZXBsYWNlTm9kZUZyb21QYXN0ZWJvYXJkIEFQSSBpbnN0ZWFkIG9mIHJlYWRTZWxl Y3Rpb25Gcm9tUGFzdGVib2FyZC4KKwogMjAxNC0wNS0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gRml4IHR3byBtb3JlIEFkb3B0Q0YgSSBtaXNzZWQg aW4gbXkgbGFzdCBwYXRjaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2Vi U2hhcmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdC9tYWMvTWlz Yy9XZWJTaGFyaW5nU2VydmljZVBpY2tlckNvbnRyb2xsZXIubW0KaW5kZXggMWZkYzhhOS4uMjhj ZDliNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hhcmluZ1NlcnZp Y2VQaWNrZXJDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hh cmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLm1tCkBAIC0zMSw2ICszMSw3IEBACiAjaW1wb3J0 ICJXZWJWaWV3SW50ZXJuYWwuaCIKICNpbXBvcnQgPEFwcEtpdC9OU1NoYXJpbmdTZXJ2aWNlLmg+ CiAjaW1wb3J0IDxXZWJDb3JlL0JpdG1hcEltYWdlLmg+CisjaW1wb3J0IDxXZWJDb3JlL0RvY3Vt ZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL0VkaXRvci5oPgogI2ltcG9ydCA8V2ViQ29yZS9Gb2N1 c0NvbnRyb2xsZXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJhbWUuaD4KQEAgLTEyMCw5ICsxMjEs MTEgQEAgLSAodm9pZClkaWRTaGFyZUltYWdlRGF0YTooTlNEYXRhICopZGF0YSBjb25maXJtRGF0 YUlzVmFsaWRUSUZGRGF0YTooQk9PTCljb25maXIKICAgICBbcGFzdGVib2FyZCBkZWNsYXJlVHlw ZXM6QFsgTlNQYXN0ZWJvYXJkVHlwZVRJRkYgXSBvd25lcjpuaWxdOwogICAgIFtwYXN0ZWJvYXJk IHNldERhdGE6ZGF0YSBmb3JUeXBlOk5TUGFzdGVib2FyZFR5cGVUSUZGXTsKIAotICAgIEZyYW1l JiBmcmFtZSA9IHBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwot ICAgIGlmICghZnJhbWUuc2VsZWN0aW9uKCkuaXNOb25lKCkpCi0gICAgICAgIGZyYW1lLmVkaXRv cigpLnJlYWRTZWxlY3Rpb25Gcm9tUGFzdGVib2FyZChzZXJ2aWNlQ29udHJvbHNQYXN0ZWJvYXJk TmFtZSk7CisgICAgTm9kZSogbm9kZSA9IHBhZ2UtPmNvbnRleHRNZW51Q29udHJvbGxlcigpLmNv bnRleHQoKS5oaXRUZXN0UmVzdWx0KCkuaW5uZXJOb2RlKCk7CisgICAgaWYgKG5vZGUpIHsKKyAg ICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IG5vZGUtPmRvY3VtZW50KCkuZnJhbWUoKSkKKyAgICAg ICAgICAgIGZyYW1lLT5lZGl0b3IoKS5yZXBsYWNlTm9kZUZyb21QYXN0ZWJvYXJkKG5vZGUsIHNl cnZpY2VDb250cm9sc1Bhc3RlYm9hcmROYW1lKTsKKyAgICB9CiAKICAgICBbc2VsZiBjbGVhcl07 CiB9Cg==