132572 2014-05-05 10:15:49 -0700 Optimize PutByVal when subscript is a rope string. 2014-05-05 11:08:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling oldest_to_newest 1006660 0 kling 2014-05-05 10:15:49 -0700 PutByVal with ropey string subscripts could be faster if we take advantage of the JSString::toAtomicString() optimization. 1006662 1 230836 kling 2014-05-05 10:16:26 -0700 Created attachment 230836 Patch 1006672 2 kling 2014-05-05 11:08:54 -0700 Committed r168300: <http://trac.webkit.org/changeset/168300> 230836 2014-05-05 10:16:26 -0700 2014-05-05 10:23:20 -0700 Patch bug-132572.diff text/plain 3459 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDAxMjg4YzAuLmNlOWQ1ODAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA1LTA1ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBPcHRpbWl6ZSBQdXRCeVZhbCB3aGVuIHN1 YnNjcmlwdCBpcyBhIHJvcGUgc3RyaW5nLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2Iv MTMyNTcyPgorCisgICAgICAgIEFkZCBhIEpTU3RyaW5nOjp0b0lkZW50aWZpZXIoKSB0aGF0IGlz IHNtYXJ0ZXIgd2hlbiB0aGUgSlNTdHJpbmcgaXMKKyAgICAgICAgcmVhbGx5IGEgcm9wZSBzdHJp bmcuIFVzZSB0aGlzIGluIGJhc2VsaW5lICYgREZHJ3MgUHV0QnlWYWwgdG8gYXZvaWQKKyAgICAg ICAgYWxsb2NhdGluZyBuZXcgU3RyaW5nSW1wbHMgdGhhdCB3ZSBpbW1lZGlhdGVseSBkZWR1cGxp Y2F0ZSBhbnl3YXkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6b3BlcmF0 aW9uUHV0QnlWYWxJbnRlcm5hbCk6CisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuY3BwOgor ICAgICAgICAqIHJ1bnRpbWUvSlNTdHJpbmcuaDoKKyAgICAgICAgKEpTQzo6SlNTdHJpbmc6OnRv SWRlbnRpZmllcik6CisKKzIwMTQtMDUtMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUu Y29tPgorCiAgICAgICAgIFJlbW92ZSB0d28gbm93LWluY29ycmVjdCBhc3NlcnRpb25zIGFmdGVy IHIxNjgyNTYuCiAKICAgICAgICAgKiBydW50aW1lL0pTU3RyaW5nLmNwcDoKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCmluZGV4IDg2OTk2YTMuLjhjOWFiNDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcApAQCAtMTIw LDcgKzEyMCw3IEBAIEFMV0FZU19JTkxJTkUgc3RhdGljIHZvaWQgSklUX09QRVJBVElPTiBvcGVy YXRpb25QdXRCeVZhbEludGVybmFsKEV4ZWNTdGF0ZSogZXhlCiAgICAgfQogCiAgICAgLy8gRG9u J3QgcHV0IHRvIGFuIG9iamVjdCBpZiB0b1N0cmluZyB0aHJvd3MgYW4gZXhjZXB0aW9uLgotICAg IElkZW50aWZpZXIgaWRlbnQoZXhlYywgcHJvcGVydHkudG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4 ZWMpKTsKKyAgICBJZGVudGlmaWVyIGlkZW50ID0gcHJvcGVydHkudG9TdHJpbmcoZXhlYyktPnRv SWRlbnRpZmllcihleGVjKTsKICAgICBpZiAoIXZtLT5leGNlcHRpb24oKSkgewogICAgICAgICBQ dXRQcm9wZXJ0eVNsb3Qgc2xvdChiYXNlVmFsdWUsIHN0cmljdCk7CiAgICAgICAgIGlmIChkaXJl Y3QpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9u cy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCmluZGV4 IDhiMjA1ZjYuLmFjZTMyZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUT3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVy YXRpb25zLmNwcApAQCAtNDYyLDcgKzQ2Miw3IEBAIHN0YXRpYyB2b2lkIHB1dEJ5VmFsKENhbGxG cmFtZSogY2FsbEZyYW1lLCBKU1ZhbHVlIGJhc2VWYWx1ZSwgSlNWYWx1ZSBzdWJzY3JpcHQsCiAg ICAgICAgIFB1dFByb3BlcnR5U2xvdCBzbG90KGJhc2VWYWx1ZSwgY2FsbEZyYW1lLT5jb2RlQmxv Y2soKS0+aXNTdHJpY3RNb2RlKCkpOwogICAgICAgICBiYXNlVmFsdWUucHV0KGNhbGxGcmFtZSwg anNDYXN0PE5hbWVJbnN0YW5jZSo+KHN1YnNjcmlwdC5hc0NlbGwoKSktPnByaXZhdGVOYW1lKCks IHZhbHVlLCBzbG90KTsKICAgICB9IGVsc2UgewotICAgICAgICBJZGVudGlmaWVyIHByb3BlcnR5 KGNhbGxGcmFtZSwgc3Vic2NyaXB0LnRvU3RyaW5nKGNhbGxGcmFtZSktPnZhbHVlKGNhbGxGcmFt ZSkpOworICAgICAgICBJZGVudGlmaWVyIHByb3BlcnR5ID0gc3Vic2NyaXB0LnRvU3RyaW5nKGNh bGxGcmFtZSktPnRvSWRlbnRpZmllcihjYWxsRnJhbWUpOwogICAgICAgICBpZiAoIWNhbGxGcmFt ZS0+dm0oKS5leGNlcHRpb24oKSkgeyAvLyBEb24ndCBwdXQgdG8gYW4gb2JqZWN0IGlmIHRvU3Ry aW5nIHRocmV3IGFuIGV4Y2VwdGlvbi4KICAgICAgICAgICAgIFB1dFByb3BlcnR5U2xvdCBzbG90 KGJhc2VWYWx1ZSwgY2FsbEZyYW1lLT5jb2RlQmxvY2soKS0+aXNTdHJpY3RNb2RlKCkpOwogICAg ICAgICAgICAgYmFzZVZhbHVlLnB1dChjYWxsRnJhbWUsIHByb3BlcnR5LCB2YWx1ZSwgc2xvdCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAppbmRleCBmYzUxNzBmLi5l NzZjODBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmlu Zy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgKQEAgLTEz OSw2ICsxMzksNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIHJldHVybiBuZXdTdHJp bmc7CiAgICAgICAgIH0KIAorICAgICAgICBJZGVudGlmaWVyIHRvSWRlbnRpZmllcihFeGVjU3Rh dGUqKSBjb25zdDsKICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiB0b0F0b21pY1N0cmluZyhF eGVjU3RhdGUqKSBjb25zdDsKICAgICAgICAgQXRvbWljU3RyaW5nSW1wbCogdG9FeGlzdGluZ0F0 b21pY1N0cmluZyhFeGVjU3RhdGUqKSBjb25zdDsKICAgICAgICAgY29uc3QgU3RyaW5nJiB2YWx1 ZShFeGVjU3RhdGUqKSBjb25zdDsKQEAgLTM4Nyw2ICszODgsMTEgQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgICAgIHJldHVybiBKU1N0cmluZzo6Y3JlYXRlKCp2bSwgcy5pbXBsKCkpOwogICAgIH0K IAorICAgIEFMV0FZU19JTkxJTkUgSWRlbnRpZmllciBKU1N0cmluZzo6dG9JZGVudGlmaWVyKEV4 ZWNTdGF0ZSogZXhlYykgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiBJZGVudGlmaWVyKGV4 ZWMsIHRvQXRvbWljU3RyaW5nKGV4ZWMpKTsKKyAgICB9CisKICAgICBBTFdBWVNfSU5MSU5FIGNv bnN0IEF0b21pY1N0cmluZyYgSlNTdHJpbmc6OnRvQXRvbWljU3RyaW5nKEV4ZWNTdGF0ZSogZXhl YykgY29uc3QKICAgICB7CiAgICAgICAgIGlmIChpc1JvcGUoKSkK