132570 2014-05-05 09:49:57 -0700 [HTML] Default argument to HTMLTableSectionElement.insertRow() should be -1 2014-05-06 10:55:14 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tbody-element P2 Normal --- 1 cdumez cdumez ap commit-queue darin eric esprehn+autocc gyuyoung.kim kondapallykalyan rniwa oldest_to_newest 1006653 0 cdumez 2014-05-05 09:49:57 -0700 The default argument to HTMLTableSectionElement.insertRow() should be -1, not 0, according to the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tbody-element Firefox 29 and IE11 both match the specification. Blink is about to change its behavior as well: http://code.google.com/p/chromium/issues/detail?id=369803 https://codereview.chromium.org/263193002/ 1006664 1 230837 cdumez 2014-05-05 10:25:59 -0700 Created attachment 230837 Patch 1006759 2 230837 cdumez 2014-05-05 15:35:10 -0700 Comment on attachment 230837 Patch FYI, this change has now landed in Blink. 1006931 3 cdumez 2014-05-06 06:13:56 -0700 FYI, if this change is approved, I will upload another one for HTMLTableRowElement.insertCell() as well (https://codereview.chromium.org/263323004/). 1006964 4 230837 darin 2014-05-06 09:04:49 -0700 Comment on attachment 230837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230837&action=review > Source/WebCore/html/HTMLTableSectionElement.cpp:61 > +PassRefPtr<HTMLElement> HTMLTableSectionElement::insertRow(ExceptionCode& ec) > +{ > + // The default 'index' argument value is -1. > + return insertRow(-1, ec); > +} Why not put this into the header and mark it inline? I see no reason to add another level of function call overhead just to supply this default argument. 1006986 5 230915 cdumez 2014-05-06 10:14:45 -0700 Created attachment 230915 Patch 1006990 6 230837 cdumez 2014-05-06 10:15:48 -0700 Comment on attachment 230837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230837&action=review >> Source/WebCore/html/HTMLTableSectionElement.cpp:61 >> +} > > Why not put this into the header and mark it inline? I see no reason to add another level of function call overhead just to supply this default argument. Agreed, I updated the patch. 1007009 7 230915 commit-queue 2014-05-06 10:55:09 -0700 Comment on attachment 230915 Patch Clearing flags on attachment: 230915 Committed r168365: <http://trac.webkit.org/changeset/168365> 1007010 8 commit-queue 2014-05-06 10:55:14 -0700 All reviewed patches have been landed. Closing bug. 230837 2014-05-05 10:25:59 -0700 2014-05-06 10:15:48 -0700 Patch bug-132570-20140505132532.patch text/plain 6564 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY4N2Q5MjI1ZDJkNmU3 OGM4NTY1MTVjNjJiMTczYTBjNDJiYjE1NS4uZWVhZTE1YmM5OTRhMDFmMzM3Y2RjZTYyMzg1ZDdk NmZjNTk1YjE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTA1ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0hUTUxdIERl ZmF1bHQgYXJndW1lbnQgdG8gSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQuaW5zZXJ0Um93KCkgc2hv dWxkIGJlIC0xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzI1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBIVE1MVGFibGVTZWN0aW9uRWxlbWVudC5pbnNlcnRSb3coKSdzIGFyZ3VtZW50IGRlZmF1bHQg dmFsdWUgc2hvdWxkIGJlIC0xLCBub3QKKyAgICAgICAgMCwgYXMgcGVyIHRoZSBzcGVjaWZpY2F0 aW9uOgorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVu dC13b3JrL211bHRpcGFnZS90YWJ1bGFyLWRhdGEuaHRtbCN0aGUtdGJvZHktZWxlbWVudAorCisg ICAgICAgIFRoZSBuZXcgYmVoYXZpb3IgbWF0Y2hlcyB0aGUgb25lIG9mIEZpcmVmb3ggMjkgYW5k IElFMTEsIGFuZCBzb29uIEJsaW5rOgorICAgICAgICBodHRwczovL2NvZGUuZ29vZ2xlLmNvbS9w L2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MzY5ODAzCisKKyAgICAgICAgVGVzdDogZmFzdC9k b20vSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRlZmF1bHQtYXJndW1lbnQuaHRt bAorCisgICAgICAgICogaHRtbC9IVE1MVGFibGVTZWN0aW9uRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIVE1MVGFibGVTZWN0aW9uRWxlbWVudDo6aW5zZXJ0Um93KToKKyAgICAgICAg KiBodG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9IVE1MVGFi bGVTZWN0aW9uRWxlbWVudC5pZGw6CisKIDIwMTQtMDUtMDUgIEFuZHJlaSBCdWN1ciAgPGFidWN1 ckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTU1JlZ2lvbnNdIFNsaWRlciBkaXNwbGF5ZWQgd3Jv bmcgaW4gcmVnaW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFibGVT ZWN0aW9uRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25F bGVtZW50LmNwcAppbmRleCAzMmI4Mzk2ZjQxMzNmNWZlMjI0NDJlZWU4Y2YwZjQ5NzViOGIyNWZk Li44OGU2YzRiNTc0ZjliYzYwYWNhMzBmY2M1ZGJmZGY0NDFmOWY2MWFiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmNwcApAQCAtNTQsNiArNTQs MTIgQEAgY29uc3QgU3R5bGVQcm9wZXJ0aWVzKiBIVE1MVGFibGVTZWN0aW9uRWxlbWVudDo6YWRk aXRpb25hbFByZXNlbnRhdGlvbkF0dHJpYnV0ZVMKICAgICByZXR1cm4gMDsKIH0KIAorUGFzc1Jl ZlB0cjxIVE1MRWxlbWVudD4gSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQ6Omluc2VydFJvdyhFeGNl cHRpb25Db2RlJiBlYykKK3sKKyAgICAvLyBUaGUgZGVmYXVsdCAnaW5kZXgnIGFyZ3VtZW50IHZh bHVlIGlzIC0xLgorICAgIHJldHVybiBpbnNlcnRSb3coLTEsIGVjKTsKK30KKwogLy8gdGhlc2Ug ZnVuY3Rpb25zIGFyZSByYXRoZXIgc2xvdywgc2luY2Ugd2UgbmVlZCB0byBnZXQgdGhlIHJvdyBh dAogLy8gdGhlIGluZGV4Li4uIGJ1dCB0aGV5IGFyZW4ndCB1c2VkIGR1cmluZyB1c3VhbCBIVE1M IHBhcnNpbmcgYW55d2F5CiBQYXNzUmVmUHRyPEhUTUxFbGVtZW50PiBIVE1MVGFibGVTZWN0aW9u RWxlbWVudDo6aW5zZXJ0Um93KGludCBpbmRleCwgRXhjZXB0aW9uQ29kZSYgZWMpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmgKaW5kZXggNzgyNWU2ODY0 NjI0NWRlMWY2ZjE2MDA1YmM2ODUwZWFhMjVmOGFlMS4uNDRhNmE3YWZiZDY1ZTgwOTdhZTM0ZjE3 YmNkNjY4NDg2MzQzYjNlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFi bGVTZWN0aW9uRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlU2Vj dGlvbkVsZW1lbnQuaApAQCAtMzUsNiArMzUsNyBAQCBjbGFzcyBIVE1MVGFibGVTZWN0aW9uRWxl bWVudCBmaW5hbCA6IHB1YmxpYyBIVE1MVGFibGVQYXJ0RWxlbWVudCB7CiBwdWJsaWM6CiAgICAg c3RhdGljIFBhc3NSZWZQdHI8SFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQ+IGNyZWF0ZShjb25zdCBR dWFsaWZpZWROYW1lJiwgRG9jdW1lbnQmKTsKIAorICAgIFBhc3NSZWZQdHI8SFRNTEVsZW1lbnQ+ IGluc2VydFJvdyhFeGNlcHRpb25Db2RlJik7CiAgICAgUGFzc1JlZlB0cjxIVE1MRWxlbWVudD4g aW5zZXJ0Um93KGludCBpbmRleCwgRXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgZGVsZXRlUm93 KGludCBpbmRleCwgRXhjZXB0aW9uQ29kZSYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQuaWRsCmluZGV4IGM2NmQ4MDZjMjAwZjg3ZjM2Njg1MWE5 MWU3NTBiZjUzYzhkMjIyZWYuLmU5YWUyYTUwMDYzMDY5NzFjODA3Nzg3NjFkZTAyYWRkMzcyODk2 NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlU2VjdGlvbkVsZW1l bnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQu aWRsCkBAIC0yNiw3ICsyNiw3IEBACiAgICAgW1JlZmxlY3Q9Y2hhcm9mZl0gYXR0cmlidXRlIERP TVN0cmluZyBjaE9mZjsKICAgICBbUmVmbGVjdF0gYXR0cmlidXRlIERPTVN0cmluZyB2QWxpZ247 CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhUTUxDb2xsZWN0aW9uIHJvd3M7Ci0gICAgW1JhaXNl c0V4Y2VwdGlvbl0gSFRNTEVsZW1lbnQgaW5zZXJ0Um93KFtEZWZhdWx0PVVuZGVmaW5lZF0gb3B0 aW9uYWwgbG9uZyBpbmRleCk7CisgICAgW1JhaXNlc0V4Y2VwdGlvbl0gSFRNTEVsZW1lbnQgaW5z ZXJ0Um93KG9wdGlvbmFsIGxvbmcgaW5kZXgpOwogICAgIFtSYWlzZXNFeGNlcHRpb25dIHZvaWQg ZGVsZXRlUm93KFtEZWZhdWx0PVVuZGVmaW5lZF0gb3B0aW9uYWwgbG9uZyBpbmRleCk7CiB9Owog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZTkxNmQwYzg3YjAzNTUwODQ4ODk3YzVhYzk4ZDQxNTE4NDJmYjQ4OC4uNzM3NTJm YWE1YjJiMzNlYjI2ODVmMzljZmNjZTEwOWFiNzEyM2QxYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTA1LTA1ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0hUTUxdIERlZmF1bHQgYXJndW1lbnQgdG8gSFRNTFRhYmxlU2VjdGlvbkVsZW1l bnQuaW5zZXJ0Um93KCkgc2hvdWxkIGJlIC0xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0IHRlc3QgdG8gdGVzdCB0aGF0IHRoZSBkZWZh dWx0IGFyZ3VtZW50IHRvCisgICAgICAgIEhUTUxUYWJsZVNlY3Rpb25FbGVtZW50Lmluc2VydFJv dygpIGlzIC0xLgorCisgICAgICAgICogZmFzdC9kb20vSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQv aW5zZXJ0Um93LWRlZmF1bHQtYXJndW1lbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2RvbS9IVE1MVGFibGVTZWN0aW9uRWxlbWVudC9pbnNlcnRSb3ctZGVmYXVsdC1hcmd1 bWVudC5odG1sOiBBZGRlZC4KKwogMjAxNC0wNS0wNSAgQW5kcmVpIEJ1Y3VyICA8YWJ1Y3VyQGFk b2JlLmNvbT4KIAogICAgICAgICBbQ1NTUmVnaW9uc10gU2xpZGVyIGRpc3BsYXllZCB3cm9uZyBp biByZWdpb25zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MVGFibGVTZWN0 aW9uRWxlbWVudC9pbnNlcnRSb3ctZGVmYXVsdC1hcmd1bWVudC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9IVE1MVGFibGVTZWN0aW9uRWxlbWVudC9pbnNlcnRSb3ctZGVmYXVs dC1hcmd1bWVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjQ3MDEyMGM2MjJlMTFjMjgwMGMz YTlmZGUxMWU1Y2RhNzRmMzJlYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50L2luc2VydFJvdy1kZWZhdWx0LWFyZ3VtZW50LWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDE1IEBACitUZXN0cyB0aGF0IEhUTUxUYWJsZVNlY3Rpb25F bGVtZW50Lmluc2VydFJvdygpJ3MgZGVmYXVsdCBhcmd1bWVudCBpcyAtMS4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgdGIuX19wcm90b19fIGlzIEhUTUxUYWJsZVNlY3Rp b25FbGVtZW50LnByb3RvdHlwZQorUEFTUyByb3dzLmxlbmd0aCBpcyA0CitQQVNTIHJvd3NbMF0u aW5uZXJIVE1MIGlzICIwIgorUEFTUyByb3dzWzFdLmlubmVySFRNTCBpcyAiMSIKK1BBU1Mgcm93 c1syXS5pbm5lckhUTUwgaXMgIjIiCitQQVNTIHJvd3NbM10uaW5uZXJIVE1MIGlzICIzIgorUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50L2luc2VydFJv dy1kZWZhdWx0LWFyZ3VtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MVGFibGVT ZWN0aW9uRWxlbWVudC9pbnNlcnRSb3ctZGVmYXVsdC1hcmd1bWVudC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmVhZGRhZTQ2NmRkYjcxZWViYTVlYTQzYzQ0OTEyMDgzYTk3NzM4Y2IKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MVGFibGVTZWN0aW9uRWxlbWVudC9pbnNlcnRS b3ctZGVmYXVsdC1hcmd1bWVudC5odG1sCkBAIC0wLDAgKzEsMjggQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0iaGVscCIgaHJlZj0iaHR0cDovL3d3dy53aGF0 d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2UvdGFidWxhci1kYXRh Lmh0bWwjdGhlLXRib2R5LWVsZW1lbnQiPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+Citk ZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBIVE1MVGFibGVTZWN0aW9uRWxlbWVudC5pbnNlcnRSb3co KSdzIGRlZmF1bHQgYXJndW1lbnQgaXMgLTEuIik7CisKK3ZhciB0YiA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoInRib2R5Iik7CitzaG91bGRCZSgidGIuX19wcm90b19fIiwgIkhUTUxUYWJsZVNl Y3Rpb25FbGVtZW50LnByb3RvdHlwZSIpOworCit0Yi5pbnNlcnRSb3coKS5pbm5lckhUTUwgPSAi MSI7IC8vIFNob3VsZCBhcHBlbmQuCit0Yi5pbnNlcnRSb3coKS5pbm5lckhUTUwgPSAiMiI7IC8v IFNob3VsZCBhcHBlbmQuCit0Yi5pbnNlcnRSb3coLTEpLmlubmVySFRNTCA9ICIzIjsgLy8gU2hv dWxkIGFwcGVuZC4KK3RiLmluc2VydFJvdygwKS5pbm5lckhUTUwgPSAiMCI7IC8vIFNob3VsZCBw cmVwZW5kLgorCit2YXIgcm93cyA9IHRiLnJvd3M7CitzaG91bGRCZSgicm93cy5sZW5ndGgiLCAi NCIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJyb3dzWzBdLmlubmVySFRNTCIsICIwIik7Citz aG91bGRCZUVxdWFsVG9TdHJpbmcoInJvd3NbMV0uaW5uZXJIVE1MIiwgIjEiKTsKK3Nob3VsZEJl RXF1YWxUb1N0cmluZygicm93c1syXS5pbm5lckhUTUwiLCAiMiIpOworc2hvdWxkQmVFcXVhbFRv U3RyaW5nKCJyb3dzWzNdLmlubmVySFRNTCIsICIzIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4K 230915 2014-05-06 10:14:45 -0700 2014-05-06 10:55:08 -0700 Patch bug-132570-20140506131418.patch text/plain 5740 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNiYTljYmZlZTBkNDZh MGQzMWQxOWU5MWQ2MWIwODQ2ZDAxOTdjNC4uYTc2MDVkOGViODhiNDY5NWU1NmQwYmI1ZTY2MjE3 YzUzOGQ1MGE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA1LTA2ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0hUTUxdIERl ZmF1bHQgYXJndW1lbnQgdG8gSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQuaW5zZXJ0Um93KCkgc2hv dWxkIGJlIC0xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzI1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBI VE1MVGFibGVTZWN0aW9uRWxlbWVudC5pbnNlcnRSb3coKSdzIGFyZ3VtZW50IGRlZmF1bHQgdmFs dWUgc2hvdWxkIGJlIC0xLCBub3QKKyAgICAgICAgMCwgYXMgcGVyIHRoZSBzcGVjaWZpY2F0aW9u OgorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13 b3JrL211bHRpcGFnZS90YWJ1bGFyLWRhdGEuaHRtbCN0aGUtdGJvZHktZWxlbWVudAorCisgICAg ICAgIFRoZSBuZXcgYmVoYXZpb3IgbWF0Y2hlcyB0aGUgb25lIG9mIEZpcmVmb3ggMjkgYW5kIElF MTEsIGFuZCBzb29uIEJsaW5rOgorICAgICAgICBodHRwczovL2NvZGUuZ29vZ2xlLmNvbS9wL2No cm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MzY5ODAzCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20v SFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRlZmF1bHQtYXJndW1lbnQuaHRtbAor CisgICAgICAgICogaHRtbC9IVE1MVGFibGVTZWN0aW9uRWxlbWVudC5oOgorICAgICAgICAqIGh0 bWwvSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQuaWRsOgorCiAyMDE0LTA1LTA2ICBDaHJpcyBGbGVp emFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFZvaWNlT3ZlciBkb2Vz IG5vdCBhbm5vdW5jZSB0ZXh0IGNoYW5nZXMgZm9yIGNvbnRlbnQgZWRpdGFibGUgcmVnaW9ucyBp biBTYWZhcmkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlU2VjdGlv bkVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQu aAppbmRleCA3ODI1ZTY4NjQ2MjQ1ZGUxZjZmMTYwMDViYzY4NTBlYWEyNWY4YWUxLi5lOTdlMjkw YWJmMjYzNzc3MTFhMzJjMWU3MTJkMjE1NzhmYzU5YzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGFibGVTZWN0aW9uRWxlbWVudC5oCkBAIC0zNSw2ICszNSw3IEBAIGNsYXNzIEhU TUxUYWJsZVNlY3Rpb25FbGVtZW50IGZpbmFsIDogcHVibGljIEhUTUxUYWJsZVBhcnRFbGVtZW50 IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxIVE1MVGFibGVTZWN0aW9uRWxlbWVu dD4gY3JlYXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCYpOwogCisgICAgUGFzc1Jl ZlB0cjxIVE1MRWxlbWVudD4gaW5zZXJ0Um93KEV4Y2VwdGlvbkNvZGUmIGVjKSB7IHJldHVybiBp bnNlcnRSb3coLTEsIGVjKTsgfQogICAgIFBhc3NSZWZQdHI8SFRNTEVsZW1lbnQ+IGluc2VydFJv dyhpbnQgaW5kZXgsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lkIGRlbGV0ZVJvdyhpbnQgaW5k ZXgsIEV4Y2VwdGlvbkNvZGUmKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MVGFibGVTZWN0aW9uRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJs ZVNlY3Rpb25FbGVtZW50LmlkbAppbmRleCBjNjZkODA2YzIwMGY4N2YzNjY4NTFhOTFlNzUwYmY1 M2M4ZDIyMmVmLi5lOWFlMmE1MDA2MzA2OTcxYzgwNzc4NzYxZGUwMmFkZDM3Mjg5NjY1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50LmlkbApAQCAt MjYsNyArMjYsNyBAQAogICAgIFtSZWZsZWN0PWNoYXJvZmZdIGF0dHJpYnV0ZSBET01TdHJpbmcg Y2hPZmY7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgdkFsaWduOwogICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBIVE1MQ29sbGVjdGlvbiByb3dzOwotICAgIFtSYWlzZXNFeGNlcHRp b25dIEhUTUxFbGVtZW50IGluc2VydFJvdyhbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIGxv bmcgaW5kZXgpOworICAgIFtSYWlzZXNFeGNlcHRpb25dIEhUTUxFbGVtZW50IGluc2VydFJvdyhv cHRpb25hbCBsb25nIGluZGV4KTsKICAgICBbUmFpc2VzRXhjZXB0aW9uXSB2b2lkIGRlbGV0ZVJv dyhbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIGxvbmcgaW5kZXgpOwogfTsKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGRjNzU4OWZjYzlhY2JhOWVlMWQxZDhkM2RlYzQzMTUzYjU2Mjc4YjUuLjc1OTk0ZTA4YzYwZjNm MjA2ZmNjOTgxYTQ4MDcwN2UzMTdkNzRiNDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0w NS0wNiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNoLmR1bWV6QHNhbXN1bmcuY29tPgorCisgICAgICAg IFtIVE1MXSBEZWZhdWx0IGFyZ3VtZW50IHRvIEhUTUxUYWJsZVNlY3Rpb25FbGVtZW50Lmluc2Vy dFJvdygpIHNob3VsZCBiZSAtMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMyNTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisK KyAgICAgICAgQWRkIGxheW91dCB0ZXN0IHRvIHRlc3QgdGhhdCB0aGUgZGVmYXVsdCBhcmd1bWVu dCB0bworICAgICAgICBIVE1MVGFibGVTZWN0aW9uRWxlbWVudC5pbnNlcnRSb3coKSBpcyAtMS4K KworICAgICAgICAqIGZhc3QvZG9tL0hUTUxUYWJsZVNlY3Rpb25FbGVtZW50L2luc2VydFJvdy1k ZWZhdWx0LWFyZ3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20v SFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRlZmF1bHQtYXJndW1lbnQuaHRtbDog QWRkZWQuCisKIDIwMTQtMDUtMDYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv bT4KIAogICAgICAgICBBWDogVm9pY2VPdmVyIGRvZXMgbm90IGFubm91bmNlIHRleHQgY2hhbmdl cyBmb3IgY29udGVudCBlZGl0YWJsZSByZWdpb25zIGluIFNhZmFyaQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRlZmF1 bHQtYXJndW1lbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRhYmxl U2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRlZmF1bHQtYXJndW1lbnQtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjY0NzAxMjBjNjIyZTExYzI4MDBjM2E5ZmRlMTFlNWNkYTc0ZjMyZWMKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MVGFibGVTZWN0aW9uRWxlbWVu dC9pbnNlcnRSb3ctZGVmYXVsdC1hcmd1bWVudC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNSBA QAorVGVzdHMgdGhhdCBIVE1MVGFibGVTZWN0aW9uRWxlbWVudC5pbnNlcnRSb3coKSdzIGRlZmF1 bHQgYXJndW1lbnQgaXMgLTEuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNT IHRiLl9fcHJvdG9fXyBpcyBIVE1MVGFibGVTZWN0aW9uRWxlbWVudC5wcm90b3R5cGUKK1BBU1Mg cm93cy5sZW5ndGggaXMgNAorUEFTUyByb3dzWzBdLmlubmVySFRNTCBpcyAiMCIKK1BBU1Mgcm93 c1sxXS5pbm5lckhUTUwgaXMgIjEiCitQQVNTIHJvd3NbMl0uaW5uZXJIVE1MIGlzICIyIgorUEFT UyByb3dzWzNdLmlubmVySFRNTCBpcyAiMyIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MVGFibGVTZWN0aW9uRWxlbWVudC9pbnNlcnRSb3ctZGVmYXVsdC1hcmd1bWVudC5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRl ZmF1bHQtYXJndW1lbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYWRkYWU0NjZkZGI3MWVlYmE1ZWE0M2M0 NDkxMjA4M2E5NzczOGNiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20v SFRNTFRhYmxlU2VjdGlvbkVsZW1lbnQvaW5zZXJ0Um93LWRlZmF1bHQtYXJndW1lbnQuaHRtbApA QCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayBy ZWw9ImhlbHAiIGhyZWY9Imh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJy ZW50LXdvcmsvbXVsdGlwYWdlL3RhYnVsYXItZGF0YS5odG1sI3RoZS10Ym9keS1lbGVtZW50Ij4K KzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgSFRN TFRhYmxlU2VjdGlvbkVsZW1lbnQuaW5zZXJ0Um93KCkncyBkZWZhdWx0IGFyZ3VtZW50IGlzIC0x LiIpOworCit2YXIgdGIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0Ym9keSIpOworc2hvdWxk QmUoInRiLl9fcHJvdG9fXyIsICJIVE1MVGFibGVTZWN0aW9uRWxlbWVudC5wcm90b3R5cGUiKTsK KwordGIuaW5zZXJ0Um93KCkuaW5uZXJIVE1MID0gIjEiOyAvLyBTaG91bGQgYXBwZW5kLgordGIu aW5zZXJ0Um93KCkuaW5uZXJIVE1MID0gIjIiOyAvLyBTaG91bGQgYXBwZW5kLgordGIuaW5zZXJ0 Um93KC0xKS5pbm5lckhUTUwgPSAiMyI7IC8vIFNob3VsZCBhcHBlbmQuCit0Yi5pbnNlcnRSb3co MCkuaW5uZXJIVE1MID0gIjAiOyAvLyBTaG91bGQgcHJlcGVuZC4KKwordmFyIHJvd3MgPSB0Yi5y b3dzOworc2hvdWxkQmUoInJvd3MubGVuZ3RoIiwgIjQiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmlu Zygicm93c1swXS5pbm5lckhUTUwiLCAiMCIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJyb3dz WzFdLmlubmVySFRNTCIsICIxIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoInJvd3NbMl0uaW5u ZXJIVE1MIiwgIjIiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygicm93c1szXS5pbm5lckhUTUwi LCAiMyIpOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==