132566 2014-05-05 07:18:16 -0700 Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI 2014-05-09 01:44:18 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED AdobeTracked, InRadar P2 Normal --- 57312 1 stavila stavila commit-queue graouts joepeck syoichi timothy webkit-bug-importer oldest_to_newest 1006618 0 stavila 2014-05-05 07:18:16 -0700 Add the regionOversetChange event to the iOS 7.0 WebInspector UI 1006619 1 webkit-bug-importer 2014-05-05 07:18:59 -0700 <rdar://problem/16811884> 1006910 2 230898 stavila 2014-05-06 04:23:58 -0700 Created attachment 230898 Patch 1006925 3 230898 commit-queue 2014-05-06 05:38:21 -0700 Comment on attachment 230898 Patch Clearing flags on attachment: 230898 Committed r168355: <http://trac.webkit.org/changeset/168355> 1006926 4 commit-queue 2014-05-06 05:38:24 -0700 All reviewed patches have been landed. Closing bug. 1006983 5 230898 joepeck 2014-05-06 10:07:38 -0700 Comment on attachment 230898 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230898&action=review > Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json:2192 > + { > + "name": "regionOversetChanged", > + "parameters": [ > + { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow containing the regions whose regionOverset values changed." } > + ], > + "description": "Fires if any of the regionOverset values changed in a Named Flow's region chain." Does adding this to the iOS 7 version actually fix an issue for you inspecting an iOS 7 device? The reason this is not in iOS-7.0 was because it did not exist in iOS 7. This change is not correct, but it is harmless. I think we should back it out. Only InspectorInstrumentation::didUpdateRegionLayout existed in iOS 7, InspectorInstrumentation::didChangeRegionOverset came later and is not in any iOS 7 release, so this event will never happen. 1007253 6 stavila 2014-05-07 01:55:40 -0700 Hi Joe, My mistake, I was under the impression the regionOversetChange event made it into iOS7. I will remove it. And one more thing, I also removed the regionLayoutUpdate event from the entire codebase (including the iOS7 inspector). Should I also add that event back into the iOS7 inspector? (that event actually exists in iOS7) 1007356 7 joepeck 2014-05-07 10:10:10 -0700 (In reply to comment #6) > My mistake, I was under the impression the regionOversetChange event made it into iOS7. Maybe the DOM event existed but the WebInspector hook for the event did not exist. > And one more thing, I also removed the regionLayoutUpdate event from the entire codebase (including the iOS7 inspector). Could you point me to the change you made? I can work back from there to see if it was good or not. 1007417 8 stavila 2014-05-07 13:42:26 -0700 https://bugs.webkit.org/show_bug.cgi?id=132564 1007670 9 joepeck 2014-05-08 10:34:18 -0700 (In reply to comment #8) > https://bugs.webkit.org/show_bug.cgi?id=132564 Thanks for the pointer. Yeah, it looks like we should leave in the bits for handling "regionLayoutUpdate" in the frontend for backwards compatibility and the best debugging experience for iOS 7. More comments in that bug. 1007925 10 stavila 2014-05-09 01:44:18 -0700 Created https://bugs.webkit.org/show_bug.cgi?id=132731 230898 2014-05-06 04:23:58 -0700 2014-05-06 10:07:38 -0700 Patch 132566.patch text/plain 2976 stavila ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc5YzhlNjIuLjJlNjkzNDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTA2ICBSYWR1IFN0YXZpbGEg IDxzdGF2aWxhQGFkb2JlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ1NTIFJlZ2lv bnNdIEFkZCB0aGUgcmVnaW9uT3ZlcnNldENoYW5nZSBldmVudCB0byB0aGUgaU9TIDcuMCBXZWJJ bnNwZWN0b3IgVUkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMjU2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSByZWdpb25PdmVyc2V0Q2hhbmdlIGV2ZW50IHdhcyBtaXNzaW5nIGZyb20gdGhlIGlP UzcgV2ViSW5zcGVjdG9yLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Qcm90b2NvbC9MZWdh Y3kvNy4wL0luc3BlY3RvcldlYkJhY2tlbmRDb21tYW5kcy5qczoKKyAgICAgICAgKiBWZXJzaW9u cy9JbnNwZWN0b3ItaU9TLTcuMC5qc29uOgorCiAyMDE0LTA1LTA1ICBSYWR1IFN0YXZpbGEgIDxz dGF2aWxhQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNdIFJlbW92ZSByZWdpb25M YXlvdXRVcGRhdGUgZXZlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1Byb3RvY29sL0xlZ2FjeS83LjAvSW5zcGVjdG9yV2ViQmFja2VuZENvbW1hbmRz LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvTGVnYWN5 LzcuMC9JbnNwZWN0b3JXZWJCYWNrZW5kQ29tbWFuZHMuanMKaW5kZXggMWJhZGIxOS4uOWQxMTUx MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9j b2wvTGVnYWN5LzcuMC9JbnNwZWN0b3JXZWJCYWNrZW5kQ29tbWFuZHMuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvTGVnYWN5LzcuMC9JbnNwZWN0 b3JXZWJCYWNrZW5kQ29tbWFuZHMuanMKQEAgLTIwMyw2ICsyMDMsNyBAQCBJbnNwZWN0b3JCYWNr ZW5kLnJlZ2lzdGVyRXZlbnQoIkNTUy5tZWRpYVF1ZXJ5UmVzdWx0Q2hhbmdlZCIsIFtdKTsKIElu c3BlY3RvckJhY2tlbmQucmVnaXN0ZXJFdmVudCgiQ1NTLnN0eWxlU2hlZXRDaGFuZ2VkIiwgWyJz dHlsZVNoZWV0SWQiXSk7CiBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyRXZlbnQoIkNTUy5uYW1l ZEZsb3dDcmVhdGVkIiwgWyJuYW1lZEZsb3ciXSk7CiBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVy RXZlbnQoIkNTUy5uYW1lZEZsb3dSZW1vdmVkIiwgWyJkb2N1bWVudE5vZGVJZCIsICJmbG93TmFt ZSJdKTsKK0luc3BlY3RvckJhY2tlbmQucmVnaXN0ZXJFdmVudCgiQ1NTLnJlZ2lvbk92ZXJzZXRD aGFuZ2VkIiwgWyJuYW1lZEZsb3ciXSk7CiBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyQ29tbWFu ZCgiQ1NTLmVuYWJsZSIsIFtdLCBbXSk7CiBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyQ29tbWFu ZCgiQ1NTLmRpc2FibGUiLCBbXSwgW10pOwogSW5zcGVjdG9yQmFja2VuZC5yZWdpc3RlckNvbW1h bmQoIkNTUy5nZXRNYXRjaGVkU3R5bGVzRm9yTm9kZSIsIFt7Im5hbWUiOiAibm9kZUlkIiwgInR5 cGUiOiAibnVtYmVyIiwgIm9wdGlvbmFsIjogZmFsc2V9LCB7Im5hbWUiOiAiaW5jbHVkZVBzZXVk byIsICJ0eXBlIjogImJvb2xlYW4iLCAib3B0aW9uYWwiOiB0cnVlfSwgeyJuYW1lIjogImluY2x1 ZGVJbmhlcml0ZWQiLCAidHlwZSI6ICJib29sZWFuIiwgIm9wdGlvbmFsIjogdHJ1ZX1dLCBbIm1h dGNoZWRDU1NSdWxlcyIsICJwc2V1ZG9FbGVtZW50cyIsICJpbmhlcml0ZWQiXSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy03LjAuanNv biBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTcuMC5qc29u CmluZGV4IDRiYjU3MDIuLmQxYTFmMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTcuMC5qc29uCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTcuMC5qc29uCkBAIC0yMTgzLDYgKzIxODMsMTMg QEAKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJmbG93TmFtZSIsICJ0eXBlIjogInN0 cmluZyIsICJkZXNjcmlwdGlvbiI6ICJJZGVudGlmaWVyIG9mIHRoZSByZW1vdmVkIE5hbWVkIEZs b3cuIiB9CiAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAgICAgICAiZGVzY3JpcHRpb24i OiAiRmlyZXMgd2hlbiBhIE5hbWVkIEZsb3cgaXMgcmVtb3ZlZDogaGFzIG5vIGFzc29jaWF0ZWQg Y29udGVudCBub2RlcyBhbmQgcmVnaW9ucy4iCisgICAgICAgICAgICB9LAorICAgICAgICAgICAg eworICAgICAgICAgICAgICAgICJuYW1lIjogInJlZ2lvbk92ZXJzZXRDaGFuZ2VkIiwKKyAgICAg ICAgICAgICAgICAicGFyYW1ldGVycyI6IFsKKyAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJuYW1lZEZsb3ciLCAiJHJlZiI6ICJOYW1lZEZsb3ciLCAiZGVzY3JpcHRpb24iOiAiVGhlIE5h bWVkIEZsb3cgY29udGFpbmluZyB0aGUgcmVnaW9ucyB3aG9zZSByZWdpb25PdmVyc2V0IHZhbHVl cyBjaGFuZ2VkLiIgfQorICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgImRlc2Ny aXB0aW9uIjogIkZpcmVzIGlmIGFueSBvZiB0aGUgcmVnaW9uT3ZlcnNldCB2YWx1ZXMgY2hhbmdl ZCBpbiBhIE5hbWVkIEZsb3cncyByZWdpb24gY2hhaW4uIgogICAgICAgICAgICAgfQogICAgICAg ICBdCiAgICAgfSwK