132559 2014-05-04 23:49:28 -0700 [Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle 2014-05-05 23:20:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia oldest_to_newest 1006565 0 zan 2014-05-04 23:49:28 -0700 [Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle 1006566 1 230809 zan 2014-05-04 23:59:56 -0700 Created attachment 230809 Patch 1006575 2 230809 cgarcia 2014-05-05 01:11:30 -0700 Comment on attachment 230809 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230809&action=review > Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:87 > - , m_readBuffer(0) > + , m_readBuffer(nullptr) Do we really need to initialize a std:unique_ptr? doesn't it set the internal pointer to 0 in its constructor? > Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:102 > - , m_readBuffer(0) > + , m_readBuffer(nullptr) Ditto. 1006576 3 230809 cgarcia 2014-05-05 01:12:03 -0700 Comment on attachment 230809 Patch Forgot to change the flag :-P 1006878 4 zan 2014-05-05 23:20:35 -0700 Committed r168351: <http://trac.webkit.org/changeset/168351> 230809 2014-05-04 23:59:56 -0700 2014-05-05 01:12:03 -0700 Patch bug-132559-20140504235932.patch text/plain 4627 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODI1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA1LTA0ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbU291cF0gVXNlIHN0ZDo6 dW5pcXVlX3B0cjxjaGFyW10+IGZvciB0aGUgcmVhZCBidWZmZXIgaW4gU29ja2V0U3RyZWFtSGFu ZGxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI1 NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW5h Z2UgdGhlIHJlYWQgYnVmZmVyIGFycmF5IHRocm91Z2ggYSBzdGQ6OnVuaXF1ZV9wdHI8Y2hhcltd PiBvYmplY3QuCisgICAgICAgIFRoaXMgYXZvaWRzIGhhbmRsaW5nIHdpdGggdGhlIHJhdyBwb2lu dGVyIGFuZCBhbHNvIGVuc3VyZXMgdGhhdCB0aGUgbWVtb3J5CisgICAgICAgIGFsbG9jYXRlZCB3 aXRoIHRoZSBuZXdbXSBvcGVyYXRvciBpcyBkZWxldGVkIHdpdGggdGhlIGRlbGV0ZVtdIG9wZXJh dG9yLAorICAgICAgICBhIHByb2JsZW0gZXhwb3NlZCBieSB0aGUgQWRkcmVzc1Nhbml0aXplciBp biBXZWJTb2NrZXQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29j a2V0U3RyZWFtSGFuZGxlLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tl dFN0cmVhbUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFu ZGxlOjpTb2NrZXRTdHJlYW1IYW5kbGUpOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFt SGFuZGxlOjpjb25uZWN0ZWQpOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxl OjpyZWFkQnl0ZXMpOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxlOjpwbGF0 Zm9ybUNsb3NlKToKKwogMjAxNC0wNS0wNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5j b20+CiAKICAgICAgICAgT3B0aW1pemUgSlNSb3BlU3RyaW5nIGZvciByZXNvbHZpbmcgZGlyZWN0 bHkgdG8gQXRvbWljU3RyaW5nLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL1NvY2tldFN0cmVhbUhhbmRsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGUuaAkocmV2aXNpb24gMTY4 MjU2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0cmVh bUhhbmRsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3ICs2Nyw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgR1JlZlB0cjxHSW5wdXRTdHJlYW0+IG1faW5wdXRTdHJlYW07CiAgICAg ICAgIEdSZWZQdHI8R1BvbGxhYmxlT3V0cHV0U3RyZWFtPiBtX291dHB1dFN0cmVhbTsKICAgICAg ICAgR1JlZlB0cjxHU291cmNlPiBtX3dyaXRlUmVhZHlTb3VyY2U7Ci0gICAgICAgIGNoYXIqIG1f cmVhZEJ1ZmZlcjsKKyAgICAgICAgc3RkOjp1bmlxdWVfcHRyPGNoYXJbXT4gbV9yZWFkQnVmZmVy OwogICAgICAgICB2b2lkKiBtX2lkOwogCiAgICAgICAgIFNvY2tldFN0cmVhbUhhbmRsZShjb25z dCBVUkwmLCBTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQqKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGVTb3VwLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFt SGFuZGxlU291cC5jcHAJKHJldmlzaW9uIDE2ODI1NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGVTb3VwLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODQsNyArODQsNyBAQCBzdGF0aWMgdm9pZCogYWN0aXZhdGVIYW5kbGUoU29ja2V0U3Ry ZWFtCiAKIFNvY2tldFN0cmVhbUhhbmRsZTo6U29ja2V0U3RyZWFtSGFuZGxlKGNvbnN0IFVSTCYg dXJsLCBTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQqIGNsaWVudCkKICAgICA6IFNvY2tldFN0cmVh bUhhbmRsZUJhc2UodXJsLCBjbGllbnQpCi0gICAgLCBtX3JlYWRCdWZmZXIoMCkKKyAgICAsIG1f cmVhZEJ1ZmZlcihudWxscHRyKQogewogICAgIExPRyhOZXR3b3JrLCAiU29ja2V0U3RyZWFtSGFu ZGxlICVwIG5ldyBjbGllbnQgJXAiLCB0aGlzLCBtX2NsaWVudCk7CiAgICAgdW5zaWduZWQgaW50 IHBvcnQgPSB1cmwuaGFzUG9ydCgpID8gdXJsLnBvcnQoKSA6ICh1cmwucHJvdG9jb2xJcygid3Nz IikgPyA0NDMgOiA4MCk7CkBAIC05OSw3ICs5OSw3IEBAIFNvY2tldFN0cmVhbUhhbmRsZTo6U29j a2V0U3RyZWFtSGFuZGxlKGMKIAogU29ja2V0U3RyZWFtSGFuZGxlOjpTb2NrZXRTdHJlYW1IYW5k bGUoR1NvY2tldENvbm5lY3Rpb24qIHNvY2tldENvbm5lY3Rpb24sIFNvY2tldFN0cmVhbUhhbmRs ZUNsaWVudCogY2xpZW50KQogICAgIDogU29ja2V0U3RyZWFtSGFuZGxlQmFzZShVUkwoKSwgY2xp ZW50KQotICAgICwgbV9yZWFkQnVmZmVyKDApCisgICAgLCBtX3JlYWRCdWZmZXIobnVsbHB0cikK IHsKICAgICBMT0coTmV0d29yaywgIlNvY2tldFN0cmVhbUhhbmRsZSAlcCBuZXcgY2xpZW50ICVw IiwgdGhpcywgbV9jbGllbnQpOwogICAgIG1faWQgPSBhY3RpdmF0ZUhhbmRsZSh0aGlzKTsKQEAg LTEyNSw4ICsxMjUsOCBAQCB2b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6Y29ubmVjdGVkKEdTb2Nr CiAgICAgbV9vdXRwdXRTdHJlYW0gPSBHX1BPTExBQkxFX09VVFBVVF9TVFJFQU0oZ19pb19zdHJl YW1fZ2V0X291dHB1dF9zdHJlYW0oR19JT19TVFJFQU0obV9zb2NrZXRDb25uZWN0aW9uLmdldCgp KSkpOwogICAgIG1faW5wdXRTdHJlYW0gPSBnX2lvX3N0cmVhbV9nZXRfaW5wdXRfc3RyZWFtKEdf SU9fU1RSRUFNKG1fc29ja2V0Q29ubmVjdGlvbi5nZXQoKSkpOwogCi0gICAgbV9yZWFkQnVmZmVy ID0gbmV3IGNoYXJbUkVBRF9CVUZGRVJfU0laRV07Ci0gICAgZ19pbnB1dF9zdHJlYW1fcmVhZF9h c3luYyhtX2lucHV0U3RyZWFtLmdldCgpLCBtX3JlYWRCdWZmZXIsIFJFQURfQlVGRkVSX1NJWkUs IEdfUFJJT1JJVFlfREVGQVVMVCwgMCwKKyAgICBtX3JlYWRCdWZmZXIgPSBzdGQ6Om1ha2VfdW5p cXVlPGNoYXJbXT4oUkVBRF9CVUZGRVJfU0laRSk7CisgICAgZ19pbnB1dF9zdHJlYW1fcmVhZF9h c3luYyhtX2lucHV0U3RyZWFtLmdldCgpLCBtX3JlYWRCdWZmZXIuZ2V0KCksIFJFQURfQlVGRkVS X1NJWkUsIEdfUFJJT1JJVFlfREVGQVVMVCwgMCwKICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxH QXN5bmNSZWFkeUNhbGxiYWNrPihyZWFkUmVhZHlDYWxsYmFjayksIG1faWQpOwogCiAgICAgbV9z dGF0ZSA9IE9wZW47CkBAIC0xNDcsOSArMTQ3LDkgQEAgdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGU6 OnJlYWRCeXRlcyhzaWduZQogCiAgICAgLy8gVGhlIGNsaWVudCBjYW4gY2xvc2UgdGhlIGhhbmRs ZSwgcG90ZW50aWFsbHkgcmVtb3ZpbmcgdGhlIGxhc3QgcmVmZXJlbmNlLgogICAgIFJlZlB0cjxT b2NrZXRTdHJlYW1IYW5kbGU+IHByb3RlY3QodGhpcyk7IAotICAgIG1fY2xpZW50LT5kaWRSZWNl aXZlU29ja2V0U3RyZWFtRGF0YSh0aGlzLCBtX3JlYWRCdWZmZXIsIGJ5dGVzUmVhZCk7CisgICAg bV9jbGllbnQtPmRpZFJlY2VpdmVTb2NrZXRTdHJlYW1EYXRhKHRoaXMsIG1fcmVhZEJ1ZmZlci5n ZXQoKSwgYnl0ZXNSZWFkKTsKICAgICBpZiAobV9pbnB1dFN0cmVhbSkgLy8gVGhlIGNsaWVudCBt YXkgaGF2ZSBjbG9zZWQgdGhlIGNvbm5lY3Rpb24uCi0gICAgICAgIGdfaW5wdXRfc3RyZWFtX3Jl YWRfYXN5bmMobV9pbnB1dFN0cmVhbS5nZXQoKSwgbV9yZWFkQnVmZmVyLCBSRUFEX0JVRkZFUl9T SVpFLCBHX1BSSU9SSVRZX0RFRkFVTFQsIDAsCisgICAgICAgIGdfaW5wdXRfc3RyZWFtX3JlYWRf YXN5bmMobV9pbnB1dFN0cmVhbS5nZXQoKSwgbV9yZWFkQnVmZmVyLmdldCgpLCBSRUFEX0JVRkZF Ul9TSVpFLCBHX1BSSU9SSVRZX0RFRkFVTFQsIDAsCiAgICAgICAgICAgICByZWludGVycHJldF9j YXN0PEdBc3luY1JlYWR5Q2FsbGJhY2s+KHJlYWRSZWFkeUNhbGxiYWNrKSwgbV9pZCk7CiB9CiAK QEAgLTIwNSw4ICsyMDUsNyBAQCB2b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6cGxhdGZvcm1DbG9z ZSgpCiAKICAgICBtX291dHB1dFN0cmVhbSA9IDA7CiAgICAgbV9pbnB1dFN0cmVhbSA9IDA7Ci0g ICAgZGVsZXRlIG1fcmVhZEJ1ZmZlcjsKLSAgICBtX3JlYWRCdWZmZXIgPSAwOworICAgIG1fcmVh ZEJ1ZmZlciA9IG51bGxwdHI7CiAKICAgICBtX2NsaWVudC0+ZGlkQ2xvc2VTb2NrZXRTdHJlYW0o dGhpcyk7CiB9Cg==