132551 2014-05-04 17:41:31 -0700 REGRESSION (r168244): compositing/visibility/visibility-image-layers-dynamic.html failing. 2014-05-05 12:47:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling bdakin bdakin kling oldest_to_newest 1006517 0 kling 2014-05-04 17:41:31 -0700 Regression from <https://trac.webkit.org/r168244>. --- /Volumes/Data/slave/mountainlion-debug-tests-wk1/build/layout-test-results/compositing/visibility/visibility-image-layers-dynamic-expected.txt +++ /Volumes/Data/slave/mountainlion-debug-tests-wk1/build/layout-test-results/compositing/visibility/visibility-image-layers-dynamic-actual.txt @@ -4,6 +4,7 @@ Initial (GraphicsLayer + (anchor 0.00 0.00) (bounds 785.00 626.00) (children 1 (GraphicsLayer @@ -54,10 +55,11 @@ After step 1 (GraphicsLayer - (bounds 785.00 1366.00) + (anchor 0.00 0.00) + (bounds 785.00 1381.00) (children 1 (GraphicsLayer - (bounds 785.00 1366.00) + (bounds 785.00 1381.00) (contentsOpaque 1) (children 3 (GraphicsLayer @@ -103,10 +105,11 @@ After step 2 (GraphicsLayer - (bounds 785.00 2090.00) + (anchor 0.00 0.00) + (bounds 785.00 2120.00) (children 1 (GraphicsLayer - (bounds 785.00 2090.00) + (bounds 785.00 2120.00) (contentsOpaque 1) (children 3 (GraphicsLayer 1006519 1 kling 2014-05-04 17:44:09 -0700 Marked as failing in <http://trac.webkit.org/changeset/168251> 1006537 2 bdakin 2014-05-04 19:05:21 -0700 Thank you, Andreas! I will consult some folks tomorrow about what to make of how these bounds that seem to historically change a lot throughout the history of the test. 1006697 3 230847 bdakin 2014-05-05 12:37:15 -0700 Created attachment 230847 Patch Oh this is hilarious. Thanks to Simon for figuring this out. The bounds have increased in size because the size of the layer tree dump effects the bounds! So now that we are printing out anchor points, the bound increase by 15 pixels for every new anchor point print-out. Just a re-baseline after all. 1006698 4 230847 thorton 2014-05-05 12:38:36 -0700 Comment on attachment 230847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230847&action=review > LayoutTests/ChangeLog:15 > + * platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Maybe leave a comment in the test? 1006701 5 bdakin 2014-05-05 12:47:31 -0700 (In reply to comment #4) > (From update of attachment 230847 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230847&action=review > > > LayoutTests/ChangeLog:15 > > + * platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: > > Maybe leave a comment in the test? I added one. Thanks, Tim! http://trac.webkit.org/changeset/168310 230847 2014-05-05 12:37:15 -0700 2014-05-05 12:38:36 -0700 Patch for-review.txt text/plain 2780 bdakin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2ODMwOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTA1ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTY4MjQ0KTogY29tcG9zaXRp bmcvdmlzaWJpbGl0eS92aXNpYmlsaXR5LWltYWdlLWxheWVycy1keW5hbWljLmh0bWwgCisgICAg ICAgIGZhaWxpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzI1NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGp1c3QgbmVlZGVkIGEgcmUtYmFzZWxpbmUgYWZ0ZXIgYWxsLiBUaGUgYm91bmRz IGhhdmUgaW5jcmVhc2VkIGluIHNpemUgCisgICAgICAgIGJlY2F1c2UgdGhlIHNpemUgb2YgdGhl IGxheWVyIHRyZWUgZHVtcCBlZmZlY3RzIHRoZSBib3VuZHMhIFNvIG5vdyB0aGF0IHdlIGFyZSAK KyAgICAgICAgcHJpbnRpbmcgb3V0IGFuY2hvciBwb2ludHMsIHRoZSBib3VuZCBpbmNyZWFzZSBi eSAxNSBwaXhlbHMgZm9yIGV2ZXJ5IG5ldyBhbmNob3IgCisgICAgICAgIHBvaW50IHByaW50LW91 dC4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vbWFj L2NvbXBvc2l0aW5nL3Zpc2liaWxpdHkvdmlzaWJpbGl0eS1pbWFnZS1sYXllcnMtZHluYW1pYy1l eHBlY3RlZC50eHQ6CisKIDIwMTQtMDUtMDUgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUu Y29tPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10gUmVtb3ZlIHJlZ2lvbkxheW91dFVwZGF0ZSBl dmVudApJbmRleDogTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNjgzMDApCisrKyBMYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsNyArMTEwLDMgQEAg d2Via2l0Lm9yZy9iLzg4MDQ1IGZhc3QvZG9tL2djLWF0dHJpYnV0ZQogIyBSZWZlcmVuY2UgZXhw ZWN0YXRpb24gZG9lc24ndCBlbmQgdXAgaW4gY29tcG9zaXRpbmcgY29kZSBwYXRoLCBsZWFkaW5n IHRvIGFudGlhbGlhc2luZyBkaWZmZXJlbmNlcy4KIHdlYmtpdC5vcmcvYi8xMzI0MjEgZmFzdC9t dWx0aWNvbC9maXhlZC1zdGFjay5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLSMgUmVncmVz c2lvbiBmcm9tIHIxNjgyNDQ6Ci0jIFRvcCBjb250ZW50IGluc2V0OiBNYXJnaW4gdGlsZXMgc2hv dWxkIG5vdCBkaXNwbGF5IGluIHRoZSBpbnNldCBhcmVhIHdoZW4gcGlubmVkCi0jIHRvIHRoZSB0 b3Agb2YgdGhlIHBhZ2UuCi13ZWJraXQub3JnL2IvMTMyNTUxIGNvbXBvc2l0aW5nL3Zpc2liaWxp dHkvdmlzaWJpbGl0eS1pbWFnZS1sYXllcnMtZHluYW1pYy5odG1sIFsgRmFpbHVyZSBdCkluZGV4 OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvY29tcG9zaXRpbmcvdmlzaWJpbGl0eS92aXNpYmls aXR5LWltYWdlLWxheWVycy1keW5hbWljLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvY29tcG9zaXRpbmcvdmlzaWJpbGl0eS92aXNpYmlsaXR5LWlt YWdlLWxheWVycy1keW5hbWljLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTY4MzAwKQorKysgTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2NvbXBvc2l0aW5nL3Zpc2liaWxpdHkvdmlzaWJpbGl0eS1p bWFnZS1sYXllcnMtZHluYW1pYy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQsNiAr NCw3IEBACiBJbml0aWFsCiAKIChHcmFwaGljc0xheWVyCisgIChhbmNob3IgMC4wMCAwLjAwKQog ICAoYm91bmRzIDc4NS4wMCA2MjYuMDApCiAgIChjaGlsZHJlbiAxCiAgICAgKEdyYXBoaWNzTGF5 ZXIKQEAgLTU0LDEwICs1NSwxMSBAQCBJbml0aWFsCiBBZnRlciBzdGVwIDEKIAogKEdyYXBoaWNz TGF5ZXIKLSAgKGJvdW5kcyA3ODUuMDAgMTM2Ni4wMCkKKyAgKGFuY2hvciAwLjAwIDAuMDApCisg IChib3VuZHMgNzg1LjAwIDEzODEuMDApCiAgIChjaGlsZHJlbiAxCiAgICAgKEdyYXBoaWNzTGF5 ZXIKLSAgICAgIChib3VuZHMgNzg1LjAwIDEzNjYuMDApCisgICAgICAoYm91bmRzIDc4NS4wMCAx MzgxLjAwKQogICAgICAgKGNvbnRlbnRzT3BhcXVlIDEpCiAgICAgICAoY2hpbGRyZW4gMwogICAg ICAgICAoR3JhcGhpY3NMYXllcgpAQCAtMTAzLDEwICsxMDUsMTEgQEAgQWZ0ZXIgc3RlcCAxCiBB ZnRlciBzdGVwIDIKIAogKEdyYXBoaWNzTGF5ZXIKLSAgKGJvdW5kcyA3ODUuMDAgMjA5MC4wMCkK KyAgKGFuY2hvciAwLjAwIDAuMDApCisgIChib3VuZHMgNzg1LjAwIDIxMjAuMDApCiAgIChjaGls ZHJlbiAxCiAgICAgKEdyYXBoaWNzTGF5ZXIKLSAgICAgIChib3VuZHMgNzg1LjAwIDIwOTAuMDAp CisgICAgICAoYm91bmRzIDc4NS4wMCAyMTIwLjAwKQogICAgICAgKGNvbnRlbnRzT3BhcXVlIDEp CiAgICAgICAoY2hpbGRyZW4gMwogICAgICAgICAoR3JhcGhpY3NMYXllcgo=