132542 2014-05-03 23:09:58 -0700 There is no HW_AVAILCPU on FreeBSD, NetBSD, and OpenBSD 2014-05-06 03:58:41 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned benjamin berto cmarcelo commit-queue kwm landry zan oldest_to_newest 1006467 0 lantw44 2014-05-03 23:09:58 -0700 Revision 167815 changes HW_NCPU to HW_AVAILCPU, which causes build failure on FreeBSD with the following message: /home/lantw44/gnome/source/webkit-trunk/Source/WTF/wtf/NumberOfCores.cpp:56:13: error: use of undeclared identifier 'HW_AVAILCPU' HW_AVAILCPU ^ /home/lantw44/gnome/source/webkit-trunk/Source/WTF/wtf/NumberOfCores.cpp:58:43: error: invalid application of 'sizeof' to an incomplete type 'int []' int sysctlResult = sysctl(name, sizeof(name) / sizeof(int), &result, &length, 0, 0); ^~~~~~ 2 errors generated. I run `grep -r HW_AVAILCPU /usr/include` on FreeBSD, NetBSD, OpenBSD, and there is no HW_AVAILCPU. 1006569 1 230810 berto 2014-05-05 00:45:10 -0700 Created attachment 230810 Patch It looks like it should be done using sysconf() as well, like we do in Linux: http://www.freebsd.org/cgi/man.cgi?query=sysconf&sektion=3&n=1 http://www.openbsd.org/cgi-bin/man.cgi?query=sysconf&sektion=3&format=html http://netbsd.gw.com/cgi-bin/man-cgi?sysconf++NetBSD-current Can someone try this patch? 1006582 2 lantw44 2014-05-05 02:09:50 -0700 (In reply to comment #1) > Created an attachment (id=230810) [details] > Patch > > It looks like it should be done using sysconf() as well, like we do in Linux: > > http://www.freebsd.org/cgi/man.cgi?query=sysconf&sektion=3&n=1 > http://www.openbsd.org/cgi-bin/man.cgi?query=sysconf&sektion=3&format=html > http://netbsd.gw.com/cgi-bin/man-cgi?sysconf++NetBSD-current > > Can someone try this patch? #include <unistd.h> is needed to use this patch on FreeBSD. 1006596 3 230819 berto 2014-05-05 04:34:23 -0700 Created attachment 230819 Patch > #include <unistd.h> is needed to use this patch on FreeBSD. Right, here's the updated version. 1006637 4 230819 msaboff 2014-05-05 09:10:54 -0700 Comment on attachment 230819 Patch r=me 1006825 5 lantw44 2014-05-05 19:00:37 -0700 This patch fixes the build problem on FreeBSD. 1006906 6 berto 2014-05-06 03:58:41 -0700 Committed r168353: <http://trac.webkit.org/changeset/168353> 230810 2014-05-05 00:45:10 -0700 2014-05-05 04:34:23 -0700 Patch 132542.diff text/plain 1585 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOThiNGRmOS4uMmViYThkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0wNS0wNSAg QWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFRoZXJlIGlzIG5v IEhXX0FWQUlMQ1BVIG9uIEZyZWVCU0QsIE5ldEJTRCwgYW5kIE9wZW5CU0QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjU0MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBzeXNjb25mKCkgdG8gZ2V0 IHRoZSBudW1iZXIgb2YgcHJvY2Vzc29yIGNvcmVzLgorCisgICAgICAgICogd3RmL051bWJlck9m Q29yZXMuY3BwOgorICAgICAgICAoV1RGOjpudW1iZXJPZlByb2Nlc3NvckNvcmVzKToKKwogMjAx NC0wNS0wNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgT3B0 aW1pemUgSlNSb3BlU3RyaW5nIGZvciByZXNvbHZpbmcgZGlyZWN0bHkgdG8gQXRvbWljU3RyaW5n LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTnVtYmVyT2ZDb3Jlcy5jcHAgYi9Tb3VyY2Uv V1RGL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAppbmRleCA5MWQyOGM4Li4yN2QyYWNlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9OdW1iZXJPZkNvcmVzLmNwcApAQCAtNDgsNyArNDgsNyBAQCBpbnQgbnVtYmVyT2ZQcm9jZXNz b3JDb3JlcygpCiAgICAgaWYgKHNfbnVtYmVyT2ZDb3JlcyA+IDApCiAgICAgICAgIHJldHVybiBz X251bWJlck9mQ29yZXM7CiAKLSNpZiBPUyhEQVJXSU4pIHx8IE9TKE9QRU5CU0QpIHx8IE9TKE5F VEJTRCkgfHwgT1MoRlJFRUJTRCkKKyNpZiBPUyhEQVJXSU4pCiAgICAgdW5zaWduZWQgcmVzdWx0 OwogICAgIHNpemVfdCBsZW5ndGggPSBzaXplb2YocmVzdWx0KTsKICAgICBpbnQgbmFtZVtdID0g ewpAQCAtNTgsNyArNTgsNyBAQCBpbnQgbnVtYmVyT2ZQcm9jZXNzb3JDb3JlcygpCiAgICAgaW50 IHN5c2N0bFJlc3VsdCA9IHN5c2N0bChuYW1lLCBzaXplb2YobmFtZSkgLyBzaXplb2YoaW50KSwg JnJlc3VsdCwgJmxlbmd0aCwgMCwgMCk7CiAKICAgICBzX251bWJlck9mQ29yZXMgPSBzeXNjdGxS ZXN1bHQgPCAwID8gZGVmYXVsdElmVW5hdmFpbGFibGUgOiByZXN1bHQ7Ci0jZWxpZiBPUyhMSU5V WCkgfHwgT1MoQUlYKSB8fCBPUyhTT0xBUklTKQorI2VsaWYgT1MoTElOVVgpIHx8IE9TKEFJWCkg fHwgT1MoU09MQVJJUykgfHwgT1MoT1BFTkJTRCkgfHwgT1MoTkVUQlNEKSB8fCBPUyhGUkVFQlNE KQogICAgIGxvbmcgc3lzY29uZlJlc3VsdCA9IHN5c2NvbmYoX1NDX05QUk9DRVNTT1JTX09OTE4p OwogCiAgICAgc19udW1iZXJPZkNvcmVzID0gc3lzY29uZlJlc3VsdCA8IDAgPyBkZWZhdWx0SWZV bmF2YWlsYWJsZSA6IHN0YXRpY19jYXN0PGludD4oc3lzY29uZlJlc3VsdCk7Cg== 230819 2014-05-05 04:34:23 -0700 2014-05-05 09:10:53 -0700 Patch 132542.diff text/plain 2133 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOThiNGRmOS4uMmViYThkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0wNS0wNSAg QWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFRoZXJlIGlzIG5v IEhXX0FWQUlMQ1BVIG9uIEZyZWVCU0QsIE5ldEJTRCwgYW5kIE9wZW5CU0QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjU0MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBzeXNjb25mKCkgdG8gZ2V0 IHRoZSBudW1iZXIgb2YgcHJvY2Vzc29yIGNvcmVzLgorCisgICAgICAgICogd3RmL051bWJlck9m Q29yZXMuY3BwOgorICAgICAgICAoV1RGOjpudW1iZXJPZlByb2Nlc3NvckNvcmVzKToKKwogMjAx NC0wNS0wNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgT3B0 aW1pemUgSlNSb3BlU3RyaW5nIGZvciByZXNvbHZpbmcgZGlyZWN0bHkgdG8gQXRvbWljU3RyaW5n LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTnVtYmVyT2ZDb3Jlcy5jcHAgYi9Tb3VyY2Uv V1RGL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAppbmRleCA5MWQyOGM4Li41ODA1NDQ2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9OdW1iZXJPZkNvcmVzLmNwcApAQCAtMjYsMTMgKzI2LDEzIEBACiAjaW5jbHVkZSAiY29uZmln LmgiCiAjaW5jbHVkZSAiTnVtYmVyT2ZDb3Jlcy5oIgogCi0jaWYgT1MoREFSV0lOKSB8fCBPUyhP UEVOQlNEKSB8fCBPUyhORVRCU0QpIHx8IE9TKEZSRUVCU0QpCisjaWYgT1MoREFSV0lOKQogI2lu Y2x1ZGUgPHN5cy9wYXJhbS5oPgogLy8gc3lzL3R5cGVzLmggbXVzdCBjb21lIGJlZm9yZSBzeXMv c3lzY3RsLmggYmVjYXVzZSB0aGUgbGF0dGVyIHVzZXMKIC8vIGRhdGEgdHlwZXMgZGVmaW5lZCBp biB0aGUgZm9ybWVyLiBTZWUgc3lzY3RsKDMpIGFuZCBzdHlsZSg5KS4KICNpbmNsdWRlIDxzeXMv dHlwZXMuaD4KICNpbmNsdWRlIDxzeXMvc3lzY3RsLmg+Ci0jZWxpZiBPUyhMSU5VWCkgfHwgT1Mo QUlYKSB8fCBPUyhTT0xBUklTKQorI2VsaWYgT1MoTElOVVgpIHx8IE9TKEFJWCkgfHwgT1MoU09M QVJJUykgfHwgT1MoT1BFTkJTRCkgfHwgT1MoTkVUQlNEKSB8fCBPUyhGUkVFQlNEKQogI2luY2x1 ZGUgPHVuaXN0ZC5oPgogI2VsaWYgT1MoV0lORE9XUykKICNpbmNsdWRlIDx3aW5kb3dzLmg+CkBA IC00OCw3ICs0OCw3IEBAIGludCBudW1iZXJPZlByb2Nlc3NvckNvcmVzKCkKICAgICBpZiAoc19u dW1iZXJPZkNvcmVzID4gMCkKICAgICAgICAgcmV0dXJuIHNfbnVtYmVyT2ZDb3JlczsKIAotI2lm IE9TKERBUldJTikgfHwgT1MoT1BFTkJTRCkgfHwgT1MoTkVUQlNEKSB8fCBPUyhGUkVFQlNEKQor I2lmIE9TKERBUldJTikKICAgICB1bnNpZ25lZCByZXN1bHQ7CiAgICAgc2l6ZV90IGxlbmd0aCA9 IHNpemVvZihyZXN1bHQpOwogICAgIGludCBuYW1lW10gPSB7CkBAIC01OCw3ICs1OCw3IEBAIGlu dCBudW1iZXJPZlByb2Nlc3NvckNvcmVzKCkKICAgICBpbnQgc3lzY3RsUmVzdWx0ID0gc3lzY3Rs KG5hbWUsIHNpemVvZihuYW1lKSAvIHNpemVvZihpbnQpLCAmcmVzdWx0LCAmbGVuZ3RoLCAwLCAw KTsKIAogICAgIHNfbnVtYmVyT2ZDb3JlcyA9IHN5c2N0bFJlc3VsdCA8IDAgPyBkZWZhdWx0SWZV bmF2YWlsYWJsZSA6IHJlc3VsdDsKLSNlbGlmIE9TKExJTlVYKSB8fCBPUyhBSVgpIHx8IE9TKFNP TEFSSVMpCisjZWxpZiBPUyhMSU5VWCkgfHwgT1MoQUlYKSB8fCBPUyhTT0xBUklTKSB8fCBPUyhP UEVOQlNEKSB8fCBPUyhORVRCU0QpIHx8IE9TKEZSRUVCU0QpCiAgICAgbG9uZyBzeXNjb25mUmVz dWx0ID0gc3lzY29uZihfU0NfTlBST0NFU1NPUlNfT05MTik7CiAKICAgICBzX251bWJlck9mQ29y ZXMgPSBzeXNjb25mUmVzdWx0IDwgMCA/IGRlZmF1bHRJZlVuYXZhaWxhYmxlIDogc3RhdGljX2Nh c3Q8aW50PihzeXNjb25mUmVzdWx0KTsK