132539 2014-05-03 19:09:06 -0700 Clear the JSString cache when under memory pressure. 2014-05-03 20:22:35 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue oldest_to_newest 1006444 0 kling 2014-05-03 19:09:06 -0700 The JSString cache is a luxury for fast mapping from StringImpl* to JSString*. We should drop it under memory pressure. 1006445 1 230779 kling 2014-05-03 19:09:38 -0700 Created attachment 230779 Patch 1006446 2 230779 sam 2014-05-03 19:18:38 -0700 Comment on attachment 230779 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230779&action=review > Source/WebCore/platform/MemoryPressureHandler.cpp:112 > + { > + ReliefLogger log("Clearing JS string cache"); > + JSDOMWindow::commonVM().stringCache.clear(); > + } We really need to find a way for this to be less of a layering violation haven. 1006455 3 230779 commit-queue 2014-05-03 20:22:33 -0700 Comment on attachment 230779 Patch Clearing flags on attachment: 230779 Committed r168235: <http://trac.webkit.org/changeset/168235> 1006456 4 commit-queue 2014-05-03 20:22:35 -0700 All reviewed patches have been landed. Closing bug. 230779 2014-05-03 19:09:38 -0700 2014-05-03 20:22:32 -0700 Patch bug-132539.diff text/plain 1574 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZGY3NDEzLi44N2Q1ODZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDUtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIENsZWFyIHRoZSBKU1N0cmluZyBjYWNoZSB3aGVuIHVuZGVyIG1lbW9yeSBwcmVzc3VyZS4K KyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzMjUzOT4KKworICAgICAgICBUaGUgV2Vh a0dDTWFwIHVzZWQgZm9yIGZhc3QgbWFwcGluZyBmcm9tIFN0cmluZ0ltcGwqIHRvIEpTU3RyaW5n KgorICAgICAgICBjYW4gYWN0dWFsbHkgZ2V0IHByZXR0eSBiaWcsIGFuZCBpZiB3ZSBmaW5kIG91 cnNlbHZlcyB1bmRlciBtZW1vcnkKKyAgICAgICAgcHJlc3N1cmUsIGl0J3MgZW50aXJlbHkgaW5l c3NlbnRpYWwuCisKKyAgICAgICAgMS4xIE1CIHByb2dyZXNzaW9uIG9uIE1lbWJ1c3RlcjMuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5UHJl c3N1cmVIYW5kbGVyOjpyZWxlYXNlTWVtb3J5KToKKwogMjAxNC0wNS0wMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4 IEdUSysgYnVpbGQgYWZ0ZXIgcjE2ODIwOS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwCmluZGV4IDQ5M2ViMTMuLjY3NTgyMjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcApA QCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkZvbnQuaCIKICNpbmNsdWRlICJGb250Q2FjaGUu aCIKICNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIKKyNpbmNsdWRlICJKU0RPTVdpbmRvdy5oIgog I2luY2x1ZGUgIk1lbW9yeUNhY2hlLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBh Z2VDYWNoZS5oIgpAQCAtMTA1LDYgKzEwNiwxMSBAQCB2b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxl cjo6cmVsZWFzZU1lbW9yeShib29sIGNyaXRpY2FsKQogICAgICAgICBnY0NvbnRyb2xsZXIoKS5k aXNjYXJkQWxsQ29tcGlsZWRDb2RlKCk7CiAgICAgfQogCisgICAgeworICAgICAgICBSZWxpZWZM b2dnZXIgbG9nKCJDbGVhcmluZyBKUyBzdHJpbmcgY2FjaGUiKTsKKyAgICAgICAgSlNET01XaW5k b3c6OmNvbW1vblZNKCkuc3RyaW5nQ2FjaGUuY2xlYXIoKTsKKyAgICB9CisKICAgICBwbGF0Zm9y bVJlbGVhc2VNZW1vcnkoY3JpdGljYWwpOwogCiAgICAgewo=