132521 2014-05-02 22:54:39 -0700 Subpixel rendering: Fieldset legend has a horizontal line through, when the fieldset is painted on odd device pixel position. 2014-05-03 09:12:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1006314 0 zalan 2014-05-02 22:54:39 -0700 see fast/forms/fieldset-align.htm 1006315 1 zalan 2014-05-02 22:55:20 -0700 <rdar://problem/16803305> 1006317 2 230747 zalan 2014-05-02 23:02:34 -0700 Created attachment 230747 Patch 1006324 3 230747 commit-queue 2014-05-03 00:48:07 -0700 Comment on attachment 230747 Patch Clearing flags on attachment: 230747 Committed r168221: <http://trac.webkit.org/changeset/168221> 1006325 4 commit-queue 2014-05-03 00:48:10 -0700 All reviewed patches have been landed. Closing bug. 1006340 5 mmaxfield 2014-05-03 05:00:00 -0700 The existing fieldset test only runs at 1x, and therefore doesn't cover this. It would be useful to create a 2x test to make sure this stays fixed. 1006344 6 zalan 2014-05-03 09:12:00 -0700 (In reply to comment #5) > The existing fieldset test only runs at 1x, and therefore doesn't cover this. It would be useful to create a 2x test to make sure this stays fixed. Indeed. bug 132524 230747 2014-05-02 23:02:34 -0700 2014-05-03 00:48:07 -0700 Patch bug-132521-20140502230212.patch text/plain 3044 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZlMjc0MTlkODkzYTc2 ODIxMTA0YzcxZDNmOTIyNzVmNjNhM2U1ZC4uMTAyZDVkNDc4MzdmMTc3M2IzODJkNjQ2MzlkYWIx NmMzOGZkZjgyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA1LTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBGaWVsZHNldCBsZWdlbmQgaGFzIGEgaG9yaXpvbnRhbCBsaW5lIHRocm91Z2gsIHdoZW4gdGhl IGZpZWxkc2V0IGlzIHBhaW50ZWQgb24gb2RkIGRldmljZSBwaXhlbCBwb3NpdGlvbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjUyMQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTY4MDMzMDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIGRldmljZSBwaXhlbCBzbmFwcGluZyB3aGVuIHRoZSBm aWVsZHNldCdzIGJvcmRlciBnZXRzIGNsaXBwZWQgb3V0IGZvciB0aGUgbGVnZW5kJ3MgdGV4dC4g SXQgZW5zdXJlcyB0aGF0CisgICAgICAgIHRoZSBkZXZpY2UgcGl4ZWwgc25hcHBlZCBib3JkZXIg Z2V0cyBwcm9wZXJseSBjbGlwcGVkIG91dC4KKworICAgICAgICBFeGlzdGluZyBmaWVsZHNldCB0 ZXN0cyBjb3ZlciBpdC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGaWVsZHNldC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGaWVsZHNldDo6cGFpbnRCb3hEZWNvcmF0aW9ucyk6 CisKKzIwMTQtMDUtMDIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKwogICAgICAg ICBDb2RlQ2xlYW51cDogUmVtb3ZlICpNYWludGFpbnNQaXhlbEFsaWdubWVudCBmcm9tIEdyYXBo aWNzTGF5ZXIqLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMyNTAxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG aWVsZHNldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmllbGRzZXQuY3Bw CmluZGV4IGNiNjdjOGNhY2RmMGMwMzNlM2JhYWRkZTI0MDAzYWVjYTdkZmM5MmQuLjY5ZDA3ODg5 MDY3OTRmNGQ4NmFiY2U4MTI0NmE3MDMxODJjNDBhYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGaWVsZHNldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckZpZWxkc2V0LmNwcApAQCAtMTc0LDE1ICsxNzQsMTkgQEAgdm9pZCBSZW5k ZXJGaWVsZHNldDo6cGFpbnRCb3hEZWNvcmF0aW9ucyhQYWludEluZm8mIHBhaW50SW5mbywgY29u c3QgTGF5b3V0UG9pbnQKICAgICAvLyBGSVhNRTogV2UgbmVlZCB0byB3b3JrIHdpdGggInJsIiBh bmQgImJ0IiBibG9jayBmbG93IGRpcmVjdGlvbnMuICBJbiB0aG9zZQogICAgIC8vIGNhc2VzIHRo ZSBsZWdlbmQgaXMgZW1iZWRkZWQgaW4gdGhlIHJpZ2h0IGFuZCBib3R0b20gYm9yZGVycyByZXNw ZWN0aXZlbHkuCiAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ3MjM2CisgICAgTGF5b3V0UmVjdCBjbGlwUmVjdDsKICAgICBpZiAoc3R5bGUoKS5pc0hvcml6 b250YWxXcml0aW5nTW9kZSgpKSB7Ci0gICAgICAgIExheW91dFVuaXQgY2xpcFRvcCA9IHBhaW50 UmVjdC55KCk7Ci0gICAgICAgIExheW91dFVuaXQgY2xpcEhlaWdodCA9IHN0ZDo6bWF4PExheW91 dFVuaXQ+KHN0eWxlKCkuYm9yZGVyVG9wV2lkdGgoKSwgbGVnZW5kLT5oZWlnaHQoKSAtICgobGVn ZW5kLT5oZWlnaHQoKSAtIGJvcmRlclRvcCgpKSAvIDIpKTsKLSAgICAgICAgZ3JhcGhpY3NDb250 ZXh0LT5jbGlwT3V0KHBpeGVsU25hcHBlZEludFJlY3QocGFpbnRSZWN0LngoKSArIGxlZ2VuZC0+ eCgpLCBjbGlwVG9wLCBsZWdlbmQtPndpZHRoKCksIGNsaXBIZWlnaHQpKTsKKyAgICAgICAgY2xp cFJlY3Quc2V0WChwYWludFJlY3QueCgpICsgbGVnZW5kLT54KCkpOworICAgICAgICBjbGlwUmVj dC5zZXRZKHBhaW50UmVjdC55KCkpOworICAgICAgICBjbGlwUmVjdC5zZXRXaWR0aChsZWdlbmQt PndpZHRoKCkpOworICAgICAgICBjbGlwUmVjdC5zZXRIZWlnaHQoc3RkOjptYXg8TGF5b3V0VW5p dD4oc3R5bGUoKS5ib3JkZXJUb3BXaWR0aCgpLCBsZWdlbmQtPmhlaWdodCgpIC0gKChsZWdlbmQt PmhlaWdodCgpIC0gYm9yZGVyVG9wKCkpIC8gMikpKTsKICAgICB9IGVsc2UgewotICAgICAgICBM YXlvdXRVbml0IGNsaXBMZWZ0ID0gcGFpbnRSZWN0LngoKTsKLSAgICAgICAgTGF5b3V0VW5pdCBj bGlwV2lkdGggPSBzdGQ6Om1heDxMYXlvdXRVbml0PihzdHlsZSgpLmJvcmRlckxlZnRXaWR0aCgp LCBsZWdlbmQtPndpZHRoKCkpOwotICAgICAgICBncmFwaGljc0NvbnRleHQtPmNsaXBPdXQocGl4 ZWxTbmFwcGVkSW50UmVjdChjbGlwTGVmdCwgcGFpbnRSZWN0LnkoKSArIGxlZ2VuZC0+eSgpLCBj bGlwV2lkdGgsIGxlZ2VuZC0+aGVpZ2h0KCkpKTsKKyAgICAgICAgY2xpcFJlY3Quc2V0WChwYWlu dFJlY3QueCgpKTsKKyAgICAgICAgY2xpcFJlY3Quc2V0WShwYWludFJlY3QueSgpICsgbGVnZW5k LT55KCkpOworICAgICAgICBjbGlwUmVjdC5zZXRXaWR0aChzdGQ6Om1heDxMYXlvdXRVbml0Pihz dHlsZSgpLmJvcmRlckxlZnRXaWR0aCgpLCBsZWdlbmQtPndpZHRoKCkpKTsKKyAgICAgICAgY2xp cFJlY3Quc2V0SGVpZ2h0KGxlZ2VuZC0+aGVpZ2h0KCkpOwogICAgIH0KKyAgICBncmFwaGljc0Nv bnRleHQtPmNsaXBPdXQocGl4ZWxTbmFwcGVkRm9yUGFpbnRpbmcoY2xpcFJlY3QsIGRvY3VtZW50 KCkuZGV2aWNlU2NhbGVGYWN0b3IoKSkpOwogCiAgICAgcGFpbnRCb3JkZXIocGFpbnRJbmZvLCBw YWludFJlY3QsIHN0eWxlKCkpOwogfQo=