132490 2014-05-02 14:43:22 -0700 Remove Blob contentDisposition handling 2014-05-02 15:42:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 1006165 0 ap 2014-05-02 14:43:22 -0700 We have a lot of code to pass Content-Disposition as part of Blob, and even code to use it, but we never set it. Reading File and XMLHttpRequest specs, it doesn't appear like there is any situation where we are supposed to set it. 1006182 1 230707 ap 2014-05-02 15:20:25 -0700 Created attachment 230707 proposed patch 1006190 2 ap 2014-05-02 15:42:07 -0700 Committed <http://trac.webkit.org/r168201>. 230707 2014-05-02 15:20:25 -0700 2014-05-02 15:39:30 -0700 proposed patch ContentDisposition.txt text/plain 7461 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODE5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA1LTAyICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBCbG9iIGNvbnRl bnREaXNwb3NpdGlvbiBoYW5kbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMyNDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRGVhZCBjb2RlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9C bG9iRGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6QmxvYkRhdGE6OmNvbnRlbnREaXNwb3NpdGlv bik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpCbG9iRGF0YTo6c2V0Q29udGVudERpc3Bv c2l0aW9uKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0Jsb2JSZWdpc3Ry eUltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QmxvYlJlZ2lzdHJ5SW1wbDo6cmVnaXN0ZXJC bG9iVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OkJsb2JSZWdpc3RyeUltcGw6OnJlZ2lzdGVyQmxv YlVSTEZvclNsaWNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0Jsb2JSZXNvdXJjZUhh bmRsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCbG9iUmVzb3VyY2VIYW5kbGU6Om5vdGlmeVJl c3BvbnNlT25TdWNjZXNzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0Jsb2JTdG9yYWdl RGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6QmxvYlN0b3JhZ2VEYXRhOjpjcmVhdGUpOgorICAg ICAgICAoV2ViQ29yZTo6QmxvYlN0b3JhZ2VEYXRhOjpjb250ZW50VHlwZSk6CisgICAgICAgIChX ZWJDb3JlOjpCbG9iU3RvcmFnZURhdGE6OkJsb2JTdG9yYWdlRGF0YSk6CisgICAgICAgIChXZWJD b3JlOjpCbG9iU3RvcmFnZURhdGE6OmNvbnRlbnREaXNwb3NpdGlvbik6IERlbGV0ZWQuCisKIDIw MTQtMDUtMDIgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAg W2lPU10gZGV2aWNlU2NhbGVGYWN0b3IgaXMgYmVpbmcgZG91YmxlLWFwcGxpZWQgd2hlbiByZW5k ZXJpbmcgY2FwdGlvbnMgaW4gZnVsbCBzY3JlZW4gbW9kZQpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9CbG9iRGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvQmxvYkRhdGEuaAkocmV2aXNpb24gMTY4MTgzKQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9CbG9iRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0x NjcsOSArMTY3LDYgQEAgcHVibGljOgogICAgIGNvbnN0IFN0cmluZyYgY29udGVudFR5cGUoKSBj b25zdCB7IHJldHVybiBtX2NvbnRlbnRUeXBlOyB9CiAgICAgdm9pZCBzZXRDb250ZW50VHlwZShj b25zdCBTdHJpbmcmKTsKIAotICAgIGNvbnN0IFN0cmluZyYgY29udGVudERpc3Bvc2l0aW9uKCkg Y29uc3QgeyByZXR1cm4gbV9jb250ZW50RGlzcG9zaXRpb247IH0KLSAgICB2b2lkIHNldENvbnRl bnREaXNwb3NpdGlvbihjb25zdCBTdHJpbmcmIGNvbnRlbnREaXNwb3NpdGlvbikgeyBtX2NvbnRl bnREaXNwb3NpdGlvbiA9IGNvbnRlbnREaXNwb3NpdGlvbjsgfQotCiAgICAgY29uc3QgQmxvYkRh dGFJdGVtTGlzdCYgaXRlbXMoKSBjb25zdCB7IHJldHVybiBtX2l0ZW1zOyB9CiAgICAgdm9pZCBz d2FwSXRlbXMoQmxvYkRhdGFJdGVtTGlzdCYpOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL0Jsb2JSZWdpc3RyeUltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvQmxvYlJlZ2lzdHJ5SW1wbC5jcHAJKHJldmlzaW9uIDE2 ODE4MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvQmxvYlJlZ2lzdHJ5SW1w bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMSw3ICsxMjEsNyBAQCB1bnNpZ25lZCBsb25nIGxv bmcgQmxvYlJlZ2lzdHJ5SW1wbDo6cmVnCiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAg ICByZWdpc3RlckJsb2JSZXNvdXJjZUhhbmRsZUNvbnN0cnVjdG9yKCk7CiAKLSAgICBSZWZQdHI8 QmxvYlN0b3JhZ2VEYXRhPiBibG9iU3RvcmFnZURhdGEgPSBCbG9iU3RvcmFnZURhdGE6OmNyZWF0 ZShibG9iRGF0YS0+Y29udGVudFR5cGUoKSwgYmxvYkRhdGEtPmNvbnRlbnREaXNwb3NpdGlvbigp KTsKKyAgICBSZWZQdHI8QmxvYlN0b3JhZ2VEYXRhPiBibG9iU3RvcmFnZURhdGEgPSBCbG9iU3Rv cmFnZURhdGE6OmNyZWF0ZShibG9iRGF0YS0+Y29udGVudFR5cGUoKSk7CiAKICAgICAvLyBUaGUg YmxvYiBkYXRhIGlzIHN0b3JlZCBpbiB0aGUgImNhbm9uaWNhbCIgd2F5LiBUaGF0IGlzLCBpdCBv bmx5IGNvbnRhaW5zIGEgbGlzdCBvZiBEYXRhIGFuZCBGaWxlIGl0ZW1zLgogICAgIC8vIDEpIFRo ZSBEYXRhIGl0ZW0gaXMgZGVub3RlZCBieSB0aGUgcmF3IGRhdGEgYW5kIHRoZSByYW5nZS4KQEAg LTIwOCw3ICsyMDgsNyBAQCB1bnNpZ25lZCBsb25nIGxvbmcgQmxvYlJlZ2lzdHJ5SW1wbDo6cmVn CiAgICAgICAgIGVuZCA9IG9yaWdpbmFsU2l6ZTsKIAogICAgIHVuc2lnbmVkIGxvbmcgbG9uZyBu ZXdMZW5ndGggPSBlbmQgLSBzdGFydDsKLSAgICBSZWZQdHI8QmxvYlN0b3JhZ2VEYXRhPiBuZXdT dG9yYWdlRGF0YSA9IEJsb2JTdG9yYWdlRGF0YTo6Y3JlYXRlKG9yaWdpbmFsU3RvcmFnZURhdGEt PmNvbnRlbnRUeXBlKCksIG9yaWdpbmFsU3RvcmFnZURhdGEtPmNvbnRlbnREaXNwb3NpdGlvbigp KTsKKyAgICBSZWZQdHI8QmxvYlN0b3JhZ2VEYXRhPiBuZXdTdG9yYWdlRGF0YSA9IEJsb2JTdG9y YWdlRGF0YTo6Y3JlYXRlKG9yaWdpbmFsU3RvcmFnZURhdGEtPmNvbnRlbnRUeXBlKCkpOwogCiAg ICAgYXBwZW5kU3RvcmFnZUl0ZW1zKG5ld1N0b3JhZ2VEYXRhLmdldCgpLCBvcmlnaW5hbFN0b3Jh Z2VEYXRhLT5pdGVtcygpLCBzdGFydCwgbmV3TGVuZ3RoKTsKIApJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9CbG9iUmVzb3VyY2VIYW5kbGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvQmxvYlJlc291cmNlSGFuZGxlLmNwcAko cmV2aXNpb24gMTY4MTgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9CbG9i UmVzb3VyY2VIYW5kbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01ODIsOCArNTgyLDkgQEAgdm9p ZCBCbG9iUmVzb3VyY2VIYW5kbGU6Om5vdGlmeVJlc3BvbnNlTwogICAgIHJlc3BvbnNlLnNldEV4 cGVjdGVkQ29udGVudExlbmd0aChtX3RvdGFsUmVtYWluaW5nU2l6ZSk7CiAgICAgcmVzcG9uc2Uu c2V0SFRUUFN0YXR1c0NvZGUoaXNSYW5nZVJlcXVlc3QgPyBodHRwUGFydGlhbENvbnRlbnQgOiBo dHRwT0spOwogICAgIHJlc3BvbnNlLnNldEhUVFBTdGF0dXNUZXh0KGlzUmFuZ2VSZXF1ZXN0ID8g aHR0cFBhcnRpYWxDb250ZW50VGV4dCA6IGh0dHBPS1RleHQpOwotICAgIGlmICghbV9ibG9iRGF0 YS0+Y29udGVudERpc3Bvc2l0aW9uKCkuaXNFbXB0eSgpKQotICAgICAgICByZXNwb25zZS5zZXRI VFRQSGVhZGVyRmllbGQoIkNvbnRlbnQtRGlzcG9zaXRpb24iLCBtX2Jsb2JEYXRhLT5jb250ZW50 RGlzcG9zaXRpb24oKSk7CisgICAgLy8gRklYTUU6IElmIGEgcmVzb3VyY2UgaWRlbnRpZmllZCB3 aXRoIGEgYmxvYjogVVJMIGlzIGEgRmlsZSBvYmplY3QsIHVzZXIgYWdlbnRzIG11c3QgdXNlIHRo YXQgZmlsZSdzIG5hbWUgYXR0cmlidXRlLAorICAgIC8vIGFzIGlmIHRoZSByZXNwb25zZSBoYWQg YSBDb250ZW50LURpc3Bvc2l0aW9uIGhlYWRlciB3aXRoIHRoZSBmaWxlbmFtZSBwYXJhbWV0ZXIg c2V0IHRvIHRoZSBGaWxlJ3MgbmFtZSBhdHRyaWJ1dGUuCisgICAgLy8gTm90YWJseSwgdGhpcyB3 aWxsIGFmZmVjdCBhIG5hbWUgc3VnZ2VzdGVkIGluICJGaWxlIFNhdmUgQXMiLgogCiAgICAgLy8g QmxvYlJlc291cmNlSGFuZGxlIGNhbm5vdCBiZSB1c2VkIHdpdGggZG93bmxvYWRpbmcsIGFuZCBk b2Vzbid0IGV2ZW4gd2FpdCBmb3IgY29udGludWVEaWRSZWNlaXZlUmVzcG9uc2UuCiAgICAgLy8g SXQncyBjdXJyZW50bHkgY2xpZW50J3MgcmVzcG9uc2liaWxpdHkgdG8ga25vdyB0aGF0IGRpZFJl Y2VpdmVSZXNwb25zZUFzeW5jIGNhbm5vdCBiZSB1c2VkIHRvIGNvbnZlcnQgYQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9CbG9iU3RvcmFnZURhdGEuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Jsb2JTdG9yYWdlRGF0YS5oCShy ZXZpc2lvbiAxNjgxODMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Jsb2JT dG9yYWdlRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSwyMiArMzksMjAgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogCiBjbGFzcyBCbG9iU3RvcmFnZURhdGEgOiBwdWJsaWMgUmVmQ291bnRlZDxC bG9iU3RvcmFnZURhdGE+IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxCbG9iU3Rv cmFnZURhdGE+IGNyZWF0ZShjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlLCBjb25zdCBTdHJpbmcm IGNvbnRlbnREaXNwb3NpdGlvbikKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxCbG9iU3RvcmFnZURh dGE+IGNyZWF0ZShjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlKQogICAgIHsKLSAgICAgICAgcmV0 dXJuIGFkb3B0UmVmKG5ldyBCbG9iU3RvcmFnZURhdGEoY29udGVudFR5cGUsIGNvbnRlbnREaXNw b3NpdGlvbikpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEJsb2JTdG9yYWdlRGF0YShj b250ZW50VHlwZSkpOwogICAgIH0KIAogICAgIGNvbnN0IFN0cmluZyYgY29udGVudFR5cGUoKSBj b25zdCB7IHJldHVybiBtX2RhdGEuY29udGVudFR5cGUoKTsgfQotICAgIGNvbnN0IFN0cmluZyYg Y29udGVudERpc3Bvc2l0aW9uKCkgY29uc3QgeyByZXR1cm4gbV9kYXRhLmNvbnRlbnREaXNwb3Np dGlvbigpOyB9ICAgIAogICAgIGNvbnN0IEJsb2JEYXRhSXRlbUxpc3QmIGl0ZW1zKCkgY29uc3Qg eyByZXR1cm4gbV9kYXRhLml0ZW1zKCk7IH0KIAogcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3Mg QmxvYlJlZ2lzdHJ5SW1wbDsKIAotICAgIEJsb2JTdG9yYWdlRGF0YShjb25zdCBTdHJpbmcmIGNv bnRlbnRUeXBlLCBjb25zdCBTdHJpbmcmIGNvbnRlbnREaXNwb3NpdGlvbikKKyAgICBCbG9iU3Rv cmFnZURhdGEoY29uc3QgU3RyaW5nJiBjb250ZW50VHlwZSkKICAgICB7CiAgICAgICAgIG1fZGF0 YS5zZXRDb250ZW50VHlwZShjb250ZW50VHlwZSk7Ci0gICAgICAgIG1fZGF0YS5zZXRDb250ZW50 RGlzcG9zaXRpb24oY29udGVudERpc3Bvc2l0aW9uKTsKICAgICB9CiAKICAgICBCbG9iRGF0YSBt X2RhdGE7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjgxOTMpCisrKyBTb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wNS0wMiAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgQmxv YiBjb250ZW50RGlzcG9zaXRpb24gaGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0ZpbGVBUEkvQmxvYlJlZ2lzdHJhdGlvbkRh dGEuY3BwOgorICAgICAgICAoV2ViS2l0OjpCbG9iUmVnaXN0cmF0aW9uRGF0YTo6ZW5jb2RlKToK KyAgICAgICAgKFdlYktpdDo6QmxvYlJlZ2lzdHJhdGlvbkRhdGE6OmRlY29kZSk6CisKIDIwMTQt MDUtMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBD bGVhbiB1cCBGb3JtRGF0YUVsZW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9GaWxl QVBJL0Jsb2JSZWdpc3RyYXRpb25EYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvRmlsZUFQSS9CbG9iUmVnaXN0cmF0aW9uRGF0YS5jcHAJKHJldmlzaW9uIDE2ODE4 MykKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9GaWxlQVBJL0Jsb2JSZWdpc3RyYXRpb25EYXRh LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMsNiBAQCBzdGQ6OnVuaXF1ZV9wdHI8Qmxv YkRhdGE+IEJsb2JSZWdpc3RyYXRpCiB2b2lkIEJsb2JSZWdpc3RyYXRpb25EYXRhOjplbmNvZGUo SVBDOjpBcmd1bWVudEVuY29kZXImIGVuY29kZXIpIGNvbnN0CiB7CiAgICAgZW5jb2RlciA8PCBt X2RhdGEtPmNvbnRlbnRUeXBlKCk7Ci0gICAgZW5jb2RlciA8PCBtX2RhdGEtPmNvbnRlbnREaXNw b3NpdGlvbigpOwogCiAgICAgY29uc3QgQmxvYkRhdGFJdGVtTGlzdCYgaXRlbXMgPSBtX2RhdGEt Pml0ZW1zKCk7CiAgICAgZW5jb2RlciA8PCBzdGF0aWNfY2FzdDx1aW50NjRfdD4oaXRlbXMuc2l6 ZSgpKTsKQEAgLTExNCwxMSArMTEzLDYgQEAgYm9vbCBCbG9iUmVnaXN0cmF0aW9uRGF0YTo6ZGVj b2RlKElQQzo6QQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgcmVzdWx0Lm1fZGF0YS0+c2V0 Q29udGVudFR5cGUoY29udGVudFR5cGUpOwogCi0gICAgU3RyaW5nIGNvbnRlbnREaXNwb3NpdGlv bjsKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGNvbnRlbnREaXNwb3NpdGlvbikpCi0gICAgICAg IHJldHVybiBmYWxzZTsKLSAgICByZXN1bHQubV9kYXRhLT5zZXRDb250ZW50RGlzcG9zaXRpb24o Y29udGVudERpc3Bvc2l0aW9uKTsKLQogICAgIHVpbnQ2NF90IGl0ZW1Db3VudDsKICAgICBpZiAo IWRlY29kZXIuZGVjb2RlKGl0ZW1Db3VudCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK