132489 2014-05-02 14:29:13 -0700 [Mac] -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snapshot will always succeed 2014-05-02 15:04:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrowe mrowe oldest_to_newest 1006153 0 mrowe 2014-05-02 14:29:13 -0700 The takeSnapshot callback in -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking the snapshot will always succeed. If it fails and the callback receives a null ShareableBitmap::Handle, as can happen if the WKView is closed while a snapshot request is pending, the callback will dereference null. 1006154 1 mrowe 2014-05-02 14:29:29 -0700 <rdar://problem/16704660> 1006159 2 230702 mrowe 2014-05-02 14:37:04 -0700 Created attachment 230702 Patch 1006173 3 mrowe 2014-05-02 15:04:32 -0700 Committed r168195: <http://trac.webkit.org/changeset/168195> 230702 2014-05-02 14:37:04 -0700 2014-05-02 14:48:16 -0700 Patch bug-132489-20140502143634.patch text/plain 1836 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDJjYzdlYWU4YzkxMjc5 NjliODI4YzkwNGQ5YzUxOGQzYjNkMDYxNi4uYmRmMjI3MmY0YzdjMThiNzhjOWJjMGNkODgxYWNj YWJiYjMwMjU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTAyICBNYXJr IFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CisKKyAgICAgICAgLVtfV0tUaHVtYm5haWxWaWV3IF9y ZXF1ZXN0U25hcHNob3RJZk5lZWRlZF0gYXNzdW1lcyB0aGF0IHRha2luZyBhIHNuYXBzaG90IHdp bGwgYWx3YXlzIHN1Y2NlZWQKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzMjQ4OT4g LyA8cmRhcjovL3Byb2JsZW0vMTY3MDQ2NjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZp ZXcubW06CisgICAgICAgICgtW19XS1RodW1ibmFpbFZpZXcgX3JlcXVlc3RTbmFwc2hvdElmTmVl ZGVkXSk6IERvbid0IGF0dGVtcHQgdG8gY3JlYXRlIGEgQ0dJbWFnZVJlZiBpZiB3ZSBmYWlsZWQK KyAgICAgICAgdG8gY3JlYXRlIGEgU2hhcmVhYmxlQml0bWFwLiBUaGlzIGhhbmRsZXMgYm90aCB0 aGUgY2FsbGJhY2sgcmVjZWl2aW5nIGEgbnVsbCBIYW5kbGUgYW5kIGEgZmFpbHVyZQorICAgICAg ICB3aXRoaW4gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGUuCisKIDIwMTQtMDQtMzAgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbCBvdXQgZml4IGZvciBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNjM3OgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3Lm1t IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3Lm1t CmluZGV4IDg3Njc2MzI0ZmY1ZmE5NDU1NjRlOGQ1NTdiNThjY2E4NzMyMGQ3ZmQuLmFkMWUyZTM4 OWMxZmJmZGQ4MWJiZDkxODcyMTc4MGVlNDRhOGVlOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KQEAgLTEzMSw3 ICsxMzEsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogICAgIF9sYXN0U25hcHNob3RTY2Fs ZSA9IF9zY2FsZTsKICAgICBfd2ViUGFnZVByb3h5LT50YWtlU25hcHNob3Qoc25hcHNob3RSZWN0 LCBiaXRtYXBTaXplLCBvcHRpb25zLCBbdGh1bWJuYWlsVmlld10oYm9vbCwgY29uc3QgU2hhcmVh YmxlQml0bWFwOjpIYW5kbGUmIGltYWdlSGFuZGxlKSB7CiAgICAgICAgIFJlZlB0cjxTaGFyZWFi bGVCaXRtYXA+IGJpdG1hcCA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlKGltYWdlSGFuZGxlLCBT aGFyZWRNZW1vcnk6OlJlYWRPbmx5KTsKLSAgICAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGNn SW1hZ2UgPSBiaXRtYXAtPm1ha2VDR0ltYWdlKCk7CisgICAgICAgIFJldGFpblB0cjxDR0ltYWdl UmVmPiBjZ0ltYWdlID0gYml0bWFwID8gYml0bWFwLT5tYWtlQ0dJbWFnZSgpIDogbnVsbHB0cjsK ICAgICAgICAgW3RodW1ibmFpbFZpZXcgX2RpZFRha2VTbmFwc2hvdDpjZ0ltYWdlLmdldCgpXTsK ICAgICB9KTsKIH0K