132484 2014-05-02 13:23:29 -0700 Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem: 2022-02-28 04:09:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson thorton oldest_to_newest 1006120 0 beidson 2014-05-02 13:23:29 -0700 Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem: <rdar://problem/16797425> 1006121 1 230690 beidson 2014-05-02 13:24:40 -0700 Created attachment 230690 Patch v1 1006132 2 230690 thorton 2014-05-02 13:45:08 -0700 Comment on attachment 230690 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373 > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); any reason to null check node? > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384 > + ASSERT_NOT_REACHED(); why this assert, and then a happy handling of it on the next line? 1006161 3 beidson 2014-05-02 14:40:49 -0700 (In reply to comment #2) > (From update of attachment 230690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review > > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373 > > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); > > any reason to null check node? Good point. > > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384 > > + ASSERT_NOT_REACHED(); > > why this assert, and then a happy handling of it on the next line? For the same reason we need to null check node - WebContextMenuClient handles all types of content menu invocations, including ones that are not about anything that deserves a rect or that have already rendered. 1006166 4 beidson 2014-05-02 14:44:15 -0700 https://trac.webkit.org/changeset/168193 230690 2014-05-02 13:24:40 -0700 2022-02-28 04:09:06 -0800 Patch v1 patch text/plain 3923 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBmMmFmMTFhLi4zYjY5OGZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTkgQEAKIDIwMTQtMDUtMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCisgICAgICAgIEltcGxlbWVudCBuZXcgZGVsZWdhdGUgbWV0aG9kIC1zaGFyaW5nU2Vy dmljZTpzb3VyY2VGcmFtZU9uU2NyZWVuRm9yU2hhcmVJdGVtOi4KKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzE2Nzk3NDI1PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMjQ4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogTWlzYy9XZWJTaGFyaW5nU2VydmljZVBpY2tlckNvbnRyb2xsZXIubW06CisgICAgICAg ICgtW1dlYlNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlciBzaGFyaW5nU2VydmljZTpzb3Vy Y2VGcmFtZU9uU2NyZWVuRm9yU2hhcmVJdGVtOl0pOgorCisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvV2ViQ29udGV4dE1lbnVDbGllbnQuaDoKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJD b250ZXh0TWVudUNsaWVudC5tbToKKyAgICAgICAgKFdlYkNvbnRleHRNZW51Q2xpZW50OjpzY3Jl ZW5SZWN0Rm9ySGl0VGVzdE5vZGUpOgorCisyMDE0LTA1LTAyICBCcmFkeSBFaWRzb24gIDxiZWlk c29uQGFwcGxlLmNvbT4KKwogICAgICAgICBDcmFzaCBpbnNpZGUgW1dlYlNoYXJpbmdTZXJ2aWNl UGlja2VyQ29udHJvbGxlciBjbGVhcl0KICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NzkxOTQ0 PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjQ3NwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYlNoYXJpbmdTZXJ2aWNlUGlja2Vy Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hhcmluZ1NlcnZpY2VQ aWNrZXJDb250cm9sbGVyLm1tCmluZGV4IDllMzNhMmUuLjFmZGM4YTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hhcmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hhcmluZ1NlcnZpY2VQaWNrZXJDb250 cm9sbGVyLm1tCkBAIC0xOTksNiArMTk5LDE0IEBAIC0gKHZvaWQpc2hhcmluZ1NlcnZpY2U6KE5T U2hhcmluZ1NlcnZpY2UgKilzaGFyaW5nU2VydmljZSBkaWRGYWlsVG9TaGFyZUl0ZW1zOihOCiAg ICAgW3NlbGYgY2xlYXJdOwogfQogCistIChOU1JlY3Qpc2hhcmluZ1NlcnZpY2U6KE5TU2hhcmlu Z1NlcnZpY2UgKilzaGFyaW5nU2VydmljZSBzb3VyY2VGcmFtZU9uU2NyZWVuRm9yU2hhcmVJdGVt OihpZCA8TlNQYXN0ZWJvYXJkV3JpdGluZz4paXRlbQoreworICAgIGlmICghX21lbnVDbGllbnQp CisgICAgICAgIHJldHVybiBOU1JlY3QoKTsKKworICAgIHJldHVybiAoTlNSZWN0KV9tZW51Q2xp ZW50LT5zY3JlZW5SZWN0Rm9ySGl0VGVzdE5vZGUoKTsKK30KKwogLSAoTlNXaW5kb3cgKilzaGFy aW5nU2VydmljZTooTlNTaGFyaW5nU2VydmljZSAqKXNoYXJpbmdTZXJ2aWNlIHNvdXJjZVdpbmRv d0ZvclNoYXJlSXRlbXM6KE5TQXJyYXkgKilpdGVtcyBzaGFyaW5nQ29udGVudFNjb3BlOihOU1No YXJpbmdDb250ZW50U2NvcGUgKilzaGFyaW5nQ29udGVudFNjb3BlCiB7CiAgICAgcmV0dXJuIFtf bWVudUNsaWVudC0+d2ViVmlldygpIHdpbmRvd107CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5oIGIvU291cmNlL1dlYktp dC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQuaAppbmRleCBiZmMzMTMy Li5iYjQ0NTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9X ZWJDb250ZXh0TWVudUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBw b3J0L1dlYkNvbnRleHRNZW51Q2xpZW50LmgKQEAgLTI3LDYgKzI3LDcgQEAKICAqLwogCiAjaW1w b3J0IDxXZWJDb3JlL0NvbnRleHRNZW51Q2xpZW50Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0ludFJl Y3QuaD4KIAogQGNsYXNzIFdlYlNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlcjsKIEBjbGFz cyBXZWJWaWV3OwpAQCAtNTAsNiArNTEsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNl YXJjaFdpdGhTcG90bGlnaHQoKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgc2hvd0NvbnRl eHRNZW51KCkgb3ZlcnJpZGU7CiAKKyAgICBXZWJDb3JlOjpJbnRSZWN0IHNjcmVlblJlY3RGb3JI aXRUZXN0Tm9kZSgpIGNvbnN0OworCiAjaWYgRU5BQkxFKFNFUlZJQ0VfQ09OVFJPTFMpCiAgICAg dm9pZCBjbGVhclNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlcigpOwogI2VuZGlmCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNs aWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51 Q2xpZW50Lm1tCmluZGV4IGQxMjRjN2MuLjA1NjdhOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tCkBAIC01 MCw2ICs1MCw3IEBACiAjaW1wb3J0IDxXZWJDb3JlL1VSTC5oPgogI2ltcG9ydCA8V2ViQ29yZS9M b2NhbGl6ZWRTdHJpbmdzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1BhZ2UuaD4KKyNpbXBvcnQgPFdl YkNvcmUvUmVuZGVyT2JqZWN0Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL1NoYXJlZEJ1ZmZlci5oPgog I2ltcG9ydCA8V2ViQ29yZS9GcmFtZS5oPgogI2ltcG9ydCA8V2ViQ29yZS9GcmFtZVZpZXcuaD4K QEAgLTM2Myw2ICszNjQsMzAgQEAgdm9pZCBXZWJDb250ZXh0TWVudUNsaWVudDo6c3RvcFNwZWFr aW5nKCkKICAgICBbTlNBcHAgc3RvcFNwZWFraW5nOm5pbF07CiB9CiAKK0ludFJlY3QgV2ViQ29u dGV4dE1lbnVDbGllbnQ6OnNjcmVlblJlY3RGb3JIaXRUZXN0Tm9kZSgpIGNvbnN0Cit7CisgICAg UGFnZSogcGFnZSA9IFttX3dlYlZpZXcgcGFnZV07CisgICAgaWYgKCFwYWdlKQorICAgICAgICBy ZXR1cm4gSW50UmVjdCgpOworCisgICAgTm9kZSogbm9kZSA9IHBhZ2UtPmNvbnRleHRNZW51Q29u dHJvbGxlcigpLmNvbnRleHQoKS5oaXRUZXN0UmVzdWx0KCkuaW5uZXJOb2RlKCk7CisKKyAgICBS ZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKKyAgICBpZiAoIXJlbmRl cmVyKSB7CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gSW50 UmVjdCgpOworICAgIH0KKworICAgIEludFJlY3QgcmVjdCA9IHJlbmRlcmVyLT5hYnNvbHV0ZUJv dW5kaW5nQm94UmVjdCgpOworICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gbm9kZS0+ZG9jdW1l bnQoKS52aWV3KCk7CisgICAgaWYgKCFmcmFtZVZpZXcpIHsKKyAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgICAgIHJldHVybiBJbnRSZWN0KCk7CisgICAgfQorCisgICAgcmV0dXJu IGZyYW1lVmlldy0+Y29udGVudHNUb1NjcmVlbihyZWN0KTsKK30KKwogTlNNZW51ICpXZWJDb250 ZXh0TWVudUNsaWVudDo6Y29udGV4dE1lbnVGb3JFdmVudChOU0V2ZW50ICpldmVudCwgTlNWaWV3 ICp2aWV3KQogewogICAgIFBhZ2UqIHBhZ2UgPSBbbV93ZWJWaWV3IHBhZ2VdOwo=