132479 2014-05-02 12:25:13 -0700 Add and implement KeyedDecoder::decodeBytes 2014-05-02 12:34:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1006087 0 andersca 2014-05-02 12:25:13 -0700 Add and implement KeyedDecoder::decodeBytes 1006088 1 230682 andersca 2014-05-02 12:26:46 -0700 Created attachment 230682 Patch 1006090 2 230682 thorton 2014-05-02 12:28:55 -0700 Comment on attachment 230682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230682&action=review > Source/WebCore/platform/KeyedCoding.h:54 > + static_assert(sizeof(T) == 1, ""); why no message! 1006096 3 andersca 2014-05-02 12:34:58 -0700 Committed r168181: <http://trac.webkit.org/changeset/168181> 230682 2014-05-02 12:26:46 -0700 2014-05-02 12:28:55 -0700 Patch bug-132479-20140502192624.patch text/plain 4254 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQ2ZWI1YmFmNDNkMzg0 ZGViYjY3Mzk4NDNlMzRlMjAwYzg0MGE5Zi4uMzhhMGFjYmE3ZWEwYmRhYzY4ZThkMmRhNjYyMThi OTgyZDhhYTgyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA1LTAyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGFuZCBpbXBs ZW1lbnQgS2V5ZWREZWNvZGVyOjpkZWNvZGVCeXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9LZXllZENvZGluZy5oOgorICAgICAg ICAoV2ViQ29yZTo6S2V5ZWREZWNvZGVyOjpkZWNvZGVCeXRlcyk6CisKIDIwMTQtMDUtMDIgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogV0syOiBp T1Mgd2ViIHBhZ2Ugc2Nyb2xsaW5nIGRvZXNuJ3Qgd29yayB3aXRoIFZvaWNlT3ZlcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CmluZGV4IDM0YjU2YWM2NmNlOWVlMGVmNThjYzQ3MmU5MGMwZGNlNTFmNzg0NzIuLjZjYjk2ZmQ3 NjRjMTI0NTdjZDY2MmFiYThkNGNkMWU3MWM2MzE2NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxNC0wNS0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBhbmQgaW1wbGVtZW50IEtleWVkRGVjb2Rlcjo6ZGVjb2RlQnl0ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjQ3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL2Nm L0tleWVkRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OktleWVkRGVjb2Rlcjo6ZGVjb2Rl Qnl0ZXMpOgorICAgICAgICAqIFNoYXJlZC9jZi9LZXllZERlY29kZXIuaDoKKwogMjAxNC0wNS0w MSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T IFdLMl0gQW5pbWF0aW9ucyBvbiB2b3guY29tIGxvb2sgd3JvbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0tleWVkQ29kaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9LZXllZENvZGluZy5oCmluZGV4IGQ2MTY5MWQzOWU3MGJmODUwNWQ5MGNjZTY1ZDljNjkwNGZj ZjllZjUuLjM3NTk5NThmMTkzYTE1YmYwZWI1MGIwMGExYTQ5YThkZDUyN2I2MjQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tleWVkQ29kaW5nLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vS2V5ZWRDb2RpbmcuaApAQCAtMzksNiArMzksNyBAQCBwcm90ZWN0ZWQ6 CiAgICAgdmlydHVhbCB+S2V5ZWREZWNvZGVyKCkgeyB9CiAKIHB1YmxpYzoKKyAgICB2aXJ0dWFs IGJvb2wgZGVjb2RlQnl0ZXMoY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IHVpbnQ4X3QqJiwgc2l6 ZV90JikgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVCb29sKGNvbnN0IFN0cmluZyYga2V5 LCBib29sJikgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVVSW50MzIoY29uc3QgU3RyaW5n JiBrZXksIHVpbnQzMl90JikgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVJbnQzMihjb25z dCBTdHJpbmcmIGtleSwgaW50MzJfdCYpID0gMDsKQEAgLTQ3LDYgKzQ4LDIxIEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIGJvb2wgZGVjb2RlRG91YmxlKGNvbnN0IFN0cmluZyYga2V5LCBkb3VibGUm KSA9IDA7CiAgICAgdmlydHVhbCBib29sIGRlY29kZVN0cmluZyhjb25zdCBTdHJpbmcmIGtleSwg U3RyaW5nJikgPSAwOwogCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KKyAgICBib29sIGRlY29k ZUJ5dGVzKGNvbnN0IFN0cmluZyYga2V5LCBWZWN0b3I8VD4mIHZlY3RvcikKKyAgICB7CisgICAg ICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKFQpID09IDEsICIiKTsKKworICAgICAgICBzaXplX3Qg c2l6ZTsKKyAgICAgICAgY29uc3QgdWludDhfdCogYnl0ZXM7CisgICAgICAgIGlmICghZGVjb2Rl Qnl0ZXMoa2V5LCBieXRlcywgc2l6ZSkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAg ICAgICAgdmVjdG9yLnJlc2l6ZShzaXplKTsKKyAgICAgICAgc3RkOjpjb3B5KGJ5dGVzLCBieXRl cyArIHNpemUsIHZlY3Rvci5kYXRhKCkpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisK ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBGPgogICAgIGJvb2wgZGVjb2RlRW51 bShjb25zdCBTdHJpbmcmIGtleSwgVCYgdmFsdWUsIEYmJiBpc1ZhbGlkRW51bUZ1bmN0aW9uKQog ICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9LZXllZERlY29kZXIu Y3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0tleWVkRGVjb2Rlci5jcHAKaW5kZXggNDZi ZDc2MjZmYTYzODkwZjcwNTc5YmRiOWU0YzBhMDE3M2JlYjBiOS4uZTRlNjYxYTljYzFiN2RmNzZi YzY3MDU4MTY1OGZmYTM4YjkzZjVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVk L2NmL0tleWVkRGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0tleWVk RGVjb2Rlci5jcHAKQEAgLTUwLDYgKzUwLDE3IEBAIEtleWVkRGVjb2Rlcjo6fktleWVkRGVjb2Rl cigpCiAgICAgQVNTRVJUKG1fYXJyYXlJbmRleFN0YWNrLmlzRW1wdHkoKSk7CiB9CiAKK2Jvb2wg S2V5ZWREZWNvZGVyOjpkZWNvZGVCeXRlcyhjb25zdCBTdHJpbmcmIGtleSwgY29uc3QgdWludDhf dComIGJ5dGVzLCBzaXplX3QmIHNpemUpCit7CisgICAgQ0ZEYXRhUmVmIGRhdGEgPSBzdGF0aWNf Y2FzdDxDRkRhdGFSZWY+KENGRGljdGlvbmFyeUdldFZhbHVlKG1fZGljdGlvbmFyeVN0YWNrLmxh c3QoKSwga2V5LmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCkpKTsKKyAgICBpZiAoIWRhdGEgfHwgQ0ZH ZXRUeXBlSUQoZGF0YSkgIT0gQ0ZEYXRhR2V0VHlwZUlEKCkpCisgICAgICAgIHJldHVybiBmYWxz ZTsKKworICAgIGJ5dGVzID0gQ0ZEYXRhR2V0Qnl0ZVB0cihkYXRhKTsKKyAgICBzaXplID0gQ0ZE YXRhR2V0TGVuZ3RoKGRhdGEpOworICAgIHJldHVybiB0cnVlOworfQorCiBib29sIEtleWVkRGVj b2Rlcjo6ZGVjb2RlQm9vbChjb25zdCBTdHJpbmcmIGtleSwgYm9vbCYgcmVzdWx0KQogewogICAg IENGQm9vbGVhblJlZiBib29sZWFuID0gc3RhdGljX2Nhc3Q8Q0ZCb29sZWFuUmVmPihDRkRpY3Rp b25hcnlHZXRWYWx1ZShtX2RpY3Rpb25hcnlTdGFjay5sYXN0KCksIGtleS5jcmVhdGVDRlN0cmlu ZygpLmdldCgpKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvS2V5ZWRE ZWNvZGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvS2V5ZWREZWNvZGVyLmgKaW5kZXgg MGExZDY3NDhjMTk2YTdkYTA1M2Q5ZDEzNjNmMTk4MzVjOTczNjg5ZS4uOThhYjc4NDQ5NGFlZGQ1 Y2EwNzlkNmYwYzRmNzdkN2FiYWZmOWYwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hh cmVkL2NmL0tleWVkRGVjb2Rlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9LZXll ZERlY29kZXIuaApAQCAtMzgsNiArMzgsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+S2V5ZWRE ZWNvZGVyKCkgb3ZlcnJpZGU7CiAKIHByaXZhdGU6CisgICAgdmlydHVhbCBib29sIGRlY29kZUJ5 dGVzKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCB1aW50OF90KiYsIHNpemVfdCYpIG92ZXJyaWRl OwogICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVCb29sKGNvbnN0IFN0cmluZyYga2V5LCBib29sJikg b3ZlcnJpZGU7CiAgICAgdmlydHVhbCBib29sIGRlY29kZVVJbnQzMihjb25zdCBTdHJpbmcmIGtl eSwgdWludDMyX3QmKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIGJvb2wgZGVjb2RlSW50MzIoY29u c3QgU3RyaW5nJiBrZXksIGludDMyX3QmKSBvdmVycmlkZTsK