132477 2014-05-02 12:15:07 -0700 Crash inside [WebSharingServicePickerController clear] 2014-05-02 13:01:30 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson commit-queue thorton oldest_to_newest 1006083 0 beidson 2014-05-02 12:15:07 -0700 Crash inside [WebSharingServicePickerController clear] Clear can be called twice on the same picker, so the _menuClient needs a null check. In radar as <rdar://problem/16791944> 1006085 1 230681 beidson 2014-05-02 12:17:55 -0700 Created attachment 230681 Patch v1 1006110 2 230681 commit-queue 2014-05-02 13:01:20 -0700 Comment on attachment 230681 Patch v1 Clearing flags on attachment: 230681 Committed r168185: <http://trac.webkit.org/changeset/168185> 1006111 3 commit-queue 2014-05-02 13:01:30 -0700 All reviewed patches have been landed. Closing bug. 230681 2014-05-02 12:17:55 -0700 2014-05-02 13:01:19 -0700 Patch v1 patch text/plain 3403 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCA1OWJiZjcxLi4zNDUxOThlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTQtMDUtMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIENyYXNoIGluc2lkZSBbV2ViU2hhcmluZ1NlcnZpY2VQaWNrZXJDb250 cm9sbGVyIGNsZWFyXQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY3OTE5NDQ+IGFuZCBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNDc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaXNjL1dlYlNoYXJpbmdTZXJ2 aWNlUGlja2VyQ29udHJvbGxlci5oOgorICAgICAgICAqIE1pc2MvV2ViU2hhcmluZ1NlcnZpY2VQ aWNrZXJDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXZWJTaGFyaW5nU2VydmljZVBpY2tlckNv bnRyb2xsZXIgY2xlYXJdKTogY2xlYXIgY2FuIGJlIGNhbGxlZCB0d2ljZSwgc28gbnVsbCBjaGVj ayBfbWVudUNsaWVudC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51 Q2xpZW50Lmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQu bW06CisgICAgICAgIChXZWJDb250ZXh0TWVudUNsaWVudDo6fldlYkNvbnRleHRNZW51Q2xpZW50 KTogRm9yIGEgc2FuaXR5IGNoZWNrLCBjYWxsIGNsZWFyIG9uIHRoZSBwaWNrZXIgaGVyZS4KKwog MjAxNC0wNS0wMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAg ICAgICBNb3JlIDMyLWJpdCBidWlsZCBmaXhlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv bWFjL01pc2MvV2ViU2hhcmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLmggYi9Tb3VyY2UvV2Vi S2l0L21hYy9NaXNjL1dlYlNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlci5oCmluZGV4IGRj YjE5N2QuLjhhYThhOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hh cmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9tYWMvTWlz Yy9XZWJTaGFyaW5nU2VydmljZVBpY2tlckNvbnRyb2xsZXIuaApAQCAtNDIsNiArNDIsNyBAQCBj bGFzcyBXZWJDb250ZXh0TWVudUNsaWVudDsKIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aERhdGE6 KE5TRGF0YSAqKWRhdGEgaW5jbHVkZUVkaXRvclNlcnZpY2VzOihCT09MKWluY2x1ZGVFZGl0b3JT ZXJ2aWNlcyBtZW51Q2xpZW50OihXZWJDb250ZXh0TWVudUNsaWVudCopbWVudUNsaWVudDsKIC0g KE5TTWVudSAqKW1lbnU7CiAtICh2b2lkKWRpZFNoYXJlSW1hZ2VEYXRhOihOU0RhdGEgKilkYXRh IGNvbmZpcm1EYXRhSXNWYWxpZFRJRkZEYXRhOihCT09MKWNvbmZpcm1EYXRhOworLSAodm9pZClj bGVhcjsKIAogQGVuZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYlNo YXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2Mv V2ViU2hhcmluZ1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLm1tCmluZGV4IGVjYzMyZTcuLjllMzNh MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hhcmluZ1NlcnZpY2VQ aWNrZXJDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViU2hhcmlu Z1NlcnZpY2VQaWNrZXJDb250cm9sbGVyLm1tCkBAIC04OCw3ICs4OCw4IEBAIC0gKGluc3RhbmNl dHlwZSlpbml0V2l0aERhdGE6KE5TRGF0YSAqKWRhdGEgaW5jbHVkZUVkaXRvclNlcnZpY2VzOihC T09MKWluY2x1ZGVFCiAKIC0gKHZvaWQpY2xlYXIKIHsKLSAgICBfbWVudUNsaWVudC0+Y2xlYXJT aGFyaW5nU2VydmljZVBpY2tlckNvbnRyb2xsZXIoKTsKKyAgICBpZiAoX21lbnVDbGllbnQpCisg ICAgICAgIF9tZW51Q2xpZW50LT5jbGVhclNoYXJpbmdTZXJ2aWNlUGlja2VyQ29udHJvbGxlcigp OwogCiAgICAgX3BpY2tlciA9IG51bGxwdHI7CiAgICAgX21lbnVDbGllbnQgPSBudWxscHRyOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1l bnVDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRN ZW51Q2xpZW50LmgKaW5kZXggZTg4ZTU2MC4uYmZjMzEzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5oCkBAIC0z NCw3ICszNCw4IEBACiBjbGFzcyBXZWJDb250ZXh0TWVudUNsaWVudCA6IHB1YmxpYyBXZWJDb3Jl OjpDb250ZXh0TWVudUNsaWVudCB7CiBwdWJsaWM6CiAgICAgV2ViQ29udGV4dE1lbnVDbGllbnQo V2ViVmlldyAqd2ViVmlldyk7Ci0gICAgCisgICAgfldlYkNvbnRleHRNZW51Q2xpZW50KCk7CisK ICAgICB2aXJ0dWFsIHZvaWQgY29udGV4dE1lbnVEZXN0cm95ZWQoKSBvdmVycmlkZTsKICAgICAK ICAgICB2aXJ0dWFsIE5TTXV0YWJsZUFycmF5KiBnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVt cyhXZWJDb3JlOjpDb250ZXh0TWVudSopIG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQubW0gYi9Tb3VyY2Uv V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbQppbmRleCA2 MTkxZjRkLi5kMTI0YzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3Vw cG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbQpAQCAtNjcsNiArNjcsMTQgQEAgV2Vi Q29udGV4dE1lbnVDbGllbnQ6OldlYkNvbnRleHRNZW51Q2xpZW50KFdlYlZpZXcgKndlYlZpZXcp CiB7CiB9CiAKK1dlYkNvbnRleHRNZW51Q2xpZW50Ojp+V2ViQ29udGV4dE1lbnVDbGllbnQoKQor eworI2lmIEVOQUJMRShTRVJWSUNFX0NPTlRST0xTKQorICAgIGlmIChtX3NoYXJpbmdTZXJ2aWNl UGlja2VyQ29udHJvbGxlcikKKyAgICAgICAgW21fc2hhcmluZ1NlcnZpY2VQaWNrZXJDb250cm9s bGVyIGNsZWFyXTsKKyNlbmRpZgorfQorCiB2b2lkIFdlYkNvbnRleHRNZW51Q2xpZW50Ojpjb250 ZXh0TWVudURlc3Ryb3llZCgpCiB7CiAgICAgZGVsZXRlIHRoaXM7Cg==