132472 2014-05-02 10:56:35 -0700 Fix several memory leaks found by code inspection 2014-05-02 11:47:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca commit-queue sam simon.fraser oldest_to_newest 1006055 0 simon.fraser 2014-05-02 10:56:35 -0700 Fix several memory leaks found by code inspection 1006056 1 230674 simon.fraser 2014-05-02 10:57:08 -0700 Created attachment 230674 Patch 1006058 2 simon.fraser 2014-05-02 10:57:56 -0700 I searched for: RetainPtr<.+>.+= \[.+alloc RetainPtr<.+>.+= [^a].+create RetainPtr<.+>.+= [^a].+copy and looked for leaks, and found a few. 1006060 3 230674 ggaren 2014-05-02 11:09:52 -0700 Comment on attachment 230674 Patch r=me 1006074 4 230674 commit-queue 2014-05-02 11:47:22 -0700 Comment on attachment 230674 Patch Clearing flags on attachment: 230674 Committed r168177: <http://trac.webkit.org/changeset/168177> 1006075 5 commit-queue 2014-05-02 11:47:25 -0700 All reviewed patches have been landed. Closing bug. 230674 2014-05-02 10:57:08 -0700 2014-05-02 11:47:22 -0700 Patch bug-132472-20140502105645.patch text/plain 4395 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjRlYTM5MDhjNTBjNjI0ZmY0MTU0OTE1OTA3OGIwN2I5 Nzg0OTg3MS4uMmEwYmJmMTRlMThkOWRlY2JlMTRiNzQxMzQ0NzQwZDUyYjJlM2M1NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTA1LTAyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBzZXZlcmFsIG1lbW9yeSBsZWFrcyBmb3VuZCBieSBjb2RlIGluc3BlY3Rp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjQ3 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAg ICAgRml4IG1lbW9yeSBsZWFrcy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvbWFj L1dpbGxTZW5kU3VibWl0RXZlbnQubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxl UGFnZS5jcHA6CisgICAgICAgIChXVFI6OkluamVjdGVkQnVuZGxlUGFnZTo6d2lsbFNlbmRSZXF1 ZXN0Rm9yRnJhbWUpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2Vi Vmlld01hYy5tbToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpjaGFuZ2VXaW5kb3dT Y2FsZUlmTmVlZGVkKToKKwogMjAxNC0wNS0wMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIERGR0Fic3RyYWN0SW50ZXJwcmV0ZXIgc2hvdWxkIG5vdCBjbGFpbSBJ bnQ1MiBhcml0aG1ldGljIGNyZWF0ZXMgSW50NTJzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL21hYy9XaWxsU2VuZFN1Ym1pdEV2ZW50Lm1tIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9tYWMvV2lsbFNlbmRTdWJtaXRFdmVudC5tbQppbmRleCAxNjU0ZjljYTgwMzkw NGY5YjA5NjQ1NjkyYTk3MDhmYjJmZDJhZTAyLi5hM2IwNThjMDE2MjQzMDhiMGU0MmVhMWNlODY0 OWU3MTgzMzBmODk1IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9X aWxsU2VuZFN1Ym1pdEV2ZW50Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFj L1dpbGxTZW5kU3VibWl0RXZlbnQubW0KQEAgLTYyLDcgKzYyLDcgQEAgVEVTVChXZWJLaXQxLCBX aWxsU2VuZFN1Ym1pdEV2ZW50KQogICAgIEBhdXRvcmVsZWFzZXBvb2wgewogICAgICAgICBSZXRh aW5QdHI8V2ViVmlldz4gd2ViVmlldyA9IGFkb3B0TlMoW1tXZWJWaWV3IGFsbG9jXSBpbml0V2l0 aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgMTIwLCAyMDApIGZyYW1lTmFtZTpuaWwgZ3JvdXBOYW1l Om5pbF0pOwogCi0gICAgICAgIFJldGFpblB0cjxGb3JtRGVsZWdhdGU+IGZvcm1EZWxlZ2F0ZSA9 IFtbRm9ybURlbGVnYXRlIGFsbG9jXSBpbml0XTsKKyAgICAgICAgUmV0YWluUHRyPEZvcm1EZWxl Z2F0ZT4gZm9ybURlbGVnYXRlID0gYWRvcHROUyhbW0Zvcm1EZWxlZ2F0ZSBhbGxvY10gaW5pdF0p OwogICAgICAgICBbd2ViVmlldyBfc2V0Rm9ybURlbGVnYXRlOmZvcm1EZWxlZ2F0ZS5nZXQoKV07 CiAKICAgICAgICAgW1t3ZWJWaWV3LmdldCgpIG1haW5GcmFtZV0gbG9hZFJlcXVlc3Q6W05TVVJM UmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbW05TQnVuZGxlIG1haW5CdW5kbGVdIFVSTEZvclJlc291 cmNlOkAiYXV0by1zdWJtaXR0aW5nLWZvcm0iIHdpdGhFeHRlbnNpb246QCJodG1sIiBzdWJkaXJl Y3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdXV07CmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5j cHAKaW5kZXggMjFkMzQ3NzMwMmM0OGFlYjgyNzFjMWE1ZWU4MTIxOGExNDNjMDIwZS4uYjQ0YzQx MGI5NDczZGMwZDg2NWU2NDFjMDYyYjhjYmQxYTk5YzExOCAxMDA2NDQKLS0tIGEvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3BwCisrKyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdl LmNwcApAQCAtMTA4Niw4ICsxMDg2LDggQEAgV0tVUkxSZXF1ZXN0UmVmIEluamVjdGVkQnVuZGxl UGFnZTo6d2lsbFNlbmRSZXF1ZXN0Rm9yRnJhbWUoV0tCdW5kbGVQYWdlUmVmIHBhZ2UKICAgICAg ICAgICAgIGlmICghbWFpbkZyYW1lVVJMIHx8IFdLU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmco YWRvcHRXSyhXS1VSTENvcHlTdHJpbmcobWFpbkZyYW1lVVJMLmdldCgpKSkuZ2V0KCksICJhYm91 dDpibGFuayIpKQogICAgICAgICAgICAgICAgIG1haW5GcmFtZVVSTCA9IGFkb3B0V0soV0tCdW5k bGVGcmFtZUNvcHlQcm92aXNpb25hbFVSTChtYWluRnJhbWUpKTsKIAotICAgICAgICAgICAgV0tS ZXRhaW5QdHI8V0tTdHJpbmdSZWY+IG1haW5GcmFtZUhvc3QgPSBXS1VSTENvcHlIb3N0TmFtZSht YWluRnJhbWVVUkwuZ2V0KCkpOwotICAgICAgICAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+ IG1haW5GcmFtZVNjaGVtZSA9IFdLVVJMQ29weVNjaGVtZShtYWluRnJhbWVVUkwuZ2V0KCkpOwor ICAgICAgICAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IG1haW5GcmFtZUhvc3QgPSBhZG9w dFdLKFdLVVJMQ29weUhvc3ROYW1lKG1haW5GcmFtZVVSTC5nZXQoKSkpOworICAgICAgICAgICAg V0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IG1haW5GcmFtZVNjaGVtZSA9IGFkb3B0V0soV0tVUkxD b3B5U2NoZW1lKG1haW5GcmFtZVVSTC5nZXQoKSkpOwogICAgICAgICAgICAgbWFpbkZyYW1lSXNF eHRlcm5hbCA9IGlzSFRUUE9ySFRUUFNTY2hlbWUobWFpbkZyYW1lU2NoZW1lLmdldCgpKSAmJiAh aXNMb2NhbEhvc3QobWFpbkZyYW1lSG9zdC5nZXQoKSk7CiAgICAgICAgIH0KICAgICAgICAgaWYg KCFtYWluRnJhbWVJc0V4dGVybmFsKSB7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21h Yy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KaW5kZXggNTA1ZmIyOTgwMDI2M2IyNzE1ODBlNmJlNThm MzAwMDVhNzAzYjNhNC4uNTc1NWIzM2ZjZTcxNTExMmQ3NDVlYWMzMTc0NGY0MDYzNTdlNTU1MiAx MDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFj Lm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5t bQpAQCAtMjU0LDcgKzI1NCw3IEBAIHZvaWQgUGxhdGZvcm1XZWJWaWV3OjpjaGFuZ2VXaW5kb3dT Y2FsZUlmTmVlZGVkKGZsb2F0IG5ld1NjYWxlKQogICAgIC8vIEluc3RlYWQgb2YgcmUtY29uc3Ry dWN0aW5nIHRoZSBjdXJyZW50IHdpbmRvdywgbGV0J3MgZmFrZSByZXNpemUgaXQgdG8gZW5zdXJl IHRoYXQgdGhlIHNjYWxlIGNoYW5nZSBnZXRzIHBpY2tlZCB1cC4KICAgICBmb3JjZVdpbmRvd0Zy YW1lc0NoYW5nZWQoKTsKICAgICAvLyBDaGFuZ2luZyB0aGUgc2NhbGluZyBmYWN0b3Igb24gdGhl IHdpbmRvdyBkb2VzIG5vdCB0cmlnZ2VyIE5TV2luZG93RGlkQ2hhbmdlQmFja2luZ1Byb3BlcnRp ZXNOb3RpZmljYXRpb24uIFdlIG5lZWQgdG8gc2VuZCB0aGUgbm90aWZpY2F0aW9uIG1hbnVhbGx5 LgotICAgIFJldGFpblB0cjxOU011dGFibGVEaWN0aW9uYXJ5PiBub3RpZmljYXRpb25Vc2VySW5m byA9IFtbTlNNdXRhYmxlRGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhDYXBhY2l0eToxXTsKKyAg ICBSZXRhaW5QdHI8TlNNdXRhYmxlRGljdGlvbmFyeT4gbm90aWZpY2F0aW9uVXNlckluZm8gPSBh ZG9wdE5TKFtbTlNNdXRhYmxlRGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhDYXBhY2l0eToxXSk7 CiAgICAgW25vdGlmaWNhdGlvblVzZXJJbmZvIHNldE9iamVjdDpbTlNOdW1iZXIgbnVtYmVyV2l0 aERvdWJsZTpjdXJyZW50U2NhbGVdIGZvcktleTpOU0JhY2tpbmdQcm9wZXJ0eU9sZFNjYWxlRmFj dG9yS2V5XTsKICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHBvc3RO b3RpZmljYXRpb25OYW1lOk5TV2luZG93RGlkQ2hhbmdlQmFja2luZ1Byb3BlcnRpZXNOb3RpZmlj YXRpb24gb2JqZWN0Om1fd2luZG93IHVzZXJJbmZvOm5vdGlmaWNhdGlvblVzZXJJbmZvLmdldCgp XTsKIH0K