132454 2014-05-01 18:07:01 -0700 REGRESSION (WebKit2) Need to support Learn button 2014-05-01 18:40:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 1005929 0 enrica 2014-05-01 18:07:01 -0700 Need to add support for the Learn button in the menu for Traditional Chinese. <rdar://problem/16778889> 1005933 1 230638 enrica 2014-05-01 18:11:40 -0700 Created attachment 230638 Patch 1005938 2 230638 benjamin 2014-05-01 18:21:14 -0700 Comment on attachment 230638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230638&action=review > Source/WebKit2/ChangeLog:12 > + the button when appropriate as well as the implemetation of the action typo: implemetation > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:838 > + CGRect presentationRect = _page->editorState().selectionRects[0].rect(); You don't need to create this outside of the if() branch. The compiler cannot optimize this out because of the objc-msgsend below. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:920 > + if (!UIKeyboardEnabledInputModesAllowOneToManyShortcuts()) lol at the name :) 1005942 3 enrica 2014-05-01 18:40:53 -0700 Committed revision 168142. 230638 2014-05-01 18:11:40 -0700 2014-05-01 18:21:13 -0700 Patch addshortcut-webkit.txt text/plain 4178 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODEzOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA1LTAxICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoV2ViS2l0 MikgTmVlZCB0byBzdXBwb3J0IExlYXJuIGJ1dHRvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjQ1NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTY3Nzg4ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRm9yIHRyYWRpdGlvbmFsIENoaW5lc2Ugd2Ugc3VwcG9ydCB0aGUgYWJpbGl0eSB0byBhZGQg c2hvcnRjdXRzCisgICAgICAgIGZvciB0eXBpbmcuIFRoaXMgaXMgZG9uZSBieSBwcmVzc2luZyB0 aGUgTGVhcm4gYnV0dG9uIG9uIHRoZSBzeXN0ZW0KKyAgICAgICAgbWVudS4gVGhpcyBwYXRjaCBh ZGRzIHRoZSBuZWNlc3NhcnkgY29kZSB0byBjYW5QZXJmb3JtQWN0aW9uIHRvIGVuYWJsZQorICAg ICAgICB0aGUgYnV0dG9uIHdoZW4gYXBwcm9wcmlhdGUgYXMgd2VsbCBhcyB0aGUgaW1wbGVtZXRh dGlvbiBvZiB0aGUgYWN0aW9uCisgICAgICAgIGl0c2VsZi4KKyAgICAgICAgSXQgYWxzbyBhZGRz IGEgY2hlY2sgZm9yIHRoZSBSZXBsYWNlIGJ1dHRvbiBub3QgdG8gYmUgc2hvd24gd2hlbiB0aGUK KyAgICAgICAgc2VsZWN0aW9uIG9ubHkgY29udGFpbnMgQ0ogY2hhcmFjdGVycy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAo LVtXS0NvbnRlbnRWaWV3IF9hZGRTaG9ydGN1dDpdKToKKyAgICAgICAgKC1bV0tDb250ZW50Vmll dyBjYW5QZXJmb3JtQWN0aW9uOndpdGhTZW5kZXI6XSk6CisKIDIwMTQtMDUtMDEgIEJlbmphbWlu IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bV0syXSBUd2Vh ayB0aGUgZXh0ZW5kZWQgYmFja2dyb3VuZCBleGNsdXNpb24gZm9yIE1vYmlsZVNhZmFyaQpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE2ODExMCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBA IC00MywxMSArNDMsMTMgQEAKICNpbXBvcnQgIl9XS0Zvcm1EZWxlZ2F0ZS5oIgogI2ltcG9ydCAi X1dLRm9ybUlucHV0U2Vzc2lvbi5oIgogI2ltcG9ydCA8RGF0YURldGVjdG9yc1VJL0RERGV0ZWN0 aW9uQ29udHJvbGxlci5oPgorI2ltcG9ydCA8VGV4dElucHV0L1RJX05TU3RyaW5nRXh0cmFzLmg+ CiAjaW1wb3J0IDxVSUtpdC9fVUlIaWdobGlnaHRWaWV3Lmg+CiAjaW1wb3J0IDxVSUtpdC9fVUlX ZWJIaWdobGlnaHRMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplci5oPgogI2ltcG9ydCA8VUlLaXQv VUlGb250X1ByaXZhdGUuaD4KICNpbXBvcnQgPFVJS2l0L1VJR2VzdHVyZVJlY29nbml6ZXJfUHJp dmF0ZS5oPgogI2ltcG9ydCA8VUlLaXQvVUlLZXlib2FyZEltcGwuaD4KKyNpbXBvcnQgPFVJS2l0 L1VJS2V5Ym9hcmRJbnRsLmg+CiAjaW1wb3J0IDxVSUtpdC9VSUxvbmdQcmVzc0dlc3R1cmVSZWNv Z25pemVyX1ByaXZhdGUuaD4KICNpbXBvcnQgPFVJS2l0L1VJVGFwR2VzdHVyZVJlY29nbml6ZXJf UHJpdmF0ZS5oPgogI2ltcG9ydCA8VUlLaXQvVUlUZXh0SW50ZXJhY3Rpb25Bc3Npc3RhbnRfUHJp dmF0ZS5oPgpAQCAtMTI0LDYgKzEyNiw3IEBAIC0gKHZvaWQpc2VsZWN0V29yZDsKIAogQGludGVy ZmFjZSBVSVRleHRJbnRlcmFjdGlvbkFzc2lzdGFudCAoU3RhZ2luZ1RvUmVtb3ZlKQogLSAodm9p ZClzY2hlZHVsZVJlcGxhY2VtZW50c0ZvclRleHQ6KE5TU3RyaW5nICopdGV4dDsKKy0gKHZvaWQp c2hvd1RleHRTZXJ2aWNlRm9yOihOU1N0cmluZyAqKXNlbGVjdGVkVGVybSBmcm9tUmVjdDooQ0dS ZWN0KXByZXNlbnRhdGlvblJlY3Q7CiBAZW5kCiAKIEBpbnRlcmZhY2UgV0tGb3JtSW5wdXRTZXNz aW9uIDogTlNPYmplY3QgPF9XS0Zvcm1JbnB1dFNlc3Npb24+CkBAIC04MzIsNyArODM1LDkgQEAg LSAoTlNBcnJheSAqKXN1cHBvcnRlZFBhc3RlYm9hcmRUeXBlc0ZvcgogCiAtICh2b2lkKV9hZGRT aG9ydGN1dDooaWQpc2VuZGVyCiB7Ci0gICAgLy8gRklYTUU6IFRvIGJlIGltcGxlbWVudGVkLgor ICAgIENHUmVjdCBwcmVzZW50YXRpb25SZWN0ID0gX3BhZ2UtPmVkaXRvclN0YXRlKCkuc2VsZWN0 aW9uUmVjdHNbMF0ucmVjdCgpOworICAgIGlmIChfdGV4dFNlbGVjdGlvbkFzc2lzdGFudCAmJiBb X3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihzaG93 VGV4dFNlcnZpY2VGb3I6ZnJvbVJlY3Q6KV0pCisgICAgICAgIFtfdGV4dFNlbGVjdGlvbkFzc2lz dGFudCBzaG93VGV4dFNlcnZpY2VGb3I6W3NlbGYgc2VsZWN0ZWRUZXh0XSBmcm9tUmVjdDpwcmVz ZW50YXRpb25SZWN0XTsKIH0KIAogLSAoTlNTdHJpbmcgKilzZWxlY3RlZFRleHQKQEAgLTkwNywx MiArOTEyLDI1IEBAICAgICAgICAgLy8gYWNjZXB0YWJsZSwgYnV0IHRoZSBpbnRlcmZhY2UKICAg ICBpZiAoYWN0aW9uID09IEBzZWxlY3RvcihfYWRkU2hvcnRjdXQ6KSkgewogICAgICAgICBpZiAo X3BhZ2UtPmVkaXRvclN0YXRlKCkuaXNJblBhc3N3b3JkRmllbGQgfHwgIShoYXNXZWJTZWxlY3Rp b24gfHwgX3BhZ2UtPmVkaXRvclN0YXRlKCkuc2VsZWN0aW9uSXNSYW5nZSkpCiAgICAgICAgICAg ICByZXR1cm4gTk87Ci0gICAgICAgIC8vIEZJWE1FOiBuZWVkIHRvIGltcGxlbWVudCwgcmV0dXJu aW5nIE5PIGFsd2F5cyBmb3Igbm93LgotICAgICAgICByZXR1cm4gTk87CisKKyAgICAgICAgTlNT dHJpbmcgKnNlbGVjdGVkVGV4dCA9IFtzZWxmIHNlbGVjdGVkVGV4dF07CisgICAgICAgIGlmICgh W3NlbGVjdGVkVGV4dCBsZW5ndGhdKQorICAgICAgICAgICAgcmV0dXJuIE5POworCisgICAgICAg IGlmICghVUlLZXlib2FyZEVuYWJsZWRJbnB1dE1vZGVzQWxsb3dPbmVUb01hbnlTaG9ydGN1dHMo KSkKKyAgICAgICAgICAgIHJldHVybiBOTzsKKyAgICAgICAgaWYgKCFbc2VsZWN0ZWRUZXh0IF9j b250YWluc0NKU2NyaXB0c10pCisgICAgICAgICAgICByZXR1cm4gTk87CisgICAgICAgIHJldHVy biBZRVM7CiAgICAgfQogCi0gICAgaWYgKGFjdGlvbiA9PSBAc2VsZWN0b3IoX3Byb21wdEZvclJl cGxhY2U6KSkKLSAgICAgICAgcmV0dXJuIF9wYWdlLT5lZGl0b3JTdGF0ZSgpLnNlbGVjdGlvbklz UmFuZ2UgJiYgX3BhZ2UtPmVkaXRvclN0YXRlKCkuaXNSZXBsYWNlQWxsb3dlZCAmJiBbW1VJS2V5 Ym9hcmRJbXBsIGFjdGl2ZUluc3RhbmNlXSBhdXRvY29ycmVjdFNwZWxsaW5nRW5hYmxlZF07Cisg ICAgaWYgKGFjdGlvbiA9PSBAc2VsZWN0b3IoX3Byb21wdEZvclJlcGxhY2U6KSkgeworICAgICAg ICBpZiAoIV9wYWdlLT5lZGl0b3JTdGF0ZSgpLnNlbGVjdGlvbklzUmFuZ2UgfHwgIV9wYWdlLT5l ZGl0b3JTdGF0ZSgpLmlzUmVwbGFjZUFsbG93ZWQgfHwgIVtbVUlLZXlib2FyZEltcGwgYWN0aXZl SW5zdGFuY2VdIGF1dG9jb3JyZWN0U3BlbGxpbmdFbmFibGVkXSkKKyAgICAgICAgICAgIHJldHVy biBOTzsKKyAgICAgICAgaWYgKFtbc2VsZiBzZWxlY3RlZFRleHRdIF9jb250YWluc0NKU2NyaXB0 c09ubHldKQorICAgICAgICAgICAgcmV0dXJuIE5POworICAgICAgICByZXR1cm4gWUVTOworICAg IH0KIAogICAgIGlmIChhY3Rpb24gPT0gQHNlbGVjdG9yKHNlbGVjdDopKSB7CiAgICAgICAgIC8v IERpc2FibGUgc2VsZWN0IGluIHBhc3N3b3JkIGZpZWxkcyBzbyB0aGF0IHlvdSBjYW4ndCBzZWUg d29yZCBib3VuZGFyaWVzLgo=