132447 2014-05-01 16:09:21 -0700 REGRESSION(r168118): [GTK] Build broken. 2014-05-02 05:03:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez webkit-unassigned andersca cgarcia commit-queue gustavo mrobinson svillar zan oldest_to_newest 1005886 0 clopez 2014-05-01 16:09:21 -0700 Revision r168118 <http://trac.webkit.org/changeset/168118> broke the GTK Build: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/47029 ../../Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp: In member function ‘void WebKit::WebContext::platformInitializeWebProcess(WebKit::WebProcessCreationParameters&)’: ../../Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:110:16: error: ‘struct WebKit::WebProcessCreationParameters’ has no member named ‘shouldTrackVisitedLinks’ parameters.shouldTrackVisitedLinks = true; ^ 1005913 1 230632 clopez 2014-05-01 17:25:52 -0700 Created attachment 230632 Patch 1006016 2 230663 clopez 2014-05-02 04:23:05 -0700 Created attachment 230663 Patch 1006017 3 230663 commit-queue 2014-05-02 05:03:37 -0700 Comment on attachment 230663 Patch Clearing flags on attachment: 230663 Committed r168168: <http://trac.webkit.org/changeset/168168> 1006018 4 commit-queue 2014-05-02 05:03:45 -0700 All reviewed patches have been landed. Closing bug. 230632 2014-05-01 17:25:52 -0700 2014-05-02 04:22:56 -0700 Patch bug-132447-20140502022529.patch text/plain 1501 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmM1MDA4OGRmZjJkOTEz YWFhYzIxMGYxZmFkYzk1MjVjOGIwZmE2MC4uNDUxMjhiMGU2OGY3ZjZkZTNhYTViOGVmZmQ5OTM4 MzY4NmRjYTA5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTAxICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04ocjE2ODExOCk6IFtHVEtdIGJ1aWxkIGJyb2tlbiBkdWUgdG8gc2hvdWxkVHJhY2tW aXNpdGVkTGlua3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMjQ0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIHNob3VsZFRyYWNrVmlzaXRlZExpbmtzIHdhcyByZW1vdmVkIG9uIHIxNjgxMTguCisgICAg ICAgIFZpc2l0ZWQgbGluayBjb2xvcmluZyB3b3JrcyBhcyBleHBlY3RlZCBhZnRlciB0aGlzIGNo YW5nZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MpOiBS ZW1vdmUKKyAgICAgICAgc2hvdWxkVHJhY2tWaXNpdGVkTGlua3MgcGFyYW1ldGVyLgorCiAyMDE0 LTA1LTAxICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtpT1NdW1dLMl0gVHdlYWsgdGhlIGV4dGVuZGVkIGJhY2tncm91bmQgZXhjbHVzaW9uIGZvciBN b2JpbGVTYWZhcmkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2Vi Q29udGV4dEd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRH dGsuY3BwCmluZGV4IGZiZGRmOGY2N2JjNGMwMDliYzNkNWIyMjQyMmUxYzNiMjM0OWQ1NTMuLmYz YTIwYjc1MjFhMzVkYzYyYzczYzY5Y2I5MGIyZDQ2M2ViOTJiOTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcApAQCAtMTA3LDcgKzEwNyw2IEBA IHZvaWQgV2ViQ29udGV4dDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNz Q3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhCiAgICAgICAgIHBhcmFtZXRlcnMuaWdub3JlVExTRXJy b3JzID0gbV9pZ25vcmVUTFNFcnJvcnM7CiAgICAgfQogCi0gICAgcGFyYW1ldGVycy5zaG91bGRU cmFja1Zpc2l0ZWRMaW5rcyA9IHRydWU7CiB9CiAKIHZvaWQgV2ViQ29udGV4dDo6cGxhdGZvcm1J bnZhbGlkYXRlQ29udGV4dCgpCg== 230663 2014-05-02 04:23:05 -0700 2014-05-02 05:03:36 -0700 Patch bug-132447-20140502132242.patch text/plain 1480 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTM2YWNmMWEwNTNhY2Rl NjkyNTc2MDI3ZjM4ZjE1MjE2MTIwY2E4Yi4uZWFmMDgzODhhNmU0Y2UzMTEwYzc2NjVlZTNlYTYz MGZjNGZmMDg0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTAxICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04ocjE2ODExOCk6IFtHVEtdIGJ1aWxkIGJyb2tlbiBkdWUgdG8gc2hvdWxkVHJhY2tW aXNpdGVkTGlua3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMjQ0NworCisgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeC4KKworICAgICAg ICBzaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyB3YXMgcmVtb3ZlZCBvbiByMTY4MTE4LgorICAgICAg ICBWaXNpdGVkIGxpbmsgY29sb3Jpbmcgd29ya3MgYXMgZXhwZWN0ZWQgYWZ0ZXIgdGhpcyBjaGFu Z2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJDb250ZXh0OjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKTogUmVt b3ZlCisgICAgICAgIHNob3VsZFRyYWNrVmlzaXRlZExpbmtzIHBhcmFtZXRlci4KKwogMjAxNC0w NS0wMSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT04gKFdlYktpdDIpIE5lZWQgdG8gc3VwcG9ydCBMZWFybiBidXR0b24uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcAppbmRleCBmYmRkZjhmNjdi YzRjMDA5YmMzZDViMjI0MjJlMWMzYjIzNDlkNTUzLi5hYjkzZGYyOTllYjI0ODM2ODEyN2UwMTNl MjhkNGNiNWIwNWIxMTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3Rr L1dlYkNvbnRleHRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2Vi Q29udGV4dEd0ay5jcHAKQEAgLTEwNiw4ICsxMDYsNiBAQCB2b2lkIFdlYkNvbnRleHQ6OnBsYXRm b3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYgcGFy YQogCiAgICAgICAgIHBhcmFtZXRlcnMuaWdub3JlVExTRXJyb3JzID0gbV9pZ25vcmVUTFNFcnJv cnM7CiAgICAgfQotCi0gICAgcGFyYW1ldGVycy5zaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyA9IHRy dWU7CiB9CiAKIHZvaWQgV2ViQ29udGV4dDo6cGxhdGZvcm1JbnZhbGlkYXRlQ29udGV4dCgpCg==