132435 2014-05-01 12:36:43 -0700 [iOS][WK2] The highlight view needs to be in WKWebView coordinates 2014-05-01 13:33:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1005810 0 benjamin 2014-05-01 12:36:43 -0700 [iOS][WK2] The highlight view needs to be in WKWebView coordinates 1005812 1 230603 benjamin 2014-05-01 12:40:32 -0700 Created attachment 230603 Patch 1005829 2 230603 thorton 2014-05-01 13:25:53 -0700 Comment on attachment 230603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230603&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:375 > + RetainPtr<UIColor> highlightUIKitColor = adoptNS([[UIColor alloc] initWithRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)]); We really need something for this in Color or somewhere. 1005831 3 230603 benjamin 2014-05-01 13:33:20 -0700 Comment on attachment 230603 Patch Clearing flags on attachment: 230603 Committed r168117: <http://trac.webkit.org/changeset/168117> 1005832 4 benjamin 2014-05-01 13:33:22 -0700 All reviewed patches have been landed. Closing bug. 230603 2014-05-01 12:40:32 -0700 2014-05-01 13:33:20 -0700 Patch bug-132435-20140501124005.patch text/plain 6503 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzFiOGUzZDM5ZjMzY2U3 M2QzODAxM2MzNTc5OTQzNjRjOWMyOWNmOS4uZGZiOTdjNzgzMjJjMTFjYzdiYmJiNTYyNjBkODRm MzdkNTIyMGIzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA1LTAxICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g VGhlIGhpZ2hsaWdodCB2aWV3IG5lZWRzIHRvIGJlIGluIFdLV2ViVmlldyBjb29yZGluYXRlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNDM1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjcwODg2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBfVUlIaWdobGlnaHRWaWV3IG5lZWRzIHRvIGJlIGlu IFdLV2ViVmlldyBjb29yZGluYXRlcyBzbyB0aGF0IGl0IHJlbmRlciB1bnNjYWxlZCBmb3IgYW55 IHBhZ2Ugc2NhbGUgZmFjdG9yLgorICAgICAgICBUaGUgdmlldyBuZWVkcyB0byBiZSBhIGNoaWxk IG9mIFdLQ29udGVudFZpZXcgc28gdGhhdCBpdCBtb3Zlcy9zY2FsZXMgd2l0aCB0aGUgcGFnZS4K KworICAgICAgICBUbyBmaXggdGhlIGlzc3VlLCBhZGQgYW4gaW52ZXJzZSB0cmFuc2Zvcm0gcm9v dCBsYXllciBmb3IgdGhlIGhpZ2h0bGlnaHQsIGFuZCBzY2FsZSB0aGUgY29vcmRpbmF0ZXMgdG8g dGhlaXIKKyAgICAgICAgaW52ZXJzZSBzY2FsZWQgY291bnRlcnBhcnQuCisKKyAgICAgICAgVGhl IHNjYWxlIGlzIG5vdCB1cGRhdGVkIGxpdmUgd2l0aCB0aGUgc2NhbGluZyBvZiBXS0NvbnRlbnRW aWV3IGJ1dCB0aGF0IHNob3VsZCBiZSBmaW5lIHNpbmNlIHRoZSB2aWV3IGRpc2FwcGVhcgorICAg ICAgICBvbiBhbnkgc2NhbGluZyBvcGVyYXRpb24gKGFuZCBJIHdvdWxkIHByZWZlciBub3QgYWRk IGxpdmUgcGFpbnRpbmcgZHVyaW5nIHNjYWxpbmcgYW5pbWF0aW9uKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmg6CisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgY2xlYW51cEludGVyYWN0aW9uXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2Rp ZEdldFRhcEhpZ2hsaWdodEZvclJlcXVlc3Q6Y29sb3I6V2ViQ29yZTo6cXVhZHM6V2ViQ29yZTo6 dG9wTGVmdFJhZGl1czpXZWJDb3JlOjp0b3BSaWdodFJhZGl1czpXZWJDb3JlOjpib3R0b21MZWZ0 UmFkaXVzOldlYkNvcmU6OmJvdHRvbVJpZ2h0UmFkaXVzOldlYkNvcmU6Ol0pOgorICAgICAgICAo LVtXS0NvbnRlbnRWaWV3IF9jYW5jZWxJbnRlcmFjdGlvbl0pOgorCiAyMDE0LTA0LTMwICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbaU9TXVtXSzJd IEFuaW1hdGVkIHJlc2l6ZSBpbmNvcnJlY3RseSBhc3N1bWVzIHRoZSBsYXlvdXQgd2lkdGggaXMg dGhlIHNhbWUgYXMgdGhlIHZpZXcgd2lkdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCmluZGV4IGMzOWJkMzg4MWYy YjRlYjM4NTMxNjY5NTIzMGRjMTZlZjIxOWQzODEuLmU2MTIzNjllOTE2NmRmYjA3ZTgxM2RjOTRm ZjIyOTQ0NzNjOWZhZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaApAQCAtOTIsNiArOTIsNyBAQCBzdHJ1Y3Qg V0tBdXRvQ29ycmVjdGlvbkRhdGEgewogCiAgICAgUmV0YWluUHRyPFVJVGV4dElucHV0VHJhaXRz PiBfdHJhaXRzOwogICAgIFJldGFpblB0cjxVSVdlYkZvcm1BY2Nlc3Nvcnk+IF9mb3JtQWNjZXNz b3J5VmlldzsKKyAgICBSZXRhaW5QdHI8VUlWaWV3PiBfaGlnaGxpZ2h0Um9vdFZpZXc7CiAgICAg UmV0YWluUHRyPF9VSUhpZ2hsaWdodFZpZXc+IF9oaWdobGlnaHRWaWV3OwogICAgIFJldGFpblB0 cjxOU1N0cmluZz4gX21hcmtlZFRleHQ7CiAgICAgUmV0YWluUHRyPFdLQWN0aW9uU2hlZXRBc3Np c3RhbnQ+IF9hY3Rpb25TaGVldEFzc2lzdGFudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggODAxODNk ZDFmM2VmMDM0NWQwOGFiYjIyNDU5NTIwODIxMDQ0Mzk5Yy4uYzk2NTMyZWQxZjc2MTlmMmFjZmE5 YjNkNmU3MjY4YmJhNThmYjgyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTIzMCw2ICsyMzAsOCBA QCBzdGF0aWMgY29uc3QgZmxvYXQgdGFwQW5kSG9sZERlbGF5ICA9IDAuNzU7CiAgICAgX2FjdGlv blNoZWV0QXNzaXN0YW50ID0gbmlsOwogICAgIFtfZm9ybUlucHV0U2Vzc2lvbiBpbnZhbGlkYXRl XTsKICAgICBfZm9ybUlucHV0U2Vzc2lvbiA9IG5pbDsKKyAgICBbX2hpZ2hsaWdodFZpZXcgcmVt b3ZlRnJvbVN1cGVydmlld107CisgICAgW19oaWdobGlnaHRSb290VmlldyByZW1vdmVGcm9tU3Vw ZXJ2aWV3XTsKICAgICBbX3RvdWNoRXZlbnRHZXN0dXJlUmVjb2duaXplciBzZXREZWxlZ2F0ZTpu aWxdOwogICAgIFtfc2luZ2xlVGFwR2VzdHVyZVJlY29nbml6ZXIgc2V0RGVsZWdhdGU6bmlsXTsK ICAgICBbX2RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyIHNldERlbGVnYXRlOm5pbF07CkBAIC0z NTMsMTUgKzM1NSwyNiBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaGlnaGxpZ2h0ZWRRdWFkc0FyZVNt YWxsZXJUaGFuUmVjdChjb25zdCBWZWN0b3I8RmxvYXRRdWFkPiYgcQogICAgICAgICByZXR1cm47 CiAKICAgICBjb25zdCBDR0Zsb2F0IFVJV2ViVmlld01pbmltdW1IaWdobGlnaHRSYWRpdXMgPSAy LjA7Ci0gICAgaWYgKCFfaGlnaGxpZ2h0VmlldykgeworCisgICAgaWYgKCFfaGlnaGxpZ2h0Um9v dFZpZXcpIHsKKyAgICAgICAgX2hpZ2hsaWdodFJvb3RWaWV3ID0gYWRvcHROUyhbW1VJVmlldyBh bGxvY10gaW5pdF0pOworICAgICAgICBbX2hpZ2hsaWdodFJvb3RWaWV3IHNldE9wYXF1ZTpOT107 CisgICAgICAgIFtfaGlnaGxpZ2h0Um9vdFZpZXcgbGF5ZXJdLmFuY2hvclBvaW50ID0gQ0dQb2lu dE1ha2UoMCwgMCk7CisKICAgICAgICAgX2hpZ2hsaWdodFZpZXcgPSBhZG9wdE5TKFtbX1VJSGln aGxpZ2h0VmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RaZXJvXSk7CiAgICAgICAgIFtf aGlnaGxpZ2h0VmlldyBzZXRPcGFxdWU6Tk9dOwogICAgICAgICBbX2hpZ2hsaWdodFZpZXcgc2V0 Q29ybmVyUmFkaXVzOlVJV2ViVmlld01pbmltdW1IaWdobGlnaHRSYWRpdXNdOworICAgICAgICBb X2hpZ2hsaWdodFJvb3RWaWV3IGFkZFN1YnZpZXc6X2hpZ2hsaWdodFZpZXcuZ2V0KCldOworICAg IH0KKyAgICBbc2VsZiBhZGRTdWJ2aWV3Ol9oaWdobGlnaHRSb290Vmlldy5nZXQoKV07CisgICAg Q0dGbG9hdCBzZWxmU2NhbGUgPSBbW3NlbGYgbGF5ZXJdIHRyYW5zZm9ybV0ubTExOworICAgIENH RmxvYXQgaGlnaGxpZ2h0Vmlld1NjYWxlID0gMSAvIHNlbGZTY2FsZTsKKyAgICBbX2hpZ2hsaWdo dFJvb3RWaWV3IHNldFRyYW5zZm9ybTpDR0FmZmluZVRyYW5zZm9ybU1ha2VTY2FsZShoaWdobGln aHRWaWV3U2NhbGUsIGhpZ2hsaWdodFZpZXdTY2FsZSldOworCisgICAgeworICAgICAgICBSZXRh aW5QdHI8VUlDb2xvcj4gaGlnaGxpZ2h0VUlLaXRDb2xvciA9IGFkb3B0TlMoW1tVSUNvbG9yIGFs bG9jXSBpbml0V2l0aFJlZDooY29sb3IucmVkKCkgLyAyNTUuMCkgZ3JlZW46KGNvbG9yLmdyZWVu KCkgLyAyNTUuMCkgYmx1ZTooY29sb3IuYmx1ZSgpIC8gMjU1LjApIGFscGhhOihjb2xvci5hbHBo YSgpIC8gMjU1LjApXSk7CisgICAgICAgIFtfaGlnaGxpZ2h0VmlldyBzZXRDb2xvcjpoaWdobGln aHRVSUtpdENvbG9yLmdldCgpXTsKICAgICB9Ci0gICAgW3NlbGYgYWRkU3VidmlldzpfaGlnaGxp Z2h0Vmlldy5nZXQoKV07Ci0KLSAgICBSZXRhaW5QdHI8VUlDb2xvcj4gaGlnaGxpZ2h0VUlLaXRD b2xvciA9IGFkb3B0TlMoW1tVSUNvbG9yIGFsbG9jXSBpbml0V2l0aFJlZDooY29sb3IucmVkKCkg LyAyNTUuMCkgZ3JlZW46KGNvbG9yLmdyZWVuKCkgLyAyNTUuMCkgYmx1ZTooY29sb3IuYmx1ZSgp IC8gMjU1LjApIGFscGhhOihjb2xvci5hbHBoYSgpIC8gMjU1LjApXSk7Ci0gICAgW19oaWdobGln aHRWaWV3IHNldENvbG9yOmhpZ2hsaWdodFVJS2l0Q29sb3IuZ2V0KCldOwogCiAgICAgYm9vbCBh bGxIaWdobGlnaHRSZWN0c0FyZVJlY3RpbGluZWFyID0gdHJ1ZTsKICAgICBjb25zdCBzaXplX3Qg cXVhZENvdW50ID0gaGlnaGxpZ2h0ZWRRdWFkcy5zaXplKCk7CkBAIC0zNjksNyArMzgyLDkgQEAg c3RhdGljIGlubGluZSBib29sIGhpZ2hsaWdodGVkUXVhZHNBcmVTbWFsbGVyVGhhblJlY3QoY29u c3QgVmVjdG9yPEZsb2F0UXVhZD4mIHEKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHF1YWRD b3VudDsgKytpKSB7CiAgICAgICAgIGNvbnN0IEZsb2F0UXVhZCYgcXVhZCA9IGhpZ2hsaWdodGVk UXVhZHNbaV07CiAgICAgICAgIGlmIChxdWFkLmlzUmVjdGlsaW5lYXIoKSkgewotICAgICAgICAg ICAgQ0dSZWN0IHJlY3QgPSBDR1JlY3RJbnNldChxdWFkLmJvdW5kaW5nQm94KCksIC1VSVdlYlZp ZXdNaW5pbXVtSGlnaGxpZ2h0UmFkaXVzLCAtVUlXZWJWaWV3TWluaW11bUhpZ2hsaWdodFJhZGl1 cyk7CisgICAgICAgICAgICBGbG9hdFJlY3QgYm91bmRpbmdCb3ggPSBxdWFkLmJvdW5kaW5nQm94 KCk7CisgICAgICAgICAgICBib3VuZGluZ0JveC5zY2FsZShzZWxmU2NhbGUpOworICAgICAgICAg ICAgQ0dSZWN0IHJlY3QgPSBDR1JlY3RJbnNldChib3VuZGluZ0JveCwgLVVJV2ViVmlld01pbmlt dW1IaWdobGlnaHRSYWRpdXMsIC1VSVdlYlZpZXdNaW5pbXVtSGlnaGxpZ2h0UmFkaXVzKTsKICAg ICAgICAgICAgIFtyZWN0cyBhZGRPYmplY3Q6W05TVmFsdWUgdmFsdWVXaXRoQ0dSZWN0OnJlY3Rd XTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIGFsbEhpZ2hsaWdodFJlY3RzQXJlUmVj dGlsaW5lYXIgPSBmYWxzZTsKQEAgLTM4Myw3ICszOTgsOCBAQCBzdGF0aWMgaW5saW5lIGJvb2wg aGlnaGxpZ2h0ZWRRdWFkc0FyZVNtYWxsZXJUaGFuUmVjdChjb25zdCBWZWN0b3I8RmxvYXRRdWFk PiYgcQogICAgIGVsc2UgewogICAgICAgICBSZXRhaW5QdHI8TlNNdXRhYmxlQXJyYXk+IHF1YWRz ID0gYWRvcHROUyhbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBpbml0V2l0aENhcGFjaXR5OnN0YXRp Y19jYXN0PGNvbnN0IE5TVUludGVnZXI+KHF1YWRDb3VudCldKTsKICAgICAgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBxdWFkQ291bnQ7ICsraSkgewotICAgICAgICAgICAgY29uc3QgRmxvYXRR dWFkJiBxdWFkID0gaGlnaGxpZ2h0ZWRRdWFkc1tpXTsKKyAgICAgICAgICAgIEZsb2F0UXVhZCBx dWFkID0gaGlnaGxpZ2h0ZWRRdWFkc1tpXTsKKyAgICAgICAgICAgIHF1YWQuc2NhbGUoc2VsZlNj YWxlLCBzZWxmU2NhbGUpOwogICAgICAgICAgICAgRmxvYXRRdWFkIGV4dGVuZGVkUXVhZCA9IGlu ZmxhdGVRdWFkKHF1YWQsIFVJV2ViVmlld01pbmltdW1IaWdobGlnaHRSYWRpdXMpOwogICAgICAg ICAgICAgW3F1YWRzIGFkZE9iamVjdDpbTlNWYWx1ZSB2YWx1ZVdpdGhDR1BvaW50OmV4dGVuZGVk UXVhZC5wMSgpXV07CiAgICAgICAgICAgICBbcXVhZHMgYWRkT2JqZWN0OltOU1ZhbHVlIHZhbHVl V2l0aENHUG9pbnQ6ZXh0ZW5kZWRRdWFkLnAyKCldXTsKQEAgLTYwMCw3ICs2MTYsNyBAQCBzdGF0 aWMgaW5saW5lIGJvb2wgaXNTYW1lUGFpcihVSUdlc3R1cmVSZWNvZ25pemVyICphLCBVSUdlc3R1 cmVSZWNvZ25pemVyICpiLCBVSQogLSAodm9pZClfY2FuY2VsSW50ZXJhY3Rpb24KIHsKICAgICBf aXNUYXBIaWdobGlnaHRJRFZhbGlkID0gTk87Ci0gICAgW19oaWdobGlnaHRWaWV3IHJlbW92ZUZy b21TdXBlcnZpZXddOworICAgIFtfaGlnaGxpZ2h0Um9vdFZpZXcgcmVtb3ZlRnJvbVN1cGVydmll d107CiB9CiAKIC0gKEJPT0wpaGFzU2VsZWN0YWJsZVBvc2l0aW9uQXRQb2ludDooQ0dQb2ludClw b2ludAo=