13242 2007-03-31 03:29:48 -0700 REGRESSION: Repro crash when specifying the content property for an image 2007-03-31 22:22:32 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED data:text/html,<img style="content: 'foo';"> InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 16190 0 mitz 2007-03-31 03:29:48 -0700 The URL crashes TOT. Backtrace: #0 0x015df328 in WebCore::StringImpl::length (this=0xffff1340) at StringImpl.h:72 #1 0x0121bf5c in WebCore::String::isEmpty (this=0x69566d8) at WebCore/platform/String.cpp:381 #2 0x011b62c4 in WebCore::RenderImage::setImageSizeForAltText (this=0x695666c, newImage=0x0) at WebCore/rendering/RenderImage.cpp:95 #3 0x013590cc in WebCore::HTMLImageElement::attach (this=0x694e3d0) at WebCore/html/HTMLImageElement.cpp:187 16195 1 13905 mitz 2007-03-31 04:07:12 -0700 Created attachment 13905 Fix the crash 15979 2 13905 darin 2007-03-31 16:23:44 -0700 Comment on attachment 13905 Fix the crash r=me 15895 3 andrew 2007-03-31 22:16:40 -0700 Landed in r20644 15896 4 mrowe 2007-03-31 22:22:26 -0700 <rdar://problem/5103235> 13905 2007-03-31 04:07:12 -0700 2007-03-31 16:23:44 -0700 Fix the crash 13242_r1.patch text/plain 3513 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNjM5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDMtMzEgIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyNDIKKyAgICAgICAgICBSRUdSRVNTSU9OOiBSZXBybyBjcmFzaCB3aGVuIHNwZWNpZnlpbmcg dGhlIGNvbnRlbnQgcHJvcGVydHkgZm9yIGFuIGltYWdlCisKKyAgICAgICAgKiBmYXN0L2ltYWdl cy90ZXh0LWNvbnRlbnQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2ltYWdlcy90ZXh0LWNvbnRlbnQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMDctMDMtMzEgIE1p dHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBX ZWluaWcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy90ZXh0LWNvbnRlbnQtY3Jhc2gt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3RleHQt Y29udGVudC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2ltYWdlcy90ZXh0LWNvbnRlbnQtY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDUgQEAKK1Rlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMjQyIFJFR1JFU1NJT046IFJlcHJvIGNyYXNoIHdoZW4gc3BlY2lmeWluZyB0aGUg Y29udGVudCBwcm9wZXJ0eSBmb3IgYW4gaW1hZ2UuCisKK05vIGNyYXNoIG1lYW5zIFNVQ0NFU1Mu CisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvdGV4dC1jb250ZW50LWNyYXNoLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvdGV4dC1jb250ZW50LWNy YXNoLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy90ZXh0LWNv bnRlbnQtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOSBAQAorPGh0bWw+Cis8 aGVhZD4KKyAgICA8dGl0bGU+PC90aXRsZT4KKyAgICA8c2NyaXB0PgorICAgICAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPHA+ CisgICAgICAgIFRlc3QgZm9yIDxpPjxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMjQyIj5odHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzI0MjwvYT4KKyAgICAgICAgUkVHUkVTU0lPTjogUmVwcm8gY3Jhc2ggd2hlbiBzcGVjaWZ5 aW5nIHRoZSBjb250ZW50IHByb3BlcnR5IGZvciBhbiBpbWFnZTwvaT4uCisgICAgPC9wPgorICAg IDxwPgorICAgICAgICBObyBjcmFzaCBtZWFucyBTVUNDRVNTLgorICAgIDwvcD4KKyAgICA8aW1n IHN0eWxlPSJjb250ZW50OiAnZm9vJzsiPgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIw NjM5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBA QAorMjAwNy0wMy0zMSAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNDIKKyAgICAgICAgICBSRUdSRVNTSU9OOiBS ZXBybyBjcmFzaCB3aGVuIHNwZWNpZnlpbmcgdGhlIGNvbnRlbnQgcHJvcGVydHkgZm9yIGFuIGlt YWdlCisKKyAgICAgICAgVGVzdDogZmFzdC9pbWFnZXMvdGV4dC1jb250ZW50LWNyYXNoLmh0bWwK KworICAgICAgICAqIGh0bWwvSFRNTEltYWdlRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MSW1hZ2VFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZSk6IEFkZGVkIGEgY2hlY2sg dGhhdCB0aGUKKyAgICAgICAgcmVuZGVyZXIgaXMgYW4gaW1hZ2UuCisgICAgICAgIChXZWJDb3Jl OjpIVE1MSW1hZ2VFbGVtZW50OjphdHRhY2gpOiBEaXR0by4KKwogMjAwNy0wMy0zMSAgTmljaG9s YXMgU2hhbmtzICA8d2Via2l0QG5pY2tzaGFua3MuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkZWxlLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJbWFnZUVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MSW1hZ2VFbGVtZW50LmNwcAkocmV2aXNpb24gMjA2MzYp CisrKyBXZWJDb3JlL2h0bWwvSFRNTEltYWdlRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTg5LDcgKzg5LDcgQEAgdm9pZCBIVE1MSW1hZ2VFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYgog ewogICAgIGNvbnN0IFF1YWxpZmllZE5hbWUmIGF0dHJOYW1lID0gYXR0ci0+bmFtZSgpOwogICAg IGlmIChhdHRyTmFtZSA9PSBhbHRBdHRyKSB7Ci0gICAgICAgIGlmIChyZW5kZXJlcigpKQorICAg ICAgICBpZiAocmVuZGVyZXIoKSAmJiByZW5kZXJlcigpLT5pc0ltYWdlKCkpCiAgICAgICAgICAg ICBzdGF0aWNfY2FzdDxSZW5kZXJJbWFnZSo+KHJlbmRlcmVyKCkpLT51cGRhdGVBbHRUZXh0KCk7 CiAgICAgfSBlbHNlIGlmIChhdHRyTmFtZSA9PSBzcmNBdHRyKQogICAgICAgICBtX2ltYWdlTG9h ZGVyLnVwZGF0ZUZyb21FbGVtZW50KCk7CkBAIC0xNzcsNyArMTc3LDcgQEAgdm9pZCBIVE1MSW1h Z2VFbGVtZW50OjphdHRhY2goKQogewogICAgIEhUTUxFbGVtZW50OjphdHRhY2goKTsKIAotICAg IGlmIChyZW5kZXJlcigpKSB7CisgICAgaWYgKHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+aXNJ bWFnZSgpKSB7CiAgICAgICAgIFJlbmRlckltYWdlKiBpbWFnZU9iaiA9IHN0YXRpY19jYXN0PFJl bmRlckltYWdlKj4ocmVuZGVyZXIoKSk7CiAgICAgICAgIGltYWdlT2JqLT5zZXRDYWNoZWRJbWFn ZShtX2ltYWdlTG9hZGVyLmltYWdlKCkpOwogICAgICAgICAK