132403 2014-04-30 14:25:00 -0700 Always-visible scrollbars continuously repaint after non-momentum scrollling 2014-04-30 15:06:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin cmarcelo commit-queue jamesr luiz simon.fraser thorton tonikitoo oldest_to_newest 1005514 0 bdakin 2014-04-30 14:25:00 -0700 Always-visible scrollbars continuously repaint after non-momentum scrolling <rdar://problem/16553878> 1005522 1 230522 bdakin 2014-04-30 14:29:05 -0700 Created attachment 230522 Patch 1005528 2 230522 simon.fraser 2014-04-30 14:47:04 -0700 Comment on attachment 230522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230522&action=review > Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:143 > + if (m_verticalScrollbarPainter) > + [m_verticalScrollbarPainter setUsePresentationValue:YES]; > + if (m_horizontalScrollbarPainter) > + [m_horizontalScrollbarPainter setUsePresentationValue:YES]; You don't really need the nil checks (messaging nil is OK). > Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:378 > + if (m_verticalScrollbarPainter && [m_verticalScrollbarPainter shouldUsePresentationValue]) { Could just be if ([m_verticalScrollbarPainter shouldUsePresentationValue]) > Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:385 > + if (m_horizontalScrollbarPainter && [m_horizontalScrollbarPainter shouldUsePresentationValue]) { Ditto. 1005542 3 bdakin 2014-04-30 15:06:14 -0700 Fixed! Thanks, Simon! http://trac.webkit.org/changeset/168049 230522 2014-04-30 14:29:05 -0700 2014-04-30 14:47:03 -0700 Patch patch-scrollbars.txt text/plain 4233 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODA0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA0LTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBbHdheXMtdmlzaWJsZSBzY3JvbGxi YXJzIGNvbnRpbnVvdXNseSByZXBhaW50IGFmdGVyIG5vbi1tb21lbnR1bSBzY3JvbGxsaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI0MDMKKyAg ICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY1NTM4 Nzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bG9uZ2VyIHVuaXZlcnNhbGx5IG9wdCBpbnRvIHByZXNlbnRhdGlvbiB2YWx1ZSBtb2RlIHdoZW5l dmVyIHRoZSBzY3JvbGwgCisgICAgICAgIHBvc2l0aW9uIGNoYW5nZXMgb24gdGhlIHNjcm9sbGlu ZyB0aHJlYWQuIFdlIHJlYWxseSBvbmx5IHdhbnQgaXQgZm9yIG1vbWVudHVtIAorICAgICAgICBz Y3JvbGxzLCBhbmQgdGhpcyB3aWxsIGVuc3VyZSB0aGF0IHdlIGFsd2F5cyBzZXQgaXQgdG8gTk8g b25jZSB3ZSBoYXZlIHNldCBpdCB0byAKKyAgICAgICAgWUVTLgorICAgICAgICAqIHBhZ2Uvc2Ny b2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZU1hYy5tbToKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlTWFjOjpoYW5kbGVXaGVlbEV2ZW50KToK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlTWFjOjpzZXRTY3Jv bGxMYXllclBvc2l0aW9uKToKKworICAgICAgICBFeHBvc2Ugc2hvdWxkVXNlUHJlc2VudGF0aW9u VmFsdWUuCisgICAgICAgICogcGxhdGZvcm0vbWFjL05TU2Nyb2xsZXJJbXBEZXRhaWxzLmg6CisK IDIwMTQtMDQtMjkgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBBWDogTWFrZSAiY29udGVudGVkaXRhYmxlIiByZWdpb25zIGludG8gQVhUZXh0QXJlYXMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlU2Ny b2xsaW5nTm9kZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9tYWMvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGVNYWMubW0JKHJldmlzaW9uIDE2ODAz MikKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlU2Ny b2xsaW5nTm9kZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTM2LDkgKzEzNiwxMyBAQCB2b2lk IFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlTWFjOjpoYW5kCiAgICAgaWYgKCFjYW5IYXZlU2Ny b2xsYmFycygpKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAod2hlZWxFdmVudC5tb21lbnR1 bVBoYXNlKCkgPT0gUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2VCZWdhbikgeworICAgICAgICBpZiAo bV92ZXJ0aWNhbFNjcm9sbGJhclBhaW50ZXIpCisgICAgICAgICAgICBbbV92ZXJ0aWNhbFNjcm9s bGJhclBhaW50ZXIgc2V0VXNlUHJlc2VudGF0aW9uVmFsdWU6WUVTXTsKKyAgICAgICAgaWYgKG1f aG9yaXpvbnRhbFNjcm9sbGJhclBhaW50ZXIpCisgICAgICAgICAgICBbbV9ob3Jpem9udGFsU2Ny b2xsYmFyUGFpbnRlciBzZXRVc2VQcmVzZW50YXRpb25WYWx1ZTpZRVNdOworICAgIH0KICAgICBp ZiAod2hlZWxFdmVudC5tb21lbnR1bVBoYXNlKCkgPT0gUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2VF bmRlZCB8fCB3aGVlbEV2ZW50Lm1vbWVudHVtUGhhc2UoKSA9PSBQbGF0Zm9ybVdoZWVsRXZlbnRQ aGFzZUNhbmNlbGxlZCkgewotICAgICAgICAvLyBJZiB0aGUgd2hlZWwgZXZlbnQgaXMgZW5kaW5n IG9yIGNhbmNlbGxlZCwgdGhlbiB3ZSBjYW4gdGVsbCB0aGUgU2Nyb2xsYmFyUGFpbnRlciBBUEkg dGhhdCB3ZSB3b24ndAotICAgICAgICAvLyBiZSB1cGRhdGluZyB0aGUgcG9zaXRpb24gZnJvbSBv dXIgc2Nyb2xsaW5nIHRocmVhZCBhbnltb3JlIGZvciB0aGUgdGltZSBiZWluZy4KICAgICAgICAg aWYgKG1fdmVydGljYWxTY3JvbGxiYXJQYWludGVyKQogICAgICAgICAgICAgW21fdmVydGljYWxT Y3JvbGxiYXJQYWludGVyIHNldFVzZVByZXNlbnRhdGlvblZhbHVlOk5PXTsKICAgICAgICAgaWYg KG1faG9yaXpvbnRhbFNjcm9sbGJhclBhaW50ZXIpCkBAIC0zNzEsMTYgKzM3NSwxNCBAQCB2b2lk IFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlTWFjOjpzZXRTCiAgICAgICAgIFtDQVRyYW5zYWN0 aW9uIGJlZ2luXTsKICAgICAgICAgW0NBVHJhbnNhY3Rpb24gbG9ja107CiAKLSAgICAgICAgaWYg KG1fdmVydGljYWxTY3JvbGxiYXJQYWludGVyKSB7Ci0gICAgICAgICAgICBbbV92ZXJ0aWNhbFNj cm9sbGJhclBhaW50ZXIgc2V0VXNlUHJlc2VudGF0aW9uVmFsdWU6WUVTXTsKKyAgICAgICAgaWYg KG1fdmVydGljYWxTY3JvbGxiYXJQYWludGVyICYmIFttX3ZlcnRpY2FsU2Nyb2xsYmFyUGFpbnRl ciBzaG91bGRVc2VQcmVzZW50YXRpb25WYWx1ZV0pIHsKICAgICAgICAgICAgIGZsb2F0IHByZXNl bnRhdGlvblZhbHVlOwogICAgICAgICAgICAgZmxvYXQgb3ZlcmhhbmdBbW91bnQ7CiAgICAgICAg ICAgICBTY3JvbGxhYmxlQXJlYTo6Y29tcHV0ZVNjcm9sbGJhclZhbHVlQW5kT3ZlcmhhbmcocG9z aXRpb24ueSgpLCB0b3RhbENvbnRlbnRzU2l6ZSgpLmhlaWdodCgpLCB2aWV3cG9ydFJlY3QuaGVp Z2h0KCksIHByZXNlbnRhdGlvblZhbHVlLCBvdmVyaGFuZ0Ftb3VudCk7CiAgICAgICAgICAgICBb bV92ZXJ0aWNhbFNjcm9sbGJhclBhaW50ZXIgc2V0UHJlc2VudGF0aW9uVmFsdWU6cHJlc2VudGF0 aW9uVmFsdWVdOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKG1faG9yaXpvbnRhbFNjcm9sbGJh clBhaW50ZXIpIHsKLSAgICAgICAgICAgIFttX2hvcml6b250YWxTY3JvbGxiYXJQYWludGVyIHNl dFVzZVByZXNlbnRhdGlvblZhbHVlOllFU107CisgICAgICAgIGlmIChtX2hvcml6b250YWxTY3Jv bGxiYXJQYWludGVyICYmIFttX2hvcml6b250YWxTY3JvbGxiYXJQYWludGVyIHNob3VsZFVzZVBy ZXNlbnRhdGlvblZhbHVlXSkgewogICAgICAgICAgICAgZmxvYXQgcHJlc2VudGF0aW9uVmFsdWU7 CiAgICAgICAgICAgICBmbG9hdCBvdmVyaGFuZ0Ftb3VudDsKICAgICAgICAgICAgIFNjcm9sbGFi bGVBcmVhOjpjb21wdXRlU2Nyb2xsYmFyVmFsdWVBbmRPdmVyaGFuZyhwb3NpdGlvbi54KCksIHRv dGFsQ29udGVudHNTaXplKCkud2lkdGgoKSwgdmlld3BvcnRSZWN0LndpZHRoKCksIHByZXNlbnRh dGlvblZhbHVlLCBvdmVyaGFuZ0Ftb3VudCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvTlNTY3JvbGxlckltcERldGFpbHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvTlNTY3JvbGxlckltcERldGFpbHMuaAkocmV2aXNpb24gMTY4MDMyKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL05TU2Nyb2xsZXJJbXBEZXRhaWxzLmgJKHdv cmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDcgQEAgQGludGVyZmFjZSBOU09iamVjdCAoU2Nyb2xs YmFyUGFpbnRlcikKIC0gKHZvaWQpc2V0Qm91bmRzU2l6ZTooTlNTaXplKWJvdW5kc1NpemU7CiAt ICh2b2lkKXNldERvdWJsZVZhbHVlOihkb3VibGUpZG91YmxlVmFsdWU7CiAtICh2b2lkKXNldFBy ZXNlbnRhdGlvblZhbHVlOihkb3VibGUpcHJlc2VudGF0aW9uVmFsdWU7CistIChCT09MKXNob3Vs ZFVzZVByZXNlbnRhdGlvblZhbHVlOwogLSAodm9pZClzZXRVc2VQcmVzZW50YXRpb25WYWx1ZToo Qk9PTCl1c2VQcmVzZW50YXRpb25WYWx1ZTsKIC0gKHZvaWQpc2V0S25vYlByb3BvcnRpb246KENH RmxvYXQpcHJvcG9ydGlvbjsKIC0gKHZvaWQpc2V0S25vYlN0eWxlOihOU1Njcm9sbGVyS25vYlN0 eWxlKWtub2JTdHlsZTsK