<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>132397</bug_id>
          
          <creation_ts>2014-04-30 12:49:26 -0700</creation_ts>
          <short_desc>check-for-inappropriate-macros-in-external-headers should get the product name, not the project name</short_desc>
          <delta_ts>2014-04-30 13:01:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1005480</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-04-30 12:49:26 -0700</bug_when>
    <thetext>check-for-inappropriate-macros-in-external-headers should get the product name, not the project name</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1005481</commentid>
    <comment_count>1</comment_count>
      <attachid>230512</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-04-30 12:49:38 -0700</bug_when>
    <thetext>Created attachment 230512
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1005486</commentid>
    <comment_count>2</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-04-30 13:01:15 -0700</bug_when>
    <thetext>Committed r168039: &lt;http://trac.webkit.org/changeset/168039&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>230512</attachid>
            <date>2014-04-30 12:49:38 -0700</date>
            <delta_ts>2014-04-30 12:55:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-132397-20140430194915.patch</filename>
            <type>text/plain</type>
            <size>1805</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MDM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTg5NmY3MDgzZDM1OTNlZTM2MjU4MzczMzQxNGY2OWFl
MjE3YTU1ZS4uMjBhNjc5YTZkYmYyYjU0MmFiNGY4MTc1ZmRjZTdkZDhmMWVmYjUwMiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy
IEBACisyMDE0LTA0LTMwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisK
KyAgICAgICAgY2hlY2stZm9yLWluYXBwcm9wcmlhdGUtbWFjcm9zLWluLWV4dGVybmFsLWhlYWRl
cnMgc2hvdWxkIGdldCB0aGUgcHJvZHVjdCBuYW1lLCBub3QgdGhlIHByb2plY3QgbmFtZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzk3CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2No
ZWNrLWZvci1pbmFwcHJvcHJpYXRlLW1hY3Jvcy1pbi1leHRlcm5hbC1oZWFkZXJzOgorCiAyMDE0
LTA0LTI5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAg
ICBbR1RLXSBNYWtlIGl0IGVhc2llciB0byBydW4gQ01ha2UgZm9yIGRvd25zdHJlYW1zCmRpZmYg
LS1naXQgYS9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1pbmFwcHJvcHJpYXRlLW1hY3Jvcy1pbi1l
eHRlcm5hbC1oZWFkZXJzIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItaW5hcHByb3ByaWF0ZS1t
YWNyb3MtaW4tZXh0ZXJuYWwtaGVhZGVycwppbmRleCBiNzhmMDZjNzhmZjRhODE3NzUzMzUwMjVj
MDU4ZGUwMTg0YzMxZWM5Li45ZTYyYTllNmM1MjAzNjY3MjUwY2E3MzUzMDAzY2QyZjIyMmM3ZjNh
IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci1pbmFwcHJvcHJpYXRlLW1hY3Jv
cy1pbi1leHRlcm5hbC1oZWFkZXJzCisrKyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLWluYXBw
cm9wcmlhdGUtbWFjcm9zLWluLWV4dGVybmFsLWhlYWRlcnMKQEAgLTI5LDcgKzI5LDcgQEAKICMg
Y2xpZW50cyBpbmNsdWRlIHRoZXNlIGhlYWRlcnMgdGhleSB3b3VsZCBub3QgYWxzbyBuZWVkIFdU
RidzIFBsYXRmb3JtLmguCiAKIGJhc2VfZGlyZWN0b3J5ID0gRU5WWydUQVJHRVRfQlVJTERfRElS
J10gb3IgdGhyb3cgIlVuYWJsZSB0byBmaW5kIFRBUkdFVF9CVUlMRF9ESVIgaW4gdGhlIGVudmly
b25tZW50ISIKLXByb2plY3RfbmFtZSA9IEVOVlsnUFJPSkVDVF9OQU1FJ10gb3IgdGhyb3cgIlVu
YWJsZSB0byBmaW5kIFBST0pFQ1RfTkFNRSBpbiB0aGUgZW52aXJvbm1lbnQhIgorcHJvZHVjdF9u
YW1lID0gRU5WWydQUk9EVUNUX05BTUUnXSBvciB0aHJvdyAiVW5hYmxlIHRvIGZpbmQgUFJPRFVD
VF9OQU1FIGluIHRoZSBlbnZpcm9ubWVudCEiCiAkaXNfc2hhbGxvd19idW5kbGUgPSAoRU5WWydT
SEFMTE9XX0JVTkRMRSddIHx8ICJOTyIpLnVwY2FzZSA9PSAiWUVTIgogCiAkZXJyb3JfcHJpbnRl
ZCA9IGZhbHNlCkBAIC02Nyw3ICs2Nyw3IEBAIGVuZAogCiBEaXIuY2hkaXIgYmFzZV9kaXJlY3Rv
cnkKIAotZnJhbWV3b3JrID0gIiN7cHJvamVjdF9uYW1lfS5mcmFtZXdvcmsiCitmcmFtZXdvcmsg
PSAiI3twcm9kdWN0X25hbWV9LmZyYW1ld29yayIKIEFSR1YuZWFjaCBkbyB8cGF0aHwKICAgZnJh
bWV3b3JrX2hlYWRlcnNfZm9yX3BhdGgoZnJhbWV3b3JrLCBwYXRoKS5lYWNoIGRvIHxoZWFkZXJ8
CiAgICAgdmVyaWZ5X21hY3Jvc19pbl9oZWFkZXIoaGVhZGVyKQo=
</data>
<flag name="review"
          id="254889"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>