132390 2014-04-30 11:06:55 -0700 [GTK][GStreamer] Remove unnecessary GLIB_CHECK_VERSION #ifdefs 2014-04-30 16:17:23 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vjaquez vjaquez achristensen agomez benjamin calvaris cgarcia cmarcelo commit-queue eric.carlson glenn gustavo jer.noble menard mrobinson philipj pnormand sergio oldest_to_newest 1005428 0 vjaquez 2014-04-30 11:06:55 -0700 Since EFL port use GLib 2.38 and GTK+, 2.33.2, I assume it is OK remove, in GTK+ and GST, the existing glib version guards. 1005434 1 230499 vjaquez 2014-04-30 11:20:10 -0700 Created attachment 230499 Patch 1005435 2 mrobinson 2014-04-30 11:23:33 -0700 I think WinCairo uses the GStreamer backend currently, but is in the process of switching away. 1005437 3 achristensen 2014-04-30 11:26:51 -0700 (In reply to comment #2) > I think WinCairo uses the GStreamer backend currently, but is in the process of switching away. I switched it away yesterday. 1005568 4 230499 commit-queue 2014-04-30 16:17:17 -0700 Comment on attachment 230499 Patch Clearing flags on attachment: 230499 Committed r168059: <http://trac.webkit.org/changeset/168059> 1005569 5 commit-queue 2014-04-30 16:17:23 -0700 All reviewed patches have been landed. Closing bug. 230499 2014-04-30 11:20:10 -0700 2014-04-30 16:17:17 -0700 Patch bug-132390-20140430201946.patch text/plain 5690 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4MDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZmNzJkN2U0MGFmNWVhNTRkY2MwYmE1 ZGM0NWRiNTFiNzdkZmNmN2EuLjVjY2QzZTgxZmFiNDUzZmI2MTFjMDAyNzMxNzU5MDdhMmZmNDIy ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMDQtMzAgIFbDrWN0b3IgTWFudWVsIErDoXF1 ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtHU3RyZWFtZXJd IFJlbW92ZSB1bm5lY2Vzc2FyeSBHTElCX0NIRUNLX1ZFUlNJT04gI2lmZGVmcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyMzkwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgRUZMIHBvcnQgdXNl IEdMaWIgMi4zOCBhbmQgR1RLKywgMi4zMy4yLCBJIGFzc3VtZSBpdCBpcyBPSworICAgICAgICBy ZW1vdmUsIGluIEdUSysgYW5kIEdTVCwgdGhlIGV4aXN0aW5nIGdsaWIgdmVyc2lvbiBndWFyZHMu CisKKyAgICAgICAgVGhpcyBjb2RlIHdhcyByb2xsYmFjayBmcm9tIHIxNDk4NzkgYmVjYXVzZSBR dCBNSVBTIHVzZWQgaXQuIEJ1dCBzaW5jZQorICAgICAgICBRdCBpcyBnb25lLCBpdCBpcyBzYWZl IHRvIHJlbW92ZSBub3cuCisKKyAgICAgICAgKiB3dGYvZ29iamVjdC9HUmVmUHRyLmNwcDoKKyAg ICAgICAgKFdURjo6cmVmR1B0cik6IERlbGV0ZWQuCisgICAgICAgIChXVEY6OmRlcmVmR1B0cik6 IERlbGV0ZWQuCisKIDIwMTQtMDQtMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBbV2luQ2Fpcm9dIFN3aXRjaCB2aWRlbyBmcm9tIEdTdHJl YW1lciB0byBNZWRpYSBGb3VuZGF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVmYmI1N2JlNTBiZjk0ZWQ5 ZGQ2YzEyMjJmNWYwZTZkZDRhMmI3ZDMuLmI5ODRkODY4YzlkNzY4ODE0ODIzMzUwYjZhOTliNjU2 MGYxN2ZiMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxNC0wNC0zMCAgVsOtY3Rv ciBNYW51ZWwgSsOhcXVleiBMZWFsICA8dmphcXVlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdW0dTdHJlYW1lcl0gUmVtb3ZlIHVubmVjZXNzYXJ5IEdMSUJfQ0hFQ0tfVkVSU0lPTiAjaWZk ZWZzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzIz OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5j ZSBFRkwgcG9ydCB1c2UgR0xpYiAyLjM4IGFuZCBHVEsrLCAyLjMzLjIsIEkgYXNzdW1lIGl0IGlz IE9LCisgICAgICAgIHJlbW92ZSwgaW4gR1RLKyBhbmQgR1NULCB0aGUgZXhpc3RpbmcgZ2xpYiB2 ZXJzaW9uIGd1YXJkcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBi eSBjdXJyZW50IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlOjp+TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZSk6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJlYW1lci5jcHA6CisgICAgICAgICh3 ZWJraXRWaWRlb1NpbmtEaXNwb3NlKToKKyAgICAgICAgKHdlYmtpdFZpZGVvU2lua0ZpbmFsaXpl KTogRGVsZXRlZC4KKwogMjAxNC0wNC0zMCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyMzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuY3BwIGIv U291cmNlL1dURi93dGYvZ29iamVjdC9HUmVmUHRyLmNwcAppbmRleCA1MmE5YTM5NDJiMGVmYTJl YTAyMjE5ZWRjZTAxMGE2Y2UxZjgxOTE4Li4xM2RlMTY2ZDAyOTY2YTA3ODZkOGU3YmVlMjkzZTYx ZDg2OGI2N2RlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuY3Bw CisrKyBiL1NvdXJjZS9XVEYvd3RmL2dvYmplY3QvR1JlZlB0ci5jcHAKQEAgLTY0LDcgKzY0LDYg QEAgdGVtcGxhdGUgPD4gdm9pZCBkZXJlZkdQdHIoR01haW5Mb29wKiBwdHIpCiAgICAgICAgIGdf bWFpbl9sb29wX3VucmVmKHB0cik7CiB9CiAKLSNpZiBHTElCX0NIRUNLX1ZFUlNJT04oMiwgMzIs IDApCiB0ZW1wbGF0ZSA8PiBHQnl0ZXMqIHJlZkdQdHIoR0J5dGVzKiBwdHIpCiB7CiAgICAgaWYg KHB0cikKQEAgLTc4LDIzICs3Nyw2IEBAIHRlbXBsYXRlIDw+IHZvaWQgZGVyZWZHUHRyKEdCeXRl cyogcHRyKQogICAgICAgICBnX2J5dGVzX3VucmVmKHB0cik7CiB9CiAKLSMgZWxzZQotCi10eXBl ZGVmIHN0cnVjdCBfR0J5dGVzIHsKLSAgICBib29sIGZha2U7Ci19IEdCeXRlczsKLQotdGVtcGxh dGUgPD4gR0J5dGVzKiByZWZHUHRyKEdCeXRlcyogcHRyKQotewotICAgIHJldHVybiBwdHI7Ci19 Ci0KLXRlbXBsYXRlIDw+IHZvaWQgZGVyZWZHUHRyKEdCeXRlcyogcHRyKQotewotfQotCi0jZW5k aWYKLQogdGVtcGxhdGUgPD4gR1ZhcmlhbnQqIHJlZkdQdHIoR1ZhcmlhbnQqIHB0cikKIHsKICAg ICBpZiAocHRyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2UuY3BwCmluZGV4IDgyYjZhZGU4NmJkZTMzNzM3YWM5NTg1ZTVlNmZhMjRlMjc0MDY5 ZWEuLmZhODUwNGQ5ZGQ2NTI3ZGZlYjc0YTc1ZDcxOWRmZDcyOGU4NDY5ZmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTkz LDI0ICs5MywxNiBAQCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXJCYXNlKE1lZGlhUGxheWVyKiBwbAogICAgICwgbV92b2x1bWVTaWdu YWxIYW5kbGVyKDApCiAgICAgLCBtX211dGVTaWduYWxIYW5kbGVyKDApCiB7Ci0jaWYgR0xJQl9D SEVDS19WRVJTSU9OKDIsIDMxLCAwKQogICAgIG1fYnVmZmVyTXV0ZXggPSBuZXcgR011dGV4Owog ICAgIGdfbXV0ZXhfaW5pdChtX2J1ZmZlck11dGV4KTsKLSNlbHNlCi0gICAgbV9idWZmZXJNdXRl eCA9IGdfbXV0ZXhfbmV3KCk7Ci0jZW5kaWYKIH0KIAogTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZTo6fk1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UoKQogewogICAgIGdfc2ln bmFsX2hhbmRsZXJfZGlzY29ubmVjdChtX3dlYmtpdFZpZGVvU2luay5nZXQoKSwgbV9yZXBhaW50 SGFuZGxlcik7CiAKLSNpZiBHTElCX0NIRUNLX1ZFUlNJT04oMiwgMzEsIDApCiAgICAgZ19tdXRl eF9jbGVhcihtX2J1ZmZlck11dGV4KTsKICAgICBkZWxldGUgbV9idWZmZXJNdXRleDsKLSNlbHNl Ci0gICAgZ19tdXRleF9mcmVlKG1fYnVmZmVyTXV0ZXgpOwotI2VuZGlmCiAKICAgICBpZiAobV9i dWZmZXIpCiAgICAgICAgIGdzdF9idWZmZXJfdW5yZWYobV9idWZmZXIpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lua0dTdHJl YW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVmlk ZW9TaW5rR1N0cmVhbWVyLmNwcAppbmRleCA0YzJhYTc2OGFiOWFiMmVjZTllZjA3OTdkNTk0NDUz ODUwZDhlMzk1Li43YzNkZjM3MjM3OWQzN2RhM2VlMjMwNjk2ZjQzMGI1NjBiMzRhNjdkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVmlkZW9T aW5rR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvVmlkZW9TaW5rR1N0cmVhbWVyLmNwcApAQCAtMTAyLDE1ICsxMDIsMTAgQEAgc3Rh dGljIHZvaWQgd2Via2l0X3ZpZGVvX3NpbmtfaW5pdChXZWJLaXRWaWRlb1NpbmsqIHNpbmspCiB7 CiAgICAgc2luay0+cHJpdiA9IEdfVFlQRV9JTlNUQU5DRV9HRVRfUFJJVkFURShzaW5rLCBXRUJL SVRfVFlQRV9WSURFT19TSU5LLCBXZWJLaXRWaWRlb1NpbmtQcml2YXRlKTsKICAgICBuZXcgKHNp bmstPnByaXYpIFdlYktpdFZpZGVvU2lua1ByaXZhdGUoKTsKLSNpZiBHTElCX0NIRUNLX1ZFUlNJ T04oMiwgMzEsIDApCiAgICAgc2luay0+cHJpdi0+ZGF0YUNvbmRpdGlvbiA9IG5ldyBHQ29uZDsK ICAgICBnX2NvbmRfaW5pdChzaW5rLT5wcml2LT5kYXRhQ29uZGl0aW9uKTsKICAgICBzaW5rLT5w cml2LT5idWZmZXJNdXRleCA9IG5ldyBHTXV0ZXg7CiAgICAgZ19tdXRleF9pbml0KHNpbmstPnBy aXYtPmJ1ZmZlck11dGV4KTsKLSNlbHNlCi0gICAgc2luay0+cHJpdi0+ZGF0YUNvbmRpdGlvbiA9 IGdfY29uZF9uZXcoKTsKLSAgICBzaW5rLT5wcml2LT5idWZmZXJNdXRleCA9IGdfbXV0ZXhfbmV3 KCk7Ci0jZW5kaWYKIAogICAgIGdzdF92aWRlb19pbmZvX2luaXQoJnNpbmstPnByaXYtPmluZm8p OwogfQpAQCAtMjI4LDIyICsyMjMsMTQgQEAgc3RhdGljIHZvaWQgd2Via2l0VmlkZW9TaW5rRGlz cG9zZShHT2JqZWN0KiBvYmplY3QpCiAgICAgV2ViS2l0VmlkZW9TaW5rUHJpdmF0ZSogcHJpdiA9 IHNpbmstPnByaXY7CiAKICAgICBpZiAocHJpdi0+ZGF0YUNvbmRpdGlvbikgewotI2lmIEdMSUJf Q0hFQ0tfVkVSU0lPTigyLCAzMSwgMCkKICAgICAgICAgZ19jb25kX2NsZWFyKHByaXYtPmRhdGFD b25kaXRpb24pOwogICAgICAgICBkZWxldGUgcHJpdi0+ZGF0YUNvbmRpdGlvbjsKLSNlbHNlCi0g ICAgICAgIGdfY29uZF9mcmVlKHByaXYtPmRhdGFDb25kaXRpb24pOwotI2VuZGlmCiAgICAgICAg IHByaXYtPmRhdGFDb25kaXRpb24gPSAwOwogICAgIH0KIAogICAgIGlmIChwcml2LT5idWZmZXJN dXRleCkgewotI2lmIEdMSUJfQ0hFQ0tfVkVSU0lPTigyLCAzMSwgMCkKICAgICAgICAgZ19tdXRl eF9jbGVhcihwcml2LT5idWZmZXJNdXRleCk7CiAgICAgICAgIGRlbGV0ZSBwcml2LT5idWZmZXJN dXRleDsKLSNlbHNlCi0gICAgICAgIGdfbXV0ZXhfZnJlZShwcml2LT5idWZmZXJNdXRleCk7Ci0j ZW5kaWYKICAgICAgICAgcHJpdi0+YnVmZmVyTXV0ZXggPSAwOwogICAgIH0KIAo=